Python 関数を使用して冗長なコードを整理したい

Question

似たような処理が続くので関数で整理したいのですが、exceptionの例外処理の文だけを変更したいで、どのように関数に組み込んだら良いのか分からないのでわかる方がいましたらアドバイスしていただけると助かります。
モードの1と2の処理はほとんど同じで最初のプリントの文字とExceptionのエラー後に出力されるプリント文字など主にプリントされる文字のみ使い分けております。どのようにして関数にして1つのコードにできますでしょうか？

以下がコードになります。

import imapclient, ssl, sys, pprint, imaplib, getpass

from numpy.lib.shape_base import expand_dims

imaplib._MAXLINE = 10000000 


print("Please choose a number below to conitue")
print("1. Gmail")
print("2.Yahoo Japan Mail")
print('3. For exit')

while_enterd = True

while while_enterd:
    try:
        mode = int(input("Number: "))
        if mode > 0 and mode < 4:
            while_enterd = False   
    except Exception as e:
        print("Please enter valid number")
    print("Value must be a number between 1 and 3")        
        
context = ssl.SSLContext(ssl.PROTOCOL_TLSv1_2)

if mode == 1:
    print("Gmail is chosen") 
    imap_obj = imapclient.IMAPClient("imap.gmail.com", ssl=True, ssl_context=context)
    print('Please type your email of Google account that ends with "@gmail.com"')
    mail_ad = input("email:")
    print('Please type your App password for gmail')
    mail_pass = getpass.getpass("App password:")
    try: 
        imap_obj.login(mail_ad, mail_pass)
    except Exception as e:
        print("Error message: " + e)
        print("If you haven't created App password on your account yet,")
        print("please refer to https://support.google.com/accounts/answer/185833?hl=en and set App password before you run this programme")
        exit()
    print("Logged in successfully")
    # pprint.pprint(imap_obj.list_folders()) # To return folders of mail in list 
    imap_obj.select_folder("Inbox", readonly=False)
    print("Please type an email address that you want to delete from your inbox")
    delete_ad = input("email:")
    enterd = True
    while enterd: 
        UIDs = imap_obj.search(["FROM", delete_ad])
        number_of_mail = len(UIDs)
        print("There are " + str(number_of_mail) + " mails. Would you like to delte them all?")
        answer = input("y/n?:")
        if answer.lower() == "y":
            print("Deleting all the mails. This may take for a while...")
            for delete_id in UIDs:
                imap_obj.delete_messages(delete_id)
        else: 
            enterd = False
        imap_obj.expunge()
        print("Mails delted successfully")
        print("Would you like to delete other mails?")
        answer = input("y/n?:")
        if answer.lower() == "y":
            print("Please type an email address that you want to delete from your inbox")
            delete_ad = input("email:")
        else:
            enterd = False
    imap_obj.logout()
    print("Logging out from the mail server")
    exit()

elif mode == 2:
    print("Yahoo Japan Mail is chosen")
    imap_obj = imapclient.IMAPClient("imap.mail.yahoo.co.jp", ssl=True, ssl_context=context)
    print('Please type your email of Yahoo account that ends with "@yahoo.co.jp"')
    mail_ad = input("email:")
    print('Please type your password for Yahoo Japan Mail')
    mail_pass = getpass.getpass("Password:")
    # Insert Exception later 
    try:
        imap_obj.login(mail_ad, mail_pass)
    except Exception:
        print("Email or Password is not correct. Please try again")
        exit()
    print("Logged in successfully")
    imap_obj.select_folder("Inbox", readonly=False)
    print("Please type an email address that you want to delete from your inbox")
    delete_ad = input("email:")
    enterd = True
    while enterd: 
        UIDs = imap_obj.search(["FROM", delete_ad])
        number_of_mail = len(UIDs)
        print("There are " + str(number_of_mail) + " mails. Would you like to delte them all?")
        answer = input("y/n?:")
        if answer.lower() == "y":
            print("Deleting all the mails. This may take for a while...")
            for delete_id in UIDs:
                imap_obj.delete_messages(delete_id)
        else: 
            enterd = False
        imap_obj.expunge()
        print("Mails delted successfully")
        print("Would you like to delete other mails?")
        answer = input("y/n?:")
        if answer.lower() == "y":
            print("Please type an email address that you want to delete from your inbox")
            delete_ad = input("email:")
        else:
            enterd = False
    print("Logging out from the mail server")
    imap_obj.logout()
    exit()
elif mode == 3:
    print("Exit")

よろしくお願いします

Answer 1

いろいろな手法があるとは思いますが、基底classを作って継承で作るのが一つの解法かと思います。

class base_cls(object):
  def imap_access(self):
    self.imap_obj = imapclient.IMAPClient("imap.mail.yahoo.co.jp", ssl=True, ssl_context=context)
    print('Please type your email of Yahoo account that ends with "@yahoo.co.jp"')
    self.mail_ad = input("email:")
    print('Please type your password for Yahoo Japan Mail')
    self.mail_pass = getpass.getpass("Password:")

class gmail_access(base_cls):
  def __init__(self) -> None:
    print("Gmail is chosen")
    super().__init__()

  def imap_login(self):
    self.imap_access()
    try:
        self.imap_obj.login(self.mail_ad, self.mail_pass)
    except Exception as e:
        print("Error message: " + e)
#以下省略

class yahoo_access(base_cls):
    print("Yahoo Japan Mail is chosen")
    super().__init__()

  def imap_login(self):
    self.imap_access()
    try:
        self.imap_obj.login(self.mail_ad, self.mail_pass)
    except Exception as e:
        print("Email or Password is not correct. Please try again")
#以下省略

動作確認はしていませんが、上記のような感じで書けるかと思います。

Comments

[ppaul]

やることが二つだけなら、クラスを一つ作って、インスタンスを作る時にパラメータを与え、GmailインスタンスとYahooインスタンスの二つを作る方が良いのでは、と思います。

[asianLad]

```python

import imapclient, ssl, sys, pprint, imaplib, getpass

from numpy.lib.shape_base import expand_dims

imaplib._MAXLINE = 10000000

print("Please choose a number below to conitue")
print("1. Gmail")
print("2.Yahoo Japan Mail")
print('3. For exit')

while_enterd = True

while while_enterd:
try:
mode = int(input("Number: "))
if mode > 0 and mode < 4:
while_enterd = False
except Exception as e:
print("Please enter valid number")
print("Value must be a number between 1 and 3")

context = ssl.SSLContext(ssl.PROTOCOL_TLSv1_2)

def mail_delete(mail_server):
print( mail_server + " is chosen")
imap_obj = imapclient.IMAPClient("imap.gmail.com", ssl=True, ssl_context=context)
print('Please type your email of ' + mail_server + ' account that ends with ' +domain)
mail_ad = input("email:")
print('Please type your password for ' + mail_server)
mail_pass = getpass.getpass("Password:")
try:
imap_obj.login(mail_ad, mail_pass)
except Exception as e:
# print("Error message: " + e)
print(exception_message)
exit()
print("Logged in successfully")
# pprint.pprint(imap_obj.list_folders()) # To return folders of mail in list
imap_obj.select_folder("Inbox", readonly=False)
print("Please type an email address that you want to delete from your inbox")
delete_ad = input("email:")
enterd = True
while enterd:
UIDs = imap_obj.search(["FROM", delete_ad])
number_of_mail = len(UIDs)
print("There are " + str(number_of_mail) + " mails. Would you like to delte them all?")
answer = input("y/n?:")
if answer.lower() == "y":
print("Deleting all the mails. This may take for a while...")
for delete_id in UIDs:
imap_obj.delete_messages(delete_id)
else:
enterd = False
imap_obj.expunge()
print("Mails delted successfully")
print("Would you like to delete other mails?")
answer = input("y/n?:")
if answer.lower() == "y":
print("Please type an email address that you want to delete from your inbox")
delete_ad = input("email:")
else:
enterd = False
imap_obj.logout()
print("Logging out from the mail server")
exit()

if mode == 1:
domain = '"@gmail.com"'
exception_message = ("If you haven't created App password on your account yet, \n please refer to https://support.google.com/accounts/answer/185833?hl=en and set App password before you run this programme")
mail_delete("Gmail")

elif mode == 2:
domain = '"@gmail.com"'
exception_message = ("Email or passowrod is not correct. Please try again")
mail_delete("Yahoo Japan Mail")

elif mode == 3:
print("Exit")

```

できました。ありがとうございます。

Answer 2

単に、異なる部分は引数にして、呼び出し時に指定すれば良いんじゃ無いでしょうか。