GUIでのwhileの不具合

Question

質問失礼します。今どちらかじゃんけんで三勝したらグリコの配点で勝敗を決めるゲームを作っています。しかし下記のコードを書いてみたところwhileを入れた瞬間急に動かなくなったり、明らかに乱数ではないもの（コンピューターの手）が出てしまったりと不具合が起きてしまいます。自分なりに原因を考えてみたところ全く分からない状況です。どなたかご教授いただけないでしょうか。

import javax.swing.JFrame;
 
public class GameMain {
	public static void main(String[] args) {
		// TODO Auto-generated method stub
		//ウィンドウ設定
		JFrame frame = new JFrame("Guriko");
		frame.setSize(640, 480);
		frame.setLocationRelativeTo(null);
		frame.setDefaultCloseOperation(JFrame.EXIT_ON_CLOSE);
		frame.setResizable(false);
		
		Panel.createPanel(frame);
		
		//ウィンドウ表示
		frame.setVisible(true);
	}
}

import java.awt.BorderLayout;
import java.awt.Color;
import java.awt.Dimension;
import java.awt.Font;
 
import javax.swing.JFrame;
import javax.swing.JLabel;
import javax.swing.JPanel;
 
public class Panel {
	public static JLabel headerLabel;
	public static JLabel contentsLabel;
	public static void createPanel(JFrame frame) {
		//ヘッダーパネル
		Dimension headerPanelDimension = new Dimension(640, 50);
		JPanel headerPanel = setPanel(Color.BLACK, headerPanelDimension);
		headerLabel = new JLabel("Let's play Guriko");
		headerLabel = setFont(Color.WHITE,headerLabel,24);
		headerPanel.add(headerLabel);
		frame.add(headerPanel,BorderLayout.NORTH);
		
		//コンテンツパネル
		Dimension contentsPanelDimension = new Dimension(640, 380);
		JPanel contentsPanel = setPanel(Color.WHITE,contentsPanelDimension);
		contentsLabel = new JLabel("Rock-Scissors-Paper...");
		contentsLabel = setFont(Color.BLACK,contentsLabel,54);
		contentsPanel.add(contentsLabel);
		frame.add(contentsPanel,BorderLayout.CENTER);
		
		//フッタパネル
		Dimension footerPanelDimension = new Dimension(640, 50);
		JPanel footerPanel = setPanel(Color.BLACK,footerPanelDimension);
		Player.createButton(footerPanel);
		frame.add(footerPanel,BorderLayout.SOUTH);
	}
	public static JPanel setPanel(Color color, Dimension PanelDimension) {
		JPanel panel = new JPanel();
		panel.setPreferredSize(PanelDimension);
		panel.setLayout(new BorderLayout());
		panel.setBackground(color);
		return(panel);
	}
	public static JLabel setFont(Color clr,JLabel label,int strSize) {
		label.setForeground(clr);
		Font labelFont = new Font("ＭＳ ゴシック",Font.PLAIN,strSize);
		label.setFont(labelFont);
		label.setHorizontalAlignment(JLabel.CENTER);
		label.setVerticalAlignment(JLabel.CENTER);
		return(label);
	}
}

import java.awt.BorderLayout;
import java.awt.Dimension;
import java.awt.Font;
import java.awt.event.ActionEvent;
import java.awt.event.ActionListener;
import java.util.Random;
 
import javax.swing.JButton;
import javax.swing.JPanel;
 
public class Player implements ActionListener {
    int win, lose, points1,points2;
	public static void createButton(JPanel footerPanel) {
		//ボタンを表示
		JButton btnGu = new JButton("Rock");
		btnGu = setButton(btnGu);
		footerPanel.add(btnGu, BorderLayout.WEST);
		
		JButton btnChoki = new JButton("Scissors");
		btnChoki = setButton(btnChoki);
		footerPanel.add(btnChoki, BorderLayout.CENTER);
		
		JButton btnPa = new JButton("Paper");
		btnPa = setButton(btnPa);
		footerPanel.add(btnPa, BorderLayout.EAST);
	}
	public static JButton setButton(JButton button) {
		int buttonSizeX = (640 - 20)/3;
		Dimension buttonDimesion = new Dimension(buttonSizeX, 50);
		button.setPreferredSize(buttonDimesion);
		Font buttonFont = new Font("ＭＳ ゴシック",Font.PLAIN,24);
		button.setFont(buttonFont);
		
		Player player = new Player();
		button.addActionListener(player);
		
		return(button);
	}
	public void actionPerformed(ActionEvent e) {
            win = 0;
            lose = 0;
            
          
            
            while (win < 3 && lose < 3) {
            
		String command = e.getActionCommand();
                int playerHand = 0;
                
		if (command.equals("Rock")) playerHand = 0;
		else if (command.equals("Scissors")) playerHand = 1;
		else if (command.equals("Paper"))  playerHand = 2;
		
		Random random = new Random();
		int computerHand = random.nextInt(3);
		if (computerHand == 0) Panel.contentsLabel.setText("Rock");
		else if (computerHand == 1) Panel.contentsLabel.setText("Scissors");
		else if (computerHand == 2) Panel.contentsLabel.setText("Paper");
                
               if(playerHand==0 && computerHand==1) {
                   Panel.headerLabel.setText("Win");
                   win++;
                        
                } else if(playerHand==1 && computerHand==2 || playerHand==2 && computerHand==0) {
                   Panel.headerLabel.setText("Win"); 
                   win++;
                        
		} else if(playerHand==0 && computerHand==2 || playerHand==2 && computerHand==1) {
                   Panel.headerLabel.setText("Lose");
                   lose++;
                        
                } else if(playerHand==1 && computerHand==0) {
                   Panel.headerLabel.setText("Lose");
                   lose++;
                        
                } else if(playerHand==computerHand) {
                   Panel.headerLabel.setText("Drew");
                }
            }
        
         
        }
}
	

Answer 1

Player や Rondom の生成は 1回だけにしましょう。
actionPerformedメソッドからは即座に復帰しないといけません。
actionPerformedはボタンが押されたときの1回分の処理を書きましょう。
win, lose の回数はコンストラクタで初期化し、actionPerformed で 3回勝負がついたら処理を終わらせればいいです。

public class Player implements ActionListener {
    int win = 0, lose = 0;
    Random random = new Random();

    public static void createButton(JPanel panel) {
        Player player = new Player();

        JButton btnGu = player.createButton("Rock");
        panel.add(btnGu, BorderLayout.WEST);

        JButton btnChoki = player.createButton("Scissors");
        panel.add(btnChoki, BorderLayout.CENTER);

        JButton btnPa = player.createButton("Paper");
        panel.add(btnPa, BorderLayout.EAST);
    }

    public JButton createButton(String name) {
        JButton button = new JButton(name);
        int buttonSizeX = (640 - 20)/3;
        Dimension buttonDimesion = new Dimension(buttonSizeX, 50);
        button.setPreferredSize(buttonDimesion);
        Font buttonFont = new Font("ＭＳ ゴシック", Font.PLAIN, 24);
        button.setFont(buttonFont);

        button.addActionListener(this);

        return button;
    }

    public void actionPerformed(ActionEvent e) {
        if (isFinish()) return;

        int playerHand = 0;
        String command = e.getActionCommand();
        if (command.equals("Rock")) playerHand = 0;
        else if (command.equals("Scissors")) playerHand = 1;
        else if (command.equals("Paper"))  playerHand = 2;

        int computerHand = random.nextInt(3);
        if (computerHand == 0) Panel.contentsLabel.setText("Rock");
        else if (computerHand == 1) Panel.contentsLabel.setText("Scissors");
        else if (computerHand == 2) Panel.contentsLabel.setText("Paper");

        if (playerHand == computerHand) {
            Panel.headerLabel.setText("Drew");
        } else if (playerHand==0 && computerHand==1 ||
                   playerHand==1 && computerHand==2 ||
                   playerHand==2 && computerHand==0) {
            Panel.headerLabel.setText("Win");
            win++;
        } else {
            Panel.headerLabel.setText("Lose");
            lose++;
        }

        if (isFinish()) {
            finish();
        }
    }

    boolean isFinish() {
        return win >= 3 || lose >= 3;
    }

    void finish() {
        String judge;
        if( win >= 3) {
            judge = "Congratulations!!<br>You Win!!";
        } else if ( lose >= 3) {
            judge = "You Lose...";
        } else {
            judge = "Wow...<br>You Drew...";
        }

        Panel.headerLabel.setText("Game Over !!");
        Panel.contentsLabel.setText("<html><body><center>" + judge +
                                    "<br>You:" + win + " vs Computer:" + lose +
                                    "</center></body></html>");
    }
}

Answer 2

さらっと実行した限りでは、停止するとか動きがおかしいというのは分かりませんでした。
ただ、グーチョキパーのボタンを押した時になんの為に while ループをするのでしょうか。
押したのは一回の勝負の手だけのはずです。

それと、プログラムとして static を乱用している状態なのが気になることと、(以前のご質問で指摘されていたと思いますが) Random オブジェクトを毎回作成すると出てくるのは偏った値になりますので、一度作成したら使い続けるようにしたほうが良いです。

以下はコンソール版の RspGame を Swing 化する形のものです。(両者はパッケージも変えています。)
3 回勝負で決着が付いたらどのような表示にするのか分からないので、延々と勝負する状態です。

RspGameSwing.java (Swing 版)

package teratail_java.q_9l3rxftcib7ioa;

import java.awt.*;

import javax.swing.*;

import teratail_java.q_9fqaju7u4pul0f.RspGame;
import teratail_java.q_9fqaju7u4pul0f.RspGame.Rsp;

public class RspGameSwing extends JFrame {
  public static void main(String[] args) {
    SwingUtilities.invokeLater(() -> new RspGameSwing().setVisible(true));
  }

  private static final String fontName = "ＭＳ ゴシック";
  private JLabel headerLabel, contentsLabel;

  RspGameSwing() {
    super("Guriko");
    setSize(640, 480);
    setLocationRelativeTo(null);
    setDefaultCloseOperation(JFrame.EXIT_ON_CLOSE);
    setResizable(false);

    RspGame.Computer computer = new RspGame.Computer();
    User user = new User();

    //ヘッダーパネル
    JPanel headerPanel = new JPanel(new BorderLayout());
    headerPanel.setBackground(Color.BLACK);
    headerLabel = createLabel("Let's play Guriko", Color.WHITE, 24);
    headerPanel.add(headerLabel);
    add(headerPanel, BorderLayout.NORTH);

    //コンテンツパネル
    JPanel contentsPanel = new JPanel(new BorderLayout());
    contentsPanel.setBackground(Color.WHITE);
    contentsLabel = createLabel("Rock-Scissors-Paper...", Color.BLACK, 54);
    contentsPanel.add(contentsLabel);
    add(contentsPanel, BorderLayout.CENTER);

    //フッタパネル
    JPanel footerPanel = new JPanel(new GridLayout(1, 3));
    footerPanel.setBackground(Color.WHITE);
    footerPanel.add(createButton(RspGame.Rsp.Rock, user, computer));
    footerPanel.add(createButton(RspGame.Rsp.Scissors, user, computer));
    footerPanel.add(createButton(RspGame.Rsp.Paper, user, computer));
    add(footerPanel,BorderLayout.SOUTH);
  }

  private JLabel createLabel(String text, Color foreground, int fontSize) {
    JLabel label = new JLabel(text);
    label.setForeground(foreground);
    label.setFont(new Font(fontName, Font.PLAIN, fontSize));
    label.setHorizontalAlignment(JLabel.CENTER);
    label.setVerticalAlignment(JLabel.CENTER);
    return label;
  }

  private JButton createButton(RspGame.Rsp rsp, User user, RspGame.Computer computer) {
    JButton button = new JButton("" + rsp);
    button.setFont(new Font(fontName, Font.PLAIN, 24));
    button.addActionListener(v -> judge(user.setRsp(rsp), computer));
    return button;
  }

  void judge(User user, RspGame.Computer computer) {
    Rsp computerRsp = computer.decideNext();

    contentsLabel.setText("" + computerRsp);
    headerLabel.setText(RspGame.winLossJudgement(user, computer));
  }

  class User extends RspGame.Player {
    User setRsp(RspGame.Rsp rsp) {
      latestRsp = rsp;
      return this;
    }
  }
}

RspGame.java ( コンソール 版)

package teratail_java.q_9fqaju7u4pul0f;
//package mygame;

import java.io.*;
import java.util.Random;

public class RspGame {
  public static void main(String[] args) throws IOException {
    BufferedReader reader = new BufferedReader(new InputStreamReader(System.in));
    User user = User.newInstance(reader);
    Computer computer = new Computer();

    while(user.getWinCount() + computer.getWinCount() < 3) {

      Rsp userRsp = user.getRsp(reader);
      Rsp computerRsp = computer.decideNext();

      System.out.println(user.name + ":" + userRsp + " || " + computer.name + ":" + computerRsp);
      System.out.println(winLossJudgement(user, computer));

      System.out.print("<RESULT> " + "WIN:" + user.getWinCount() + " LOSE:" + computer.getWinCount());
      System.out.println(" <SCORE> " + user.name + ":" + user.getWinPoint() + " || " + computer.name + ":" + computer.getWinPoint());
    }

    System.out.println("Finish!!!");
    System.out.println("Let's Judge..........");

    if(user.getWinPoint() > computer.getWinPoint()) {
      System.out.print("Congratulations!! You Win!!");
    } else if(user.getWinPoint() < computer.getWinPoint()) {
      System.out.print("You Lose...");
    } else {
      System.out.print("Wow... You Draw...");
    }
    System.out.println(" <SCORE> " + user.name + ":" + user.getWinPoint() + " || " + computer.name + ":" + computer.getWinPoint());
  }

  public static String winLossJudgement(Player user, Player computer) {
    if(user.latestRsp.drawsWith(computer.latestRsp)) {
      return "Draw";
    }
    if(user.latestRsp.isWinBy(computer.latestRsp)) {
      user.youWin();
      return "Win";
    }
    computer.youWin();
    return "Lose";
  }
  
  public enum Rsp {
    Rock(3), Scissors(6), Paper(6);

    static Rsp valueOf(int i) {
      if(i < 0 || values().length <= i) return null;
      return values()[i];
    }

    final int winPoint;
    Rsp(int winPoint) {
      this.winPoint = winPoint;
    }

    public boolean drawsWith(Rsp other) {
      return ordinal() == other.ordinal();
    }
    public boolean isWinBy(Rsp other) {
      return (ordinal() + 1) % values().length == other.ordinal();
    }
  }

  public static abstract class Player {
    final String name;
    private int winCount, winPoint;
    protected Rsp latestRsp;
    public Player() {
      this("no name");
    }
    public Player(String name) {
      this.name = name;
    }
    public void youWin() {
      this.winCount ++;
      this.winPoint += latestRsp.winPoint;
    }
    public int getWinCount() { return winCount; }
    public int getWinPoint() { return winPoint; }
  }

  static class User extends Player {
    static User newInstance(BufferedReader reader) throws IOException {
      System.out.print("Please enter your Name：");
      return new User(reader.readLine());     
    }
    private User(String name) {
      super(name);
    }
    Rsp getRsp(BufferedReader reader) throws IOException {
      while(true) {
        System.out.println("\nPlease enter your choice");
        System.out.print("(ROCK：0，SCISSORS：1、PAPER：2)　--> ");
        String line = reader.readLine();
        try {
          latestRsp = Rsp.valueOf(Integer.parseInt(line));
          if(latestRsp != null) return latestRsp;
          System.out.println("【ERROR】You can choose only 0, 1 or 2");
        } catch(NumberFormatException e) {
          System.out.println("【ERROR】You can enter only the NUMBER 0, 1 or 2");
        }
      }
    }
  }

  public static class Computer extends Player {
    private Random rand = new Random();
    public Computer() {
      super("Computer");
    }
    public Rsp decideNext() {
      return latestRsp = Rsp.valueOf(rand.nextInt(3));
    }
  }
}