パスカルの三角形　MallocでOver flow がおきます。C言語

LeetCodeの問題でRuntime Errorが出ます。
アドバイスをいただけないでしょうか？
leetcodeの問題のリンクです

Return an array of arrays of size *returnSize.
The sizes of the arrays are returned as *returnColumnSizes array.
Note: Both returned array and *columnSizes array must be malloced, assume caller calls free().

C
1int** generate(int numRows, int** returnColumnSizes, int* returnSize) {
2	
3
4    int **q, i, j;
5
6
7    *returnSize = numRows;
8	q = (int **) malloc (sizeof(int *) * numRows);
9    
10    
11	for (i = 0; i < numRows; i++) {
12        
13        printf("%d\n",i);
14        
15		q[i] = (int *) malloc (sizeof(int) * (i + 1));
16        q[i][0] = 1;
17        q[i][i] = 1;
18        
19        if(i!=0){
20            for(j=1; j<i; j++){
21                q[i][j] = q[i-1][j-1] + q[i-1][j];
22            }    
23        }
24	}
25    
26//この下の３行でエラーが出ています。
27	*returnColumnSizes = (int *) malloc (sizeof(int) * numRows);
28	 for (i = 0; i < numRows; i++) 
29	 	(*returnColumnSizes)[i] = i + 1;
30    
31    return q;  
32    
33    
34}
35
36
37

//修正後のコード

C
1
2
3int** generate(int numRows, int* returnSize , int** returnColumnSizes) {
4	
5    int **q, i, j;
6
7    *returnSize = numRows;
8	q = (int **) malloc (sizeof(int *) * numRows);
9    *returnColumnSizes = (int *) malloc (sizeof(int) * numRows);
10		
11    
12	for (i = 0; i < numRows; i++) {
13        (*returnColumnSizes)[i] = i + 1;
14		q[i] = (int *) malloc (sizeof(int) * (i + 1));
15        q[i][0] = 1;
16        q[i][i] = 1;   
17        
18        if(i!=0){
19            for(j=1; j<i; j++){
20                q[i][j] = q[i-1][j-1] + q[i-1][j];
21            }    
22        }   
23	}
24
25    return q;      
26}
27
28
29
30
31

Error
1=================================================================
2==32==ERROR: AddressSanitizer: stack-buffer-overflow on address 0x7ffece7f8470 at pc 0x557d430bf63e bp 0x7ffece7f83a0 sp 0x7ffece7f8390
3WRITE of size 8 at 0x7ffece7f8470 thread T0
4    #2 0x7f0d7e3130b2 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x270b2)
5Address 0x7ffece7f8470 is located in stack of thread T0 at offset 32 in frame
6  This frame has 5 object(s):
7    [32, 36) 'ret_size' <== Memory access at offset 32 partially overflows this variable
8    [96, 104) 'nbytes'
9    [160, 168) 'line'
10    [224, 232) 'ret_colsize'
11    [288, 292) 'SEPARATOR'
12HINT: this may be a false positive if your program uses some custom stack unwind mechanism, swapcontext or vfork
13      (longjmp and C++ exceptions *are* supported)
14Shadow bytes around the buggy address:
15  0x100059cf7030: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
16  0x100059cf7040: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
17  0x100059cf7050: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
18  0x100059cf7060: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
19  0x100059cf7070: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
20=>0x100059cf7080: 00 00 00 00 00 00 00 00 00 00 f1 f1 f1 f1[04]f2
21  0x100059cf7090: f2 f2 f2 f2 f2 f2 00 f2 f2 f2 f2 f2 f2 f2 00 f2
22  0x100059cf70a0: f2 f2 f2 f2 f2 f2 00 f2 f2 f2 f2 f2 f2 f2 04 f2
23  0x100059cf70b0: f2 f2 00 00 00 00 00 00 00 00 00 00 00 00 00 00
24  0x100059cf70c0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
25  0x100059cf70d0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
26Shadow byte legend (one shadow byte represents 8 application bytes):
27  Addressable:           00
28  Partially addressable: 01 02 03 04 05 06 07 
29  Heap left redzone:       fa
30  Freed heap region:       fd
31  Stack left redzone:      f1
32  Stack mid redzone:       f2
33  Stack right redzone:     f3
34  Stack after return:      f5
35  Stack use after scope:   f8
36  Global redzone:          f9
37  Global init order:       f6
38  Poisoned by user:        f7
39  Container overflow:      fc
40  Array cookie:            ac
41  Intra object redzone:    bb
42  ASan internal:           fe
43  Left alloca redzone:     ca
44  Right alloca redzone:    cb
45  Shadow gap:              cc
46==32==ABORTING

BeatStar

2021/09/26 09:44

> アドバイスをいただけないでしょうか『デバッグしましょう』ですね。プログラミングは『書いて終わり』ではありません。デバッグやテストまで含みます。デバッグはプログラミングする上で当たり前の技術です。『C言語デバッグ方法』とかで検索してください。

alizona

2021/09/26 09:51 編集

テストケースのinput が5の場合 numRows:0 q[0][0]==1 q[0][0]==1 numRows:1 q[1][0]==1 q[1][1]==1 numRows:2 q[2][0]==1 q[2][1]==2 q[2][2]==1 numRows:3 q[3][0]==1 q[3][1]==3 q[3][2]==3 q[3][3]==1 numRows:4 q[4][0]==1 q[4][1]==4 q[4][2]==6 q[4][3]==4 q[4][4]==1 ここまではコメントで出力できてるのですが、 *returnColumnSizes = (int *) malloc (sizeof(int) * numRows); for (i = 0; i < numRows; i++) (*returnColumnSizes)[i] = i + 1; この３行でover flow になります。 returnColumnSizesをmallocできないので、プログラムが qの２次元配列をreturnしても、呼び出し先でouputされた時には、出力が [ ]となります。