teratail
回答率
85.46%
質問するログイン新規登録
トップJavaScriptに関する質問javascript 添削してほしいです

編集履歴

回答編集履歴

6

バグ修正（ w: height を w: width に）

2022/09/15 00:30

投稿

shiracamus
shiracamus

スコア5406

test CHANGED
@@ -40,7 +40,7 @@
40
40
  };
41
41
 
42
42
  const debugChunk = (width, height) => {
43
- const dangeon = splitDangeon([{x: 0, y: 0, w: height, h: height}]);
43
+ const dangeon = splitDangeon([{x: 0, y: 0, w: width, h: height}]);
44
44
  console.log(dangeon);
45
45
  };
46
46
 

5

空白調整

2022/09/15 00:24

投稿

shiracamus
shiracamus

スコア5406

test CHANGED
@@ -28,7 +28,7 @@
28
28
  return chunk;
29
29
  splitChunks = [
30
30
  { x: chunk.x, y: chunk.y, w: chunk.w, h: splitY },
31
- { x: chunk.x, y: splitY, w: chunk.w, h: height },
31
+ { x: chunk.x, y: splitY, w: chunk.w, h: height },
32
32
  ]
33
33
  }
34
34
  if (--divide > 0) {

4

空白調整

2022/09/15 00:23

投稿

shiracamus
shiracamus

スコア5406

test CHANGED
@@ -17,7 +17,7 @@
17
17
  return chunk;
18
18
  splitChunks = [
19
19
  { x: chunk.x, y: chunk.y, w: splitX, h: chunk.h },
20
- { x: splitX, y: chunk.y, w: width, h: chunk.h },
20
+ { x: splitX, y: chunk.y, w: width, h: chunk.h },
21
21
  ];
22
22
  } else { //横
23
23
  let splitY = CHUNK_SPLIT_MIN;

3

変数名スペルミス修正

2022/09/14 10:33

投稿

shiracamus
shiracamus

スコア5406

test CHANGED
@@ -17,7 +17,7 @@
17
17
  return chunk;
18
18
  splitChunks = [
19
19
  { x: chunk.x, y: chunk.y, w: splitX, h: chunk.h },
20
- { x: splitX, y: chunk.y, w: width, h: chunk.h },
20
+ { x: splitX, y: chunk.y, w: width, h: chunk.h },
21
21
  ];
22
22
  } else { //横
23
23
  let splitY = CHUNK_SPLIT_MIN;
@@ -28,7 +28,7 @@
28
28
  return chunk;
29
29
  splitChunks = [
30
30
  { x: chunk.x, y: chunk.y, w: chunk.w, h: splitY },
31
- { x: chunk.x, y: splitY, w: chunk.w, h: height },
31
+ { x: chunk.x, y: splitY, w: chunk.w, h: height },
32
32
  ]
33
33
  }
34
34
  if (--divide > 0) {
@@ -40,9 +40,8 @@
40
40
  };
41
41
 
42
42
  const debugChunk = (width, height) => {
43
- const dangeion = splitDangeon([{x: 0, y: 0, w: height, h: height}]);
43
+ const dangeon = splitDangeon([{x: 0, y: 0, w: height, h: height}]);
44
- console.log(dangeion);
44
+ console.log(dangeon);
45
- console.log('\n');
46
45
  };
47
46
 
48
47
  debugChunk(16, 16);

2

空白調整

2022/09/14 10:26

投稿

shiracamus
shiracamus

スコア5406

test CHANGED
@@ -17,7 +17,7 @@
17
17
  return chunk;
18
18
  splitChunks = [
19
19
  { x: chunk.x, y: chunk.y, w: splitX, h: chunk.h },
20
- { x: splitX, y: chunk.y, w: width, h: chunk.h },
20
+ { x: splitX, y: chunk.y, w: width, h: chunk.h },
21
21
  ];
22
22
  } else { //横
23
23
  let splitY = CHUNK_SPLIT_MIN;
@@ -28,7 +28,7 @@
28
28
  return chunk;
29
29
  splitChunks = [
30
30
  { x: chunk.x, y: chunk.y, w: chunk.w, h: splitY },
31
- { x: chunk.x, y: splitY, w: chunk.w, h: height },
31
+ { x: chunk.x, y: splitY, w: chunk.w, h: height },
32
32
  ]
33
33
  }
34
34
  if (--divide > 0) {

1

変数名変更

2022/09/14 10:25

投稿

shiracamus
shiracamus

スコア5406

test CHANGED
@@ -5,36 +5,36 @@
5
5
 
6
6
  const CHUNK_SPLIT_MIN = 4;
7
7
 
8
- const splitDangeon = (rooms, divide = 10) => {
8
+ const splitDangeon = (chunks, divide = 10) => {
9
- return rooms.flatMap(room => {
9
+ return chunks.flatMap(chunk => {
10
- let splitRooms;
10
+ let splitChunks;
11
11
  if (Math.random() > 0.5) { //縦
12
12
  let splitX = CHUNK_SPLIT_MIN;
13
13
  for (let i = 0; Math.random() > i; i += 0.1)
14
14
  splitX++;
15
- const width = room.w - splitX;
15
+ const width = chunk.w - splitX;
16
16
  if (width <= CHUNK_SPLIT_MIN)
17
- return room;
17
+ return chunk;
18
- splitRooms = [
18
+ splitChunks = [
19
- { x: room.x, y: room.y, w: splitX, h: room.h },
19
+ { x: chunk.x, y: chunk.y, w: splitX, h: chunk.h },
20
- { x: splitX, y: room.y, w: width, h: room.h },
20
+ { x: splitX, y: chunk.y, w: width, h: chunk.h },
21
21
  ];
22
22
  } else { //横
23
23
  let splitY = CHUNK_SPLIT_MIN;
24
24
  for (let i = 0; Math.random() > i; i += 0.1)
25
25
  splitY++;
26
- const height = room.h - splitY;
26
+ const height = chunk.h - splitY;
27
27
  if (height <= CHUNK_SPLIT_MIN)
28
- return room;
28
+ return chunk;
29
- splitRooms = [
29
+ splitChunks = [
30
- { x: room.x, y: room.y, w: room.w, h: splitY },
30
+ { x: chunk.x, y: chunk.y, w: chunk.w, h: splitY },
31
- { x: room.x, y: splitY, w: room.w, h: height },
31
+ { x: chunk.x, y: splitY, w: chunk.w, h: height },
32
32
  ]
33
33
  }
34
34
  if (--divide > 0) {
35
- return splitDangeon(splitRooms, divide);
35
+ return splitDangeon(splitChunks, divide);
36
36
  } else {
37
- return splitRooms;
37
+ return splitChunks;
38
38
  }
39
39
  });
40
40
  };