編集履歴

回答編集履歴

GitHub リンク追加

2021/09/07 16:23

投稿

スコア12670

test CHANGED Viewed

@@ -571,3 +571,19 @@
 }
 ```
+----
+弄ってみたコードを GitHub に入れています。
+[https://github.com/Jimbe-github/teratail_java/tree/master/workspace2/teratail_java/src/teratail_java/q357803](https://github.com/Jimbe-github/teratail_java/tree/master/workspace2/teratail_java/src/teratail_java/q357803)
+C.java はオリジナル、C2.java は GameFrame.java から出した Turtle.java を使って C.java の構造を変えずに番号追加(ついでに点線や繰り返し部分を修正)、GameFrame.java は…まぁこちらのより弄っています ^^;;;

文字表示位置計算、50や9の変数化、亀さん修正など

2021/09/07 16:23

投稿

jimbe

スコア12670

test CHANGED Viewed

@@ -4,7 +4,9 @@
 各イベントの座標に制限が有るのか無いのかコードから良く分からなかったので、全体を対象にしています。
-マスの大きさであるとか文字の位置だとかあちこちに直接数値が書いてありますので、私としてはまだ考える余地のあるコードです。
+動かした見た目は殆ど変わらないのに、コードは修正の度に長く…。
@@ -14,21 +16,9 @@
-import java.awt.BasicStroke;
-import java.awt.Color;
+import java.awt.*;
-import java.awt.Dimension;
-import java.awt.Graphics;
-import java.awt.Graphics2D;
+import java.awt.geom.Rectangle2D;
-import java.awt.GridBagConstraints;
-import java.awt.GridBagLayout;
-import java.awt.Point;
 import java.util.ArrayList;
@@ -86,7 +76,7 @@
     gbc.anchor = GridBagConstraints.CENTER;
-    add(new GamePanel(), gbc); //描画領域の追加
+    add(new GamePanel(50, 9), gbc); //描画領域の追加
   }
@@ -102,15 +92,15 @@
     }
-    final int number, x, y;
+    private int number, x, y;
-    final int gx, gy, size;
+    private int gx, gy, size;
-    private Color background;
+    private Color background = new Color(0, 170, 0);
     private Event event;
-    Square(int number, int x, int y) {
+    Square(int number, int x, int y, int size) {
       this.number = number;
@@ -118,29 +108,23 @@
       this.y = y;
+      this.size = size;
-      this.gx = x * 50;
+      this.gx = x * size;
-      this.gy = y * 50;
+      this.gy = y * size;
-      this.size = 50;
-      this.background = new Color(0, 170, 0);
-    }
+    }
-    void setEvent(Event event) {
+    void setEvent(Event event) { this.event = event; }
-      this.event = event;
-    }
     //イベントがあるか
-    boolean hasEvent() {
-      return event != null;
+    boolean hasEvent() { return event != null; }
-    }
+    //マスの各方向の座標
     Point getPoint(Direction dir) {
@@ -184,9 +168,25 @@
       g.drawRect(gx, gy, size, size); //枠
-      g.drawString(""+number, gx+size-15, gy+size-5); //番号
+      drawStringAtBottomRight(g, ""+number); //番号
-      if(hasEvent()) event.draw(g, gx+5, gy+5+10); //イベント
+      if(hasEvent()) event.draw(g, gx+2, gy+2); //イベント
+    }
+    private void drawStringAtBottomRight(Graphics g, String text) {
+      FontMetrics fm = g.getFontMetrics();
+      int descent = fm.getDescent(); //ベースラインの高さ
+      Rectangle2D rect = fm.getStringBounds(text, g);
+      int width = (int)rect.getWidth(); //文字列の幅
+      g.drawString(text, gx+size-width-1, gy+size-descent-1); //-1 はちょっと隙間
     }
@@ -216,9 +216,21 @@
     void draw(Graphics g, int gx, int gy) {
+      FontMetrics fm = g.getFontMetrics();
+      gy += fm.getAscent(); //ベースラインから文字頂までの高さ
       g.drawString(text1, gx, gy);
+      if(text2 != null) {
+        Rectangle2D rect = fm.getStringBounds(text2, g);
+        gy += (int)rect.getHeight();
-      if(text2 != null) g.drawString(text2, gx, gy+13);
+        g.drawString(text2, gx, gy);
+      }
     }
@@ -272,10 +284,18 @@
-  //亀さん
+  //右好きの亀さん
   private static class Turtle {
+    interface Confirm {
+      //安全確認. x,y にマイナスや大きな値が入っても例外を出さないよう注意.
+      boolean isSafe(int x, int y);
+    }
     enum Direction {
       NORTH(0,-1) { Direction right() { return EAST; } },
@@ -288,7 +308,7 @@
-      int dx, dy;
+      final int dx, dy;
       Direction(int dx, int dy) {
@@ -306,7 +326,9 @@
     private Direction dir;
+    private Confirm confirm;
-    Turtle(int x, int y, Direction dir) {
+    Turtle(int x, int y, Direction dir, Confirm confirm) {
       this.x = x;
@@ -314,29 +336,23 @@
       this.dir = dir;
+      this.confirm = confirm;
-    }
+    }
+    int getX() { return x; }
+    int getY() { return y; }
-    Point forward() {
+    void forward() {
       x += dir.dx;
       y += dir.dy;
-      return new Point(x, y);
-    }
-    Point getRightPoint() {
-      Direction right = dir.right();
+      Direction sence = dir.right(); //この辺が右好き
-      return new Point(x+right.dx, y+right.dy);
+      if(confirm.isSafe(x+sence.dx, y+sence.dy)) dir = sence;
-    }
-    void turnRight() {
-      dir = dir.right();
     }
@@ -352,13 +368,23 @@
     private Random random = new Random();
+    private final int square_size;
+    private final int square_count;
-    GamePanel() {
+    GamePanel(int square_size, int square_count) {
       super(null);
+      this.square_size = square_size;
+      this.square_count = square_count;
-      setPreferredSize(new Dimension(50*9+50, 50*9));
+      setPreferredSize(new Dimension(square_size*(square_count+1), square_size*square_count));
       setMinimumSize(getPreferredSize());
@@ -398,31 +424,25 @@
     private void initSquareList() {
-      int i = 0;
-      squareList.add(new Square(i+1, 4, 4));
-      Turtle t = new Turtle(4, 4, Turtle.Direction.EAST);
+      Turtle turtle = new Turtle(square_count/2, square_count/2, Turtle.Direction.EAST, new Turtle.Confirm() {
-      for(i++ ; i<9*9; i++) {
-        Point point = t.forward();
+        @Override
-        squareList.add(new Square(i+1, point.x, point.y));
+        public boolean isSafe(int x, int y) {
-        Point right = t.getRightPoint();
-        boolean found = false;
-        for(Square s : squareList) {
-          if(found = (s.x == right.x && s.y == right.y)) break;
+          for(Square s : squareList) if(s.x == x && s.y == y) return false; //既に通った
+          return true;
         }
+      });
+      for(int number=1; number<=square_count*square_count; turtle.forward(), number++) {
-        if(!found) t.turnRight(); //右に進めるなら右に曲がる
+        squareList.add(new Square(number, turtle.getX(), turtle.getY(), square_size));
       }
@@ -480,7 +500,7 @@
     private Square getRandomSquare() {
-      return getRandomSquare(9,0,9,0);
+      return getRandomSquare(square_count,0,square_count,0);
     }
@@ -498,11 +518,7 @@
     private Square getSquare(int x, int y) {
-      for(Square s : squareList) {
-        if(s.x == x && s.y == y) return s;
+      for(Square s : squareList) if(s.x == x && s.y == y) return s;
-      }
       return null;
@@ -520,11 +536,11 @@
       g.setColor(Color.yellow);
-      g.fillRect(50*9, 0, 50, 50);
+      g.fillRect(square_size*square_count, 0, square_size, square_size);
       g.setColor(Color.black);
-      g.drawString("ゴール", 50*9+5, 13);
+      g.drawString("ゴール", square_size*square_count+5, 13);
@@ -540,9 +556,9 @@
       dotLineDrawer.setStart(squareList.get(0).getPoint(Square.Direction.CENTER));
-      for(int i=1; i<squareList.size()-1; i++) {
+      for(Square s : squareList.subList(1, squareList.size()-1)) {
-        dotLineDrawer.draw(g, squareList.get(i).getPoint(Square.Direction.CENTER));
+        dotLineDrawer.draw(g, s.getPoint(Square.Direction.CENTER));
       }

点線を BasicStroke 使用に変更、螺旋化を亀さん使用に変更。

2021/09/05 18:20

投稿

jimbe

スコア12670

test CHANGED Viewed

@@ -14,18 +14,26 @@
+import java.awt.BasicStroke;
 import java.awt.Color;
 import java.awt.Dimension;
 import java.awt.Graphics;
+import java.awt.Graphics2D;
 import java.awt.GridBagConstraints;
 import java.awt.GridBagLayout;
 import java.awt.Point;
+import java.util.ArrayList;
+import java.util.List;
 import java.util.Random;
@@ -94,9 +102,9 @@
     }
-    private int number;
+    final int number, x, y;
-    private int gx, gy, size;
+    final int gx, gy, size;
     private Color background;
@@ -106,6 +114,10 @@
       this.number = number;
+      this.x = x;
+      this.y = y;
       this.gx = x * 50;
       this.gy = y * 50;
@@ -218,19 +230,13 @@
   private static class DotLineDrawer {
-    private int count;
     private int x, y;
-    private int solid_period;
+    private BasicStroke dashed;
-    private int pattern_length;
-    DotLineDrawer(int solid_period, int space_period) {
+    DotLineDrawer(int solid_period) {
-      this.solid_period = solid_period;
-      this.pattern_length = solid_period + space_period;
+      dashed = new BasicStroke(0, BasicStroke.CAP_BUTT, BasicStroke.JOIN_MITER, 1, new float[]{solid_period}, 0);
     }
@@ -238,8 +244,6 @@
     void setStart(Point start) {
-      count = 0;
       x = start.x;
       y = start.y;
@@ -250,105 +254,177 @@
     void draw(Graphics g, Point end) {
+      Graphics2D g2 = (Graphics2D)g.create();
+      g2.setStroke(dashed);
+      g2.drawLine(x, y, end.x, end.y);
+      g2.dispose();
+      x = end.x;
+      y = end.y;
+    }
+  }
+  //亀さん
+  private static class Turtle {
+    enum Direction {
+      NORTH(0,-1) { Direction right() { return EAST; } },
+      SOUTH(0, 1) { Direction right() { return WEST; } },
+      EAST( 1,0) { Direction right() { return SOUTH; } },
+      WEST(-1,0) { Direction right() { return NORTH; } };
+      int dx, dy;
+      Direction(int dx, int dy) {
+        this.dx = dx;
+        this.dy = dy;
+      }
+      abstract Direction right();
+    }
+    private int x, y;
+    private Direction dir;
+    Turtle(int x, int y, Direction dir) {
+      this.x = x;
+      this.y = y;
+      this.dir = dir;
+    }
+    Point forward() {
+      x += dir.dx;
+      y += dir.dy;
+      return new Point(x, y);
+    }
+    Point getRightPoint() {
+      Direction right = dir.right();
+      return new Point(x+right.dx, y+right.dy);
+    }
+    void turnRight() {
+      dir = dir.right();
+    }
+  }
+  //描画する紙を表すクラス
+  private static class GamePanel extends JPanel {
+    private List<Square> squareList = new ArrayList<>(); //中心を index=0 とし、螺旋を展開した直線状態
+    private Random random = new Random();
+    GamePanel() {
+      super(null);
+      setPreferredSize(new Dimension(50*9+50, 50*9));
+      setMinimumSize(getPreferredSize());
+      initSquareList();
+      squareList.get(0).setEvent(new Event("スタート"));
+      setForwardingEvent(); //"進む"イベント(1)
+      setRotateEvent("⤵ 90°"); //盤面回転イベント(1)
+      setForwardingEvent(); //"進む"イベント(2)
+      setRotateEvent("⤵ 180°"); //盤面回転イベント(2)
+      setForwardingEvent(); //"進む"イベント(3)
-      if(x != end.x) { //横線?
+      setToLeftEvent(); //"左へ"イベント
+      setForwardingEvent(); //"進む"イベント(4)
+      setForwardingEvent(); //"進む"イベント(5)
+      setForwardingEvent(); //"進む"イベント(6)
+    }
+    //マス準備
+    private void initSquareList() {
+      int i = 0;
+      squareList.add(new Square(i+1, 4, 4));
+      Turtle t = new Turtle(4, 4, Turtle.Direction.EAST);
+      for(i++ ; i<9*9; i++) {
+        Point point = t.forward();
+        squareList.add(new Square(i+1, point.x, point.y));
-        int dx = (int)Math.signum(end.x - x);
+        Point right = t.getRightPoint();
+        boolean found = false;
-        for( ; x!=end.x; x+=dx, count=(count+1)%pattern_length) {
+        for(Square s : squareList) {
-          if(count < solid_period) g.drawRect(x, y, 0, 0);
+          if(found = (s.x == right.x && s.y == right.y)) break;
         }
-      } else { //縦線
-        int dy = (int)Math.signum(end.y - y);
-        for( ; y!=end.y; y+=dy, count=(count+1)%pattern_length) {
-          if(count < solid_period) g.drawRect(x, y, 0, 0);
+        if(!found) t.turnRight(); //右に進めるなら右に曲がる
-        }
+      }
-      }
-    }
-  }
-  //描画する紙を表すクラス
-  private static class GamePanel extends JPanel {
-    //螺旋座標
-    private static final int POINTS[] = {
-        4,4,  5,4,  5,5,  4,5,  3,5,  3,4,  3,3,  4,3,  5,3,
-        6,3,  6,4,  6,5,  6,6,  5,6,  4,6,  3,6,  2,6,  2,5,
-        2,4,  2,3,  2,2,  3,2,  4,2,  5,2,  6,2,  7,2,  7,3,
-        7,4,  7,5,  7,6,  7,7,  6,7,  5,7,  4,7,  3,7,  2,7,
-        1,7,  1,6,  1,5,  1,4,  1,3,  1,2,  1,1,  2,1,  3,1,
-        4,1,  5,1,  6,1,  7,1,  8,1,  8,2,  8,3,  8,4,  8,5,
-        8,6,  8,7,  8,8,  7,8,  6,8,  5,8,  4,8,  3,8,  2,8,
-        1,8,  0,8,  0,7,  0,6,  0,5,  0,4,  0,3,  0,2,  0,1,
-        0,0,  1,0,  2,0,  3,0,  4,0,  5,0,  6,0,  7,0,  8,0
-    };
-    private Square squares[] = new Square[9*9]; //中心を [0] とし、螺旋を展開した直線状態
-    private Random random = new Random();
-    GamePanel() {
-      super(null);
-      setPreferredSize(new Dimension(50*9+50, 50*9));
-      setMinimumSize(getPreferredSize());
-      for(int number=1, i=0, j=0; number<=9*9; number++, i++, j+=2) {
-        squares[i] = new Square(number, POINTS[j], POINTS[j+1]);
-      }
-      squares[0].setEvent(new Event("スタート"));
-      setForwardingEvent(); //"進む"イベント(1)
-      setRotateEvent("⤵ 90°"); //盤面回転イベント(1)
-      setForwardingEvent(); //"進む"イベント(2)
-      setRotateEvent("⤵ 180°"); //盤面回転イベント(2)
-      setForwardingEvent(); //"進む"イベント(3)
-      setToLeftEvent(); //"左へ"イベント
-      setForwardingEvent(); //"進む"イベント(4)
-      setForwardingEvent(); //"進む"イベント(5)
-      setForwardingEvent(); //"進む"イベント(6)
     }
@@ -422,9 +498,9 @@
     private Square getSquare(int x, int y) {
-      for(int i=0; i<POINTS.length; i+=2) {
+      for(Square s : squareList) {
-        if(POINTS[i] == x && POINTS[i+1] == y) return squares[i/2];
+        if(s.x == x && s.y == y) return s;
       }
@@ -454,27 +530,23 @@
       //各マス
-      for(int i=0; i<squares.length; i++) {
-        squares[i].draw(g);
+      for(Square s : squareList) s.draw(g);
-      }
       //点線
-      DotLineDrawer dotLineDrawer = new DotLineDrawer(5,5);
+      DotLineDrawer dotLineDrawer = new DotLineDrawer(5);
-      dotLineDrawer.setStart(squares[0].getPoint(Square.Direction.CENTER));
+      dotLineDrawer.setStart(squareList.get(0).getPoint(Square.Direction.CENTER));
-      for(int i=1; i<squares.length-1; i++) {
+      for(int i=1; i<squareList.size()-1; i++) {
-        dotLineDrawer.draw(g, squares[i].getPoint(Square.Direction.CENTER));
+        dotLineDrawer.draw(g, squareList.get(i).getPoint(Square.Direction.CENTER));
-      }
+      }
-      dotLineDrawer.draw(g, squares[squares.length-1].getPoint(Square.Direction.EAST)); //最後はマスの右端まで
+      dotLineDrawer.draw(g, squareList.get(squareList.size()-1).getPoint(Square.Direction.EAST)); //最後はマスの右端まで
     }

getSquare 修正

2021/09/05 13:33

投稿

jimbe

スコア12670

test CHANGED Viewed

@@ -422,7 +422,13 @@
     private Square getSquare(int x, int y) {
+      for(int i=0; i<POINTS.length; i+=2) {
+        if(POINTS[i] == x && POINTS[i+1] == y) return squares[i/2];
+      }
-      return squares[y*9+x];
+      return null;
     }