回答編集履歴

rest_counts/rest_sets 及び Status 関係を追加

2020/05/14 20:00

投稿

jimbe

スコア13355

answer CHANGED Viewed

@@ -19,7 +19,7 @@
 import android.widget.TextView;
 public class CountDownTimerActivity extends AppCompatActivity implements Workout.Listener {
-  private TextView setTextView, countTextView, lefttimeTextView;
+  private TextView setTextView, countTextView, statusTextView, lefttimeTextView;
   private ProgressBar progressBar;
   private Button startStopButton, resetButton;
   private View.OnClickListener onStartListener, onStopListener;
@@ -36,10 +36,10 @@
     setTextView = findViewById(R.id.setNumber);
     countTextView = findViewById(R.id.countNumber);
+    statusTextView = findViewById(R.id.status);
     lefttimeTextView = findViewById(R.id.timeLeft);
     progressBar = findViewById(R.id.pb);
-    progressBar.setMax(workout.getTickMax());
     startStopButton = findViewById(R.id.button_start_stop);
@@ -68,7 +68,7 @@
   }
   private Workout getWorkout(int id) {
-    return new Workout("test",10,0,2,1,0); //テスト用
+    return new Workout("test",10,5,2,2,20); //テスト用
     /*
     try (Cursor cursor = NewListItemActivity.mSQLiteHelper.getData("SELECT * FROM WORKOUTLIST WHERE id=" + id);) {
       while(cursor.moveToNext()) {
@@ -88,7 +88,11 @@
   private void showWorkout(WorkoutProperties properties) {
     countTextView.setText(""+properties.getCount());
     setTextView.setText(""+properties.getSet());
+    statusTextView.setText(""+properties.getStatus());
+    if(progressBar.getMax() != properties.getTickMax()) {
+      progressBar.setMax(properties.getTickMax());
+    }
     progressBar.setProgress(properties.getTickMax() - properties.getTick());
     int left = properties.getLeftSecond();
@@ -159,6 +163,7 @@
   int getTick();
   int getTickMax();
   int getLeftSecond();
+  Workout.Status getStatus();
 }
 class Workout implements WorkoutProperties {
@@ -168,31 +173,43 @@
     void finish(WorkoutProperties properties);
     void stop(WorkoutProperties properties);
   }
+  enum Status {
+    Nonexecution, Training, RestCounts, RestSets
+  }
   private static final int PARTICLE_SIZE = 20; //1秒を何tickに分けるか
-  //private String name;
+  private String name;
-  //private int time; //トレーニング時間[s]
+  private int time; //トレーニング時間[s]
-  //private int rest_time; //休憩時間[s]
+  private int rest_counts; //休憩時間[s]
   private int countMax; //カウント
   private int setMax; //セット数
-  //private int set_during; //セット間の休憩時間[s]
+  private int rest_sets; //セット間の休憩時間[s]
   private Listener listener;
   private Timer timer;
   private int tick, tickMax;
   private int count, set;
+  private Status status;
   private Handler handler;
+  /**
+   *
+   * @param name トレーニング名?
+   * @param time トレーニング時間[s]
+   * @param rest_counts 休憩時間[s]
+   * @param count カウント
+   * @param set セット数
+   * @param rest_sets セット間の休憩時間[s]
+   */
-  Workout(String name, int time, int rest_time, int count, int set, int set_during) {
+  Workout(String name, int time, int rest_counts, int count, int set, int rest_sets) {
-    //this.name = name;
+    this.name = name;
-    //this.time = time;
+    this.time = time;
-    //this.rest_time = rest_time;
+    this.rest_counts = rest_counts;
     this.countMax = count;
     this.setMax = set;
-    //this.set_during = set_during;
+    this.rest_sets = rest_sets;
-    this.tickMax = time * PARTICLE_SIZE;
     this.handler = new Handler();
     reset();
@@ -203,16 +220,17 @@
   public int getTick() { return tick; }
   public int getTickMax() { return tickMax; }
   public int getLeftSecond() { return calcLeftSecond(tick); }
+  public Status getStatus() { return status; }
   private static int calcLeftSecond(int tick) { return (tick + PARTICLE_SIZE - 1) / PARTICLE_SIZE; }
   synchronized void start(Listener listener) {
-    if(timer != null)
-      throw new IllegalStateException();
+    if(timer != null) throw new IllegalStateException();
     this.listener = listener;
+    status = Status.Training;
+    listener.start(Workout.this);
     timer = new Timer();
     timer.scheduleAtFixedRate(new TickTask(), 1000L / PARTICLE_SIZE, 1000L / PARTICLE_SIZE); //[ms]
-    listener.start(Workout.this);
   }
   private class TickTask extends TimerTask {
@@ -240,12 +258,33 @@
   }
   private boolean downTick() {
+    if(--tick > 0) return false;
+    switch(status) {
+      case RestCounts:
-    if(--tick <= 0) {
+        if(count <= 0) {
+          status = Status.RestSets;
+          tickMax = rest_sets * PARTICLE_SIZE;
+          tick = tickMax;
+          break;
+        }
+        /*break;*/
+      case RestSets:
+        status = Status.Training;
+        if(count <= 0) count = countMax;
+        tickMax = time * PARTICLE_SIZE;
+        tick = tickMax;
+        break;
+      default: //Training
-      if(--count <= 0) {
+        if(--count <= 0) {
+          if(--set <= 0) {
+            status = Status.Nonexecution;
-        if(--set <= 0) return true; //finish
+            return true; //finish
-        count = countMax;
-      }
+          }
+        }
+        status = Status.RestCounts;
+        tickMax = rest_counts * PARTICLE_SIZE;
-      tick = tickMax;
+        tick = tickMax;
     }
     return false;
   }
@@ -253,12 +292,14 @@
   private static class WorkoutSnapshot implements WorkoutProperties {
     private int tick, tickMax;
     private int count, set;
+    private Status status;
     WorkoutSnapshot(Workout wo) {
       this.tick = wo.tick;
       this.tickMax = wo.tickMax;
       this.count = wo.count;
       this.set = wo.set;
+      this.status = wo.status;
     }
     public int getSet() { return set; }
@@ -266,6 +307,7 @@
     public int getTick() { return tick; }
     public int getTickMax() { return tickMax; }
     public int getLeftSecond() { return calcLeftSecond(tick); }
+    public Status getStatus() { return status; }
   }
   private synchronized void postProgress(WorkoutProperties properties) {
@@ -294,9 +336,11 @@
   synchronized void reset() {
     if(timer == null) {
-      this.count = countMax;
+      count = countMax;
-      this.set = setMax;
+      set = setMax;
+      tickMax = time * PARTICLE_SIZE;
-      this.tick = tickMax;
+      tick = tickMax;
+      status = Status.Nonexecution;
     }
   }
 }

CountDownTimer から Timer#scheduleAtFixedRate に変更

2020/05/14 20:00

投稿

jimbe

スコア13355

answer CHANGED Viewed

@@ -27,7 +27,7 @@
   @Override
   protected void onCreate(Bundle savedInstanceState) {
     super.onCreate(savedInstanceState);
-    setContentView(R.layout.activity_main); //activity_count_down_timer
+    setContentView(R.layout.activity_count_down_timer);
     //データベースからトレーニングの中身を取得する
     Intent intent = getIntent();
@@ -68,7 +68,7 @@
   }
   private Workout getWorkout(int id) {
-    return new Workout("test",10,0,3,4,0); //テスト用
+    return new Workout("test",10,0,2,1,0); //テスト用
     /*
     try (Cursor cursor = NewListItemActivity.mSQLiteHelper.getData("SELECT * FROM WORKOUTLIST WHERE id=" + id);) {
       while(cursor.moveToNext()) {
@@ -85,12 +85,13 @@
     */
   }
-  private void showWorkout(Workout workout) {
+  private void showWorkout(WorkoutProperties properties) {
-    countTextView.setText(""+workout.getCount());
+    countTextView.setText(""+properties.getCount());
-    setTextView.setText(""+workout.getSet());
+    setTextView.setText(""+properties.getSet());
-    progressBar.setProgress(workout.getTick());
+    progressBar.setProgress(properties.getTickMax() - properties.getTick());
-    int left = workout.getLeftSecond();
+    int left = properties.getLeftSecond();
     int minute = left / 60;
     int second = left % 60;
     lefttimeTextView.setText(String.format((minute>0?"%1$02d:":"")+"%2$02d", minute, second));
@@ -106,26 +107,26 @@
   }
   @Override
-  public void start(Workout workout) {
+  public void start(WorkoutProperties properties) {
     setStop();
     startStopButton.setEnabled(true);
     resetButton.setEnabled(false);
   }
   @Override
-  public void progress(Workout workout) {
+  public void progress(WorkoutProperties properties) {
-    showWorkout(workout);
+    showWorkout(properties);
   }
   @Override
-  public void finish(Workout workout) {
+  public void finish(WorkoutProperties properties) {
-    showWorkout(workout);
+    showWorkout(properties);
     startStopButton.setEnabled(false);
     resetButton.setEnabled(true);
   }
   @Override
-  public void stop(Workout workout) {
+  public void stop(WorkoutProperties properties) {
     setRestart();
     startStopButton.setEnabled(true);
     resetButton.setEnabled(true);
@@ -148,15 +149,24 @@
 ```java
 package com.teratail.q259715;
-import android.os.CountDownTimer;
+import android.os.Handler;
-import android.util.Log;
+import java.util.*;
-class Workout {
+interface WorkoutProperties {
+  int getSet();
+  int getCount();
+  int getTick();
+  int getTickMax();
+  int getLeftSecond();
+}
+class Workout implements WorkoutProperties {
   interface Listener {
-    void start(Workout workout);
+    void start(WorkoutProperties properties);
-    void progress(Workout workout);
+    void progress(WorkoutProperties properties);
-    void finish(Workout workout);
+    void finish(WorkoutProperties properties);
-    void stop(Workout workout);
+    void stop(WorkoutProperties properties);
   }
   private static final int PARTICLE_SIZE = 20; //1秒を何tickに分けるか
@@ -169,10 +179,10 @@
   //private int set_during; //セット間の休憩時間[s]
   private Listener listener;
-  private CountDownTimer countDownTimer;
+  private Timer timer;
   private int tick, tickMax;
   private int count, set;
-  private boolean firstTick = false; //CountDownTimer の 最初の onTick を無視するため
+  private Handler handler;
   Workout(String name, int time, int rest_time, int count, int set, int set_during) {
     //this.name = name;
@@ -183,62 +193,111 @@
     //this.set_during = set_during;
     this.tickMax = time * PARTICLE_SIZE;
+    this.handler = new Handler();
     reset();
   }
-  int getSet() { return set; }
+  public int getSet() { return set; }
-  int getCount() { return count; }
+  public int getCount() { return count; }
-  int getTick() { return tick; }
+  public int getTick() { return tick; }
-  int getTickMax() { return tickMax; }
+  public int getTickMax() { return tickMax; }
-  int getLeftSecond() { return (tick+PARTICLE_SIZE-1) / PARTICLE_SIZE; }
+  public int getLeftSecond() { return calcLeftSecond(tick); }
+  private static int calcLeftSecond(int tick) { return (tick + PARTICLE_SIZE - 1) / PARTICLE_SIZE; }
-  void start(Listener listener) {
+  synchronized void start(Listener listener) {
+    if(timer != null)
+      throw new IllegalStateException();
     this.listener = listener;
-    long millisInFuture = (tick+tickMax*(count*set-1))*1000L/PARTICLE_SIZE;
-    firstTick = true;
+    timer = new Timer();
-    countDownTimer = new CountDownTimer(millisInFuture, 1000L/PARTICLE_SIZE) { //[ms]
+    timer.scheduleAtFixedRate(new TickTask(), 1000L / PARTICLE_SIZE, 1000L / PARTICLE_SIZE); //[ms]
+    listener.start(Workout.this);
+  }
+  private class TickTask extends TimerTask {
-      @Override
+    @Override
-      public void onTick(long ignore) {
+    public void run() {
-        if(firstTick) { //最初の onTick を無視
+      boolean finish = downTick();
+      final WorkoutProperties properties = new WorkoutSnapshot(Workout.this);
+      handler.post(new Runnable() {
-          firstTick = false;
+        public void run() {
-          return;
+          postProgress(properties);
         }
+      });
+      if(finish) {
+        synchronized(this) {
-        downTick();
+          timer.cancel();
+          timer = null;
+        }
+        handler.post(new Runnable() {
+          public void run() {
-        Workout.this.listener.progress(Workout.this);
+            postFinish(properties);
+          }
+        });
       }
-      @Override
-      public void onFinish() {
-        onTick(0L); //終了時の Tick を発生(したように見せかける)
-        Workout.this.listener.finish(Workout.this);
-        Workout.this.listener = null;
-      }
+    }
-    }.start();
-    listener.start(Workout.this);
   }
-  private void downTick() {
+  private boolean downTick() {
     if(--tick <= 0) {
       if(--count <= 0) {
-        if(--set <= 0) return; //finish
+        if(--set <= 0) return true; //finish
         count = countMax;
       }
       tick = tickMax;
     }
+    return false;
   }
+  private static class WorkoutSnapshot implements WorkoutProperties {
+    private int tick, tickMax;
+    private int count, set;
+    WorkoutSnapshot(Workout wo) {
+      this.tick = wo.tick;
+      this.tickMax = wo.tickMax;
+      this.count = wo.count;
-  void stop() {
+      this.set = wo.set;
+    }
+    public int getSet() { return set; }
+    public int getCount() { return count; }
+    public int getTick() { return tick; }
+    public int getTickMax() { return tickMax; }
+    public int getLeftSecond() { return calcLeftSecond(tick); }
+  }
+  private synchronized void postProgress(WorkoutProperties properties) {
-    if(countDownTimer != null) {
+    if(listener != null) {
-      countDownTimer.cancel();
+      listener.progress(properties);
+    }
+  }
+  private synchronized void postFinish(WorkoutProperties properties) {
-      countDownTimer = null;
+    if(listener != null) {
-      listener.stop(this);
+      listener.finish(properties);
       listener = null;
     }
   }
+  synchronized void stop() {
+    if(timer != null) {
-  void reset() {
+      timer.cancel();
+      timer = null;
+      if(listener != null) {
-    this.count = countMax;
+        listener.stop(this);
-    this.set = setMax;
+        listener = null;
-    this.tick = tickMax;
+      }
+    }
   }
+  synchronized void reset() {
+    if(timer == null) {
+      this.count = countMax;
+      this.set = setMax;
+      this.tick = tickMax;
+    }
+  }
 }
 ```

Workout のイベント発生とカウントダウンのタイミングを変更

2020/05/13 15:50

投稿

jimbe

スコア13355

answer CHANGED Viewed

@@ -149,6 +149,7 @@
 package com.teratail.q259715;
 import android.os.CountDownTimer;
+import android.util.Log;
 class Workout {
   interface Listener {
@@ -158,7 +159,7 @@
     void stop(Workout workout);
   }
-  private static final int PARTICLE_SIZE = 2; //1秒を何tickに分けるか
+  private static final int PARTICLE_SIZE = 20; //1秒を何tickに分けるか
   //private String name;
   //private int time; //トレーニング時間[s]
@@ -171,6 +172,7 @@
   private CountDownTimer countDownTimer;
   private int tick, tickMax;
   private int count, set;
+  private boolean firstTick = false; //CountDownTimer の 最初の onTick を無視するため
   Workout(String name, int time, int rest_time, int count, int set, int set_during) {
     //this.name = name;
@@ -189,35 +191,40 @@
   int getCount() { return count; }
   int getTick() { return tick; }
   int getTickMax() { return tickMax; }
-  int getLeftSecond() { return tick / PARTICLE_SIZE; }
+  int getLeftSecond() { return (tick+PARTICLE_SIZE-1) / PARTICLE_SIZE; }
   void start(Listener listener) {
     this.listener = listener;
     long millisInFuture = (tick+tickMax*(count*set-1))*1000L/PARTICLE_SIZE;
+    firstTick = true;
     countDownTimer = new CountDownTimer(millisInFuture, 1000L/PARTICLE_SIZE) { //[ms]
       @Override
-      public void onTick(long millisUntilFinished) {
+      public void onTick(long ignore) {
-        tick --;
+        if(firstTick) { //最初の onTick を無視
-        if(tick < 0) {
+          firstTick = false;
-          tick = tickMax - 1;
-          if(--count <= 0) {
-            set --;
+          return;
-            count = countMax;
-          }
         }
+        downTick();
         Workout.this.listener.progress(Workout.this);
       }
       @Override
       public void onFinish() {
-        tick = 0;
+        onTick(0L); //終了時の Tick を発生(したように見せかける)
-        count = 0;
-        set = 0;
         Workout.this.listener.finish(Workout.this);
         Workout.this.listener = null;
       }
     }.start();
     listener.start(Workout.this);
   }
+  private void downTick() {
+    if(--tick <= 0) {
+      if(--count <= 0) {
+        if(--set <= 0) return; //finish
+        count = countMax;
+      }
+      tick = tickMax;
+    }
+  }
   void stop() {
     if(countDownTimer != null) {