編集履歴

回答編集履歴

コード追加

2020/01/22 11:51

投稿

スコア13395

answer CHANGED Viewed

@@ -1,4 +1,323 @@
 かなりひどいコードです.
 命名規則を無視し変数名はテキトウ, スコープを理解せずオブジェクトをそこら中で作りまくり, static 変数だらけです.
-Fishing を new するのはメインメソッドでの1回のみとなるように, スコープを理解して修正してみてください.
+Fishing を new するのはメインメソッドでの1回のみとなるように, スコープを理解して修正してみてください.
+---
+```java
+import java.awt.CardLayout;
+import java.awt.event.*;
+import java.util.Random;
+import javax.swing.*;
+public class JFishing extends JFrame {
+  /** 魚 */
+  private static class Fish {
+    private ImageIcon icon;
+    private int score;
+    Fish(String iconName, int score) {
+      icon = new ImageIcon(iconName);
+      this.score = score;
+    }
+    Icon getIcon() { return icon; }
+    int getScore() { return score; }
+  }
+  /** 釣り上げチャンス */
+  private static class CatchChance {
+    private static Random random = new Random(System.currentTimeMillis());
+    private int ratio;
+    private Icon icon;
+    private int time;
+    private Fish[] fishes;
+    /**
+     * コンストラクタ
+     * @param ratio 確率(全体に占める割合)
+     * @param iconName イメージファイル名
+     * @param time 継続時間
+     * @param fishes 釣れる可能性のある魚の配列
+     */
+    CatchChance(int ratio, String iconName, int time, Fish ... fishes) {
+      this.ratio = ratio;
+      this.icon = new ImageIcon(iconName);
+      this.time = time;
+      this.fishes = fishes;
+    }
+    int getRatio() { return ratio; }
+    Icon getIcon() { return icon; }
+    int getTime() { return time; }
+    Fish getFish() {
+      if(fishes.length == 0) return null;
+      int j = random.nextInt(fishes.length);
+      return fishes[j];
+    }
+  };
+  /** 魚が掛かっていない状態 */
+  private static class NormalState extends CatchChance {
+    private Random random = new Random(System.currentTimeMillis());
+    NormalState(String iconName) {
+      super(0, iconName, 0);
+    }
+    /** 魚が掛かっていない時間 */
+    int getTime() {
+      return 100 * (random.nextInt(50) + 1); // 100 - 5000
+    }
+  }
+  private static final CatchChance CATCH_CHANCES[] = {
+      new NormalState("しーん.jpg"),
+      new CatchChance(11,"！.jpg",    600, new Fish("N0.jpg" ,  0), new Fish("N1.jpg" , 50), new Fish("N2.jpg" ,  50), new Fish("N3.jpg" ,100), new Fish("N4.jpg" , 100)),
+      new CatchChance( 7,"！！.jpg",  400, new Fish("R0.jpg" ,150), new Fish("R1.jpg" ,150), new Fish("R2.jpg" , 200), new Fish("R3.jpg" ,200), new Fish("R4.jpg" , 250)),
+      new CatchChance( 2,"！！！.jpg",300, new Fish("SR0.jpg",300), new Fish("SR1.jpg",300), new Fish("SR2.jpg", 400), new Fish("SR3.jpg",400), new Fish("SR4.jpg", 500)),
+      new CatchChance( 0,"？.jpg",      0, new Fish("SC0.jpg",-50), new Fish("SC1.jpg",-50), new Fish("SC2.jpg",-100), new Fish("SC3.jpg",  0), new Fish("SC4.jpg",1000))
+  };
+  public static void main(String[] args) {
+    new JFishing().setVisible(true);
+  }
+  //private int flag = 0; //使い道不定
+  private int gamescore = 0;
+  private int alltime = 0; //60sカウントに使う。
+  private CardLayout mgr;
+  private CatchPanel catchPanel;
+  JFishing() {
+    super();
+    setDefaultCloseOperation(JFrame.EXIT_ON_CLOSE);
+    setBounds(550, 100, 770, 800);
+    mgr = new CardLayout();
+    getContentPane().setLayout(mgr);
+    add(new TitlePanel(),   "Title");
+    add(new ExplainPanel(), "Explain");
+    add(new GamePanel(),    "Game");
+    catchPanel = new CatchPanel();
+    add(catchPanel, "Catch");
+    showTitlePanel();
+  }
+  private void showTitlePanel() {
+    gamescore = 0;
+    alltime = 0;
+    mgr.show(getContentPane(), "Title");
+  }
+  private void showExplainPanel() {
+    mgr.show(getContentPane(), "Explain");
+  }
+  private void showGamePanel() {
+    mgr.show(getContentPane(), "Game");
+  }
+  private void showCatchPanel(Fish fish) {
+    catchPanel.setFish(fish);
+    mgr.show(getContentPane(), "Catch");
+  }
+  /** タイトルパネル */
+  private class TitlePanel extends JPanel {
+    TitlePanel() {
+      super(null);
+      setTitle("魚釣りゲーム～タイトル～");
+      JLabel titleLabel = new JLabel(new ImageIcon("タイトル画像.jpg"));
+      titleLabel.setBounds(-10, 0, 770, 760);
+      add(titleLabel);
+      JButton startButton = new JButton("スタート");
+      startButton.setBounds(310, 580, 130, 30);
+      startButton.addActionListener(e -> showGamePanel()); // スタート→メイン画面へ遷移
+      add(startButton);
+      JButton explainButton = new JButton("あそびかた");
+      explainButton.setBounds(310, 650, 130, 30);
+      explainButton.addActionListener(e -> showExplainPanel());
+      add(explainButton);
+    }
+  }
+  /** ルール説明パネル */
+  private class ExplainPanel extends JPanel {
+    private Icon rule1Icon = new ImageIcon("ルール１.jpg");
+    private Icon rule2Icon = new ImageIcon("ルール2.jpg");
+    private JLabel ruleLabel;
+    private JButton titleButton;
+    private JButton nextButton;
+    ExplainPanel() {
+      super(null);
+      setTitle("魚釣りゲームのルール説明");
+      ruleLabel = new JLabel(rule1Icon);
+      ruleLabel.setBounds(0, 150, 760, 460);
+      add(ruleLabel);
+      titleButton = new JButton("タイトルへ");
+      titleButton.setBounds(50, 520, 180, 30);
+      titleButton.addActionListener(e -> showTitlePanel());
+      add(titleButton);
+      nextButton = new JButton("つぎへ");
+      nextButton.setBounds(100, 540, 130, 30);
+      nextButton.addActionListener(e -> showRule2());
+      add(nextButton);
+      addComponentListener(new ComponentAdapter() {
+        @Override
+        public void componentShown(ComponentEvent e) {
+          showRule1();
+        }
+      });
+    }
+    private void showRule1() {
+      ruleLabel.setIcon(rule1Icon);
+      nextButton.setVisible(true);
+      titleButton.setVisible(false);
+    }
+    private void showRule2() {
+      ruleLabel.setIcon(rule2Icon);
+      nextButton.setVisible(false);
+      titleButton.setVisible(true);
+    }
+  }
+  /** ゲームパネル */
+  private class GamePanel extends JPanel {
+    private long starttime;
+    private CatchAction catchAction;
+    private JLabel scoreLabel;
+    GamePanel() {
+      super(null);
+      setTitle("魚釣りゲーム");
+      scoreLabel = new JLabel();
+      scoreLabel.setBounds(100, 0, 400, 400);
+      add(scoreLabel);
+      JLabel seaLabel = new JLabel(new ImageIcon("海.jpg"));
+      seaLabel.setBounds(195, 400, 560, 350);
+      add(seaLabel);
+      JLabel fisherLabel = new JLabel(new ImageIcon("釣りbasic2.jpg"));
+      fisherLabel.setBounds(0, 180, 380, 380);
+      add(fisherLabel);
+      catchAction = new CatchAction(CATCH_CHANCES);
+      catchAction.setOnCatchListener(fish -> {
+        gamescore += fish.getScore();
+        rewriteScoreLabel();
+        showCatchPanel(fish);
+      });
+      JButton catchButton = new JButton(catchAction);
+      catchButton.setBounds(378, 120, 375, 280);
+      add(catchButton);
+      addComponentListener(new ComponentAdapter() {
+        @Override
+        public void componentShown(ComponentEvent e) {
+          starttime = System.currentTimeMillis();
+          rewriteScoreLabel();
+          catchAction.start();
+        }
+        @Override
+        public void componentHidden(ComponentEvent e) {
+          alltime += (int)(System.currentTimeMillis() - starttime);
+          catchAction.stop();
+        }
+      });
+      rewriteScoreLabel();
+    }
+    private void rewriteScoreLabel() {
+      scoreLabel.setText("SCORE: " + gamescore + "点");
+    }
+  }
+  /** 釣り上げ */
+  private static class CatchAction extends AbstractAction {
+    interface OnCatchListener {
+      void onCatch(Fish fish);
+    }
+    private OnCatchListener listener;
+    private CatchChance[] catchChances;
+    private int totalRatio;
+    private Random random = new Random(System.currentTimeMillis());
+    private Timer timer;
+    private CatchChance chance;
+    CatchAction(CatchChance[] catchChances) {
+       this.catchChances = catchChances;
+       totalRatio = 0;
+       for(CatchChance cr : catchChances) totalRatio += cr.getRatio();
+       chance = catchChances[0];
+       putValue(LARGE_ICON_KEY, chance.getIcon());
+    }
+    void setOnCatchListener(OnCatchListener listener) {
+      this.listener = listener;
+    }
+    void start() {
+      chance = catchChances[0];
+      putValue(LARGE_ICON_KEY, chance.getIcon());
+      int delay = chance.getTime();
+      timer = new Timer(delay, new ActionListener() {
+        public void actionPerformed(ActionEvent e) {
+          timer.stop();
+          chance = (chance == catchChances[0] ? getChance() : catchChances[0]);
+          putValue(LARGE_ICON_KEY, chance.getIcon());
+          timer.setInitialDelay(chance.getTime());
+          timer.restart();
+        }
+      });
+      timer.setRepeats(false);
+      timer.start();
+    }
+    private CatchChance getChance() {
+      int v = random.nextInt(totalRatio);
+      int i = 1;
+      while(v>=catchChances[i].getRatio()) v-=catchChances[i++].getRatio();
+      return catchChances[i];
+    }
+    void stop() {
+      if(timer != null) {
+        timer.stop();
+        timer = null;
+      }
+    }
+    @Override
+    public void actionPerformed(ActionEvent e) {
+      Fish fish = chance.getFish();
+      if(fish != null && listener != null) {
+        stop();
+        listener.onCatch(fish);
+      }
+    }
+  }
+  /** 釣り上げパネル */
+  private class CatchPanel extends JPanel {
+    private JLabel imageLabel;
+    CatchPanel() {
+      JButton returnButton = new JButton("もどる");
+      returnButton.setBounds(280, 650, 130, 30);
+      returnButton.addActionListener(e -> {
+        if(alltime < 60000) {
+          showGamePanel();
+        } else {
+          //game end
+        }
+      });
+      add(returnButton);
+      imageLabel = new JLabel();
+      imageLabel.setBounds(150, 200, 400, 400);
+      add(imageLabel);
+      JLabel catchLabel = new JLabel("釣り上げた！");
+      catchLabel.setBounds(305, 120, 100, 100);
+      add(catchLabel);
+    }
+    void setFish(Fish fish) {
+      imageLabel.setIcon(fish.getIcon());
+    }
+  }
+}
+```