編集履歴

質問編集履歴

ファイルポインタのNULLチェックを入れました。

2023/04/25 12:41

投稿

yu_89

スコア34

test CHANGED Viewed

File without changes

test CHANGED Viewed

@@ -134,6 +134,17 @@
   fp  = fopen(argv[1],"r");
   fp1 = fopen(argv[2],"r");
+  if(fp == NULL)
+    printf("fp:cannnot open file\n");
+  else
+    printf("fp:open file\n");
+  if(fp1 == NULL)
+    printf("fp1:cannnot open file\n");
+  else
+    printf("fp1:open file\n");
   iter = 0;
   flag = 0;
@@ -187,25 +198,7 @@
       S4r1[i]  +=  pow((double)pwr1, 4.0);
       S4i1[i]  +=  pow((double)pwi1, 4.0);
     }
-    for(i = 0; i < N; i++)
-    {
-      pwr2      =  ar2[i];
-      pwi2      =  ai2[i];
-      S1r2[i]  +=  (double)pwr2;
-      S1i2[i]  +=  (double)pwi2;
-      S2r2[i]  +=  pow((double)pwr2, 2.0);
-      S2i2[i]  +=  pow((double)pwi2, 2.0);
-      S3r2[i]  +=  pow((double)pwr2, 3.0);
-      S3i2[i]  +=  pow((double)pwi2, 3.0);
-      S4r2[i]  +=  pow((double)pwr2, 4.0);
-      S4i2[i]  +=  pow((double)pwi2, 4.0);
-    }
     dcnt++;
   }

コードを文字数制限ギリギリまで可能な限り載せました。検証に必要なデータを作るためのコードも載せました。

2023/04/25 09:47

投稿

yu_89

スコア34

test CHANGED Viewed

File without changes

test CHANGED Viewed

@@ -1,8 +1,4 @@
 ### 実現したいこと
-c言語のメモリの動的確保について
-### 前提
 c言語のmallocによるメモリの動的確保について、気になることがあり質問させていただきます。
 質問としては、mallocを使いすぎることでメモリを確保する際にmalloc同士で干渉などを起こすことがあるのでしょうか？
 といのも、以下のコードでは配列を返す自作関数内でmallocを用いてメモリを動的に確保しており、main関数内ではその自作関数を計11回呼び出しています。このプログラムを実行するとコンパイルはできるのですが、実行すると何度やってもセグメンテーションエラーになり、実行できませんでした。しかし、mallocを使っている関数を一部コメントアウトし、main関数内でもコメントアウトした関数の呼び出し部をコメントアウトして実行すると、エラーにならず実行できました。その後、コメントアウトを解除して実行すると今度はセグメンテーションエラーにならずに実行できました。
@@ -14,30 +10,27 @@
 #include	<stdio.h>
 #include	<stdlib.h>
 #include	<math.h>
-#include     <time.h>
 #include     <string.h>
+#define N 1024
 int  fft1();
 int  window_func();
-int  cmpnum();
 void swap(float *x, float *y);
-double* freq(int N);
+double* freq(void);
-double* CalcPower(double data[], int N);
+double* CalcPower(double data[]);
-double  Threshold_kurtosis(double M[], int N);
-double  Threshold_crossfreq(double median, double sub[], int num);
-double* Kurtosis(double a[], double b[], double c[], double d[], int e);
+double* Kurtosis(double a[], double b[], double c[], double d[]);
-double calcMedian();
-double GetRandom(int min, int max);
-double pulse(int frame);
 int main(int argc,const char *argv[])
 {
-  int	N = 1024;
   int	i, j, k, n, n_frame, iter, flag;
+  int  n_frame = 2929;
+  char    datar[256], datai[256];
   float   ar1[N], ai1[N], ar2[N], ai2[N];
   double  pwr1, pwi1, pwr2, pwi2;
@@ -46,12 +39,12 @@
   double  S1r1[N], S2r1[N], S3r1[N], S4r1[N], S6r1[N];
   double  S1i1[N], S2i1[N], S3i1[N], S4i1[N];
-  double  Myu1r1[N], Myu2r1[N], Myu3r1[N], Myu4r1[N], Myu6r1[N];
+  double  Myu1r1[N], Myu2r1[N], Myu3r1[N], Myu4r1[N];
   double  Myu1i1[N], Myu2i1[N], Myu3i1[N], Myu4i1[N];
   double  S1r2[N], S2r2[N], S3r2[N], S4r2[N], S6r2[N];
   double  S1i2[N], S2i2[N], S3i2[N], S4i2[N];
-  double  Myu1r2[N], Myu2r2[N], Myu3r2[N], Myu4r2[N], Myu6r2[N];
+  double  Myu1r2[N], Myu2r2[N], Myu3r2[N], Myu4r2[N];
   double  Myu1i2[N], Myu2i2[N], Myu3i2[N], Myu4i2[N];
   double  sub_Myu1r[N], sub_Myu2r[N], sub_Myu3r[N], sub_Myu4r[N];
@@ -59,8 +52,7 @@
   double  Myu21[N], Myu22[N], sub_Myu2[N];
   double  sub_myu2[N], b[N], h[N], h1[N];
-  double  median, median1;
-  double  d[N], d1[N], s;
+  double  d[N], d1[N];
   double  sub_d[N];
   double  sub_d_neighbor[N], sub_d_neighbor1[N];
@@ -68,25 +60,23 @@
   double  modi_Myu2_freq[N];
-  double  Mr[N], Mi[N], Ma[N], Mb[N], Mc[N];
-  double  Fr[N], Fi[N];
-  double  sum_kr, sum_ki, sum_kc;
-  double  s_k, s_kr, s_ki, s_ka, s_kb, s_kc;
-  double  br[N], bi[N], ba[N], bb[N], qr[N], qa[N];
-  double  xr[N], xi[N], xa[N], xb[N], qi[N], qb[N];
-  double  modi_Myu2_kur1[N];
-  double  modi_Myu2_kur2[N];
-  double  com[N];
-  double  modi_Myu2_com[N];
   double* fq = NULL;
   double* Kr = NULL;
   double* Ki = NULL;
   double* Ka = NULL;
   double* Kb = NULL;
+  double  Mr[N], Mi[N], Ma[N], Mb[N];
+  double  Fr[N], Fi[N];
+  double  br[N], bi[N], ba[N], bb[N], qr[N], qa[N];
+  double  xr[N], xi[N], xa[N], xb[N], qi[N], qb[N];
+  double  modi_Myu2_kur1[N];
+  double  modi_Myu2_kur2[N];
+  double  com[N];
+  double  modi_Myu2_com[N];
   double* Myu21_power = NULL;
   double* sub_Myu2_power = NULL;
@@ -94,27 +84,171 @@
   double* modi_power_kur1 = NULL;
   double* modi_power_kur2 = NULL;
   double* modi_power_freq = NULL;
-  FILE  *fp, *fp1, *fp2, *fp3;
+  FILE  *fp, *fp1;
+  for(i = 0; i < N; i++)
+  {
+    ar1[i] = 0.0;
+    ai1[i] = 0.0;
+    ar2[i] = 0.0;
+    ai2[i] = 0.0;
+    Myu21[i] = 0.0;
+    Myu22[i] = 0.0;
+    S1r1[i] = 0.0;
+    S1i1[i] = 0.0;
+    S2r1[i] = 0.0;
+    S2i1[i] = 0.0;
+    S3r1[i] = 0.0;
+    S3i1[i] = 0.0;
+    S4r1[i] = 0.0;
+    S4i1[i] = 0.0;
+    S1r2[i] = 0.0;
+    S1i2[i] = 0.0;
+    S2r2[i] = 0.0;
+    S2i2[i] = 0.0;
+    S3r2[i] = 0.0;
+    S3i2[i] = 0.0;
+    S4r2[i] = 0.0;
+    S4i2[i] = 0.0;
+    Myu1r1[i] = 0.0;
+    Myu1i1[i] = 0.0;
+    Myu2r1[i] = 0.0;
+    Myu2i1[i] = 0.0;
+    Myu3r1[i] = 0.0;
+    Myu3i1[i] = 0.0;
+    Myu4r1[i] = 0.0;
+    Myu4i1[i] = 0.0;
+  }
+  pwr1 = 0.0;
+  pwi1 = 0.0;
+  pwr2 = 0.0;
+  pwi2 = 0.0;
+  dcnt = 0.0;
+  fp  = fopen(argv[1],"r");
+  fp1 = fopen(argv[2],"r");
+  iter = 0;
+  flag = 0;
+  for(n = 0; n < n_frame; n++)
+  {
+    for(i = 0; i < N; i++)
+    {
+      fgets(datar, sizeof(datar), fp);
+      ar1[i] = atof(datar);
+      ar2[i] = 0.0;
+    }
+    for(i = 0; i < N; i++)
+    {
+      fgets(datai, sizeof(datai), fp1);
+      ar2[i] = atof(datai);
+      ai2[i] = 0.0;
+    }
+    window_func(ar1, N);
+    window_func(ai1, N);
+    fft1(ar1, ai1, N, iter, flag);
+    window_func(ar2, N);
+    window_func(ai2, N);
+    fft1(ar2, ai2, N, iter, flag);
+    for(i = 0; i < N/2; i++)
+    {
+      swap(&ar1[i], &ar1[N/2+i]);
+      swap(&ai1[i], &ai1[N/2+i]);
+      swap(&ar2[i], &ar2[N/2+i]);
+      swap(&ai2[i], &ai2[N/2+i]);
+    }
+    for(i = 0; i < N; i++)
+    {
+      pwr1      =  ar1[i];
+      pwi1      =  ai1[i];
+      S1r1[i]  +=  (double)pwr1;
+      S1i1[i]  +=  (double)pwi1;
+      S2r1[i]  +=  pow((double)pwr1, 2.0);
+      S2i1[i]  +=  pow((double)pwi1, 2.0);
+      S3r1[i]  +=  pow((double)pwr1, 3.0);
+      S3i1[i]  +=  pow((double)pwi1, 3.0);
+      S4r1[i]  +=  pow((double)pwr1, 4.0);
+      S4i1[i]  +=  pow((double)pwi1, 4.0);
+    }
+    for(i = 0; i < N; i++)
+    {
+      pwr2      =  ar2[i];
+      pwi2      =  ai2[i];
+      S1r2[i]  +=  (double)pwr2;
+      S1i2[i]  +=  (double)pwi2;
+      S2r2[i]  +=  pow((double)pwr2, 2.0);
+      S2i2[i]  +=  pow((double)pwi2, 2.0);
+      S3r2[i]  +=  pow((double)pwr2, 3.0);
+      S3i2[i]  +=  pow((double)pwi2, 3.0);
+      S4r2[i]  +=  pow((double)pwr2, 4.0);
+      S4i2[i]  +=  pow((double)pwi2, 4.0);
+    }
+    dcnt++;
+  }
+  printf("\n");
+  fclose(fp);
+  fclose(fp1);
+  fq = freq();
+  for(i = 0; i < N; i++)
+  {
+    Myu1r1[i] = S1r1[i] / dcnt;
+    Myu1i1[i] = S1i1[i] / dcnt;
+    Myu2r1[i] = S2r1[i] / dcnt;
+    Myu2i1[i] = S2i1[i] / dcnt;
+    Myu3r1[i] = S3r1[i] / dcnt;
+    Myu3i1[i] = S3i1[i] / dcnt;
+    Myu4r1[i] = S4r1[i] / dcnt;
+    Myu4i1[i] = S4i1[i] / dcnt;
+    Myu21[i] = Myu2r1[i] + Myu2i1[i];
+  }
+Myu21_power = CalcPower(Myu21);
+  sub_Myu2_power = CalcPower(Myu21);
-  modi_power_freq = CalcPower(sub_Myu2, N);
+  modi_power_freq = CalcPower(Myu21);
-  Kr = Kurtosis(Myu1r1, Myu2r1, Myu3r1, Myu4r1, N);
+  Kr = Kurtosis(Myu1r1, Myu2r1, Myu3r1, Myu4r1);
-  Ki = Kurtosis(Myu1i1, Myu2i1, Myu3i1, Myu4i1, N);
+  Ki = Kurtosis(Myu1i1, Myu2i1, Myu3i1, Myu4i1);
-  Myu21_power = CalcPower(Myu21, N);
-  sub_Myu2_power = CalcPower(sub_Myu2, N);
-  Ka = Kurtosis(Myu1r2, Myu2r2, Myu3r2, Myu4r2, N);
+  Ka = Kurtosis(Myu1r1, Myu2r1, Myu3r1, Myu4r1);
-  Kb = Kurtosis(Myu1i2, Myu2i2, Myu3i2, Myu4i2, N);
+  Kb = Kurtosis(Myu1i1, Myu2i1, Myu3i1,  Myu4i1);
-  modi_power_kur1 = CalcPower(modi_Myu2_kur1, N);
+  modi_power_kur1 = CalcPower(Myu21);
-  modi_power_kur2 = CalcPower(modi_Myu2_kur2, N);
+  modi_power_kur2 = CalcPower(Myu21);
-  modi_power_com = CalcPower(modi_Myu2_com, N);
+  modi_power_com = CalcPower(Myu21);
   free(fq);
   free(Kr);
@@ -132,7 +266,138 @@
 }
+void swap(float *x, float *y)
+{
+  float temp;
+  temp = *x;
+  *x   = *y;
+  *y   = temp;
+}
+int fft1(float ar[], float ai[], int n, int iter, int flag)
+{
+  int    i, j, it, xp, xp2, k, j1, j2, im1, jm1;
+  double sign, w, wr, wi, dr1, dr2, di1, di2, tr, ti, arg;
+  if(n < 2) return(999);
+  if(iter <= 0)
+  {
+    iter = 0;
+    i = n;
+    while(1)
+    {
+      if((i /= 2) == 0) break;
+      iter++;
+    }
+  }
+  j = 1;
+  for(i = 0; i < iter; i++) j *= 2;
+  if(n != j) return(1);
+  if(flag == 1) sign=1.0;
+  else sign=-1.0;
+  xp2 = n;
+  for(it = 0; it < iter; it++)
+  {
+    xp = xp2;
+    xp2 = xp / 2;
+    w = 3.141592653589793 / xp2;
+    for(k = 0; k < xp2; k++)
+    {
+      arg = k * w;
+      wr = cos(arg);
+      wi = sign * sin(arg);
+      i = k - xp;
+      for(j = xp; j <= n; j += xp)
+      {
+        j1  = j + i;
+        j2  = j1 + xp2;
+        dr1 = ar[j1];
+        dr2 = ar[j2];
+        di1 = ai[j1];
+        di2 = ai[j2];
+        tr  = dr1 - dr2;
+        ti  = di1 - di2;
+        ar[j1] = dr1 + dr2;
+        ai[j1] = di1 + di2;
+        ar[j2] = tr * wr - ti * wi;
+        ai[j2] = ti * wr + tr * wi;
+      }
+    }
+  }
+  j1 = n / 2;
+  j2 = n - 1;
+  j = 1;
+  for(i = 1; i <= j2; i++)
+  {
+    if(i < j)
+    {
+      im1 = i - 1;
+      jm1 = j - 1;
+      tr  = ar[jm1];
+      ti  = ai[jm1];
+      ar[jm1] = ar[im1];
+      ai[jm1] = ai[im1];
+      ar[im1] = tr;
+      ai[im1] = ti;
+    }
+    k = j1;
+    while(k < j)
+    {
+      j -= k;
+      k /= 2;
+    }
+    j += k;
+  }
+  if(flag == 0) return(0);
+  w = n;
+  for(i = 0; i < n; i++)
+  {
+    ar[i] = ar[i] / w;
+    ai[i] = ai[i] / w;
+  }
+  return(0);
+}
+int window_func(float frame[], int n)
+{
+  int	 i;
+  float  winv[n];
+  double pi = 3.141592653589793;
+  for(i = 0; i < n; i++)
+  {
+    winv[i] = 0.35875 - 0.48829 * cos(2.0*pi*i/(n-1)) + 0.14128 * cos(4.0*pi*i/(n-1)) - 0.01168 * cos(6.0*pi*i/(n-1));
+    frame[i] = frame[i] * winv[i];
+  }
+  return(0);
+}
-double* CalcPower(double data[], int N)
+double* CalcPower(double data[])
 {
   int i;
   double av[N];
@@ -150,13 +415,13 @@
   return power;
 }
-double* Kurtosis(double Myu1[], double Myu2[], double Myu3[], double Myu4[], int N)
+double* Kurtosis(double Myu1[], double Myu2[], double Myu3[], double Myu4[])
 {
   int i;
   double M1[N], M2[N], M3[N], M4[N];
   double top[N], bottom[N];
   double* K = (double*)malloc(N * sizeof(double));
   for(i = 0; i < N; i++)
   {
     M1[i] = 0.0;
@@ -194,7 +459,7 @@
 }
-double* freq(int N)
+double* freq(void)
 {
   int i;
   double* fq = (double*)malloc(N * sizeof(double));
@@ -205,7 +470,41 @@
   return fq;
 }
+```
+```C
+#include <stdio.h>
+#include <stdlib.h>
+#include <time.h>
+#define N  3000000
+double GetRandom();
+int main()
+{
+  int i;
+  FILE *fp, *fp1;
+  fp    = fopen("rand1.dat", "w");
+  fp1 = fopen("rand2.dat", "w");
+  srand((unsigned int)time(NULL));
+  for(i = 0; i < N; i++)
+  {
+    fprintf(fp, "%f\n", GetRandom(0,1));
+    fprintf(fp1, "%f\n", GetRandom(0,1));
+  }
+  fclose(fp);
+  fclose(fp1);
+  return 0;
+}
+double GetRandom(int min, int max)
+{
+  return min + (double)(rand() * (max - min + 1.0) / (1.0 + RAND_MAX));
+}
 ```
 ### 補足情報（FW/ツールのバージョンなど）