編集履歴

質問編集履歴

短くなったので再投稿（エラーが起きてるのでまだまだです）

2023/01/27 23:50

投稿

TrueRyoB

スコア79

test CHANGED Viewed

File without changes

test CHANGED Viewed

@@ -16,6 +16,7 @@
 using System.Collections;
 using System.Collections.Generic;
 using static System.Collections.IEnumerable;
+using System;
 using System.Linq;
 using UnityEngine;
 using UnityEngine.UI;
@@ -23,9 +24,8 @@
 public class InventoryManagement : MonoBehaviour
 {
-    public string[] skill_inventory = new string[6];
+    public ItemInInventory[] skill_inventory = new ItemInInventory[6];
-    public string[] item_inventory = new string[16];
+    public ItemInInventory[] item_inventory = new ItemInInventory[16];
-    //今からこの配列を複雑構造にする
     public ItemDataBase database;
     public Category item_category;
@@ -35,20 +35,18 @@
     public GameObject text;
     private TextMeshProUGUI _text;
-    public List<ItemInInventory> skill_list = new List<ItemInInventory>();
-    public List<ItemInInventory> item_list = new List<ItemInInventory>();
     public struct ItemInInventory
     {
-        string id;
+        public string id;
-        string type;
+        public string type;
-        int cooldown;
+        public int cooldown;
-        int ability_haste;
+        public int ability_haste;
-        int arm_power;
+        public int arm_power;
-        int absolute_dig;
+        public int absolute_dig;
-        float ratio_dig;
+        public float ratio_dig;
-        int money_invested;
+        public int money_invested;
-        bool availability;
+        public bool availability;
         public ItemInInventory(string id,string type, int cooldown, int ability_haste, int arm_power, int absolute_dig, float ratio_dig, int money_invested, bool availability)
         {
             this.id = id;
@@ -90,17 +88,17 @@
         AssignImageFromArray(skill_inventory);
     }
-    private void AssignImageFromArray(string[] array)
+    private void AssignImageFromArray(ItemInInventory[] array)
     {
         var i = 0;
-        foreach(string id in array)
+        foreach(ItemInInventory item in array)
         {
             if(item_iconBox[i] != null)//まだiconBoxの割り当てが済んでいないため　あとでやる（やらないパターン）
             {
-                if(id != "")
+                if(item.id != "")
                 {
-                    if(array.Length == 6){skill_iconBox[i].GetComponent<Image>().sprite = SearchItemFromID(id).item_image;}//parameterの配列がskillかitem由来か確認
+                    if(array.Length == 6){skill_iconBox[i].GetComponent<Image>().sprite = SearchItemFromID(item.id).item_image;}//parameterの配列がskillかitem由来か確認
-                    else{item_iconBox[i].GetComponent<Image>().sprite = SearchItemFromID(id).item_image;}
+                    else{item_iconBox[i].GetComponent<Image>().sprite = SearchItemFromID(item.id).item_image;}
                 }
                 else
                 {
@@ -118,11 +116,11 @@
         Item selected_item;
         if(i >= 6)
         {
-            selected_item = SearchItemFromID(item_inventory[i-6]);
+            selected_item = SearchItemFromID(item_inventory[i-6].id);
         }
         else
         {
-            selected_item = SearchItemFromID(skill_inventory[i]);
+            selected_item = SearchItemFromID(skill_inventory[i].id);
         }
         if(selected_item!=null)
         {
@@ -194,54 +192,21 @@
     public void AddNewItems(string newID)
     {
-        List<ItemInInventory> list;
+        //List<ItemInInventory> list;
+        ItemInInventory[] array;
-        if(SearchItemFromID(newID).type.ToString() == "Skill"){list = skill_list;}
+        if(SearchItemFromID(newID).type.ToString() == "Skill"){array = skill_inventory;}
-        else{list = item_list;}
+        else{array = item_inventory;}
-        if(list.Count<=6 || (list.Count<=16 && SearchItemFromID(newID).type.ToString() != "Skill"))
+        int index = Array.IndexOf(array, null);
-        list.Add(ConvertIDintoStructedItem(newID));
+        if (index >= 0) array[index] = ConvertIDintoStructedItem(newID);
         DisplayItems();
     }
-    /*
-    public void AddItems(string newID)
-    {
-        bool _ifSkill;
-        string[] inventory;
-        var i = 0;
-        if(SearchItemFromID(newID).type.ToString() == "Skill")
-        {
-            _ifSkill = true;
-            inventory = skill_inventory;
-        }
-        else
-        {
-            _ifSkill = false;
-            inventory = item_inventory;
-        }
-        foreach(string id in inventory)
-        {
-            if(id == "")
-            {
-                break;
-            }
-            i++;
-        }
-        if(_ifSkill){skill_inventory[i] = newID;}
-        else{item_inventory[i] = newID;}
-        DisplayItems();
-    }
-    */
     public void ItemUsed(int i, GameObject icon)
     {
-        Item selected_item = SearchItemFromID(item_inventory[i]);
+        Item selected_item = SearchItemFromID(item_inventory[i].id);
         if(selected_item.type.ToString()=="Reusable")
         {
@@ -251,7 +216,7 @@
     public void SkillUsed(int i, GameObject icon)
     {
-        Debug.Log(SearchItemFromID(skill_inventory[i]).item_name);
+        Debug.Log(SearchItemFromID(skill_inventory[i].id).item_name);
         //ここに効果発動させるコマンドと、周りを光の尾で照らすコマンドをかく
     }
@@ -268,43 +233,12 @@
             }
         }
-        return null; //if matched id isnt found
+        return null;
     }
 }
-//class ItemInInventory : MonoBehaviour
-struct ItemInInventory
-{
-    string id;
-    string type;
-    int cooldown;//
-    int ability_haste;
-    int arm_power;
-    int absolute_dig;
-    float ratio_dig;
-    int money_invested;//
-    //これの必要の有無をどう設定したらいいかわからん　もし二つ兼ね備えるのが来たらどうする
-    //結論　アイテム側の数値も増やす！
-    //もし値が0じゃなかったらnullじゃないってしよかー！結論：できない、、処理側で0じゃなかったら作動するようにしよか（めんどい！）
-    //まあこれは値格納するためだけの存在やから...(KONAMI)
-/*
-    ItemInInventory(Item item)
-    {
-        this.id = item.item_id;
-        this.type = item.type.ToString();
-        this.cooldown = item.cooldown;
-        this.ability_haste = item.ability_haste;
-        this.arm_power = item.arm_power;
-        this.absolute_dig = item.absolute_dig;
-        this.ratio_dig = item.ratio_dig;
-        this.money_invested = item.money_invested;
-    }
-    */
-}
 ```

Unity

コード変えました（途中けいか）

2023/01/27 23:21

投稿

TrueRyoB

スコア79

test CHANGED Viewed

File without changes

test CHANGED Viewed

@@ -15,6 +15,8 @@
 ```c#
 using System.Collections;
 using System.Collections.Generic;
+using static System.Collections.IEnumerable;
+using System.Linq;
 using UnityEngine;
 using UnityEngine.UI;
 using TMPro;
@@ -23,56 +25,92 @@
 {
     public string[] skill_inventory = new string[6];
     public string[] item_inventory = new string[16];
+    //今からこの配列を複雑構造にする
     public ItemDataBase database;
+    public Category item_category;
     public GameObject[] skill_iconBox = new GameObject[6];
     public GameObject[] item_iconBox = new GameObject[16];
     public GameObject text;
     private TextMeshProUGUI _text;
+    public List<ItemInInventory> skill_list = new List<ItemInInventory>();
+    public List<ItemInInventory> item_list = new List<ItemInInventory>();
+    public struct ItemInInventory
+    {
+        string id;
+        string type;
+        int cooldown;
+        int ability_haste;
+        int arm_power;
+        int absolute_dig;
+        float ratio_dig;
+        int money_invested;
+        bool availability;
+        public ItemInInventory(string id,string type, int cooldown, int ability_haste, int arm_power, int absolute_dig, float ratio_dig, int money_invested, bool availability)
+        {
+            this.id = id;
+            this.type = type;
+            this.cooldown = cooldown;
+            this.ability_haste = ability_haste;
+            this.arm_power = arm_power;
+            this.absolute_dig = absolute_dig;
+            this.ratio_dig = ratio_dig;
+            this.money_invested = money_invested;
+            this.availability = availability;
+        }
+    }
     void Start()
     {
         _text = text.GetComponent<TextMeshProUGUI>();
         DisplayItems();
+        DebugCheck();
+    }
+    private void DebugCheck()
+    {
+        AddNewItems("pickaxe_diamond_1");
+        AddNewItems("pickaxe_wood_1");
+        AddNewItems("runner");
+    }
+    private ItemInInventory ConvertIDintoStructedItem(string newID)
+    {
+        string id = newID;
+        Item item = SearchItemFromID(id);
+        return new ItemInInventory(id,item.type.ToString(),item.cooldown,item.ability_haste,item.arm_power,item.absolute_dig,item.ratio_dig,item.money_invested,true);
     }
     public void DisplayItems()
     {
+        AssignImageFromArray(item_inventory);
+        AssignImageFromArray(skill_inventory);
+    }
+    private void AssignImageFromArray(string[] array)
+    {
         var i = 0;
-        foreach(string id in item_inventory)
+        foreach(string id in array)
         {
             if(item_iconBox[i] != null)//まだiconBoxの割り当てが済んでいないため　あとでやる（やらないパターン）
             {
                 if(id != "")
                 {
+                    if(array.Length == 6){skill_iconBox[i].GetComponent<Image>().sprite = SearchItemFromID(id).item_image;}//parameterの配列がskillかitem由来か確認
-                    item_iconBox[i].GetComponent<Image>().sprite = SearchItemFromID(id).item_image;
+                    else{item_iconBox[i].GetComponent<Image>().sprite = SearchItemFromID(id).item_image;}
                 }
                 else
                 {
+                    if(array.Length == 6){skill_iconBox[i].GetComponent<Image>().sprite = null;}
-                    item_iconBox[i].GetComponent<Image>().sprite = null;
+                    else{item_iconBox[i].GetComponent<Image>().sprite = null;}
                 }
             }
             i++;
         }
-        i = 0;
-        foreach(string id in skill_inventory)
-        {
-            if(skill_iconBox[i] != null)//まだiconBoxの割り当てが済んでいないため　あとでやる（やらないパターン）
-            {
-                if(id != "")
-                {
-                    skill_iconBox[i].GetComponent<Image>().sprite = SearchItemFromID(id).item_image;
-                }
-                else
-                {
-                    skill_iconBox[i].GetComponent<Image>().sprite = null;
-                }
-            }
-            i++;
-        }
     }
     public void DisplayItemDescription(int i)
@@ -88,53 +126,118 @@
         }
         if(selected_item!=null)
         {
-            //_text.text = selected_item.item_name;
+            _text.text = GenerateText(selected_item,"others");
-            _text.text = "<size=20>"+ selected_item.item_name +"</size>"+"\n\n <size=16>"+selected_item.information+"</size>";
-        }
+        }
-    }
+    }
+    private string GenerateText(Item item, string _availability)
+    {
+        string name; string text_parameter; string num_parameter; string type; string item_info;
+        name = "<size=20>" + item.item_name + "</size>";
+        text_parameter = "<size=16>" + SearchCategoryFromItem(item,"text") + "</size>";
+        num_parameter = "";
+        type = "";
+        if(_availability == "others")
+        {
+            type = "<size=16>" + item.type.ToString() + "</size>";
+        }
+        else if(_availability == "true")
+        {
+            type = "<size=16>" + "Available" + "</size>";
+        }
+        else if(_availability == "false")
+        {
+            type = "<size=16>" + "Unavailable" + "</size>";
+        }
+        item_info = "<size=10> \n" + item.information + "</size>";
+        return  name + text_parameter + num_parameter + type + item_info;
+    }
+    private string SearchCategoryFromItem(Item item,string purpose)
+    {
+        if(purpose == "text")
+        {
+            if(item_category.Diggable.Contains(item))
+            {
+                return "Diggable:";
+            }
+            else if(item_category.Investable.Contains(item))
+            {
+                return "Investable:";
+            }
+        }
+        else if(purpose == "unit")
+        {
+            if(item_category.Unit_KiloTon.Contains(item))
+            {
+                return "kt";
+            }
+        }
+        return "";
+    }
     public void ResetText()
     {
     }
-    public void ItemAdded(string newItemID)
+    public void AddNewItems(string newID)
-    {
+    {
+        List<ItemInInventory> list;
+        if(SearchItemFromID(newID).type.ToString() == "Skill"){list = skill_list;}
+        else{list = item_list;}
+        if(list.Count<=6 || (list.Count<=16 && SearchItemFromID(newID).type.ToString() != "Skill"))
+        list.Add(ConvertIDintoStructedItem(newID));
+        DisplayItems();
+    }
+    /*
+    public void AddItems(string newID)
+    {
+        bool _ifSkill;
+        string[] inventory;
         var i = 0;
+        if(SearchItemFromID(newID).type.ToString() == "Skill")
+        {
+            _ifSkill = true;
+            inventory = skill_inventory;
+        }
+        else
+        {
+            _ifSkill = false;
+            inventory = item_inventory;
+        }
-        foreach(string id in item_inventory)
+        foreach(string id in inventory)
         {
             if(id == "")
             {
-                item_inventory[i] = newItemID;
                 break;
             }
-            else
-            {
-                i++;
+            i++;
-                continue;
-            }
+        }
+        if(_ifSkill){skill_inventory[i] = newID;}
-        }
+        else{item_inventory[i] = newID;}
         DisplayItems();
     }
-    public void SkillAdded(string newSkillID)
-    {
-        var i = 0;
-        foreach(string id in skill_inventory)
-        {
-            if(id == "")
-            {
-                skill_inventory[i] = newSkillID;
-                break;
+    */
-            }
-            else
-            {
-                i++;
-                continue;
-            }
-        }
-        DisplayItems();
-    }
     public void ItemUsed(int i, GameObject icon)
     {
@@ -144,7 +247,6 @@
         {
             icon.GetComponent<Image>().color = new Color32(58,58,58,255);
         }
     }
     public void SkillUsed(int i, GameObject icon)
@@ -172,5 +274,37 @@
 }
+//class ItemInInventory : MonoBehaviour
+struct ItemInInventory
+{
+    string id;
+    string type;
+    int cooldown;//
+    int ability_haste;
+    int arm_power;
+    int absolute_dig;
+    float ratio_dig;
+    int money_invested;//
+    //これの必要の有無をどう設定したらいいかわからん　もし二つ兼ね備えるのが来たらどうする
+    //結論　アイテム側の数値も増やす！
+    //もし値が0じゃなかったらnullじゃないってしよかー！結論：できない、、処理側で0じゃなかったら作動するようにしよか（めんどい！）
+    //まあこれは値格納するためだけの存在やから...(KONAMI)
+/*
+    ItemInInventory(Item item)
+    {
+        this.id = item.item_id;
+        this.type = item.type.ToString();
+        this.cooldown = item.cooldown;
+        this.ability_haste = item.ability_haste;
+        this.arm_power = item.arm_power;
+        this.absolute_dig = item.absolute_dig;
+        this.ratio_dig = item.ratio_dig;
+        this.money_invested = item.money_invested;
+    }
+    */
+}
 ```

Unity

コードそのままコピペしました

2023/01/26 22:11

投稿

TrueRyoB

スコア79

test CHANGED Viewed

File without changes

test CHANGED Viewed

@@ -9,3 +9,168 @@
 皆さんの意見を聞かせてください
+### 今のコード
+行数の多さが今気になってます。
+```c#
+using System.Collections;
+using System.Collections.Generic;
+using UnityEngine;
+using UnityEngine.UI;
+using TMPro;
+public class InventoryManagement : MonoBehaviour
+{
+    public string[] skill_inventory = new string[6];
+    public string[] item_inventory = new string[16];
+    public ItemDataBase database;
+    public GameObject[] skill_iconBox = new GameObject[6];
+    public GameObject[] item_iconBox = new GameObject[16];
+    public GameObject text;
+    private TextMeshProUGUI _text;
+    void Start()
+    {
+        _text = text.GetComponent<TextMeshProUGUI>();
+        DisplayItems();
+    }
+    public void DisplayItems()
+    {
+        var i = 0;
+        foreach(string id in item_inventory)
+        {
+            if(item_iconBox[i] != null)//まだiconBoxの割り当てが済んでいないため　あとでやる（やらないパターン）
+            {
+                if(id != "")
+                {
+                    item_iconBox[i].GetComponent<Image>().sprite = SearchItemFromID(id).item_image;
+                }
+                else
+                {
+                    item_iconBox[i].GetComponent<Image>().sprite = null;
+                }
+            }
+            i++;
+        }
+        i = 0;
+        foreach(string id in skill_inventory)
+        {
+            if(skill_iconBox[i] != null)//まだiconBoxの割り当てが済んでいないため　あとでやる（やらないパターン）
+            {
+                if(id != "")
+                {
+                    skill_iconBox[i].GetComponent<Image>().sprite = SearchItemFromID(id).item_image;
+                }
+                else
+                {
+                    skill_iconBox[i].GetComponent<Image>().sprite = null;
+                }
+            }
+            i++;
+        }
+    }
+    public void DisplayItemDescription(int i)
+    {
+        Item selected_item;
+        if(i >= 6)
+        {
+            selected_item = SearchItemFromID(item_inventory[i-6]);
+        }
+        else
+        {
+            selected_item = SearchItemFromID(skill_inventory[i]);
+        }
+        if(selected_item!=null)
+        {
+            //_text.text = selected_item.item_name;
+            _text.text = "<size=20>"+ selected_item.item_name +"</size>"+"\n\n <size=16>"+selected_item.information+"</size>";
+        }
+    }
+    public void ResetText()
+    {
+    }
+    public void ItemAdded(string newItemID)
+    {
+        var i = 0;
+        foreach(string id in item_inventory)
+        {
+            if(id == "")
+            {
+                item_inventory[i] = newItemID;
+                break;
+            }
+            else
+            {
+                i++;
+                continue;
+            }
+        }
+        DisplayItems();
+    }
+    public void SkillAdded(string newSkillID)
+    {
+        var i = 0;
+        foreach(string id in skill_inventory)
+        {
+            if(id == "")
+            {
+                skill_inventory[i] = newSkillID;
+                break;
+            }
+            else
+            {
+                i++;
+                continue;
+            }
+        }
+        DisplayItems();
+    }
+    public void ItemUsed(int i, GameObject icon)
+    {
+        Item selected_item = SearchItemFromID(item_inventory[i]);
+        if(selected_item.type.ToString()=="Reusable")
+        {
+            icon.GetComponent<Image>().color = new Color32(58,58,58,255);
+        }
+    }
+    public void SkillUsed(int i, GameObject icon)
+    {
+        Debug.Log(SearchItemFromID(skill_inventory[i]).item_name);
+        //ここに効果発動させるコマンドと、周りを光の尾で照らすコマンドをかく
+    }
+    private Item SearchItemFromID(string given_ID)
+    {
+        Item selected_item;
+        foreach(Item item in database.items)
+        {
+            if(item.item_id == given_ID)
+            {
+                selected_item = item;
+                return selected_item;
+            }
+        }
+        return null; //if matched id isnt found
+    }
+}
+```

Unity