編集履歴

質問編集履歴

コードの修正

2021/06/03 01:36

投稿

sakuramochiIII

スコア8

test CHANGED Viewed

File without changes

test CHANGED Viewed

@@ -38,17 +38,17 @@
 class App:
-    def init(self):
+    def __init__(self):
         pyxel.init(160, 120, caption="Invadors game",
         palette=[1],quit_key=pyxel.KEY_NONE)
 #Player
+class player:
-    def init(self):
+    def __init__(self):
         pyxel.image(0).load(0, 0, "./player.png")
@@ -56,9 +56,9 @@
         playerX_change = 0
+class sound:
-    def init(self):
+    def __init__(self):
         self.music_player = MusicPlayer('laser.wav')
@@ -66,9 +66,11 @@
 #kadai
+class kadai:
-    def init(self):
+    def __init__(self):
-        kadaiImg = pyxel.image.load('kadai.png')
+        pyxel.image(1).load(0, 0, "./kadai.png")
         kadaiX = random.randint(0, 736)
@@ -80,9 +82,11 @@
 #Bullet
+class Bullet:
-    def ini(self):
+    def __init__(self):
-        bulletImg = pyxel.image.load('bullet.png')
+        pyxel.image(2).load(0, 0, "./bullet.png")
         bulletX, bulletY = 0, 480
@@ -96,19 +100,315 @@
 #Score
+class score:
+        score_value = 0
+def player(x, y):
+    screen.blit(playerImg, (x, y))
+def kadai(x, y):
+    screen.blit(kadaiImg, (x, y))
+def fire_bullet(x, y):
+    global bullet_state
+    bullet_state = 'fire'
+    screen.blit(bulletImg, (x + 16, y + 10))
+def isCollision(kadaiX, kadaiY, bulletX, bulletY):
+    distance = math.sqrt(math.pow(kadaiX - bulletX, 2) + math.pow(kadaiY - bulletY, 2))
+    if distance < 27:
+        return true
+    else:
+        return False
+def __init__(self):
+ running = True
+ while running:
+      screen.fill((0, 0, 0))
+      font = pyxel.font.SysFont(None, 80)
+      message = font.render('Hello World', False, (255, 255, 255))
+      screen.blit(message, (20,50))
+      for event in pyxel.event.get():
+            if event.type == pyxel.QUIT:
+                 running = False
+            if event.type == pyxel.KEYDOWN:
+             if event.key == pyxel.K_LEFT:
+                 playerX_change = -1.5
+             if event.key == pyxel.K_RIGHT:
+                 playerX_change = 1.5
+             if event.key == pyxel.K_SPACE:
+              if bullet_state == 'ready':
+                 bulletX = playerX
+              fire_bullet(bulletX, bulletY)
+             if event.type == pyxel.KEYUP:
+              if event.key == pyxel.K_LEFT or event.key == pyxel.K_RIGHT:
+                playerX_change = 0
+    #Player
+def __init__(player):
+    playerX += playerX_change
+    if playerX <= 0:
+         playerX = 0
+    elif playerX >= 736:
+       playerX = 736
+    #kadai
+    if kadai > 440:
+         pass
+    kadaiX += kadaiX_change
+    if kadaiX <= 0:
+        kadaiX_change = 4 #go right if come to the leftend
+        kadaiY += kadaiY_change
+    elif kadaiX >= 736:
+        kadaiX_change = -4 #go left if come to the rightend
+        kadaiY += kadaiY_change
+    collision = isCollision(kadaiX, kadaiY, bulletX, bulletY)
+    if collosion:
+        bulletY = 480
+        bullet_state = 'ready'
+        score_value += 1
+        kadaiX = random.randint(0, 736)
+        kadaiY = random.randint(50, 150)
+    #bullet Movement
+    if bulletY <=0:
+        bulletY = 480
+        bullet_state = 'ready'
+    if bullet_state == 'fire':
+        fire_bullet(bulletX, bulletY)
+        bulletY -= bulletY_change
+    #Score
+    font = pyxel.font.SysFont(None, 32) #creating fonts 'None' is default
+    score = font.render("Score: {str(score_value)}", True, (255,255,255))
+    screen.blit(score, (20,50))
+    player(playerX, playerY)
+    kadai(kadaiX, kadaiY)
+    pyxel.display.update()
+App()
+```
+### 試したこと
+ここに問題に対して試したことを記載してください。
+### 補足情報（FW/ツールのバージョンなど）
+最終目標としては、Pygameで書かれたコードを同じ動作をするようにpyxelで書き換えることです。
+```Pygame
+import pygame
+from pygame import mixer
+import random
+import math
+pygame.init()
+screen = pygame.display.set_mode((800, 600))
+screen.fill((150,150,150))
+pygame.display.set_caption('Invaders game')
+#Player
+playerimg = pygame.image.load('player.png')
+playerX,playerY = 370, 480
+playerX_change = 0
+#mixer.Sound('laser.wav').play()
+#Enemy
+enemyImg = pygame.image.load('enemy.png')
+enemyX = random.randint(0, 736)
+enemyY = random.randint(50, 150)
+enemyX_change, enemyY_change = 4, 40
+#Bullet
+bulletImg = pygame.image.load('bullet.png')
+bulletX, bulletY = 0, 480
+bulletX_change, bulletY_change = 0, 3
+bullet_state = 'ready'
+#Score
 score_value = 0
 def player(x, y):
     screen.blit(playerImg, (x, y))
-def kadai(x, y):
+def enemy(x, y):
-    screen.blit(kadaiImg, (x, y))
+    screen.blit(enemyImg, (x, y))
@@ -122,9 +422,9 @@
-def isCollision(kadaiX, kadaiY, bulletX, bulletY):
+def isCollision(enemyX, enemyY, bulletX, bulletY):
-    distance = math.sqrt(math.pow(kadaiX - bulletX, 2) + math.pow(kadaiY - bulletY, 2))
+    distance = math.sqrt(math.pow(enemyX - bulletX, 2) + math.pow(enemyY - bulletY, 2))
     if distance < 27:
@@ -136,49 +436,49 @@
-def init(self):
- running = True
+running = True
- while running:
+while running:
-      screen.fill((0, 0, 0))
+    screen.fill((0, 0, 0))
-      font = pyxel.font.SysFont(None, 80)
+      #font = pygame.font.SysFont(None, 80)
-      message = font.render('Hello World', False, (255, 255, 255))
+      #message = font.render('Hello World', False, (255, 255, 255))
-      screen.blit(message, (20,50))
+      #screen.blit(message, (20,50))
-      for event in pyxel.event.get():
+    for event in pygame.event.get():
-            if event.type == pyxel.QUIT:
+            if event.type == pygame.QUIT:
                  running = False
-            if event.type == pyxel.KEYDOWN:
+if event.type == pygame.KEYDOWN:
-             if event.key == pyxel.K_LEFT:
+    if event.key == pygame.K_LEFT:
-                 playerX_change = -1.5
+        playerX_change = -1.5
-             if event.key == pyxel.K_RIGHT:
+    if event.key == pygame.K_RIGHT:
-                 playerX_change = 1.5
+        playerX_change = 1.5
-             if event.key == pyxel.K_SPACE:
+    if event.key == pygame.K_SPACE:
-              if bullet_state == 'ready':
+       if bullet_state is 'ready':
-                 bulletX = playerX
+            bulletX = playerX
-              fire_bullet(bulletX, bulletY)
+            fire_bullet(bulletX, bulletY)
-             if event.type == pyxel.KEYUP:
+    if event.type == pygame.KEYUP:
-              if event.key == pyxel.K_LEFT or event.key == pyxel.K_RIGHT:
+            if event.key == pygame.K_LEFT or event.key == pygame.K_RIGHT:
                 playerX_change = 0
@@ -186,8 +486,6 @@
     #Player
-def init(player):
     playerX += playerX_change
     if playerX <= 0:
@@ -196,33 +494,33 @@
     elif playerX >= 736:
-       playerX = 736
+        playerX = 736
-    #kadai
+    #Enemy
-    if kadai > 440:
+    if enemy > 440:
-         pass
+        break
-    kadaiX += kadaiX_change
+    enemyX += enemyX_change
-    if kadaiX <= 0:
+    if enemyX <= 0:
-        kadaiX_change = 4 #go right if come to the leftend
+        enemyX_change = 4 #go right if come to the leftend
-        kadaiY += kadaiY_change
+        enemyY += enemyY_change
-    elif kadaiX >= 736:
+    elif enemyX >= 736:
-        kadaiX_change = -4 #go left if come to the rightend
+        enemyX_change = -4 #go left if come to the rightend
-        kadaiY += kadaiY_change
+        enemyY += enemyY_change
-    collision = isCollision(kadaiX, kadaiY, bulletX, bulletY)
+    collision = isCollision(enemyX, enemyY, bulletX, bulletY)
     if collosion:
@@ -232,9 +530,9 @@
         score_value += 1
-        kadaiX = random.randint(0, 736)
+        enemyX = random.randint(0, 736)
-        kadaiY = random.randint(50, 150)
+        enemyY = random.randint(50, 150)
@@ -248,7 +546,7 @@
-    if bullet_state == 'fire':
+    if bullet_state is 'fire':
         fire_bullet(bulletX, bulletY)
@@ -262,7 +560,7 @@
     #Score
-    font = pyxel.font.SysFont(None, 32) #creating fonts 'None' is default
+    font = pygame.font.SysFont(None, 32) #creating fonts 'None' is default
     score = font.render("Score: {str(score_value)}", True, (255,255,255))
@@ -274,302 +572,10 @@
     player(playerX, playerY)
-    kadai(kadaiX, kadaiY)
+    enemy(enemyX, enemyY)
-    pyxel.display.update()
+    pygame.display.update()
-App()
 ```
-### 試したこと
-ここに問題に対して試したことを記載してください。
-### 補足情報（FW/ツールのバージョンなど）
-最終目標としては、Pygameで書かれたコードを同じ動作をするようにpyxelで書き換えることです。
-```Pygame
-import pygame
-from pygame import mixer
-import random
-import math
-pygame.init()
-screen = pygame.display.set_mode((800, 600))
-screen.fill((150,150,150))
-pygame.display.set_caption('Invaders game')
-#Player
-playerimg = pygame.image.load('player.png')
-playerX,playerY = 370, 480
-playerX_change = 0
-#mixer.Sound('laser.wav').play()
-#Enemy
-enemyImg = pygame.image.load('enemy.png')
-enemyX = random.randint(0, 736)
-enemyY = random.randint(50, 150)
-enemyX_change, enemyY_change = 4, 40
-#Bullet
-bulletImg = pygame.image.load('bullet.png')
-bulletX, bulletY = 0, 480
-bulletX_change, bulletY_change = 0, 3
-bullet_state = 'ready'
-#Score
-score_value = 0
-def player(x, y):
-    screen.blit(playerImg, (x, y))
-def enemy(x, y):
-    screen.blit(enemyImg, (x, y))
-def fire_bullet(x, y):
-    global bullet_state
-    bullet_state = 'fire'
-    screen.blit(bulletImg, (x + 16, y + 10))
-def isCollision(enemyX, enemyY, bulletX, bulletY):
-    distance = math.sqrt(math.pow(enemyX - bulletX, 2) + math.pow(enemyY - bulletY, 2))
-    if distance < 27:
-        return true
-    else:
-        return False
-running = True
-while running:
-    screen.fill((0, 0, 0))
-      #font = pygame.font.SysFont(None, 80)
-      #message = font.render('Hello World', False, (255, 255, 255))
-      #screen.blit(message, (20,50))
-    for event in pygame.event.get():
-            if event.type == pygame.QUIT:
-                 running = False
-if event.type == pygame.KEYDOWN:
-    if event.key == pygame.K_LEFT:
-        playerX_change = -1.5
-    if event.key == pygame.K_RIGHT:
-        playerX_change = 1.5
-    if event.key == pygame.K_SPACE:
-       if bullet_state is 'ready':
-            bulletX = playerX
-            fire_bullet(bulletX, bulletY)
-    if event.type == pygame.KEYUP:
-            if event.key == pygame.K_LEFT or event.key == pygame.K_RIGHT:
-                playerX_change = 0
-    #Player
-    playerX += playerX_change
-    if playerX <= 0:
-         playerX = 0
-    elif playerX >= 736:
-        playerX = 736
-    #Enemy
-    if enemy > 440:
-        break
-    enemyX += enemyX_change
-    if enemyX <= 0:
-        enemyX_change = 4 #go right if come to the leftend
-        enemyY += enemyY_change
-    elif enemyX >= 736:
-        enemyX_change = -4 #go left if come to the rightend
-        enemyY += enemyY_change
-    collision = isCollision(enemyX, enemyY, bulletX, bulletY)
-    if collosion:
-        bulletY = 480
-        bullet_state = 'ready'
-        score_value += 1
-        enemyX = random.randint(0, 736)
-        enemyY = random.randint(50, 150)
-    #bullet Movement
-    if bulletY <=0:
-        bulletY = 480
-        bullet_state = 'ready'
-    if bullet_state is 'fire':
-        fire_bullet(bulletX, bulletY)
-        bulletY -= bulletY_change
-    #Score
-    font = pygame.font.SysFont(None, 32) #creating fonts 'None' is default
-    score = font.render("Score: {str(score_value)}", True, (255,255,255))
-    screen.blit(score, (20,50))
-    player(playerX, playerY)
-    enemy(enemyX, enemyY)
-    pygame.display.update()
-```

コードの追記

2021/06/03 01:36

投稿

sakuramochiIII

スコア8

test CHANGED Viewed

File without changes

test CHANGED Viewed

@@ -297,3 +297,279 @@
 ### 補足情報（FW/ツールのバージョンなど）
+最終目標としては、Pygameで書かれたコードを同じ動作をするようにpyxelで書き換えることです。
+```Pygame
+import pygame
+from pygame import mixer
+import random
+import math
+pygame.init()
+screen = pygame.display.set_mode((800, 600))
+screen.fill((150,150,150))
+pygame.display.set_caption('Invaders game')
+#Player
+playerimg = pygame.image.load('player.png')
+playerX,playerY = 370, 480
+playerX_change = 0
+#mixer.Sound('laser.wav').play()
+#Enemy
+enemyImg = pygame.image.load('enemy.png')
+enemyX = random.randint(0, 736)
+enemyY = random.randint(50, 150)
+enemyX_change, enemyY_change = 4, 40
+#Bullet
+bulletImg = pygame.image.load('bullet.png')
+bulletX, bulletY = 0, 480
+bulletX_change, bulletY_change = 0, 3
+bullet_state = 'ready'
+#Score
+score_value = 0
+def player(x, y):
+    screen.blit(playerImg, (x, y))
+def enemy(x, y):
+    screen.blit(enemyImg, (x, y))
+def fire_bullet(x, y):
+    global bullet_state
+    bullet_state = 'fire'
+    screen.blit(bulletImg, (x + 16, y + 10))
+def isCollision(enemyX, enemyY, bulletX, bulletY):
+    distance = math.sqrt(math.pow(enemyX - bulletX, 2) + math.pow(enemyY - bulletY, 2))
+    if distance < 27:
+        return true
+    else:
+        return False
+running = True
+while running:
+    screen.fill((0, 0, 0))
+      #font = pygame.font.SysFont(None, 80)
+      #message = font.render('Hello World', False, (255, 255, 255))
+      #screen.blit(message, (20,50))
+    for event in pygame.event.get():
+            if event.type == pygame.QUIT:
+                 running = False
+if event.type == pygame.KEYDOWN:
+    if event.key == pygame.K_LEFT:
+        playerX_change = -1.5
+    if event.key == pygame.K_RIGHT:
+        playerX_change = 1.5
+    if event.key == pygame.K_SPACE:
+       if bullet_state is 'ready':
+            bulletX = playerX
+            fire_bullet(bulletX, bulletY)
+    if event.type == pygame.KEYUP:
+            if event.key == pygame.K_LEFT or event.key == pygame.K_RIGHT:
+                playerX_change = 0
+    #Player
+    playerX += playerX_change
+    if playerX <= 0:
+         playerX = 0
+    elif playerX >= 736:
+        playerX = 736
+    #Enemy
+    if enemy > 440:
+        break
+    enemyX += enemyX_change
+    if enemyX <= 0:
+        enemyX_change = 4 #go right if come to the leftend
+        enemyY += enemyY_change
+    elif enemyX >= 736:
+        enemyX_change = -4 #go left if come to the rightend
+        enemyY += enemyY_change
+    collision = isCollision(enemyX, enemyY, bulletX, bulletY)
+    if collosion:
+        bulletY = 480
+        bullet_state = 'ready'
+        score_value += 1
+        enemyX = random.randint(0, 736)
+        enemyY = random.randint(50, 150)
+    #bullet Movement
+    if bulletY <=0:
+        bulletY = 480
+        bullet_state = 'ready'
+    if bullet_state is 'fire':
+        fire_bullet(bulletX, bulletY)
+        bulletY -= bulletY_change
+    #Score
+    font = pygame.font.SysFont(None, 32) #creating fonts 'None' is default
+    score = font.render("Score: {str(score_value)}", True, (255,255,255))
+    screen.blit(score, (20,50))
+    player(playerX, playerY)
+    enemy(enemyX, enemyY)
+    pygame.display.update()
+```

内容の改善、補足

2021/06/03 00:45

投稿

sakuramochiIII

スコア8

test CHANGED Viewed

File without changes

test CHANGED Viewed

@@ -1,8 +1,10 @@
 ### 前提・実現したいこと
+pyxelでインベーダーゲームを作っています。
-実行しても何も起こらなくなってしまいました。アドバイスお願いします。
+下のエラーメッセージを改善しようと書き換えたところ、実行しても何も起こらなくなってしまいました。アドバイスお願いします。
@@ -12,7 +14,13 @@
 ```
+  File "/Users/higashirinako/Downloads/pyxel_me/a.py", line 78
-エラーメッセージ(無し)
+    playerX += playerX_change
+                             ^
+IndentationError: unindent does not match any outer indentation level
 ```
@@ -289,7 +297,3 @@
 ### 補足情報（FW/ツールのバージョンなど）
-ここにより詳細な情報を記載してください。