質問編集履歴

インデントされていコードがあったので修正

2018/04/12 10:41

投稿

KIYZ

スコア17

test CHANGED Viewed

File without changes

test CHANGED Viewed

@@ -184,69 +184,69 @@
 <header>
-<nav class="navbar navbar-inverse navbar-static-top">
-<div class="container">
-<div class="navbar-header">
-<button type="button" class="navbar-toggle collapsed" data-toggle="collapse" data-target="#bs-example-navbar-collapse-1" aria-expanded="false">
-<span class="sr-only">Toggle navigation</span>
-<span class="icon-bar"></span>
-<span class="icon-bar"></span>
-<span class="icon-bar"></span>
-</button>
-<a class="navbar-brand" href="/">Microposts</a>
-</div>
-<div class="collapse navbar-collapse" id="bs-example-navbar-collapse-1">
-<ul class="nav navbar-nav navbar-right">
-@if (Auth::check())
-<li>{!! link_to_route('users.index', 'Users') !!}</li>
-<li class="dropdown">
-<a href="#" class="dropdown-toggle" data-toggle="dropdown" role="button" aria-haspopup="true" aria-expanded="false">{{ Auth::user()->name }} <span class="caret"></span></a>
-<ul class="dropdown-menu">
-<li>{!! link_to_route('users.show', 'My profile', ['id' => $user->id]) !!}</li>
-<li>{!! link_to_route('micropost.favorites', 'Favorites') !!}</li> <!--TODO-->
-<li role="separator" class="divider"></li>
-<li>{!! link_to_route('logout.get', 'Logout') !!}</li>
-</ul>
-</li>
-@else
-<li>{!! link_to_route('signup.get', 'Signup') !!}</li>
-<li>{!! link_to_route('login.get', 'Login') !!}</li>
-@endif
-</ul>
-</div>
-</div>
-</nav>
+    <nav class="navbar navbar-inverse navbar-static-top">
+        <div class="container">
+            <div class="navbar-header">
+                <button type="button" class="navbar-toggle collapsed" data-toggle="collapse" data-target="#bs-example-navbar-collapse-1" aria-expanded="false">
+                    <span class="sr-only">Toggle navigation</span>
+                    <span class="icon-bar"></span>
+                    <span class="icon-bar"></span>
+                    <span class="icon-bar"></span>
+                </button>
+                <a class="navbar-brand" href="/">Microposts</a>
+            </div>
+            <div class="collapse navbar-collapse" id="bs-example-navbar-collapse-1">
+                <ul class="nav navbar-nav navbar-right">
+                    @if (Auth::check())
+                        <li>{!! link_to_route('users.index', 'Users') !!}</li>
+                        <li class="dropdown">
+                            <a href="#" class="dropdown-toggle" data-toggle="dropdown" role="button" aria-haspopup="true" aria-expanded="false">{{ Auth::user()->name }} <span class="caret"></span></a>
+                            <ul class="dropdown-menu">
+                                <li>{!! link_to_route('users.show', 'My profile', ['id' => $user->id]) !!}</li>
+                                <li>{!! link_to_route('micropost.favorites', 'Favorites') !!}</li> <!--TODO-->
+                                <li role="separator" class="divider"></li>
+                                <li>{!! link_to_route('logout.get', 'Logout') !!}</li>
+                            </ul>
+                        </li>
+                    @else
+                        <li>{!! link_to_route('signup.get', 'Signup') !!}</li>
+                        <li>{!! link_to_route('login.get', 'Login') !!}</li>
+                    @endif
+                </ul>
+            </div>
+        </div>
+    </nav>
 </header>
@@ -284,160 +284,160 @@
 {
-public function index()
+    public function index()
-{
+    {
-$users = User::paginate(10);
+        $users = User::paginate(10);
-return view('users.index', [
+        return view('users.index', [
-'users' => $users,
+           'users' => $users,
-]);
+        ]);
+    }
+    public function show($id)
+    {
+        $user = User::find($id);
+        $microposts = $user->microposts()->orderBy('created_at', 'DESC')->paginate(10);
+        $data = [
+            'user' => $user,
+            'microposts' => $microposts,
+        ];
+        $data += $this->counts($user);
+        return view('users.show', $data);
+    }
+    public function followings($id)
+    {
+        $user = User::find($id);
+        $followings = $user->followings()->paginate(10);
+        $data = [
+            'user' => $user,
+            'users' => $followings,
+        ];
+        $data += $this->counts($user);
+        return view('users.followings', $data);
+    }
+    public function followers($id)
+    {
+        $user = User::find($id);
+        $followers = $user->followers()->paginate(10);
+        $data = [
+            'user' => $user,
+            'users' => $followers,
+        ];
+        $data += $this->counts($user);
+        return view('users.followers', $data);
+    }
+    public function favorites($id)
+    {
+        $user = User::find($id);
+        $microposts = $user->microposts()->orderBy('created_at', 'desc')->paginate(10);
+        $favorites = $user->favorites()->orderBy('created_at', 'desc')->paginate(10);
+        foreach ($microposts as $micropost) {
+            if ($micropost->id === $favorites->user_id) {
+                $favorite_microposts = $micropost;
+            }
+        }
+        $data = [
+            'user' => $user,
+            'microposts' => $microposts,
+            'favorites' => $favorites,
+            'favorite_microposts' => $favorite_microposts,
+        ];
+        $data += $this->counts($user);
+        return view('users.favorites', $data);
+    }
 }
-public function show($id)
-{
-$user = User::find($id);
-$microposts = $user->microposts()->orderBy('created_at', 'DESC')->paginate(10);
-$data = [
-'user' => $user,
-'microposts' => $microposts,
-];
-$data += $this->counts($user);
-return view('users.show', $data);
-}
-public function followings($id)
-{
-$user = User::find($id);
-$followings = $user->followings()->paginate(10);
-$data = [
-'user' => $user,
-'users' => $followings,
-];
-$data += $this->counts($user);
-return view('users.followings', $data);
-}
-public function followers($id)
-{
-$user = User::find($id);
-$followers = $user->followers()->paginate(10);
-$data = [
-'user' => $user,
-'users' => $followers,
-];
-$data += $this->counts($user);
-return view('users.followers', $data);
-}
-public function favorites($id)
-{
-$user = User::find($id);
-$microposts = $user->microposts()->orderBy('created_at', 'desc')->paginate(10);
-$favorites = $user->favorites()->orderBy('created_at', 'desc')->paginate(10);
-foreach ($microposts as $micropost) {
-if ($micropost->id === $favorites->user_id) {
-$favorite_microposts = $micropost;
-}
-}
-$data = [
-'user' => $user,
-'microposts' => $microposts,
-'favorites' => $favorites,
-'favorite_microposts' => $favorite_microposts,
-];
-$data += $this->counts($user);
-return view('users.favorites', $data);
-}
-}
 ```
@@ -448,6 +448,8 @@
 <?php
 Route::get('/', 'WelcomeController@index');
@@ -474,34 +476,34 @@
 Route::group(['middleware' => 'auth'], function () {
-Route::resource('users', 'UsersController', ['only' => ['index', 'show']]); // ユーザ一覧, ユーザ詳細
+    Route::resource('users', 'UsersController', ['only' => ['index', 'show']]); // ユーザ一覧, ユーザ詳細
-Route::group(['prefix' => 'users/{id}'], function () {
+    Route::group(['prefix' => 'users/{id}'], function () {
-Route::post('follow', 'UserFollowController@store')->name('user.follow');
+        Route::post('follow', 'UserFollowController@store')->name('user.follow');
-Route::delete('unfollow', 'UserFollowController@destroy')->name('user.unfollow');
+        Route::delete('unfollow', 'UserFollowController@destroy')->name('user.unfollow');
-Route::get('followings', 'UsersController@followings')->name('users.followings');
+        Route::get('followings', 'UsersController@followings')->name('users.followings');
-Route::get('followers', 'UsersController@followers')->name('users.followers');
+        Route::get('followers', 'UsersController@followers')->name('users.followers');
+    });
+    Route::resource('microposts', 'MicropostsController', ['only' => ['store', 'destroy']]); // 投稿の保存, 投稿の削除
+    // お気に入り
+    Route::post('favorite/{id}', 'FavoritesController@store')->name('micropost.favorite');
+    Route::delete('unfavorite/{id}', 'FavoritesController@destroy')->name('micropost.unfavorite');
+    Route::get('favorites/{id}', 'UsersController@favorites')->name('micropost.favorites');
 });
-Route::resource('microposts', 'MicropostsController', ['only' => ['store', 'destroy']]); // 投稿の保存, 投稿の削除
-// お気に入り
-Route::post('favorite/{id}', 'FavoritesController@store')->name('micropost.favorite');
-Route::delete('unfavorite/{id}', 'FavoritesController@destroy')->name('micropost.unfavorite');
-Route::get('favorites/{id}', 'UsersController@favorites')->name('micropost.favorites');
-});
 ```

「試したこと」を追加

2018/04/12 10:41

投稿

KIYZ

スコア17

test CHANGED Viewed

File without changes

test CHANGED Viewed

@@ -124,6 +124,50 @@
+### 試したこと
+__UsersController.php__ の `show(){}` の様に、
+```
+public function index($id)
+    {
+        $users = User::paginate(10);
+        $user = User::find($id);
+        return view('users.index', [
+           'users' => $users,
+           'user' => $user,
+        ]);
+    }
+```
+とすれば __index.blade.php__ にログインユーザーの情報を渡すことができるのではないかと思ったのですが、それをすると Missing Argument エラーが出てしまいます。
+```
+1/1
+ErrorException in UsersController.php line 14:
+Missing argument 1 for App\Http\Controllers\UsersController::index()
+```
 ### 該当のソースコード

「ヒントになりそうなこと」を追加

2018/04/12 09:22

投稿

KIYZ

スコア17

test CHANGED Viewed

File without changes

test CHANGED Viewed

@@ -92,6 +92,38 @@
+### ヒントになりそうなこと
+__UsersController.php__ の `index()` に以下を追記すると1.と2.を両方とも実現することができます。
+```
+public function index()
+    {
+        $users = User::paginate(10);
+        $user = User::find(2); // 追記。 動作確認としてidを直接指定。$userにログインユーザーのidを代入することができれば実現可能？
+        return view('users.index', [
+           'users' => $users,
+           'user' => $user, // 追記。ユーザー一覧ページのviewに渡す
+        ]);
+    }
+```
 ### 該当のソースコード