回答編集履歴

見直しキャンペーン中

2023/07/27 13:35

投稿

TN8001

スコア9326

test CHANGED Viewed

@@ -1,457 +1,229 @@
 > 1)選択が解除できず、ずっとGrayのスタイルが残る
 ~~`MoveCurrentToPosition(-1)`でもすればいいんじゃないですかね？~~
 ~~[CollectionView.MoveCurrentToPosition(Int32) メソッド (System.Windows.Data) | Microsoft Docs](https://docs.microsoft.com/ja-jp/dotnet/api/system.windows.data.collectionview.movecurrenttoposition)~~
 [ApplicationCommands.SelectAll プロパティ (System.Windows.Input) | Microsoft Docs](https://docs.microsoft.com/ja-jp/dotnet/api/system.windows.input.applicationcommands.selectall)
 との対称性を考えて`RoutedCommand`にしてみました。
-`View`で完結するのがいい点ですが、`ViewModel`でどうこうしたい場合は逆に扱いにくいです^^;
+Viewで完結するのがいい点ですが、ViewModelでどうこうしたい場合は逆に扱いにくいです^^;
 > 2)TextBoxを選択、☑を操作した時に、LightGrayにならない。
 フォーカスが`TextBox`や`CheckBox`に行きますから当然そうなりますね。
 `SelectionUnit="Cell"`でいいならこんな感じで行けましたがどうでしょうか。
 参考
 [wpf - DataGrid SelectionUnit=Cell disables all support for a selected row? - Stack Overflow](https://stackoverflow.com/questions/9489041/datagrid-selectionunit-cell-disables-all-support-for-a-selected-row)
-```xaml
+```xml
 <Window
   x:Class="Questions337191.Views.MainWindow"
   xmlns="http://schemas.microsoft.com/winfx/2006/xaml/presentation"
   xmlns:x="http://schemas.microsoft.com/winfx/2006/xaml"
   xmlns:b="http://schemas.microsoft.com/xaml/behaviors"
   xmlns:v="clr-namespace:Questions337191.Views"
   xmlns:vm="clr-namespace:Questions337191.ViewModels"
   Width="525"
   Height="350">
   <Window.DataContext>
     <vm:MainWindowViewModel />
   </Window.DataContext>
   <DockPanel>
     <!--
       メニューから呼ぶとなぜか激重になる。
       以降ボタンから呼んでもDataGridの左上ボタンでも同じく激重。
       意味が分からないｗ
     -->
     <!--<Menu DockPanel.Dock="Top">
       <MenuItem Header="編集">
         <MenuItem Command="ApplicationCommands.SelectAll" CommandTarget="{Binding ElementName=dataGrid}" />
         <MenuItem Command="v:DataGridBehavior.UnselectAll" CommandTarget="{Binding ElementName=dataGrid}" />
       </MenuItem>
     </Menu>-->
     <Grid>
       <Grid.RowDefinitions>
         <RowDefinition Height="Auto" />
         <RowDefinition />
       </Grid.RowDefinitions>
       <StackPanel Orientation="Horizontal">
         <Button
           MinWidth="100"
           Margin="5"
           Command="ApplicationCommands.SelectAll"
           CommandTarget="{Binding ElementName=dataGrid}"
           Content="すべて選択" />
         <Button
           MinWidth="100"
           Margin="5"
           Command="v:DataGridBehavior.UnselectAll"
           CommandTarget="{Binding ElementName=dataGrid}"
           Content="選択解除" />
       </StackPanel>
       <DataGrid
         x:Name="dataGrid"
         Grid.Row="1"
         ItemsSource="{Binding MyList}"
         SelectionUnit="Cell">
         <b:Interaction.Behaviors>
           <v:DataGridBehavior />
         </b:Interaction.Behaviors>
         <DataGrid.RowStyle>
           <Style TargetType="DataGridRow">
             <Setter Property="Height" Value="20" />
             <Style.Triggers>
               <Trigger Property="v:DataGridAttachedProperties.IsCellSelected" Value="True">
                 <Setter Property="Height" Value="40" />
                 <Setter Property="Background" Value="Gray" />
               </Trigger>
             </Style.Triggers>
           </Style>
         </DataGrid.RowStyle>
         <DataGrid.CellStyle>
           <Style TargetType="DataGridCell">
             <Style.Triggers>
               <Trigger Property="IsSelected" Value="True">
                 <Setter Property="Background" Value="LightGray" />
                 <Setter Property="v:DataGridAttachedProperties.IsCellSelected" Value="True" />
               </Trigger>
               <Trigger Property="IsSelected" Value="False">
                 <Setter Property="v:DataGridAttachedProperties.IsCellSelected" Value="False" />
               </Trigger>
             </Style.Triggers>
           </Style>
         </DataGrid.CellStyle>
         <DataGrid.Columns>
           <DataGridTemplateColumn Width="100">
             <DataGridTemplateColumn.CellTemplate>
               <DataTemplate>
                 <StackPanel Orientation="Horizontal">
                   <TextBox Text="コメント" />
                   <TextBlock Text="○" />
                 </StackPanel>
               </DataTemplate>
             </DataGridTemplateColumn.CellTemplate>
           </DataGridTemplateColumn>
         </DataGrid.Columns>
       </DataGrid>
     </Grid>
   </DockPanel>
 </Window>
 ```
-```C#
+```cs
 using Livet;
 using System.Collections.ObjectModel;
 using System.Linq;
 namespace Questions337191.ViewModels
 {
     public class MainWindowViewModel : ViewModel
-    {
+    {
         public ObservableCollection<Person> MyList { get; }
         public MainWindowViewModel()
-        {
+        {
             MyList = new ObservableCollection<Person>(
                 Enumerable.Range(1, 10_000).Select(i => new Person
                 {
                     Name = "田中" + i,
                     Age = 20 + i,
                     AuthMember = i % 2 == 0,
                 }));
-        }
+        }
-    }
+    }
     public class Person
-    {
+    {
         public string Name { get; set; }
         public int Age { get; set; }
         public bool AuthMember { get; set; }
-    }
+    }
 }
 ```
-```C#
+```cs
 using Microsoft.Xaml.Behaviors;
 using System.Linq;
 using System.Windows;
 using System.Windows.Controls;
 using System.Windows.Input;
 using System.Windows.Media;
 namespace Questions337191.Views
 {
     // [wpf - DataGrid SelectionUnit=Cell disables all support for a selected row? - Stack Overflow](https://stackoverflow.com/questions/9489041/datagrid-selectionunit-cell-disables-all-support-for-a-selected-row)
     public static class DataGridAttachedProperties
-    {
+    {
         public static bool GetIsCellSelected(DependencyObject obj) => (bool)obj.GetValue(IsCellSelectedProperty);
         public static void SetIsCellSelected(DependencyObject obj, bool value) => obj.SetValue(IsCellSelectedProperty, value);
         public static readonly DependencyProperty IsCellSelectedProperty
             = DependencyProperty.RegisterAttached("IsCellSelected", typeof(bool), typeof(DataGridAttachedProperties),
                 new UIPropertyMetadata(false, OnIsCellSelectedChanged));
         private static void OnIsCellSelectedChanged(DependencyObject d, DependencyPropertyChangedEventArgs e)
-        {
+        {
             if (d is DataGridCell cell)
             {
                 var row = FindVisualParent<DataGridRow>(cell);
                 // 同じ行内で複数選択がある状態でそのうち１つを選択し直した場合
                 // そのセルはCellSelectedChangedが出ない（選択状態は変わらない）ので
                 // 周りの選択解除だけ伝わってしまいバグる
                 //row.SetValue(IsCellSelectedProperty, e.NewValue);
                 // しかたがないので行内全走査
                 // 重そうだが100桁くらいなら気にならなかった（1000桁あると数秒止まった^^;
                 var p = FindVisualParent<DataGridCellsPanel>(cell);
                 var b = p.Children.Cast<DataGridCell>().Any(x => x.IsSelected);
                 row.SetValue(IsCellSelectedProperty, b);
             }
-        }
+        }
         private static T FindVisualParent<T>(DependencyObject child) where T : DependencyObject
-        {
+        {
             var parentObject = VisualTreeHelper.GetParent(child);
             if (parentObject == null) return null;
             if (parentObject is T parent) return parent;
             else return FindVisualParent<T>(parentObject);
-        }
+        }
-    }
+    }
     public class DataGridBehavior : Behavior<DataGrid>
-    {
+    {
         public static readonly RoutedUICommand UnselectAll = new RoutedUICommand("選択解除", "UnselectAll", typeof(DataGridBehavior));
         protected override void OnAttached()
-        {
+        {
             base.OnAttached();
             var commandBinding = new CommandBinding(UnselectAll, Executed);
             AssociatedObject.CommandBindings.Add(commandBinding);
-        }
+        }
         protected override void OnDetaching()
-        {
+        {
             base.OnDetaching();
             AssociatedObject.CommandBindings.Clear();
-        }
+        }
         private void Executed(object target, ExecutedRoutedEventArgs e)
-        {
+        {
             if (AssociatedObject.SelectionUnit == DataGridSelectionUnit.FullRow)
                 AssociatedObject.UnselectAll();
             else
                 AssociatedObject.UnselectAllCells();
             e.Handled = true;
-        }
+        }
-    }
+    }
 }
 ```
 ---
 あれこれいじっていたらいろいろバグを見つけてしまいました^^;
 * `DataGridAttachedProperties`複数選択時未考慮
   回答コードを参照してください。
 * `Menu`や`ContextMenu`で`DataGrid`に`SelectAll`を使うと以降激重
   `SelectAll`だけの（`Style`等をすべてなくして追加コードが一切ない）状態でも再現しますので、WPFのバグっぽいです（意味が分からな過ぎて原因も回避法もわかりません^^;

対称性

2021/05/11 08:56

投稿

TN8001

スコア9326

test CHANGED Viewed

@@ -10,7 +10,7 @@
 [ApplicationCommands.SelectAll プロパティ (System.Windows.Input) | Microsoft Docs](https://docs.microsoft.com/ja-jp/dotnet/api/system.windows.input.applicationcommands.selectall)
-との対照性を考えて`RoutedCommand`にしてみました。
+との対称性を考えて`RoutedCommand`にしてみました。
 `View`で完結するのがいい点ですが、`ViewModel`でどうこうしたい場合は逆に扱いにくいです^^;

RoutedCommand

2021/05/11 08:56

投稿

TN8001

スコア9326

test CHANGED Viewed

@@ -2,9 +2,17 @@
-`MoveCurrentToPosition(-1)`でもすればいいんじゃないですかね？
+~~`MoveCurrentToPosition(-1)`でもすればいいんじゃないですかね？~~
-[CollectionView.MoveCurrentToPosition(Int32) メソッド (System.Windows.Data) | Microsoft Docs](https://docs.microsoft.com/ja-jp/dotnet/api/system.windows.data.collectionview.movecurrenttoposition)
+~~[CollectionView.MoveCurrentToPosition(Int32) メソッド (System.Windows.Data) | Microsoft Docs](https://docs.microsoft.com/ja-jp/dotnet/api/system.windows.data.collectionview.movecurrenttoposition)~~
+[ApplicationCommands.SelectAll プロパティ (System.Windows.Input) | Microsoft Docs](https://docs.microsoft.com/ja-jp/dotnet/api/system.windows.input.applicationcommands.selectall)
+との対照性を考えて`RoutedCommand`にしてみました。
+`View`で完結するのがいい点ですが、`ViewModel`でどうこうしたい場合は逆に扱いにくいです^^;
@@ -34,6 +42,8 @@
   xmlns:x="http://schemas.microsoft.com/winfx/2006/xaml"
+  xmlns:b="http://schemas.microsoft.com/xaml/behaviors"
   xmlns:v="clr-namespace:Questions337191.Views"
   xmlns:vm="clr-namespace:Questions337191.ViewModels"
@@ -42,131 +52,173 @@
   Height="350">
   <Window.DataContext>
     <vm:MainWindowViewModel />
   </Window.DataContext>
-  <Grid>
-    <Grid.RowDefinitions>
-      <RowDefinition Height="50" />
-      <RowDefinition />
-      <RowDefinition Height="50" />
-    </Grid.RowDefinitions>
-    <Button
-      Width="100"
-      Margin="5"
-      HorizontalAlignment="Left"
-      Command="{Binding UnselectCommand}"
-      Content="選択解除" />
-    <DataGrid
-      Grid.Row="1"
-      IsSynchronizedWithCurrentItem="True"
-      ItemsSource="{Binding MyList}"
-      SelectionUnit="Cell">
-      <DataGrid.RowStyle>
-        <Style TargetType="DataGridRow">
-          <Setter Property="Height" Value="20" />
-          <Style.Triggers>
-            <Trigger Property="v:DataGridAttachedProperties.IsCellSelected" Value="True">
-              <Setter Property="Height" Value="40" />
-              <Setter Property="Background" Value="Gray" />
-            </Trigger>
-          </Style.Triggers>
-        </Style>
-      </DataGrid.RowStyle>
-      <DataGrid.CellStyle>
-        <Style TargetType="DataGridCell">
-          <Style.Triggers>
-            <Trigger Property="IsSelected" Value="True">
-              <Setter Property="Background" Value="LightGray" />
-              <Setter Property="v:DataGridAttachedProperties.IsCellSelected" Value="True" />
-            </Trigger>
-            <Trigger Property="IsSelected" Value="False">
-              <Setter Property="v:DataGridAttachedProperties.IsCellSelected" Value="False" />
-            </Trigger>
-          </Style.Triggers>
-        </Style>
-      </DataGrid.CellStyle>
-      <DataGrid.Columns>
-        <DataGridTemplateColumn Width="100">
-          <DataGridTemplateColumn.CellTemplate>
-            <DataTemplate>
-              <StackPanel Orientation="Horizontal">
-                <TextBox Width="50" Text="コメント" />
-                <TextBlock Text="○" />
-              </StackPanel>
-            </DataTemplate>
-          </DataGridTemplateColumn.CellTemplate>
-        </DataGridTemplateColumn>
-      </DataGrid.Columns>
-    </DataGrid>
-  </Grid>
+  <DockPanel>
+    <!--
+      メニューから呼ぶとなぜか激重になる。
+      以降ボタンから呼んでもDataGridの左上ボタンでも同じく激重。
+      意味が分からないｗ
+    -->
+    <!--<Menu DockPanel.Dock="Top">
+      <MenuItem Header="編集">
+        <MenuItem Command="ApplicationCommands.SelectAll" CommandTarget="{Binding ElementName=dataGrid}" />
+        <MenuItem Command="v:DataGridBehavior.UnselectAll" CommandTarget="{Binding ElementName=dataGrid}" />
+      </MenuItem>
+    </Menu>-->
+    <Grid>
+      <Grid.RowDefinitions>
+        <RowDefinition Height="Auto" />
+        <RowDefinition />
+      </Grid.RowDefinitions>
+      <StackPanel Orientation="Horizontal">
+        <Button
+          MinWidth="100"
+          Margin="5"
+          Command="ApplicationCommands.SelectAll"
+          CommandTarget="{Binding ElementName=dataGrid}"
+          Content="すべて選択" />
+        <Button
+          MinWidth="100"
+          Margin="5"
+          Command="v:DataGridBehavior.UnselectAll"
+          CommandTarget="{Binding ElementName=dataGrid}"
+          Content="選択解除" />
+      </StackPanel>
+      <DataGrid
+        x:Name="dataGrid"
+        Grid.Row="1"
+        ItemsSource="{Binding MyList}"
+        SelectionUnit="Cell">
+        <b:Interaction.Behaviors>
+          <v:DataGridBehavior />
+        </b:Interaction.Behaviors>
+        <DataGrid.RowStyle>
+          <Style TargetType="DataGridRow">
+            <Setter Property="Height" Value="20" />
+            <Style.Triggers>
+              <Trigger Property="v:DataGridAttachedProperties.IsCellSelected" Value="True">
+                <Setter Property="Height" Value="40" />
+                <Setter Property="Background" Value="Gray" />
+              </Trigger>
+            </Style.Triggers>
+          </Style>
+        </DataGrid.RowStyle>
+        <DataGrid.CellStyle>
+          <Style TargetType="DataGridCell">
+            <Style.Triggers>
+              <Trigger Property="IsSelected" Value="True">
+                <Setter Property="Background" Value="LightGray" />
+                <Setter Property="v:DataGridAttachedProperties.IsCellSelected" Value="True" />
+              </Trigger>
+              <Trigger Property="IsSelected" Value="False">
+                <Setter Property="v:DataGridAttachedProperties.IsCellSelected" Value="False" />
+              </Trigger>
+            </Style.Triggers>
+          </Style>
+        </DataGrid.CellStyle>
+        <DataGrid.Columns>
+          <DataGridTemplateColumn Width="100">
+            <DataGridTemplateColumn.CellTemplate>
+              <DataTemplate>
+                <StackPanel Orientation="Horizontal">
+                  <TextBox Text="コメント" />
+                  <TextBlock Text="○" />
+                </StackPanel>
+              </DataTemplate>
+            </DataGridTemplateColumn.CellTemplate>
+          </DataGridTemplateColumn>
+        </DataGrid.Columns>
+      </DataGrid>
+    </Grid>
+  </DockPanel>
 </Window>
@@ -178,65 +230,151 @@
 using Livet;
-using Livet.Commands;
 using System.Collections.ObjectModel;
 using System.Linq;
+namespace Questions337191.ViewModels
+{
+    public class MainWindowViewModel : ViewModel
+    {
+        public ObservableCollection<Person> MyList { get; }
+        public MainWindowViewModel()
+        {
+            MyList = new ObservableCollection<Person>(
+                Enumerable.Range(1, 10_000).Select(i => new Person
+                {
+                    Name = "田中" + i,
+                    Age = 20 + i,
+                    AuthMember = i % 2 == 0,
+                }));
+        }
+    }
+    public class Person
+    {
+        public string Name { get; set; }
+        public int Age { get; set; }
+        public bool AuthMember { get; set; }
+    }
+}
+```
+```C#
+using Microsoft.Xaml.Behaviors;
+using System.Linq;
-using System.Windows.Data;
+using System.Windows;
+using System.Windows.Controls;
 using System.Windows.Input;
+using System.Windows.Media;
-namespace Questions337191.ViewModels
+namespace Questions337191.Views
 {
-    public class MainWindowViewModel : ViewModel
+    // [wpf - DataGrid SelectionUnit=Cell disables all support for a selected row? - Stack Overflow](https://stackoverflow.com/questions/9489041/datagrid-selectionunit-cell-disables-all-support-for-a-selected-row)
+    public static class DataGridAttachedProperties
     {
+        public static bool GetIsCellSelected(DependencyObject obj) => (bool)obj.GetValue(IsCellSelectedProperty);
+        public static void SetIsCellSelected(DependencyObject obj, bool value) => obj.SetValue(IsCellSelectedProperty, value);
-        public ObservableCollection<Person> MyList { get; }
+        public static readonly DependencyProperty IsCellSelectedProperty
+            = DependencyProperty.RegisterAttached("IsCellSelected", typeof(bool), typeof(DataGridAttachedProperties),
-        public ICommand UnselectCommand { get; }
+                new UIPropertyMetadata(false, OnIsCellSelectedChanged));
-        public MainWindowViewModel()
+        private static void OnIsCellSelectedChanged(DependencyObject d, DependencyPropertyChangedEventArgs e)
-        {
+        {
-            MyList = new ObservableCollection<Person>(
+            if (d is DataGridCell cell)
-                Enumerable.Range(1, 5).Select(i => new Person
-                {
+            {
+                var row = FindVisualParent<DataGridRow>(cell);
+                // 同じ行内で複数選択がある状態でそのうち１つを選択し直した場合
+                // そのセルはCellSelectedChangedが出ない（選択状態は変わらない）ので
+                // 周りの選択解除だけ伝わってしまいバグる
+                //row.SetValue(IsCellSelectedProperty, e.NewValue);
-                    Name = "田中" + i,
+                // しかたがないので行内全走査
-                    Age = 20 + i,
-                    AuthMember = i % 2 == 0
+                // 重そうだが100桁くらいなら気にならなかった（1000桁あると数秒止まった^^;
-                }));
+                var p = FindVisualParent<DataGridCellsPanel>(cell);
+                var b = p.Children.Cast<DataGridCell>().Any(x => x.IsSelected);
-            UnselectCommand = new ViewModelCommand(TestButton);
+                row.SetValue(IsCellSelectedProperty, b);
-        }
+            }
+        }
-        public void TestButton()
+        private static T FindVisualParent<T>(DependencyObject child) where T : DependencyObject
-        {
+        {
-            var cv = CollectionViewSource.GetDefaultView(MyList);
+            var parentObject = VisualTreeHelper.GetParent(child);
-            cv.MoveCurrentToPosition(-1);
+            if (parentObject == null) return null;
+            if (parentObject is T parent) return parent;
+            else return FindVisualParent<T>(parentObject);
         }
@@ -244,15 +382,55 @@
-    public class Person
+    public class DataGridBehavior : Behavior<DataGrid>
     {
+        public static readonly RoutedUICommand UnselectAll = new RoutedUICommand("選択解除", "UnselectAll", typeof(DataGridBehavior));
+        protected override void OnAttached()
+        {
+            base.OnAttached();
+            var commandBinding = new CommandBinding(UnselectAll, Executed);
+            AssociatedObject.CommandBindings.Add(commandBinding);
+        }
-        public string Name { get; set; }
+        protected override void OnDetaching()
+        {
+            base.OnDetaching();
+            AssociatedObject.CommandBindings.Clear();
+        }
+        private void Executed(object target, ExecutedRoutedEventArgs e)
+        {
+            if (AssociatedObject.SelectionUnit == DataGridSelectionUnit.FullRow)
-        public int Age { get; set; }
+                AssociatedObject.UnselectAll();
+            else
-        public bool AuthMember { get; set; }
+                AssociatedObject.UnselectAllCells();
+            e.Handled = true;
+        }
     }
@@ -262,72 +440,18 @@
-```C#
-// [wpf - DataGrid SelectionUnit=Cell disables all support for a selected row? - Stack Overflow](https://stackoverflow.com/questions/9489041/datagrid-selectionunit-cell-disables-all-support-for-a-selected-row)
-using System.Windows;
-using System.Windows.Controls;
-using System.Windows.Media;
-namespace Questions337191.Views
-{
-    public static class DataGridAttachedProperties
-    {
-        public static bool GetIsCellSelected(DependencyObject obj) => (bool)obj.GetValue(IsCellSelectedProperty);
-        public static void SetIsCellSelected(DependencyObject obj, bool value) => obj.SetValue(IsCellSelectedProperty, value);
-        public static readonly DependencyProperty IsCellSelectedProperty
-            = DependencyProperty.RegisterAttached("IsCellSelected", typeof(bool), typeof(DataGridAttachedProperties),
-                new UIPropertyMetadata(false, OnIsCellSelectedChanged));
-        private static void OnIsCellSelectedChanged(DependencyObject d, DependencyPropertyChangedEventArgs e)
-        {
-            if (d is DataGridCell cell)
-            {
-                var row = FindVisualParent<DataGridRow>(cell);
-                row.SetValue(IsCellSelectedProperty, e.NewValue);
-            }
-        }
-        private static T FindVisualParent<T>(DependencyObject child) where T : DependencyObject
-        {
-            var parentObject = VisualTreeHelper.GetParent(child);
-            if (parentObject == null) return null;
-            if (parentObject is T parent) return parent;
-            else return FindVisualParent<T>(parentObject);
-        }
-    }
-}
-```
+---
+あれこれいじっていたらいろいろバグを見つけてしまいました^^;
+* `DataGridAttachedProperties`複数選択時未考慮
+  回答コードを参照してください。
+* `Menu`や`ContextMenu`で`DataGrid`に`SelectAll`を使うと以降激重
+  `SelectAll`だけの（`Style`等をすべてなくして追加コードが一切ない）状態でも再現しますので、WPFのバグっぽいです（意味が分からな過ぎて原因も回避法もわかりません^^;