トップ Javaに関する質問画面遷移の課題、numPickerとEditTextbuttonの対応について

編集履歴

回答編集履歴

スコープとキャスト修正

2020/03/24 09:38

投稿

jimbe

スコア13355

answer CHANGED Viewed

@@ -35,7 +35,7 @@
 public class MainActivity extends AppCompatActivity {
   //ドラムロールの表示と同じ順にボタンの id を並べた配列を作る
-  final int[] buttons={
+  private static final int[] buttons={
           R.id.btn月1,R.id.btn月2,R.id.btn月3,R.id.btn月4,R.id.btn月5,R.id.btn月6,
           R.id.btn火1,R.id.btn火2,R.id.btn火3,R.id.btn火4,R.id.btn火5,R.id.btn火6,
           R.id.btn水1,R.id.btn水2,R.id.btn水3,R.id.btn水4,R.id.btn水5,R.id.btn水6,
@@ -61,7 +61,7 @@
       //結果のコードを取得＆ボタンのテクストに記入
       String txtName=data.getStringExtra("txtName");
       int numPicker=data.getIntExtra("numPicker", -1); //0-35
-      Button button=(Button)findViewById(buttons[numPicker]);
+      Button button=findViewById(buttons[numPicker]);
       button.setText(txtName);
     }
   }

コードやり直し

2020/03/24 09:38

投稿

jimbe

スコア13355

answer CHANGED Viewed

@@ -21,222 +21,222 @@
 NumberPicker は選択するだけで決定するインターフェースであり, 選択してボタンを押して決定すると言うものではありません.
 選択した時に呼ばれるリスナーがありますので, お調べになっては如何でしょうか.
-#追加
+#コードやり直し
+MainActivity.java
 ```java
-import android.os.*;
+package to.msn.wings.ourapp;
-class Lecture implements Parcelable {
-  static final String INTENT_NAME = "Lecture";
-  final String name;
-  final String room;
-  final int dayOfWeek; //0-5
-  final int time; //0-5
-  Lecture(int dayOfWeek, int time) {
-    this("","", dayOfWeek, time);
-  }
-  Lecture(String name, String room, int dayOfWeek, int time) {
-    this.name = name;
-    this.room = room;
-    this.dayOfWeek = dayOfWeek;
-    this.time = time;
-  }
-  @Override
-  public int describeContents() {
-    return 0;
-  }
-  @Override
-  public void writeToParcel(Parcel dest, int flags) {
-    dest.writeString(name);
-    dest.writeString(room);
-    dest.writeInt(dayOfWeek);
-    dest.writeInt(time);
-  }
-  public static final Creator<Lecture> CREATOR = new Creator<Lecture>() {
-    public Lecture createFromParcel(Parcel source) {
-      return new Lecture(source);
-    }
-    public Lecture[] newArray(int size) {
-      return new Lecture[size];
-    }
-  };
-  //Creator<Lecture> 用
-  private Lecture(Parcel source) {
-    name = source.readString();
-    room = source.readString();
-    dayOfWeek = source.readInt();
-    time = source.readInt();
-  }
-}
-```
-```java
 import androidx.appcompat.app.AppCompatActivity;
-import android.app.Activity;
+import android.os.Bundle;
 import android.content.Intent;
-import android.os.Bundle;
 import android.view.View;
-import android.widget.*;
+import android.widget.Button;
 public class MainActivity extends AppCompatActivity {
-  private static final String[] WEEKDAY_HEADER = {"月","火","水","木","金","土"};
+  //ドラムロールの表示と同じ順にボタンの id を並べた配列を作る
+  final int[] buttons={
-  private static final int TIME_COUNT = 6; //一日の最大講義数
+          R.id.btn月1,R.id.btn月2,R.id.btn月3,R.id.btn月4,R.id.btn月5,R.id.btn月6,
+          R.id.btn火1,R.id.btn火2,R.id.btn火3,R.id.btn火4,R.id.btn火5,R.id.btn火6,
+          R.id.btn水1,R.id.btn水2,R.id.btn水3,R.id.btn水4,R.id.btn水5,R.id.btn水6,
+          R.id.btn木1,R.id.btn木2,R.id.btn木3,R.id.btn木4,R.id.btn木5,R.id.btn木6,
+          R.id.btn金1,R.id.btn金2,R.id.btn金3,R.id.btn金4,R.id.btn金5,R.id.btn金6,
-  private Button[][] lectureSchedule;
+          R.id.btn土1,R.id.btn土2,R.id.btn土3,R.id.btn土4,R.id.btn土5,R.id.btn土6
+  };
   @Override
   protected void onCreate(Bundle savedInstanceState) {
     super.onCreate(savedInstanceState);
     setContentView(R.layout.activity_main);
-    Button scheduleSelectButton = findViewById(R.id.scheduleSelectButton);
-    scheduleSelectButton.setOnClickListener(new View.OnClickListener() {
-      @Override
-      public void onClick(View v) {
-        Intent intent = SubActivity2.createStartActivityIntent( MainActivity.this, WEEKDAY_HEADER, TIME_COUNT);
-        startActivityForResult(intent, 0);
-      }
-    });
-    lectureSchedule = initScheduleGrid(WEEKDAY_HEADER, TIME_COUNT);
   }
-  private Button[][] initScheduleGrid(String[] columnLabels, int rowCount) {
-    lectureSchedule = new Button[rowCount][columnLabels.length];
-    GridLayout grid = findViewById(R.id.grid);
-    grid.setColumnCount(1+columnLabels.length);
-    grid.setRowCount(1+rowCount);
-    //一行目(曜日)
-    Space space = new Space(this); //左上角
-    grid.addView(space, createLayoutParamsOfTimeLabel());
-    for(int j=0; j<columnLabels.length; j++) {
-      TextView textView = new TextView(this);
+  public void btn2_onClick(View view){
-      textView.setText(columnLabels[j]);
-      textView.setTextAlignment(View.TEXT_ALIGNMENT_CENTER);
+    Intent intent=new Intent(this, SubActivity2.class);
-      grid.addView(textView, createLayoutParamsOfWeekday());
-    }
-    //二行目以降(時間割)
+    //アクティビティを起動(サブ画面起動)
-    for(int i=0; i<rowCount; i++) {
-      TextView timeLabel = new TextView(this);
-      timeLabel.setText(""+(i+1));
-      grid.addView(timeLabel, createLayoutParamsOfTimeLabel());
-      for(int j=0; j<columnLabels.length; j++) {
-        Button button = new Button(this);
-        button.setText("");
+    startActivityForResult(intent,0);
-        button.setTag(new Lecture(j, i));
-        //button.setOnClickListener(clickListener);
-        grid.addView(button, createLayoutParamsOfWeekday());
-        lectureSchedule[i][j] = button;
-      }
-    }
-    return lectureSchedule;
   }
-  private GridLayout.LayoutParams createLayoutParamsOfTimeLabel() {
-    return createLayoutParams(GridLayout.LayoutParams.WRAP_CONTENT, 0, GridLayout.CENTER);
-  }
-  private GridLayout.LayoutParams createLayoutParamsOfWeekday() {
-    return createLayoutParams( 0, 1, GridLayout.FILL);
-  }
-  private GridLayout.LayoutParams createLayoutParams(int width, int columnSpecWeight, GridLayout.Alignment rowSpecAlignment) {
-    GridLayout.LayoutParams params = new GridLayout.LayoutParams();
-    params.width = width;
-    params.height = GridLayout.LayoutParams.WRAP_CONTENT;
-    params.columnSpec = GridLayout.spec(GridLayout.UNDEFINED, GridLayout.FILL, columnSpecWeight);
-    params.rowSpec = GridLayout.spec(GridLayout.UNDEFINED, rowSpecAlignment, 1);
-    return params;
-  }
   @Override
-  protected void onActivityResult(int requestCode, int resultCode, Intent data){
+  protected void onActivityResult(int requestCode,int resultCode,Intent data){
     super.onActivityResult(requestCode, resultCode, data);
     //リクエストコードと結果コードをチェック
-    if(requestCode == 0 && resultCode == Activity.RESULT_OK){
+    if(requestCode==0 && resultCode==RESULT_OK){
+      //結果のコードを取得＆ボタンのテクストに記入
-      Lecture lecture = data.getParcelableExtra(Lecture.INTENT_NAME);
+      String txtName=data.getStringExtra("txtName");
+      int numPicker=data.getIntExtra("numPicker", -1); //0-35
-      Button button = lectureSchedule[lecture.time][lecture.dayOfWeek];
+      Button button=(Button)findViewById(buttons[numPicker]);
-      button.setText(lecture.name);
+      button.setText(txtName);
-      button.setTag(lecture);
     }
   }
 }
 ```
+activity_main.xml
-```java
+```xml
+<?xml version="1.0" encoding="utf-8"?>
+<LinearLayout xmlns:android="http://schemas.android.com/apk/res/android"
+    xmlns:app="http://schemas.android.com/apk/res-auto"
-import androidx.appcompat.app.AppCompatActivity;
+    android:layout_width="match_parent"
+    android:layout_height="match_parent"
-import android.app.Activity;
+    android:orientation="vertical">
-import android.content.*;
-import android.os.Bundle;
-import android.text.*;
-import android.view.View;
-import android.widget.*;
+    <androidx.constraintlayout.widget.ConstraintLayout
+        android:layout_width="match_parent"
-public class SubActivity2 extends AppCompatActivity {
+        android:layout_height="wrap_content">
-  public static final String INTENT_EXTRA_WEEKDAY = "Weekday";
-  public static final String INTENT_EXTRA_TIMECOUNT = "TimeCount";
-  private String[] weekday;
-  @Override
+        <Button
+            android:id="@+id/btn2"
+            android:layout_width="wrap_content"
-  protected void onCreate(Bundle savedInstanceState){
+            android:layout_height="wrap_content"
-    super.onCreate(savedInstanceState);
+            android:layout_gravity="end"
+            android:layout_marginTop="8dp"
+            android:layout_marginEnd="8dp"
-    setContentView(R.layout.activity_sub2);
+            android:text="時間割選択"
+            app:layout_constraintEnd_toEndOf="parent"
+            app:layout_constraintTop_toTopOf="parent"
+            android:onClick="btn2_onClick"/>
+        <Button
+            android:id="@+id/btn1"
-    final EditText lectureName = findViewById(R.id.lectureName);
+            android:layout_width="wrap_content"
-    final EditText lectureRoom = findViewById(R.id.lectureRoom);
+            android:layout_height="wrap_content"
+            android:layout_gravity="top"
-    final NumberPicker timePicker = findViewById(R.id.timePicker);
+            android:layout_marginStart="8dp"
+            android:layout_marginTop="8dp"
+            android:text="写真選択"
-    final Button okButton = findViewById(R.id.okButton);
+            app:layout_constraintStart_toStartOf="parent"
+            app:layout_constraintTop_toTopOf="parent" />
+    </androidx.constraintlayout.widget.ConstraintLayout>
+    <LinearLayout
-    // name と room の入力状態によって ok の有効/無効を設定
+        android:layout_width="match_parent"
+        android:layout_height="50dp"
-    TextWatcher textWatcher = new TextWatcher() {
+        android:orientation="vertical">
-      @Override
-      public void beforeTextChanged(CharSequence s, int start, int count, int after) {}
-      @Override
-      public void onTextChanged(CharSequence s, int start, int before, int count) {
-        okButton.setEnabled(lectureName.length() > 0 && lectureRoom.length() > 0);
-      }
-      @Override
-      public void afterTextChanged(Editable s) {}
+    </LinearLayout>
-    };
+    <TableLayout
+        android:layout_width="match_parent"
-    lectureName.addTextChangedListener(textWatcher);
+        android:layout_height="match_parent"
-    lectureRoom.addTextChangedListener(textWatcher);
+        android:orientation="vertical"
+        android:shrinkColumns="0,1,2,3,4,5,6">
+        <TableRow
+            android:layout_width="match_parent"
+            android:layout_height="match_parent">
+            <Button
+                android:layout_width="wrap_content"
+                android:layout_height="wrap_content"/>
+            <Button
+                android:layout_width="wrap_content"
+                android:layout_height="wrap_content"
+                android:text="月"/>
+            <Button
+                android:layout_width="wrap_content"
+                android:layout_height="wrap_content"
+                android:text="火"/>
+            <Button
+                android:layout_width="wrap_content"
+                android:layout_height="wrap_content"
+                android:text="水"/>
+            <Button
+                android:layout_width="wrap_content"
+                android:layout_height="wrap_content"
+                android:text="木"/>
+            <Button
+                android:layout_width="wrap_content"
+                android:layout_height="wrap_content"
+                android:text="金"/>
+            <Button
+                android:layout_width="wrap_content"
+                android:layout_height="wrap_content"
+                android:text="土"/>
-    okButton.setEnabled(false);
+        </TableRow>
-    okButton.setOnClickListener(new View.OnClickListener() {
-      @Override
-      public void onClick(View v) {
-        String name = lectureName.getText().toString();
-        String room = lectureRoom.getText().toString();
-        int dayOfWeek = timePicker.getValue() / weekday.length;
-        int time = timePicker.getValue() % weekday.length;
+        <TableRow
+            android:layout_width="match_parent"
+            android:layout_height="match_parent">
+            <Button
-        Intent data = new Intent();
+                android:layout_width="wrap_content"
-        data.putExtra(Lecture.INTENT_NAME, new Lecture(name, room, dayOfWeek, time));
+                android:layout_height="wrap_content"
-        setResult(Activity.RESULT_OK, data);
+                android:text="1" />
-        finish();
+            <Button
-      }
+                android:id="@+id/btn月1"
+                android:layout_width="wrap_content"
+                android:layout_height="wrap_content" />
-    });
+            <Button
+                android:id="@+id/btn火1"
+                android:layout_width="wrap_content"
+                android:layout_height="wrap_content" />
+            <Button
+                android:id="@+id/btn水1"
+                android:layout_width="wrap_content"
+                android:layout_height="wrap_content" />
+            <Button
+                android:id="@+id/btn木1"
+                android:layout_width="wrap_content"
+                android:layout_height="wrap_content" />
+            <Button
+                android:id="@+id/btn金1"
+                android:layout_width="wrap_content"
+                android:layout_height="wrap_content" />
+            <Button
+                android:id="@+id/btn土1"
+                android:layout_width="wrap_content"
+                android:layout_height="wrap_content" />
+        </TableRow>
-    Intent data = getIntent(); //必須
+(以下5行, 時間ボタンの text と 曜日ボタンの id を変える他は同様)
-    if(data == null) throw new IllegalArgumentException("必要な intent データがありません");
+    </TableLayout>
+</LinearLayout>
+```
+SubActivity2.java
+```java
-    weekday = data.getStringArrayExtra(INTENT_EXTRA_WEEKDAY);
+package to.msn.wings.ourapp;
-    int timeCount = data.getIntExtra(INTENT_EXTRA_TIMECOUNT, 0);
+import android.content.Intent;
-    timePicker.setMinValue(0);
+import android.os.Bundle;
-    timePicker.setMaxValue(weekday.length*timeCount-1);
+import androidx.appcompat.app.AppCompatActivity;
-    timePicker.setDisplayedValues(createDisplayedValues(weekday, timeCount));
-    timePicker.setValue(0);
+import android.view.View;
-  }
+import android.widget.EditText;
+import android.widget.NumberPicker;
+public class SubActivity2 extends AppCompatActivity{
   //ドラムロールに表示したい値を含んだ配列を作る
-  private String[] createDisplayedValues(String[] weekday, int timeCount) {
+  private static final String[] pref={
-    String[] displayedValues = new String[weekday.length * timeCount];
+          "月1","月2","月3","月4","月5","月6",
-    for(int i=0, k=0; i<weekday.length; i++) {
+          "火1","火2","火3","火4","火5","火6",
+          "水1","水2","水3","水4","水5","水6",
+          "木1","木2","木3","木4","木5","木6",
+          "金1","金2","金3","金4","金5","金6",
-      for(int j=1; j<=timeCount; j++, k++) displayedValues[k] = weekday[i] + j;
+          "土1","土2","土3","土4","土5","土6"
-    }
+  };
+  @Override
+  protected void onCreate(Bundle savedInstanceState){
-    return displayedValues;
+    super.onCreate(savedInstanceState);
-  }
+    setContentView(R.layout.activity_sub2);
-  public static Intent createStartActivityIntent(Context packageContext, String[] weekday, int timeCount) {
+    //numberPickerをインスタンス化する
-    Intent intent = new Intent(packageContext, SubActivity2.class);
+    final NumberPicker picker=findViewById(R.id.numPicker0);
-    intent.putExtra(INTENT_EXTRA_WEEKDAY, weekday);
+    //配列のインデックスの最小、最大を指定する
-    intent.putExtra(INTENT_EXTRA_TIMECOUNT, timeCount);
-    return intent;
+    picker.setMinValue(0);
+    picker.setMaxValue(pref.length-1);
+    //numberpickerに配列をセットする
+    picker.setDisplayedValues(pref);
   }
+  //ボタンクリック時に呼び出されるメソッド
+  public void btn88_onClick(View v){
+    //インテントを生成＆データをセット
+    Intent i=new Intent();
+    //講義名
+    EditText txtName=findViewById(R.id.txtName);
+    i.putExtra("txtName",txtName.getText().toString());
+    //教室
+    EditText txtName2=findViewById(R.id.txtName2);
+    i.putExtra("txtName2",txtName2.getText().toString());
+    //numberPicker
+    NumberPicker numPicker=findViewById(R.id.numPicker0);
+    i.putExtra("numPicker",numPicker.getValue()); //0-35
+    //結果情報をセット
+    setResult(RESULT_OK,i);
+    //現在のアクティビティを終了
+    finish();
+  }
 }
 ```

コード修正

2020/03/24 09:26

投稿

jimbe

スコア13355

answer CHANGED Viewed

@@ -73,12 +73,12 @@
 import androidx.appcompat.app.AppCompatActivity;
 import android.app.Activity;
 import android.content.Intent;
-import android.os.*;
+import android.os.Bundle;
 import android.view.View;
 import android.widget.*;
 public class MainActivity extends AppCompatActivity {
-  private static final String[] WEEKRY_HEADER = {"月","火","水","木","金","土"};
+  private static final String[] WEEKDAY_HEADER = {"月","火","水","木","金","土"};
   private static final int TIME_COUNT = 6; //一日の最大講義数
   private Button[][] lectureSchedule;
@@ -91,62 +91,57 @@
     scheduleSelectButton.setOnClickListener(new View.OnClickListener() {
       @Override
       public void onClick(View v) {
-        Intent intent = SubActivity2.createStartActivityIntent( MainActivity.this, WEEKRY_HEADER, TIME_COUNT);
+        Intent intent = SubActivity2.createStartActivityIntent( MainActivity.this, WEEKDAY_HEADER, TIME_COUNT);
         startActivityForResult(intent, 0);
       }
     });
-    GridLayout grid = findViewById(R.id.grid);
-    lectureSchedule = initScheduleGrid(grid, WEEKRY_HEADER.length, TIME_COUNT);
+    lectureSchedule = initScheduleGrid(WEEKDAY_HEADER, TIME_COUNT);
   }
-  private Button[][] initScheduleGrid(GridLayout grid, int width, int height) {
+  private Button[][] initScheduleGrid(String[] columnLabels, int rowCount) {
-    grid.setColumnCount(1+width);
+    lectureSchedule = new Button[rowCount][columnLabels.length];
-    grid.setRowCount(1+height);
+    GridLayout grid = findViewById(R.id.grid);
-    lectureSchedule = new Button[height][width];
+    grid.setColumnCount(1+columnLabels.length);
+    grid.setRowCount(1+rowCount);
     //一行目(曜日)
-    Space space = new Space(this);
+    Space space = new Space(this); //左上角
-    grid.addView(space, createTimeLabelLayoutParams()); //左上角
+    grid.addView(space, createLayoutParamsOfTimeLabel());
-    for(int j=0; j<WEEKRY_HEADER.length; j++) {
+    for(int j=0; j<columnLabels.length; j++) {
       TextView textView = new TextView(this);
-      textView.setText(WEEKRY_HEADER[j]);
+      textView.setText(columnLabels[j]);
       textView.setTextAlignment(View.TEXT_ALIGNMENT_CENTER);
-      textView.setLayoutParams(createLayoutParams());
+      grid.addView(textView, createLayoutParamsOfWeekday());
-      grid.addView(textView);
     }
     //二行目以降(時間割)
-    for(int i=0; i<TIME_COUNT; i++) {
+    for(int i=0; i<rowCount; i++) {
       TextView timeLabel = new TextView(this);
       timeLabel.setText(""+(i+1));
-      timeLabel.setLayoutParams(createTimeLabelLayoutParams());
+      grid.addView(timeLabel, createLayoutParamsOfTimeLabel());
-      grid.addView(timeLabel);
-      for(int j=0; j<WEEKRY_HEADER.length; j++) {
+      for(int j=0; j<columnLabels.length; j++) {
         Button button = new Button(this);
         button.setText("");
         button.setTag(new Lecture(j, i));
-        button.setLayoutParams(createLayoutParams());
         //button.setOnClickListener(clickListener);
-        grid.addView(button);
+        grid.addView(button, createLayoutParamsOfWeekday());
         lectureSchedule[i][j] = button;
       }
     }
     return lectureSchedule;
   }
-  private GridLayout.LayoutParams createTimeLabelLayoutParams() {
+  private GridLayout.LayoutParams createLayoutParamsOfTimeLabel() {
-    GridLayout.LayoutParams params = new GridLayout.LayoutParams();
-    params.width = GridLayout.LayoutParams.WRAP_CONTENT;
-    params.height = GridLayout.LayoutParams.WRAP_CONTENT;
-    params.columnSpec = GridLayout.spec(GridLayout.UNDEFINED, GridLayout.FILL, 0);
-    params.rowSpec = GridLayout.spec(GridLayout.UNDEFINED, GridLayout.CENTER, 1);
+    return createLayoutParams(GridLayout.LayoutParams.WRAP_CONTENT, 0, GridLayout.CENTER);
-    return params;
   }
-  private GridLayout.LayoutParams createLayoutParams() {
+  private GridLayout.LayoutParams createLayoutParamsOfWeekday() {
+    return createLayoutParams( 0, 1, GridLayout.FILL);
+  }
+  private GridLayout.LayoutParams createLayoutParams(int width, int columnSpecWeight, GridLayout.Alignment rowSpecAlignment) {
     GridLayout.LayoutParams params = new GridLayout.LayoutParams();
-    params.width = 0;
+    params.width = width;
     params.height = GridLayout.LayoutParams.WRAP_CONTENT;
-    params.columnSpec = GridLayout.spec(GridLayout.UNDEFINED, GridLayout.FILL, 1);
+    params.columnSpec = GridLayout.spec(GridLayout.UNDEFINED, GridLayout.FILL, columnSpecWeight);
-    params.rowSpec = GridLayout.spec(GridLayout.UNDEFINED, GridLayout.FILL, 1);
+    params.rowSpec = GridLayout.spec(GridLayout.UNDEFINED, rowSpecAlignment, 1);
     return params;
   }
   @Override
@@ -172,9 +167,9 @@
 import android.widget.*;
 public class SubActivity2 extends AppCompatActivity {
-  public static final String INTENT_DAY_OF_WEEK_LABELS = "dayOfWeekLabels";
+  public static final String INTENT_EXTRA_WEEKDAY = "Weekday";
-  public static final String INTENT_TIME_COUNT = "TimeCount";
+  public static final String INTENT_EXTRA_TIMECOUNT = "TimeCount";
-  private String[] dayOfWeekLabels;
+  private String[] weekday;
   @Override
   protected void onCreate(Bundle savedInstanceState){
@@ -186,7 +181,7 @@
     final NumberPicker timePicker = findViewById(R.id.timePicker);
     final Button okButton = findViewById(R.id.okButton);
-    // name と room の入力状態によって regist の有効/無効を設定
+    // name と room の入力状態によって ok の有効/無効を設定
     TextWatcher textWatcher = new TextWatcher() {
       @Override
       public void beforeTextChanged(CharSequence s, int start, int count, int after) {}
@@ -207,8 +202,8 @@
       public void onClick(View v) {
         String name = lectureName.getText().toString();
         String room = lectureRoom.getText().toString();
-        int dayOfWeek = timePicker.getValue() / dayOfWeekLabels.length;
+        int dayOfWeek = timePicker.getValue() / weekday.length;
-        int time = timePicker.getValue() % dayOfWeekLabels.length;
+        int time = timePicker.getValue() % weekday.length;
         Intent data = new Intent();
         data.putExtra(Lecture.INTENT_NAME, new Lecture(name, room, dayOfWeek, time));
@@ -220,27 +215,27 @@
     Intent data = getIntent(); //必須
     if(data == null) throw new IllegalArgumentException("必要な intent データがありません");
-    dayOfWeekLabels = data.getStringArrayExtra(INTENT_DAY_OF_WEEK_LABELS);
+    weekday = data.getStringArrayExtra(INTENT_EXTRA_WEEKDAY);
-    int timeCount = data.getIntExtra(INTENT_TIME_COUNT, 0);
+    int timeCount = data.getIntExtra(INTENT_EXTRA_TIMECOUNT, 0);
     timePicker.setMinValue(0);
-    timePicker.setMaxValue(dayOfWeekLabels.length*timeCount-1);
+    timePicker.setMaxValue(weekday.length*timeCount-1);
-    timePicker.setDisplayedValues(createDisplayedValues(dayOfWeekLabels, timeCount));
+    timePicker.setDisplayedValues(createDisplayedValues(weekday, timeCount));
     timePicker.setValue(0);
   }
   //ドラムロールに表示したい値を含んだ配列を作る
-  private String[] createDisplayedValues(String[] dayOfWeekLabels, int timeCount) {
+  private String[] createDisplayedValues(String[] weekday, int timeCount) {
-    String[] displayedValues = new String[dayOfWeekLabels.length * timeCount];
+    String[] displayedValues = new String[weekday.length * timeCount];
-    for(int i=0, k=0; i<dayOfWeekLabels.length; i++) {
+    for(int i=0, k=0; i<weekday.length; i++) {
-      for(int j=1; j<=timeCount; j++, k++) displayedValues[k] = dayOfWeekLabels[i] + j;
+      for(int j=1; j<=timeCount; j++, k++) displayedValues[k] = weekday[i] + j;
     }
     return displayedValues;
   }
-  public static Intent createStartActivityIntent(Context packageContext, String[] dayOfWeekLabels, int timeCount) {
+  public static Intent createStartActivityIntent(Context packageContext, String[] weekday, int timeCount) {
     Intent intent = new Intent(packageContext, SubActivity2.class);
-    intent.putExtra(INTENT_DAY_OF_WEEK_LABELS, dayOfWeekLabels);
+    intent.putExtra(INTENT_EXTRA_WEEKDAY, weekday);
-    intent.putExtra(INTENT_TIME_COUNT, timeCount);
+    intent.putExtra(INTENT_EXTRA_TIMECOUNT, timeCount);
     return intent;
   }
 }

コード追加

2020/03/22 10:54

投稿

jimbe

スコア13355

answer CHANGED Viewed

@@ -23,108 +23,225 @@
 #追加
-activity_main.xml
-```xml
+```java
-<?xml version="1.0" encoding="utf-8"?>
-<androidx.constraintlayout.widget.ConstraintLayout
+import android.os.*;
- xmlns:android="http://schemas.android.com/apk/res/android"
- xmlns:app="http://schemas.android.com/apk/res-auto"
- xmlns:tools="http://schemas.android.com/tools"
- android:layout_width="match_parent"
- android:layout_height="match_parent"
- tools:context=".MainActivity">
+class Lecture implements Parcelable {
- <androidx.constraintlayout.widget.ConstraintLayout
-  android:id="@+id/header"
-  android:layout_width="match_parent"
-  android:layout_height="wrap_content"
-  android:layout_marginBottom="50dp"
-  app:layout_constraintTop_toTopOf="parent"
+  static final String INTENT_NAME = "Lecture";
-  app:layout_constraintLeft_toLeftOf="parent"
-  app:layout_constraintRight_toRightOf="parent">
-  <Button
-   android:id="@+id/photoSelectButton"
-   android:layout_width="wrap_content"
-   android:layout_height="wrap_content"
-   android:layout_margin="8dp"
+  final String name;
-   android:text="写真選択"
-   app:layout_constraintTop_toTopOf="parent"
-   app:layout_constraintLeft_toLeftOf="parent" />
-  <Button
-   android:id="@+id/scheduleSelectButton"
-   android:layout_width="wrap_content"
-   android:layout_height="wrap_content"
-   android:layout_margin="8dp"
-   android:text="時間割選択"
-   app:layout_constraintTop_toTopOf="parent"
-   app:layout_constraintRight_toRightOf="parent" />
- </androidx.constraintlayout.widget.ConstraintLayout>
- <GridLayout
+  final String room;
-  android:id="@+id/grid"
+  final int dayOfWeek; //0-5
-  android:layout_width="match_parent"
+  final int time; //0-5
+  Lecture(int dayOfWeek, int time) {
-  android:layout_height="wrap_content"
+    this("","", dayOfWeek, time);
-  app:layout_constraintTop_toBottomOf="@id/header"
-  app:layout_constraintLeft_toLeftOf="parent"
+  }
-  app:layout_constraintRight_toRightOf="parent"
+  Lecture(String name, String room, int dayOfWeek, int time) {
+    this.name = name;
+    this.room = room;
+    this.dayOfWeek = dayOfWeek;
+    this.time = time;
+  }
+  @Override
+  public int describeContents() {
+    return 0;
+  }
+  @Override
+  public void writeToParcel(Parcel dest, int flags) {
+    dest.writeString(name);
+    dest.writeString(room);
+    dest.writeInt(dayOfWeek);
+    dest.writeInt(time);
+  }
-  app:layout_constraintBottom_toBottomOf="parent" />
+  public static final Creator<Lecture> CREATOR = new Creator<Lecture>() {
+    public Lecture createFromParcel(Parcel source) {
+      return new Lecture(source);
+    }
+    public Lecture[] newArray(int size) {
+      return new Lecture[size];
+    }
+  };
-</androidx.constraintlayout.widget.ConstraintLayout>
+  //Creator<Lecture> 用
+  private Lecture(Parcel source) {
+    name = source.readString();
+    room = source.readString();
+    dayOfWeek = source.readInt();
+    time = source.readInt();
+  }
+}
 ```
-activity_sub2.xml
-```xml
+```java
-<?xml version="1.0" encoding="utf-8"?>
-<androidx.constraintlayout.widget.ConstraintLayout
+import androidx.appcompat.app.AppCompatActivity;
- xmlns:android="http://schemas.android.com/apk/res/android"
- xmlns:app="http://schemas.android.com/apk/res-auto"
+import android.app.Activity;
- android:layout_width="match_parent"
+import android.content.Intent;
+import android.os.*;
+import android.view.View;
- android:layout_height="match_parent">
+import android.widget.*;
- <EditText
-  android:id="@+id/lectureName"
-  android:layout_width="match_parent"
-  android:layout_height="wrap_content"
-  android:inputType="text"
-  android:hint="講義名を入力してください。"
-  app:layout_constraintTop_toTopOf="parent"
-  app:layout_constraintLeft_toLeftOf="parent"
-  app:layout_constraintRight_toRightOf="parent" />
- <EditText
-  android:id="@+id/lectureRoom"
-  android:layout_width="match_parent"
-  android:layout_height="wrap_content"
-  android:inputType="text"
-  android:hint="教室を入力してください。"
-  app:layout_constraintTop_toBottomOf="@id/lectureName"
-  app:layout_constraintLeft_toLeftOf="parent"
-  app:layout_constraintRight_toRightOf="parent" />
- <TextView
-  android:id="@+id/scheduleLabel"
-  android:layout_width="wrap_content"
-  android:layout_height="wrap_content"
-  android:layout_gravity="center"
-  android:layout_margin="30dp"
-  android:textStyle="bold"
-  android:text="@string/時間割"
-  android:textColor="#00f"
-  android:textSize="40sp"
-  app:layout_constraintTop_toBottomOf="@id/lectureRoom"
-  app:layout_constraintLeft_toLeftOf="parent"
-  app:layout_constraintRight_toRightOf="parent" />
- <NumberPicker
-  android:id="@+id/timePicker"
-  android:layout_width="wrap_content"
-  android:layout_height="wrap_content"
-  android:background="#aaf"
-  android:layout_margin="10dp"
-  app:layout_constraintTop_toBottomOf="@id/scheduleLabel"
-  app:layout_constraintLeft_toLeftOf="parent"
-  app:layout_constraintRight_toRightOf="parent" />
- <Button
-  android:id="@+id/okButton"
-  android:layout_width="match_parent"
-  android:layout_height="wrap_content"
-  android:layout_margin="40dp"
-  android:text="@string/ok"
-  app:layout_constraintTop_toBottomOf="@id/timePicker"
-  app:layout_constraintLeft_toLeftOf="parent"
-  app:layout_constraintRight_toRightOf="parent" />
-</androidx.constraintlayout.widget.ConstraintLayout>
+public class MainActivity extends AppCompatActivity {
+  private static final String[] WEEKRY_HEADER = {"月","火","水","木","金","土"};
+  private static final int TIME_COUNT = 6; //一日の最大講義数
+  private Button[][] lectureSchedule;
+  @Override
+  protected void onCreate(Bundle savedInstanceState) {
+    super.onCreate(savedInstanceState);
+    setContentView(R.layout.activity_main);
+    Button scheduleSelectButton = findViewById(R.id.scheduleSelectButton);
+    scheduleSelectButton.setOnClickListener(new View.OnClickListener() {
+      @Override
+      public void onClick(View v) {
+        Intent intent = SubActivity2.createStartActivityIntent( MainActivity.this, WEEKRY_HEADER, TIME_COUNT);
+        startActivityForResult(intent, 0);
+      }
+    });
+    GridLayout grid = findViewById(R.id.grid);
+    lectureSchedule = initScheduleGrid(grid, WEEKRY_HEADER.length, TIME_COUNT);
+  }
+  private Button[][] initScheduleGrid(GridLayout grid, int width, int height) {
+    grid.setColumnCount(1+width);
+    grid.setRowCount(1+height);
+    lectureSchedule = new Button[height][width];
+    //一行目(曜日)
+    Space space = new Space(this);
+    grid.addView(space, createTimeLabelLayoutParams()); //左上角
+    for(int j=0; j<WEEKRY_HEADER.length; j++) {
+      TextView textView = new TextView(this);
+      textView.setText(WEEKRY_HEADER[j]);
+      textView.setTextAlignment(View.TEXT_ALIGNMENT_CENTER);
+      textView.setLayoutParams(createLayoutParams());
+      grid.addView(textView);
+    }
+    //二行目以降(時間割)
+    for(int i=0; i<TIME_COUNT; i++) {
+      TextView timeLabel = new TextView(this);
+      timeLabel.setText(""+(i+1));
+      timeLabel.setLayoutParams(createTimeLabelLayoutParams());
+      grid.addView(timeLabel);
+      for(int j=0; j<WEEKRY_HEADER.length; j++) {
+        Button button = new Button(this);
+        button.setText("");
+        button.setTag(new Lecture(j, i));
+        button.setLayoutParams(createLayoutParams());
+        //button.setOnClickListener(clickListener);
+        grid.addView(button);
+        lectureSchedule[i][j] = button;
+      }
+    }
+    return lectureSchedule;
+  }
+  private GridLayout.LayoutParams createTimeLabelLayoutParams() {
+    GridLayout.LayoutParams params = new GridLayout.LayoutParams();
+    params.width = GridLayout.LayoutParams.WRAP_CONTENT;
+    params.height = GridLayout.LayoutParams.WRAP_CONTENT;
+    params.columnSpec = GridLayout.spec(GridLayout.UNDEFINED, GridLayout.FILL, 0);
+    params.rowSpec = GridLayout.spec(GridLayout.UNDEFINED, GridLayout.CENTER, 1);
+    return params;
+  }
+  private GridLayout.LayoutParams createLayoutParams() {
+    GridLayout.LayoutParams params = new GridLayout.LayoutParams();
+    params.width = 0;
+    params.height = GridLayout.LayoutParams.WRAP_CONTENT;
+    params.columnSpec = GridLayout.spec(GridLayout.UNDEFINED, GridLayout.FILL, 1);
+    params.rowSpec = GridLayout.spec(GridLayout.UNDEFINED, GridLayout.FILL, 1);
+    return params;
+  }
+  @Override
+  protected void onActivityResult(int requestCode, int resultCode, Intent data){
+    super.onActivityResult(requestCode, resultCode, data);
+    //リクエストコードと結果コードをチェック
+    if(requestCode == 0 && resultCode == Activity.RESULT_OK){
+      Lecture lecture = data.getParcelableExtra(Lecture.INTENT_NAME);
+      Button button = lectureSchedule[lecture.time][lecture.dayOfWeek];
+      button.setText(lecture.name);
+      button.setTag(lecture);
+    }
+  }
+}
+```
+```java
+import androidx.appcompat.app.AppCompatActivity;
+import android.app.Activity;
+import android.content.*;
+import android.os.Bundle;
+import android.text.*;
+import android.view.View;
+import android.widget.*;
+public class SubActivity2 extends AppCompatActivity {
+  public static final String INTENT_DAY_OF_WEEK_LABELS = "dayOfWeekLabels";
+  public static final String INTENT_TIME_COUNT = "TimeCount";
+  private String[] dayOfWeekLabels;
+  @Override
+  protected void onCreate(Bundle savedInstanceState){
+    super.onCreate(savedInstanceState);
+    setContentView(R.layout.activity_sub2);
+    final EditText lectureName = findViewById(R.id.lectureName);
+    final EditText lectureRoom = findViewById(R.id.lectureRoom);
+    final NumberPicker timePicker = findViewById(R.id.timePicker);
+    final Button okButton = findViewById(R.id.okButton);
+    // name と room の入力状態によって regist の有効/無効を設定
+    TextWatcher textWatcher = new TextWatcher() {
+      @Override
+      public void beforeTextChanged(CharSequence s, int start, int count, int after) {}
+      @Override
+      public void onTextChanged(CharSequence s, int start, int before, int count) {
+        okButton.setEnabled(lectureName.length() > 0 && lectureRoom.length() > 0);
+      }
+      @Override
+      public void afterTextChanged(Editable s) {}
+    };
+    lectureName.addTextChangedListener(textWatcher);
+    lectureRoom.addTextChangedListener(textWatcher);
+    okButton.setEnabled(false);
+    okButton.setOnClickListener(new View.OnClickListener() {
+      @Override
+      public void onClick(View v) {
+        String name = lectureName.getText().toString();
+        String room = lectureRoom.getText().toString();
+        int dayOfWeek = timePicker.getValue() / dayOfWeekLabels.length;
+        int time = timePicker.getValue() % dayOfWeekLabels.length;
+        Intent data = new Intent();
+        data.putExtra(Lecture.INTENT_NAME, new Lecture(name, room, dayOfWeek, time));
+        setResult(Activity.RESULT_OK, data);
+        finish();
+      }
+    });
+    Intent data = getIntent(); //必須
+    if(data == null) throw new IllegalArgumentException("必要な intent データがありません");
+    dayOfWeekLabels = data.getStringArrayExtra(INTENT_DAY_OF_WEEK_LABELS);
+    int timeCount = data.getIntExtra(INTENT_TIME_COUNT, 0);
+    timePicker.setMinValue(0);
+    timePicker.setMaxValue(dayOfWeekLabels.length*timeCount-1);
+    timePicker.setDisplayedValues(createDisplayedValues(dayOfWeekLabels, timeCount));
+    timePicker.setValue(0);
+  }
+  //ドラムロールに表示したい値を含んだ配列を作る
+  private String[] createDisplayedValues(String[] dayOfWeekLabels, int timeCount) {
+    String[] displayedValues = new String[dayOfWeekLabels.length * timeCount];
+    for(int i=0, k=0; i<dayOfWeekLabels.length; i++) {
+      for(int j=1; j<=timeCount; j++, k++) displayedValues[k] = dayOfWeekLabels[i] + j;
+    }
+    return displayedValues;
+  }
+  public static Intent createStartActivityIntent(Context packageContext, String[] dayOfWeekLabels, int timeCount) {
+    Intent intent = new Intent(packageContext, SubActivity2.class);
+    intent.putExtra(INTENT_DAY_OF_WEEK_LABELS, dayOfWeekLabels);
+    intent.putExtra(INTENT_TIME_COUNT, timeCount);
+    return intent;
+  }
+}
 ```

xml 追加

2020/03/22 09:08

投稿

jimbe

スコア13355

answer CHANGED Viewed

@@ -19,4 +19,112 @@
 setOnClickListener で行っている処理も無駄に意味不明です.
 NumberPicker は選択するだけで決定するインターフェースであり, 選択してボタンを押して決定すると言うものではありません.
-選択した時に呼ばれるリスナーがありますので, お調べになっては如何でしょうか.
+選択した時に呼ばれるリスナーがありますので, お調べになっては如何でしょうか.
+#追加
+activity_main.xml
+```xml
+<?xml version="1.0" encoding="utf-8"?>
+<androidx.constraintlayout.widget.ConstraintLayout
+ xmlns:android="http://schemas.android.com/apk/res/android"
+ xmlns:app="http://schemas.android.com/apk/res-auto"
+ xmlns:tools="http://schemas.android.com/tools"
+ android:layout_width="match_parent"
+ android:layout_height="match_parent"
+ tools:context=".MainActivity">
+ <androidx.constraintlayout.widget.ConstraintLayout
+  android:id="@+id/header"
+  android:layout_width="match_parent"
+  android:layout_height="wrap_content"
+  android:layout_marginBottom="50dp"
+  app:layout_constraintTop_toTopOf="parent"
+  app:layout_constraintLeft_toLeftOf="parent"
+  app:layout_constraintRight_toRightOf="parent">
+  <Button
+   android:id="@+id/photoSelectButton"
+   android:layout_width="wrap_content"
+   android:layout_height="wrap_content"
+   android:layout_margin="8dp"
+   android:text="写真選択"
+   app:layout_constraintTop_toTopOf="parent"
+   app:layout_constraintLeft_toLeftOf="parent" />
+  <Button
+   android:id="@+id/scheduleSelectButton"
+   android:layout_width="wrap_content"
+   android:layout_height="wrap_content"
+   android:layout_margin="8dp"
+   android:text="時間割選択"
+   app:layout_constraintTop_toTopOf="parent"
+   app:layout_constraintRight_toRightOf="parent" />
+ </androidx.constraintlayout.widget.ConstraintLayout>
+ <GridLayout
+  android:id="@+id/grid"
+  android:layout_width="match_parent"
+  android:layout_height="wrap_content"
+  app:layout_constraintTop_toBottomOf="@id/header"
+  app:layout_constraintLeft_toLeftOf="parent"
+  app:layout_constraintRight_toRightOf="parent"
+  app:layout_constraintBottom_toBottomOf="parent" />
+</androidx.constraintlayout.widget.ConstraintLayout>
+```
+activity_sub2.xml
+```xml
+<?xml version="1.0" encoding="utf-8"?>
+<androidx.constraintlayout.widget.ConstraintLayout
+ xmlns:android="http://schemas.android.com/apk/res/android"
+ xmlns:app="http://schemas.android.com/apk/res-auto"
+ android:layout_width="match_parent"
+ android:layout_height="match_parent">
+ <EditText
+  android:id="@+id/lectureName"
+  android:layout_width="match_parent"
+  android:layout_height="wrap_content"
+  android:inputType="text"
+  android:hint="講義名を入力してください。"
+  app:layout_constraintTop_toTopOf="parent"
+  app:layout_constraintLeft_toLeftOf="parent"
+  app:layout_constraintRight_toRightOf="parent" />
+ <EditText
+  android:id="@+id/lectureRoom"
+  android:layout_width="match_parent"
+  android:layout_height="wrap_content"
+  android:inputType="text"
+  android:hint="教室を入力してください。"
+  app:layout_constraintTop_toBottomOf="@id/lectureName"
+  app:layout_constraintLeft_toLeftOf="parent"
+  app:layout_constraintRight_toRightOf="parent" />
+ <TextView
+  android:id="@+id/scheduleLabel"
+  android:layout_width="wrap_content"
+  android:layout_height="wrap_content"
+  android:layout_gravity="center"
+  android:layout_margin="30dp"
+  android:textStyle="bold"
+  android:text="@string/時間割"
+  android:textColor="#00f"
+  android:textSize="40sp"
+  app:layout_constraintTop_toBottomOf="@id/lectureRoom"
+  app:layout_constraintLeft_toLeftOf="parent"
+  app:layout_constraintRight_toRightOf="parent" />
+ <NumberPicker
+  android:id="@+id/timePicker"
+  android:layout_width="wrap_content"
+  android:layout_height="wrap_content"
+  android:background="#aaf"
+  android:layout_margin="10dp"
+  app:layout_constraintTop_toBottomOf="@id/scheduleLabel"
+  app:layout_constraintLeft_toLeftOf="parent"
+  app:layout_constraintRight_toRightOf="parent" />
+ <Button
+  android:id="@+id/okButton"
+  android:layout_width="match_parent"
+  android:layout_height="wrap_content"
+  android:layout_margin="40dp"
+  android:text="@string/ok"
+  app:layout_constraintTop_toBottomOf="@id/timePicker"
+  app:layout_constraintLeft_toLeftOf="parent"
+  app:layout_constraintRight_toRightOf="parent" />
+</androidx.constraintlayout.widget.ConstraintLayout>
+```

button88 部分修正

2020/03/22 09:06

投稿

jimbe

スコア13355

answer CHANGED Viewed

@@ -14,8 +14,8 @@
 2つ目は3つ目の一部分のことのようですし, 3つ目はボタンがどうなっているかに因りますので, 全体のレイアウトのご提示が必要です.
-また, 現状のコードではボタンを押しても SubActivity2 から MainActivity には戻りません.
+また, id="@+id/button88" のボタンに onClick="btn88_onClick" していた場合, 現状のコードではボタンを押しても SubActivity2 から MainActivity には戻りません.
-xml で onClick を指定しているボタンに対して setOnClickListener で別の処理を設定しているため, xml の設定は上書きされています.
+ setOnClickListener で別の処理を設定しているため, xml の設定は上書きされ, btn88_onClick は呼ばれません.
 setOnClickListener で行っている処理も無駄に意味不明です.
 NumberPicker は選択するだけで決定するインターフェースであり, 選択してボタンを押して決定すると言うものではありません.

修正

2020/03/21 09:14

投稿

jimbe

スコア13355

answer CHANGED Viewed

@@ -14,7 +14,7 @@
 2つ目は3つ目の一部分のことのようですし, 3つ目はボタンがどうなっているかに因りますので, 全体のレイアウトのご提示が必要です.
-また, 現状のコードではボタンを押しても SubActivity から MainActivity には戻りません.
+また, 現状のコードではボタンを押しても SubActivity2 から MainActivity には戻りません.
 xml で onClick を指定しているボタンに対して setOnClickListener で別の処理を設定しているため, xml の設定は上書きされています.
 setOnClickListener で行っている処理も無駄に意味不明です.

追記

2020/03/21 07:33

投稿

jimbe

スコア13355

answer CHANGED Viewed

@@ -12,4 +12,11 @@
 の "36" です.
 pref 配列の"要素数"は 6x6=36 ですが, MinValue(0) と "0" 始まりですので, MaxValue は "35" でなければなりません.
-2つ目は3つ目の一部分のことのようですし, 3つ目はボタンがどうなっているかに因りますので, 全体のレイアウトのご提示が必要です.
+2つ目は3つ目の一部分のことのようですし, 3つ目はボタンがどうなっているかに因りますので, 全体のレイアウトのご提示が必要です.
+また, 現状のコードではボタンを押しても SubActivity から MainActivity には戻りません.
+xml で onClick を指定しているボタンに対して setOnClickListener で別の処理を設定しているため, xml の設定は上書きされています.
+setOnClickListener で行っている処理も無駄に意味不明です.
+NumberPicker は選択するだけで決定するインターフェースであり, 選択してボタンを押して決定すると言うものではありません.
+選択した時に呼ばれるリスナーがありますので, お調べになっては如何でしょうか.

追記

2020/03/21 07:31

投稿

jimbe

スコア13355

answer CHANGED Viewed

@@ -10,4 +10,6 @@
 picker.setMaxValue(36);
 ```
 の "36" です.
-pref 配列の"要素数"は 6x6=36 ですが, MinValue(0) と "0" 始まりですので, MaxValue は "35" でなければなりません.
+pref 配列の"要素数"は 6x6=36 ですが, MinValue(0) と "0" 始まりですので, MaxValue は "35" でなければなりません.
+2つ目は3つ目の一部分のことのようですし, 3つ目はボタンがどうなっているかに因りますので, 全体のレイアウトのご提示が必要です.