編集履歴

回答編集履歴

またコメント修正忘れ

2020/03/16 14:06

投稿

スコア13209

test CHANGED Viewed

@@ -60,7 +60,7 @@
  * chars の各文字を循環出力する.
- * next() で次の文字に移動し, 最後の文字の後は先頭の文字に戻る.
+ * countUp() で次の文字に移動し, 最後の文字の後は先頭の文字に戻る.
  * この時, 登録されていれば CarryOverListener#carryOver() を呼び出す.

出力方法を変更

2020/03/16 14:06

投稿

jimbe

スコア13209

test CHANGED Viewed

@@ -28,9 +28,17 @@
       StringCounter stringCounter = new StringCounter(moto, charsRow);
-      stringCounter.outputAllPatternTo(System.out); //表示
-      stringCounter.outputAllPatternTo("ShinIrekae.txt"); //ファイル
+      try (PrintStream out = new PrintStream("ShinIrekae.txt");) {
+        do {
+          System.out.println(stringCounter);
+          out.println(stringCounter);
+        } while(stringCounter.countUp());
+      }
     }
@@ -38,12 +46,16 @@
 }
 interface CarryOverListener {
   void carryOver();
 }
 /**
  * chars の各文字を循環出力する.
@@ -70,7 +82,7 @@
   }
-  void next() {
+  void countUp() {
     if(++index >= chars.length) {
@@ -86,10 +98,12 @@
   @Override
-  public void carryOver() { next(); }
+  public void carryOver() { countUp(); }
 }
 class StringCounter implements CarryOverListener {
   private List<CharCounter> ccList;
@@ -114,104 +128,112 @@
   }
+  /**
+   * 最下位桁をカウントアップ
+   * @return 処理後も有効値なら true (最上位桁でキャリーオーバーが発生したら false)
+   */
+  boolean countUp() {
-  void outputAllPatternTo(String filename) throws IOException {
+    if(!carry) ccList.get(ccList.size()-1).countUp();
+    return !carry;
+  }
+  boolean isCarryOver() { return carry; }
+  @Override
+  public void carryOver() { carry = true; }
+  @Override
+  public String toString() {
-    try (PrintStream out = new PrintStream(filename);) {
+    StringBuilder sb = new StringBuilder();
+    for(CharCounter cc : ccList) sb.append(cc.get());
-      outputAllPatternTo(out);
+    return sb.toString();
+  }
+}
+class CharsRow {
+  private static String[] ROWS = {
+    "あぁかがさざただなはばぱまやゃらわ",
+    "いぃきぎしじちぢにひびぴみりゐ",
+    "うぅくぐすずつづぬふぶぷむゆゅる",
+    "えぇけげせぜてでねへべぺめれゑ",
+    "おぉこごそぞとどのほぼぽもよょろ",
+  };
+  private Map<Character,char[]> cache = new HashMap<>();
+  void check(String moto) {
+    for(char c : moto.toCharArray()){
+      char[] r = get(c);
+      System.out.println(c + "は、" + r[0] + (r.length>=2?"段にあります":"です"));
     }
   }
+  char[] get(char c) {
+    for(String r : ROWS) {
+      if(r.indexOf(c) >= 0) {
-  void outputAllPatternTo(PrintStream out) {
+        char[] a = cache.get(r.charAt(0));
-    carry = false;
+        if(a == null) {
-    for (CharCounter last=ccList.get(ccList.size()-1); !carry; last.next()) {
+          a = r.toCharArray();
-      for(CharCounter cc : ccList) out.print(cc.get());
+          cache.put(r.charAt(0), a);
+        }
-      out.println();
+        return a;
+      }
     }
+    char[] a = cache.get(c);
+    if(a == null) {
+      a = new char[]{c};
+      cache.put(c, a);
+    }
+    return a;
   }
-  @Override
-  public void carryOver() { carry = true; }
 }
-class CharsRow {
-  private static String[] ROWS = {
-    "あぁかがさざただなはばぱまやゃらわ",
-    "いぃきぎしじちぢにひびぴみりゐ",
-    "うぅくぐすずつづぬふぶぷむゆゅる",
-    "えぇけげせぜてでねへべぺめれゑ",
-    "おぉこごそぞとどのほぼぽもよょろ",
-  };
-  private Map<Character,char[]> cache = new HashMap<>();
-  void check(String moto) {
-    for(char c : moto.toCharArray()){
-      char[] r = get(c);
-      System.out.println(c + "は、" + r[0] + (r.length>=2?"段にあります":"です"));
-    }
-  }
-  char[] get(char c) {
-    for(String r : ROWS) {
-      if(r.indexOf(c) >= 0) {
-        char[] a = cache.get(r.charAt(0));
-        if(a == null) {
-          a = r.toCharArray();
-          cache.put(r.charAt(0), a);
-        }
-        return a;
-      }
-    }
-    char[] a = cache.get(c);
-    if(a == null) {
-      a = new char[]{c};
-      cache.put(c, a);
-    }
-    return a;
-  }
-}
 ```
 ```plain text

バグ修正

2020/03/16 13:56

投稿

jimbe

スコア13209

test CHANGED Viewed

@@ -126,6 +126,8 @@
   void outputAllPatternTo(PrintStream out) {
+    carry = false;
     for (CharCounter last=ccList.get(ccList.size()-1); !carry; last.next()) {
       for(CharCounter cc : ccList) out.print(cc.get());

コード内コメント直し忘れ

2020/03/16 13:37

投稿

jimbe

スコア13209

test CHANGED Viewed

@@ -46,7 +46,7 @@
 /**
- * source の各文字を循環出力する.
+ * chars の各文字を循環出力する.
  * next() で次の文字に移動し, 最後の文字の後は先頭の文字に戻る.

コード改良

2020/03/16 13:33

投稿

jimbe

スコア13209

test CHANGED Viewed

@@ -26,7 +26,7 @@
-      StringCounter stringCounter = new StringCounter(moto);
+      StringCounter stringCounter = new StringCounter(moto, charsRow);
       stringCounter.outputAllPatternTo(System.out); //表示
@@ -96,12 +96,10 @@
   private boolean carry;
-  StringCounter(String moto) {
+  StringCounter(String moto, CharsRow charsRow) {
     ccList = new ArrayList<>();
-    CharsRow charsRow = new CharsRow();
     CarryOverListener prev = this;
     for(char c : moto.toCharArray()){

クラス分け

2020/03/16 13:06

投稿

jimbe

スコア13209

test CHANGED Viewed

@@ -20,180 +20,198 @@
+      CharsRow charsRow = new CharsRow();
-      hikaku(moto);
+      charsRow.check(moto);
-      mk(moto);
+      StringCounter stringCounter = new StringCounter(moto);
+      stringCounter.outputAllPatternTo(System.out); //表示
+      stringCounter.outputAllPatternTo("ShinIrekae.txt"); //ファイル
     }
   }
+}
+interface CarryOverListener {
+  void carryOver();
+}
+/**
+ * source の各文字を循環出力する.
+ * next() で次の文字に移動し, 最後の文字の後は先頭の文字に戻る.
+ * この時, 登録されていれば CarryOverListener#carryOver() を呼び出す.
+ */
+class CharCounter implements CarryOverListener {
+  private CarryOverListener listener;
+  private char[] chars;
+  private int index;
+  CharCounter(char[] chars, CarryOverListener listener) {
+    this.chars = chars;
+    this.listener = listener;
+  }
+  void next() {
+    if(++index >= chars.length) {
+      index = 0;
+      if(listener != null) listener.carryOver();
+    }
+  }
+  char get() { return chars[index]; }
+  @Override
+  public void carryOver() { next(); }
+}
+class StringCounter implements CarryOverListener {
+  private List<CharCounter> ccList;
+  private boolean carry;
-  private static void hikaku(String moto){
+  StringCounter(String moto) {
+    ccList = new ArrayList<>();
+    CharsRow charsRow = new CharsRow();
+    CarryOverListener prev = this;
     for(char c : moto.toCharArray()){
+      CharCounter cc = new CharCounter(charsRow.get(c), prev);
+      ccList.add(cc);
+      prev = cc;
+    }
+  }
+  void outputAllPatternTo(String filename) throws IOException {
+    try (PrintStream out = new PrintStream(filename);) {
+      outputAllPatternTo(out);
+    }
+  }
+  void outputAllPatternTo(PrintStream out) {
+    for (CharCounter last=ccList.get(ccList.size()-1); !carry; last.next()) {
+      for(CharCounter cc : ccList) out.print(cc.get());
+      out.println();
+    }
+  }
+  @Override
+  public void carryOver() { carry = true; }
+}
+class CharsRow {
+  private static String[] ROWS = {
+    "あぁかがさざただなはばぱまやゃらわ",
+    "いぃきぎしじちぢにひびぴみりゐ",
+    "うぅくぐすずつづぬふぶぷむゆゅる",
+    "えぇけげせぜてでねへべぺめれゑ",
+    "おぉこごそぞとどのほぼぽもよょろ",
+  };
+  private Map<Character,char[]> cache = new HashMap<>();
+  void check(String moto) {
+    for(char c : moto.toCharArray()){
-      String r = getCharsRow(c);
+      char[] r = get(c);
-      if(r != null) {
-        System.out.println(c + "は、" + r.charAt(0) + (r.length()>=2?"段にあります":"です"));
+      System.out.println(c + "は、" + r[0] + (r.length>=2?"段にあります":"です"));
+    }
+  }
+  char[] get(char c) {
+    for(String r : ROWS) {
+      if(r.indexOf(c) >= 0) {
+        char[] a = cache.get(r.charAt(0));
+        if(a == null) {
+          a = r.toCharArray();
+          cache.put(r.charAt(0), a);
+        }
+        return a;
       }
     }
+    char[] a = cache.get(c);
+    if(a == null) {
+      a = new char[]{c};
+      cache.put(c, a);
+    }
+    return a;
   }
-  private static void mk(String moto) throws IOException {
-    List<CharCounter> ccList = new ArrayList<>();
-    CarryFlag carryFlag = new CarryFlag();
-    CarryOverListener prev = carryFlag;
-    for(char c : moto.toCharArray()){
-      String r = getCharsRow(c);
-      CharCounter cc = new CharCounter(r!=null?r:""+c, prev);
-      ccList.add(cc);
-      prev = cc;
-    }
-    try (BufferedWriter bw = new BufferedWriter(new FileWriter("ShinIrekae.txt"));) {
-      StringBuilder sb = new StringBuilder();
-      for (CharCounter last = ccList.get(ccList.size()-1); !carryFlag.isOn(); last.next()) {
-        sb.delete(0, sb.length());
-        for(CharCounter cc : ccList) sb.append(cc.get());
-        System.out.println(sb.toString());
-        bw.write(sb.toString());
-        bw.newLine();
-      }
-    }
-  }
-  private static String getCharsRow(char c) {
-    for(String r : ROWS) {
-      if(r.indexOf(c) >= 0) return r;
-    }
-    return null;
-  }
-  private static String A = "あぁかがさざただなはばぱまやゃらわ";
-  private static String I = "いぃきぎしじちぢにひびぴみりゐ";
-  private static String U = "うぅくぐすずつづぬふぶぷむゆゅる";
-  private static String E = "えぇけげせぜてでねへべぺめれゑ";
-  private static String O = "おぉこごそぞとどのほぼぽもよょろ";
-  private static String N = "ん";
-  private static String[] ROWS = {A,I,U,E,O,N};
 }
-interface CarryOverListener {
-  void carryOver();
-}
-class CarryFlag implements CarryOverListener {
-  private boolean flag = false;
-  @Override
-  public void carryOver() {
-    flag = true;
-  }
-  boolean isOn() { return flag; }
-}
-/**
- * source の各文字を循環出力する.
- * next() で次の文字に移動し, 最後の文字の後は先頭の文字に戻る.
- * この時, 登録されていれば CarryOverListener#carryOver() を呼び出す.
- */
-class CharCounter implements CarryOverListener {
-  private CarryOverListener listener;
-  private char[] chars;
-  private int index;
-  CharCounter(String source, CarryOverListener l) {
-    this.chars = source.toCharArray();
-    this.listener = l;
-    index = 0;
-  }
-  void next() {
-    if(++index >= chars.length) {
-      index = 0;
-      if(listener != null) listener.carryOver();
-    }
-  }
-  char get() { return chars[index]; }
-  @Override
-  public void carryOver() { next(); }
-}
 ```
 ```plain text

getCharsRow 追加

2020/03/16 12:40

投稿

jimbe

スコア13209

test CHANGED Viewed

@@ -32,19 +32,13 @@
   private static void hikaku(String moto){
-    final String[] rows = {A,I,U,E,O,N};
     for(char c : moto.toCharArray()){
-      for(String r : rows) {
+      String r = getCharsRow(c);
-        if(r.indexOf(c) >= 0) {
+      if(r != null) {
-          System.out.println(c + "は、" + r.charAt(0) + (r.length()>=2?"段にあります":"です"));
+        System.out.println(c + "は、" + r.charAt(0) + (r.length()>=2?"段にあります":"です"));
-          continue;
-        }
       }
@@ -62,54 +56,54 @@
     CarryOverListener prev = carryFlag;
-    String[] rows = {A,I,U,E,O};
     for(char c : moto.toCharArray()){
-      CharCounter cc = null;
-      for(String r : rows) {
+      String r = getCharsRow(c);
-        if(r.indexOf(c) >= 0) {
-          cc = new CharCounter(r, prev);
+      CharCounter cc = new CharCounter(r!=null?r:""+c, prev);
+      ccList.add(cc);
-          break;
+      prev = cc;
-        }
+    }
+    try (BufferedWriter bw = new BufferedWriter(new FileWriter("ShinIrekae.txt"));) {
+      StringBuilder sb = new StringBuilder();
+      for (CharCounter last = ccList.get(ccList.size()-1); !carryFlag.isOn(); last.next()) {
+        sb.delete(0, sb.length());
+        for(CharCounter cc : ccList) sb.append(cc.get());
+        System.out.println(sb.toString());
+        bw.write(sb.toString());
+        bw.newLine();
       }
-      if(cc == null) cc = new CharCounter(""+c, prev);
-      ccList.add(cc);
-      prev = cc;
     }
-    try (BufferedWriter bw = new BufferedWriter(new FileWriter("ShinIrekae.txt"));) {
-      StringBuilder sb = new StringBuilder();
-      for (CharCounter last = ccList.get(ccList.size()-1); !carryFlag.isOn(); last.next()) {
-        sb.delete(0, sb.length());
-        for(CharCounter cc : ccList) sb.append(cc.get());
-        System.out.println(sb.toString());
-        bw.write(sb.toString());
-        bw.newLine();
-      }
+  }
+  private static String getCharsRow(char c) {
+    for(String r : ROWS) {
+      if(r.indexOf(c) >= 0) return r;
     }
+    return null;
   }
@@ -126,6 +120,8 @@
   private static String N = "ん";
+  private static String[] ROWS = {A,I,U,E,O,N};
 }
 interface CarryOverListener {