編集履歴

回答編集履歴

pygame連携について追記

2020/02/16 09:54

投稿

スコア5406

test CHANGED Viewed

@@ -235,3 +235,133 @@
     main()
 ```
+pygameとの連携がうまく動かないということなら、以下のような単純化した処理に置き換えて動作核にしてみてはいかがですか？
+```py
+import os
+import sys
+import time
+import threading
+import pygame
+from pygame.locals import *
+os.environ['PYGAME_HIDE_SUPPORT_PROMPT'] = 'hide'
+import tkinter as tk
+from tkinter import font, IntVar
+class Game:
+    def __init__(self, title):
+        self.title = title
+    def run(self):
+        self.running = True
+        while self.running:
+            time.sleep(1)
+    def push_switch(self, number):
+        print("push_switch:", repr(number))
+    def quit(self):
+        self.running = False
+def main():
+    game = Game('Contoller input')
+    thread = threading.Thread(target=game.run)
+    thread.start()
+    pygame.joystick.init()
+    pygame.init()
+    try:
+        j = pygame.joystick.Joystick(0) # create a joystick instance
+        j.init() # init instance
+        print(j.get_name())
+    except pygame.error:
+        print('Joystickが見つかりませんでした。')
+        game.quit()
+    for e in pygame.event.get():
+        print(e)
+        if(e.type == pygame.locals.JOYBUTTONDOWN or e.type == pygame.locals.JOYAXISMOTION or e.type == QUIT):
+            if(e.type == QUIT):
+                print("quit")
+                game.quit()
+                thread.join()
+            if(e.type == pygame.locals.JOYBUTTONDOWN):
+                print("button " + str(e.button))
+                if(e.button < 7):
+                    game.push_switch(e.button)
+            elif(e.type == pygame.locals.JOYAXISMOTION):
+                print("turntable spin")
+                game.push_switch(7)
+if __name__ == '__main__':
+    main()
+```

スイッチ番号変更

2020/02/16 09:54

投稿

shiracamus

スコア5406

test CHANGED Viewed

@@ -110,15 +110,33 @@
         self.running = True
-        self.window = window = tk.Tk()
+        self.window = tk.Tk()
-        window.title(self.title)
+        self.window.title(self.title)
-        window.geometry('640x360')
+        self.window.geometry('640x360')
+        self.switches = self._make_switches()
+        self.window.after(1000, self._check_to_quit)
+        self.window.mainloop()
+        # need to delete variables that reference tkinter objects in the thread
+        del self.switches
+        del self.window
+    def _make_switches(self):
-        canvas = tk.Canvas(window, width=640, height=360)
+        canvas = tk.Canvas(self.window, width=640, height=360)
         canvas.place(x=0, y=0)
@@ -140,49 +158,39 @@
         for i, key in enumerate(white_keys):
-            label = tk.Label(window, font=font1, textvariable=key.count)
+            label = tk.Label(self.window, font=font1, textvariable=key.count)
             label.place(x=310 + 90 * i, y=333)
         for i, key in enumerate(black_keys):
-            label = tk.Label(window, font=font1, textvariable=key.count)
+            label = tk.Label(self.window, font=font1, textvariable=key.count)
             label.place(x=355 + 90 * i, y=5)
-        label = tk.Label(window, font=font1, textvariable=disk.count)
+        label = tk.Label(self.window, font=font1, textvariable=disk.count)
         label.place(x=205, y=300)
-        self.keys = dict(zip((0, 2, 4, 6, 1, 3, 5, 7),
+        return dict(zip((0, 2, 4, 6, 1, 3, 5, 7),
-                             (*white_keys, *black_keys, disk)))
+                        (*white_keys, *black_keys, disk)))
-        self.window.after(1000, self.check_to_quit)
-        self.window.mainloop()
-        # need to delete variables that reference tkinter objects
-        del self.keys
-        del self.window
     def push_switch(self, index):
-        self.keys[index].push()
+        self.switches[index].push()
-    def check_to_quit(self):
+    def _check_to_quit(self):
         if self.running:
-            self.window.after(1000, self.check_to_quit)
+            self.window.after(1000, self._check_to_quit)
         else:

ボタン順序変更

2020/02/12 08:35

投稿

shiracamus

スコア5406

test CHANGED Viewed

@@ -134,8 +134,6 @@
         disk = Disk(canvas, x=35, y=65, size=220)
-        self.keys = [*white_keys, *black_keys, disk]
         font1 = font.Font(family='Bauhaus93', size=10, weight='bold')
@@ -158,6 +156,10 @@
+        self.keys = dict(zip((0, 2, 4, 6, 1, 3, 5, 7),
+                             (*white_keys, *black_keys, disk)))
         self.window.after(1000, self.check_to_quit)
         self.window.mainloop()

変数削除が必要なことをコメント追記

2020/02/12 06:02

投稿

shiracamus

スコア5406

test CHANGED Viewed

@@ -162,6 +162,8 @@
         self.window.mainloop()
+        # need to delete variables that reference tkinter objects
         del self.keys
         del self.window

exit()削除

2020/02/12 04:39

投稿

shiracamus

スコア5406

test CHANGED Viewed

@@ -216,8 +216,6 @@
     thread.join()
-    exit()
 if __name__ == '__main__':

終了処理変更

2020/02/12 04:28

投稿

shiracamus

スコア5406

test CHANGED Viewed

@@ -162,6 +162,10 @@
         self.window.mainloop()
+        del self.keys
+        del self.window
     def push_switch(self, index):
@@ -180,10 +184,6 @@
             self.window.destroy()
-            del self.keys
-            del self.window
     def quit(self):
@@ -198,8 +198,6 @@
     thread = threading.Thread(target=game.run)
-    thread.setDaemon(True)
     thread.start()

終了処理変更

2020/02/12 04:25

投稿

shiracamus

スコア5406

test CHANGED Viewed

@@ -178,11 +178,11 @@
         else:
-            self.keys = None
             self.window.destroy()
+            del self.keys
-            self.window = None
+            del self.window

正常終了するように修正

2020/02/12 03:30

投稿

shiracamus

スコア5406

test CHANGED Viewed

@@ -4,7 +4,7 @@
 tkinterだけの処理を書いてみました。
-残念ながら、スレッド終了がうまくいかなくてコマンド終了できませんけど、動作確認はできます。
+このプログラムだけで動作確認してみてください。
@@ -162,8 +162,6 @@
         self.window.mainloop()
-        print("exit mainloop()")
     def push_switch(self, index):
@@ -184,6 +182,8 @@
             self.window.destroy()
+            self.window = None
     def quit(self):

quit処理変更

2020/02/12 03:26

投稿

shiracamus

スコア5406

test CHANGED Viewed

@@ -108,6 +108,8 @@
     def run(self):
+        self.running = True
         self.window = window = tk.Tk()
         window.title(self.title)
@@ -156,8 +158,12 @@
+        self.window.after(1000, self.check_to_quit)
         self.window.mainloop()
+        print("exit mainloop()")
     def push_switch(self, index):
@@ -166,11 +172,23 @@
+    def check_to_quit(self):
+        if self.running:
+            self.window.after(1000, self.check_to_quit)
+        else:
+            self.keys = None
+            self.window.destroy()
     def quit(self):
-        self.window.destroy()
+        self.running = False
@@ -180,6 +198,8 @@
     thread = threading.Thread(target=game.run)
+    thread.setDaemon(True)
     thread.start()

メソッド名変更

2020/02/12 03:23

投稿

shiracamus

スコア5406

test CHANGED Viewed

@@ -44,7 +44,7 @@
-    def count_up(self):
+    def push(self):
         self.count.set(self.count.get() + 1)
@@ -160,9 +160,9 @@
-    def count_up(self, index):
+    def push_switch(self, index):
-        self.keys[index].count_up()
+        self.keys[index].push()
@@ -188,7 +188,7 @@
     for i in range(8):
-        game.count_up(i)
+        game.push_switch(i)
         time.sleep(1)

outline削除

2020/02/12 03:03

投稿

shiracamus

スコア5406

test CHANGED Viewed

@@ -36,15 +36,9 @@
         self.canvas = canvas
-        outer = x1, y1, x2, y2
-        inner = x1 + 2, y1 + 2, x2 - 2, y2 - 2
-        self.outline = shape(*outer)
-        self.on = shape(*inner, fill='red')
+        self.on = shape(x1, y1, x2, y2, fill='red')
-        self.off = shape(*inner, fill=color)
+        self.off = shape(x1, y1, x2, y2, fill=color)
         self.count = IntVar()

クラス名変更

2020/02/12 00:45

投稿

shiracamus

スコア5406

test CHANGED Viewed

@@ -28,7 +28,7 @@
-class Shape:
+class Switch:
@@ -74,7 +74,7 @@
-class Key(Shape):
+class Key(Switch):
@@ -88,7 +88,7 @@
-class Disk(Shape):
+class Disk(Switch):

コメント削除

2020/02/12 00:41

投稿

shiracamus

スコア5406

test CHANGED Viewed

@@ -128,32 +128,22 @@
+        white_keys = [Key(canvas, x, y=195)
+                      for x in range(280, 280 + 90 * 4, 90)]
+        black_keys = [Key(canvas, x, y=30, color='black')
+                      for x in range(325, 325 + 90 * 3, 90)]
+        disk = Disk(canvas, x=35, y=65, size=220)
+        self.keys = [*white_keys, *black_keys, disk]
         font1 = font.Font(family='Bauhaus93', size=10, weight='bold')
-        # 白鍵盤
-        white_keys = [Key(canvas, x, y=195)
-                      for x in range(280, 280 + 90 * 4, 90)]
-        # 黒鍵盤
-        black_keys = [Key(canvas, x, y=30, color='black')
-                      for x in range(325, 325 + 90 * 3, 90)]
-        # 皿
-        disk = Disk(canvas, x=35, y=65, size=220)
-        self.keys = [*white_keys, *black_keys, disk]
-        # カウンタ表示
         for i, key in enumerate(white_keys):
             label = tk.Label(window, font=font1, textvariable=key.count)

クラス名変更

2020/02/11 16:15

投稿

shiracamus

スコア5406

test CHANGED Viewed

@@ -88,7 +88,7 @@
-class Circle(Shape):
+class Disk(Shape):
@@ -146,7 +146,7 @@
         # 皿
-        disk = Circle(canvas, x=35, y=65, size=220)
+        disk = Disk(canvas, x=35, y=65, size=220)
         self.keys = [*white_keys, *black_keys, disk]

サンプルコード追記

2020/02/11 09:44

投稿

shiracamus

スコア5406

test CHANGED Viewed

@@ -1 +1,225 @@
 色を戻すのは、tk部品の afterを使えばいいですよ。
+tkinterだけの処理を書いてみました。
+残念ながら、スレッド終了がうまくいかなくてコマンド終了できませんけど、動作確認はできます。
+```python
+import os
+import sys
+import time
+import threading
+os.environ['PYGAME_HIDE_SUPPORT_PROMPT'] = 'hide'
+import tkinter as tk
+from tkinter import font, IntVar
+class Shape:
+    def __init__(self, canvas, shape, x1, y1, x2, y2, color):
+        self.canvas = canvas
+        outer = x1, y1, x2, y2
+        inner = x1 + 2, y1 + 2, x2 - 2, y2 - 2
+        self.outline = shape(*outer)
+        self.on = shape(*inner, fill='red')
+        self.off = shape(*inner, fill=color)
+        self.count = IntVar()
+    def count_up(self):
+        self.count.set(self.count.get() + 1)
+        self.light_on()
+    def light_on(self):
+        self.canvas.tag_raise(self.on, self.off)
+        self.canvas.after(300, self.light_off)
+    def light_off(self):
+        self.canvas.tag_raise(self.off, self.on)
+class Key(Shape):
+    def __init__(self, canvas, x, y, width=70, height=135, color='white'):
+        super().__init__(canvas, canvas.create_rectangle,
+                         x, y, x + width, y + height, color)
+class Circle(Shape):
+    def __init__(self, canvas, x, y, size, color='white'):
+        super().__init__(canvas, canvas.create_oval,
+                         x, y, x + size, y + size, color)
+class Game:
+    def __init__(self, title):
+        self.title = title
+    def run(self):
+        self.window = window = tk.Tk()
+        window.title(self.title)
+        window.geometry('640x360')
+        canvas = tk.Canvas(window, width=640, height=360)
+        canvas.place(x=0, y=0)
+        font1 = font.Font(family='Bauhaus93', size=10, weight='bold')
+        # 白鍵盤
+        white_keys = [Key(canvas, x, y=195)
+                      for x in range(280, 280 + 90 * 4, 90)]
+        # 黒鍵盤
+        black_keys = [Key(canvas, x, y=30, color='black')
+                      for x in range(325, 325 + 90 * 3, 90)]
+        # 皿
+        disk = Circle(canvas, x=35, y=65, size=220)
+        self.keys = [*white_keys, *black_keys, disk]
+        # カウンタ表示
+        for i, key in enumerate(white_keys):
+            label = tk.Label(window, font=font1, textvariable=key.count)
+            label.place(x=310 + 90 * i, y=333)
+        for i, key in enumerate(black_keys):
+            label = tk.Label(window, font=font1, textvariable=key.count)
+            label.place(x=355 + 90 * i, y=5)
+        label = tk.Label(window, font=font1, textvariable=disk.count)
+        label.place(x=205, y=300)
+        self.window.mainloop()
+    def count_up(self, index):
+        self.keys[index].count_up()
+    def quit(self):
+        self.window.destroy()
+def main():
+    game = Game('Contoller input')
+    thread = threading.Thread(target=game.run)
+    thread.start()
+    time.sleep(1)
+    for i in range(8):
+        game.count_up(i)
+        time.sleep(1)
+    game.quit()
+    thread.join()
+    exit()
+if __name__ == '__main__':
+    main()
+```