teratail
回答率
85.48%
質問するログイン新規登録
トップJavaScriptに関する質問JavaScriptの綺麗なコードの書き方

編集履歴

回答編集履歴

4

微修正

2015/10/13 12:30

投稿

.tkn
.tkn

スコア10

test CHANGED
@@ -50,9 +50,9 @@
50
50
 
51
51
  document.getElementById('address').value = response.location.name;
52
52
 
53
- document.getElementsByName("gender")["1"].checked = (response.gender === "male");
53
+ document.getElementsByName("gender")[1].checked = (response.gender === "male");
54
54
 
55
- document.getElementsByName("gender")["2"].checked = (response.gender === "female");
55
+ document.getElementsByName("gender")[2].checked = (response.gender === "female");
56
56
 
57
57
  document.getElementById('education').value = (function getSchoolNameOf(educations) {
58
58
 

3

インデントの変更

2015/10/13 12:30

投稿

.tkn
.tkn

スコア10

test CHANGED
@@ -22,13 +22,13 @@
22
22
 
23
23
  function userLogin() {
24
24
 
25
- FB.api('/me', function (response) {
25
+ FB.api('/me', function(response) {
26
26
 
27
27
  document.getElementById('name').value = response.name;
28
28
 
29
29
  document.getElementById('email').value = response.email;
30
30
 
31
- document.getElementById('age').value = (function getAgeOf (birthday_string) {
31
+ document.getElementById('age').value = (function getAgeOf(birthday_string) {
32
32
 
33
33
  var birthday = new Date(birthday_string);
34
34
 
@@ -54,7 +54,7 @@
54
54
 
55
55
  document.getElementsByName("gender")["2"].checked = (response.gender === "female");
56
56
 
57
- document.getElementById('education').value = (function getSchoolNameOf (educations) {
57
+ document.getElementById('education').value = (function getSchoolNameOf(educations) {
58
58
 
59
59
  var keys = Object.keys(educations);
60
60
 

2

インデントの変更

2015/10/09 07:06

投稿

.tkn
.tkn

スコア10

test CHANGED
@@ -36,11 +36,9 @@
36
36
 
37
37
  var differenceOfYear = today.getFullYear() - birthday.getFullYear();
38
38
 
39
+ if (today.getMonth() <= birthday.getMonth()
39
40
 
40
-
41
- if (today.getMonth() <= birthday.getMonth() &&
42
-
43
- today.getDate() < birthday.getDate() )
41
+ && today.getDate() < birthday.getDate())
44
42
 
45
43
  return differenceOfYear - 1;
46
44
 
@@ -56,7 +54,7 @@
56
54
 
57
55
  document.getElementsByName("gender")["2"].checked = (response.gender === "female");
58
56
 
59
- document.getElementById('education').value = (function getSchoolNameOf(educations) {
57
+ document.getElementById('education').value = (function getSchoolNameOf (educations) {
60
58
 
61
59
  var keys = Object.keys(educations);
62
60
 

1

インデントの変更

2015/10/09 07:05

投稿

.tkn
.tkn

スコア10

test CHANGED
@@ -22,47 +22,49 @@
22
22
 
23
23
  function userLogin() {
24
24
 
25
- FB.api('/me', function (response) {
25
+ FB.api('/me', function (response) {
26
26
 
27
- document.getElementById('name').value = response.name;
27
+ document.getElementById('name').value = response.name;
28
28
 
29
- document.getElementById('email').value = response.email;
29
+ document.getElementById('email').value = response.email;
30
30
 
31
- document.getElementById('age').value = (function getAgeOf (birthday_string) {
31
+ document.getElementById('age').value = (function getAgeOf (birthday_string) {
32
32
 
33
- var birthday = new Date(birthday_string);
33
+ var birthday = new Date(birthday_string);
34
34
 
35
- var today = new Date();
35
+ var today = new Date();
36
36
 
37
- var differenceOfYear = today.getFullYear() - birthday.getFullYear();
37
+ var differenceOfYear = today.getFullYear() - birthday.getFullYear();
38
38
 
39
- if (today.getMonth() <= birthday.getMonth() &&
40
39
 
41
- today.getDate() < birthday.getDate() )
42
40
 
43
- return differenceOfYear - 1;
41
+ if (today.getMonth() <= birthday.getMonth() &&
44
42
 
45
- else
43
+ today.getDate() < birthday.getDate() )
46
44
 
47
- return differenceOfYear;
45
+ return differenceOfYear - 1;
48
46
 
49
- })(response.birthday);
47
+ else
50
48
 
51
- document.getElementById('address').value = response.location.name;
49
+ return differenceOfYear;
52
50
 
53
- document.getElementsByName("gender")["1"].checked = (response.gender === "male");
51
+ })(response.birthday);
54
52
 
55
- document.getElementsByName("gender")["2"].checked = (response.gender === "female");
53
+ document.getElementById('address').value = response.location.name;
56
54
 
57
- document.getElementById('education').value = (function getSchoolNameOf(educations) {
55
+ document.getElementsByName("gender")["1"].checked = (response.gender === "male");
58
56
 
59
- var keys = Object.keys(educations);
57
+ document.getElementsByName("gender")["2"].checked = (response.gender === "female");
60
58
 
61
- return educations[keys.pop()].school.name;
59
+ document.getElementById('education').value = (function getSchoolNameOf(educations) {
62
60
 
63
- })(response.education);
61
+ var keys = Object.keys(educations);
64
62
 
63
+ return educations[keys.pop()].school.name;
64
+
65
+ })(response.education);
66
+
65
- });
67
+ });
66
68
 
67
69
  }
68
70