teratail
回答率
85.30%
質問するログイン新規登録
トップJavaScriptに関する質問JavaScriptの綺麗なコードの書き方

編集履歴

回答編集履歴

4

微修正

2015/10/13 12:30

投稿

.tkn
.tkn

スコア10

answer CHANGED
@@ -24,8 +24,8 @@
24
24
  return differenceOfYear;
25
25
  })(response.birthday);
26
26
  document.getElementById('address').value = response.location.name;
27
- document.getElementsByName("gender")["1"].checked = (response.gender === "male");
27
+ document.getElementsByName("gender")[1].checked = (response.gender === "male");
28
- document.getElementsByName("gender")["2"].checked = (response.gender === "female");
28
+ document.getElementsByName("gender")[2].checked = (response.gender === "female");
29
29
  document.getElementById('education').value = (function getSchoolNameOf(educations) {
30
30
  var keys = Object.keys(educations);
31
31
  return educations[keys.pop()].school.name;

3

インデントの変更

2015/10/13 12:30

投稿

.tkn
.tkn

スコア10

answer CHANGED
@@ -10,10 +10,10 @@
10
10
 
11
11
  ```javascript
12
12
  function userLogin() {
13
- FB.api('/me', function (response) {
13
+ FB.api('/me', function(response) {
14
14
  document.getElementById('name').value = response.name;
15
15
  document.getElementById('email').value = response.email;
16
- document.getElementById('age').value = (function getAgeOf (birthday_string) {
16
+ document.getElementById('age').value = (function getAgeOf(birthday_string) {
17
17
  var birthday = new Date(birthday_string);
18
18
  var today = new Date();
19
19
  var differenceOfYear = today.getFullYear() - birthday.getFullYear();
@@ -26,7 +26,7 @@
26
26
  document.getElementById('address').value = response.location.name;
27
27
  document.getElementsByName("gender")["1"].checked = (response.gender === "male");
28
28
  document.getElementsByName("gender")["2"].checked = (response.gender === "female");
29
- document.getElementById('education').value = (function getSchoolNameOf (educations) {
29
+ document.getElementById('education').value = (function getSchoolNameOf(educations) {
30
30
  var keys = Object.keys(educations);
31
31
  return educations[keys.pop()].school.name;
32
32
  })(response.education);

2

インデントの変更

2015/10/09 07:06

投稿

.tkn
.tkn

スコア10

answer CHANGED
@@ -17,9 +17,8 @@
17
17
  var birthday = new Date(birthday_string);
18
18
  var today = new Date();
19
19
  var differenceOfYear = today.getFullYear() - birthday.getFullYear();
20
-
21
- if (today.getMonth() <= birthday.getMonth() &&
20
+ if (today.getMonth() <= birthday.getMonth()
22
- today.getDate() < birthday.getDate() )
21
+ && today.getDate() < birthday.getDate())
23
22
  return differenceOfYear - 1;
24
23
  else
25
24
  return differenceOfYear;
@@ -27,7 +26,7 @@
27
26
  document.getElementById('address').value = response.location.name;
28
27
  document.getElementsByName("gender")["1"].checked = (response.gender === "male");
29
28
  document.getElementsByName("gender")["2"].checked = (response.gender === "female");
30
- document.getElementById('education').value = (function getSchoolNameOf(educations) {
29
+ document.getElementById('education').value = (function getSchoolNameOf (educations) {
31
30
  var keys = Object.keys(educations);
32
31
  return educations[keys.pop()].school.name;
33
32
  })(response.education);

1

インデントの変更

2015/10/09 07:05

投稿

.tkn
.tkn

スコア10

answer CHANGED
@@ -10,26 +10,27 @@
10
10
 
11
11
  ```javascript
12
12
  function userLogin() {
13
- FB.api('/me', function (response) {
13
+ FB.api('/me', function (response) {
14
- document.getElementById('name').value = response.name;
14
+ document.getElementById('name').value = response.name;
15
- document.getElementById('email').value = response.email;
15
+ document.getElementById('email').value = response.email;
16
- document.getElementById('age').value = (function getAgeOf (birthday_string) {
16
+ document.getElementById('age').value = (function getAgeOf (birthday_string) {
17
- var birthday = new Date(birthday_string);
17
+ var birthday = new Date(birthday_string);
18
- var today = new Date();
18
+ var today = new Date();
19
- var differenceOfYear = today.getFullYear() - birthday.getFullYear();
19
+ var differenceOfYear = today.getFullYear() - birthday.getFullYear();
20
+
20
- if (today.getMonth() <= birthday.getMonth() &&
21
+ if (today.getMonth() <= birthday.getMonth() &&
21
- today.getDate() < birthday.getDate() )
22
+ today.getDate() < birthday.getDate() )
22
- return differenceOfYear - 1;
23
+ return differenceOfYear - 1;
23
- else
24
+ else
24
- return differenceOfYear;
25
+ return differenceOfYear;
25
- })(response.birthday);
26
+ })(response.birthday);
26
- document.getElementById('address').value = response.location.name;
27
+ document.getElementById('address').value = response.location.name;
27
- document.getElementsByName("gender")["1"].checked = (response.gender === "male");
28
+ document.getElementsByName("gender")["1"].checked = (response.gender === "male");
28
- document.getElementsByName("gender")["2"].checked = (response.gender === "female");
29
+ document.getElementsByName("gender")["2"].checked = (response.gender === "female");
29
- document.getElementById('education').value = (function getSchoolNameOf(educations) {
30
+ document.getElementById('education').value = (function getSchoolNameOf(educations) {
30
- var keys = Object.keys(educations);
31
+ var keys = Object.keys(educations);
31
- return educations[keys.pop()].school.name;
32
+ return educations[keys.pop()].school.name;
32
- })(response.education);
33
+ })(response.education);
33
- });
34
+ });
34
35
  }
35
36
  ```