編集履歴

質問編集履歴

コードの修正

2017/07/30 09:31

投稿

退会済みユーザー

スコア0

test CHANGED Viewed

File without changes

test CHANGED Viewed

@@ -6,7 +6,7 @@
 ```
-Duplicat method keyPressed() in type ShootingGame
+NullPointerException
 ```
@@ -28,12 +28,10 @@
 int numOfMaxShots = 50;
+int nextShot = 0;
 Shot[] shots = new Shot[numOfMaxShots];
-int nextShot = 0;
-ArrayList<BULLET> bulletList = new ArrayList<BULLET>();
 int numOfMaxBombs = 50;
 Bomb[] bombs = new Bomb[numOfMaxBombs];
@@ -52,8 +50,6 @@
 void setup() {
   size(600, 600);
@@ -88,138 +84,268 @@
   for(int i = 0; i < numOfMaxShots; i++) {
+   shots[i] = new Shot(0, height + 100, color(255, 255, 0));
+  }
+  for(int i = 0; i < numOfMaxBombs; i++) {
+    bombs[i] = new Bomb(0, -100, color(255, 0, 0));
+  }
+}
+void draw() {
+  background(0);
+  myShip.draw();
+  myShipController();
+  drawEnemies();
+  drawBombs();
+  enemyController();
+  shotsController();
+  collisionDetection();
+}
+{
+  if (code==0) {
+    background(0);
+    textSize(32);
+    fill(255);
+    text("'a Click' is clicked to start", 400, 350) ;
+  }
+  if (code==1) {
+    background(0);
+    for(int i = 0; i < numOfMaxShots; i++) {
     shots[i] = new Shot(0, height + 100, color(255, 255, 0));
   }
+    text("SCORE:"+str(score), width/7, height -50) ;
+  }
+  if (code==2) {
+    fill(0);
+    rect(0, 0, width, height);
+    textSize(32);
+    fill(255);
+    text("GAME OVER", 600, 350) ;
+    text("RESTART is 'd Click'", 600, 500);
+  }
+}
+void drawEnemies() {
+  for(int i = 0; i < numOfEnemies; i++) {
+    en1[i].draw();
+  }
+}
+void enemyController() {
+  for(int i = 0; i < numOfEnemies; i++) {
+    if(en1[i].xpos < 0 || en1[i].xpos + en1[i].getWidth() > width) {
+      en1[i].speed = - en1[i].speed;
+    }
+    en1[i].moveXaxis();
+    if(en1[i].visible) {
+      if(floor(random(50)) == 5) {
+        bombs[nextBomb].xpos = en1[i].xpos + en1[i].getWidth() / 2;
+        bombs[nextBomb].ypos = en1[i].ypos + en1[i].getHeight();
+        bombs[nextBomb].visible = true;
+        nextBomb = (nextBomb + 1) % numOfMaxBombs;
+      }
+    }
+  }
+}
+void drawBombs() {
   for(int i = 0; i < numOfMaxBombs; i++) {
-    bombs[i] = new Bomb(0, -100, color(255, 0, 0));
-  }
-}
-void draw() {
-  background(0);
-  myShip.draw();
-  myShipController();
-  drawEnemies();
-  drawBombs();
-  enemyController();
-  shotsController();
-  collisionDetection();
-}
-{
+    bombs[i].draw();
+    bombs[i].move();
+  }
+}
+void collisionDetection() {
+  for(int i = 0; i < numOfEnemies; i++) {
+    for(int j = 0; j < numOfMaxShots; j++) {
+      if(en1[i].visible && en1[i].isIn(shots[j].xpos, shots[j].ypos)) {
+        en1[i].visible = false;
+        shots[j].visible = false;
+      }
+    }
+  }
+  for(int i = 0; i < numOfMaxBombs; i++) {
+    if(bombs[i].visible && myShip.isIn(bombs[i].xpos, bombs[i].ypos)) {
+      myShip.visible = false;
+      bombs[i].visible = false;
+    }
+  }
+}
+void keyPressed() {
+  if(key == 'd') {
+    keyRight = true;
+  }
+  if(key == 'a') {
+    keyLeft = true;
+  }
+  if(key == 'w') {
+    keyUp = true;
+  }
+  if(key == 's') {
+    keyDown = true;
+  }
+}
+void keyReleased() {
+  if(key == 'a') {
+    keyLeft = false;
+  }
+  else if(key == 'd') {
+    keyRight = false;
+  }
+  else if(key == 'w') {
+    keyUp = false;
+  }
+  else if(key == 's') {
+    keyDown = false;
+  }
+  else if(keyCode == ' ') {
+    fire();
+  }
   if (code==0) {
+    if (key=='a') {
-    background(0);
+      code=1;
-    textSize(32);
-    fill(255);
-    text("'a Click' is clicked to start", 400, 350) ;
-  }
+    }
-  if (code==1) {
-    background(0);
-    for (int i=bulletList.size()-1; i>=0; i--) {
-      BULLET b = bulletList.get(i);
-      if (b.isAlive()) {
-        b.move();
-        b.display();
-      } else {
-        bulletList.remove(i);
-      }
+  }
-    }
-    text("SCORE:"+str(score), width/7, height -50) ;
-  }
   if (code==2) {
-    fill(0);
-    rect(0, 0, width, height);
-    textSize(32);
-    fill(255);
-    text("GAME OVER", 600, 350) ;
-    text("RESTART is 'd Click'", 600, 500);
-  }
-}
-void keyPressed() {
-  if (code==0) {
-    if (key=='a') {
-      code=1;
-    }
-  }
-  if (code==1) {
-    if (key=='s') {
-      bulletList.add(new BULLET(myShip.xpos, myShip.ypos));
-    }
-  }
-  if (code==2) {
     if (key=='d') {
       code=0;
@@ -230,166 +356,6 @@
 }
-void drawEnemies() {
-  for(int i = 0; i < numOfEnemies; i++) {
-    enemy[i].draw();
-  }
-}
-void enemyController() {
-  for(int i = 0; i < numOfEnemies; i++) {
-    if(en1[i].xpos < 0 || en1[i].xpos + en1[i].getWidth() > width) {
-      en1[i].speed = - en1[i].speed;
-    }
-    en1[i].moveXaxis();
-    if(en1[i].visible) {
-      if(floor(random(50)) == 5) {
-        bombs[nextBomb].xpos = en1[i].xpos + en1[i].getWidth() / 2;
-        bombs[nextBomb].ypos = en1[i].ypos + en1[i].getHeight();
-        bombs[nextBomb].visible = true;
-        nextBomb = (nextBomb + 1) % numOfMaxBombs;
-      }
-    }
-  }
-}
-void drawBombs() {
-  for(int i = 0; i < numOfMaxBombs; i++) {
-    bombs[i].draw();
-    bombs[i].move();
-  }
-}
-void collisionDetection() {
-  for(int i = 0; i < numOfEnemies; i++) {
-    for(int j = 0; j < numOfMaxShots; j++) {
-      if(enemy[i].visible && enemy[i].isIn(shots[j].xpos, shots[j].ypos)) {
-        enemy[i].visible = false;
-        shots[j].visible = false;
-      }
-    }
-  }
-  for(int i = 0; i < numOfMaxBombs; i++) {
-    if(bombs[i].visible && myShip.isIn(bombs[i].xpos, bombs[i].ypos)) {
-      myShip.visible = false;
-      bombs[i].visible = false;
-    }
-  }
-}
-void keyPressed() {
-  if(key == 'd') {
-    keyRight = true;
-  }
-  if(key == 'a') {
-    keyLeft = true;
-  }
-  if(key == 'w') {
-    keyUp = true;
-  }
-  if(key == 's') {
-    keyDown = true;
-  }
-}
-void keyReleased() {
-  if(key == 'a') {
-    keyLeft = false;
-  }
-  else if(key == 'd') {
-    keyRight = false;
-  }
-  else if(key == 'w') {
-    keyUp = false;
-  }
-  else if(key == 's') {
-    keyDown = false;
-  }
-  else if(keyCode == ' ') {
-    fire();
-  }
-}
 void myShipController() {
   if(keyLeft) {
@@ -574,6 +540,66 @@
+class Bomb {
+  int xpos;
+  int ypos;
+  color c;
+  int speed = 3;
+  boolean visible = false;
+  Bomb(int _xpos, int _ypos, color _c) {
+    xpos = _xpos;
+    ypos = _ypos;
+    c = _c;
+  }
+  void draw() {
+    fill(c);
+    if(visible) {
+      fill(c);
+      ellipse(xpos, ypos, 10, 10);
+    }
+  }
+  void move() {
+    if(visible && ypos < height + 50) {
+      ypos += speed;
+    }
+    else {
+      visible = false;
+    }
+  }
+}
 class Shot {
   int xpos;
@@ -612,9 +638,7 @@
   }
-  void move() {
+ void move() {
     if(ypos > -50) {
@@ -632,140 +656,6 @@
 }
-class Bomb {
-  int xpos;
-  int ypos;
-  color c;
-  int speed = 3;
-  boolean visible = false;
-  Bomb(int _xpos, int _ypos, color _c) {
-    xpos = _xpos;
-    ypos = _ypos;
-    c = _c;
-  }
-  void draw() {
-    fill(c);
-    if(visible) {
-      fill(c);
-      ellipse(xpos, ypos, 10, 10);
-    }
-  }
-  void move() {
-    if(visible && ypos < height + 50) {
-      ypos += speed;
-    }
-    else {
-      visible = false;
-    }
-  }
-}
-class BULLET {
-  float bx;
-  float by;
-  float bwi;
-  float bhe;
-  float bsp;
-  BULLET(float _x, float _y) {
-    bx = _x;
-    by = _y;
-    bwi = 30;
-    bhe = 5;
-    bsp = 15;
-  }
-  void move() {
-    bx += bsp;
-    if (e1x<50||e1x<mouseX) {
-      bx = width;
-      by = height;
-    }
-  }
-  void display() {
-    stroke(50, 225, 100);
-    fill(255);
-    ellipse(bx, by, bwi, bhe);
-  }
-  boolean isAlive() {
-    if (bx+bwi/2<0 || width<bx-bwi/7 || by+bhe/3<0 || height<by-bhe/3) {
-      return false;
-    }
-    return true;
-  }
-}
 ```