編集履歴

質問編集履歴

出力結果を書きました。

2016/07/24 10:49

投稿

退会済みユーザー

スコア0

test CHANGED Viewed

File without changes

test CHANGED Viewed

@@ -10,6 +10,72 @@
+```
+ 1
+Side : 224.210646
+Area : 2072.541918
+ 2
+Side : 200.143520
+Area : 1352.474029
+ 3
+Side : 186.673849
+Area : 1447.508549
+ 4
+Side : 240.090907
+Area : 1719.078096
+ 5
+Side : 142.866303
+Area : 967.710959
+ 6
+Side : 164.552194
+Area : 935.697066
+ 7
+Side : 95.511362
+Area : 172.333253
+ 8
+Side : 224.741866
+Area : 1657.931090
+ 9
+Side : 185.111045
+Area : 1389.912227
+10
+Side : 143.538119
+Area : 446.386604
+```
 ###発生している問題・エラーメッセージ
 Segmentation fault: 11が表示されます。

コードをポインタを用いないものに変更しました。

2016/07/24 10:49

投稿

退会済みユーザー

スコア0

test CHANGED Viewed

File without changes

test CHANGED Viewed

@@ -4,6 +4,12 @@
+[追記]
+A[SIZE]をポインタを用いないものに変更しましたがどのソートを実行してもソートされません。
 ###発生している問題・エラーメッセージ
 Segmentation fault: 11が表示されます。
@@ -56,13 +62,13 @@
-triangle_t *A[SIZE];
+triangle_t A[SIZE];
 //A[]の初期化
-void init_triangle()
+void init_triangle(triangle_t t[], int n)
 {
@@ -70,15 +76,15 @@
-  for (i = 0; i < SIZE; i++) {
+  for (i = 0; i < n; i++) {
     for (j = 0; j < 3; j++) {
-      A[i]->p[j].x = 0;
+      t[i].p[j].x = 0;
-      A[i]->p[j].y = 0;
+      t[i].p[j].y = 0;
-      A[i]->p[j].z = 0;
+      t[i].p[j].z = 0;
     }
@@ -90,7 +96,7 @@
 //三角形の辺の和, 面積を出力
-void print_triangle(triangle_t *t)
+void print_triangle(triangle_t t)
 {
@@ -100,13 +106,11 @@
-  if (t != NULL) {
-    s[0] = sqrt(pow((double)(t->p[1].x - t->p[0].x), 2) + pow((double)(t->p[1].y - t->p[0].y), 2) + pow((double)(t->p[1].z - t->p[0].z), 2));
+    s[0] = sqrt(pow((double)(t.p[1].x - t.p[0].x), 2) + pow((double)(t.p[1].y - t.p[0].y), 2) + pow((double)(t.p[1].z - t.p[0].z), 2));
-    s[1] = sqrt(pow((double)(t->p[2].x - t->p[1].x), 2) + pow((double)(t->p[2].y - t->p[1].y), 2) + pow((double)(t->p[2].z - t->p[1].z), 2));
+    s[1] = sqrt(pow((double)(t.p[2].x - t.p[1].x), 2) + pow((double)(t.p[2].y - t.p[1].y), 2) + pow((double)(t.p[2].z - t.p[1].z), 2));
-    s[2] = sqrt(pow((double)(t->p[0].x - t->p[2].x), 2) + pow((double)(t->p[0].y - t->p[2].y), 2) + pow((double)(t->p[0].z - t->p[2].z), 2));
+    s[2] = sqrt(pow((double)(t.p[0].x - t.p[2].x), 2) + pow((double)(t.p[0].y - t.p[2].y), 2) + pow((double)(t.p[0].z - t.p[2].z), 2));
     ss = s[0] + s[1] + s[2];
@@ -124,15 +128,13 @@
     printf("Area : %f\n", a);
-  }
 }
 //三角形生成
-triangle_t *create_triangle()
+triangle_t create_triangle()
 {
@@ -140,7 +142,7 @@
   double s[3]; //各辺の長さ
-  triangle_t tr, *ptr; //三角形
+  triangle_t tr; //三角形
   int i;
@@ -186,17 +188,29 @@
     }
-    ptr = &tr;
     //printf("   x      y      z\n");
-    //for (i = 0; i < 3; i++) printf("%d %6d %6d %6d\n", i + 1, ptr->p[i].x, ptr->p[i].y, ptr->p[i].z);
+    //for (i = 0; i < 3; i++) printf("%d %6d %6d %6d\n", i + 1, ptr.p[i].x, ptr.p[i].y, ptr.p[i].z);
-    return ptr;
+    return tr;
-  }
+  }
+  else {
+    for (i = 0; i < 3; i++) {
+      tr.p[i].x = x[i];
+      tr.p[i].y = y[i];
+      tr.p[i].z = z[i];
+    }
-  else return NULL;
+    return tr;
+  }
 }
@@ -204,7 +218,7 @@
 //三角形の面積(等しければ3辺の和)を比較し前者が小さければ負, 後者が小さければ正を返す
-int cmp_triangle(triangle_t *t1, triangle_t *t2)
+int cmp_triangle(triangle_t t1, triangle_t t2)
 {
@@ -216,21 +230,21 @@
-  s1[0] = sqrt(pow((double)(t1->p[1].x - t1->p[0].x), 2) + pow((double)(t1->p[1].y - t1->p[0].y), 2) + pow((double)(t1->p[1].z - t1->p[0].z), 2));
+  s1[0] = sqrt(pow((double)(t1.p[1].x - t1.p[0].x), 2) + pow((double)(t1.p[1].y - t1.p[0].y), 2) + pow((double)(t1.p[1].z - t1.p[0].z), 2));
-  s1[1] = sqrt(pow((double)(t1->p[2].x - t1->p[1].x), 2) + pow((double)(t1->p[2].y - t1->p[1].y), 2) + pow((double)(t1->p[2].z - t1->p[1].z), 2));
+  s1[1] = sqrt(pow((double)(t1.p[2].x - t1.p[1].x), 2) + pow((double)(t1.p[2].y - t1.p[1].y), 2) + pow((double)(t1.p[2].z - t1.p[1].z), 2));
-  s1[2] = sqrt(pow((double)(t1->p[0].x - t1->p[2].x), 2) + pow((double)(t1->p[0].y - t1->p[2].y), 2) + pow((double)(t1->p[0].z - t1->p[2].z), 2));
+  s1[2] = sqrt(pow((double)(t1.p[0].x - t1.p[2].x), 2) + pow((double)(t1.p[0].y - t1.p[2].y), 2) + pow((double)(t1.p[0].z - t1.p[2].z), 2));
   ss1 = (s1[0] + s1[1] + s1[2]) / 2;
-  s2[0] = sqrt(pow((double)(t2->p[1].x - t2->p[0].x), 2) + pow((double)(t2->p[1].y - t2->p[0].y), 2) + pow((double)(t2->p[1].z - t2->p[0].z), 2));
+  s2[0] = sqrt(pow((double)(t2.p[1].x - t2.p[0].x), 2) + pow((double)(t2.p[1].y - t2.p[0].y), 2) + pow((double)(t2.p[1].z - t2.p[0].z), 2));
-  s2[1] = sqrt(pow((double)(t2->p[2].x - t2->p[1].x), 2) + pow((double)(t2->p[2].y - t2->p[1].y), 2) + pow((double)(t2->p[2].z - t2->p[1].z), 2));
+  s2[1] = sqrt(pow((double)(t2.p[2].x - t2.p[1].x), 2) + pow((double)(t2.p[2].y - t2.p[1].y), 2) + pow((double)(t2.p[2].z - t2.p[1].z), 2));
-  s2[2] = sqrt(pow((double)(t2->p[0].x - t2->p[2].x), 2) + pow((double)(t2->p[0].y - t2->p[2].y), 2) + pow((double)(t2->p[0].z - t2->p[2].z), 2));
+  s2[2] = sqrt(pow((double)(t2.p[0].x - t2.p[2].x), 2) + pow((double)(t2.p[0].y - t2.p[2].y), 2) + pow((double)(t2.p[0].z - t2.p[2].z), 2));
   ss2 = (s2[0] + s2[1] + s2[2]) / 2;
@@ -242,7 +256,7 @@
-  //printf("The latter's side = %f\n", sqrt(ss2 * (ss2 - s2[0]) * (ss2 - s2[1]) * (ss2 - s2[2])));
+  //printf("The latter's side = %f\n", sqrt(ss2  (ss2 - s2[0])  (ss2 - s2[1])  (ss2 - s2[2])));
@@ -278,7 +292,7 @@
 //cmp_triangleの結果を文字で出力するバージョン
-void print_cmp_triangle(triangle_t *t1, triangle_t *t2)
+void print_cmp_triangle(triangle_t t1, triangle_t t2)
 {
@@ -322,7 +336,7 @@
 //バブルソート
-void bubble_sort()
+void bubble_sort(triangle_t t[], int n)
 {
@@ -330,11 +344,11 @@
-  for (i = 0; i < SIZE; i++)
+  for (i = 0; i < n; i++)
-    for (j = SIZE - 1; j > i; j--)
+    for (j = n - 1; j > i; j--)
-      if (cmp_triangle(A[j - 1], A[j]) > 0) swap(A[j - 1], A[j]);
+      if (cmp_triangle(t[j - 1], t[j]) > 0) swap(&t[j - 1], &t[j]);
 }
@@ -344,21 +358,21 @@
 //G:ギャップ列
-void shell_sort()
+void shell_sort(triangle_t t[], int n)
-{
+{
-  int i, j, k;
+  int i, j, k = 0;
   int K;
-  int G[SIZE];
+  int G[n];
   //G[k] = 2^(k+1)-1 : Hibbardの方法
-  for (i = 0; G[i] < SIZE; i++) G[i] = (pow(2, k + 1)) - 1;
+  for (i = 0; G[i] < n; i++) G[i] = (pow(2, k + 1)) - 1;
   K = i - 1;
@@ -366,21 +380,21 @@
   for (k = K; k >= 0; k--) {
-    for (i = G[k]; i < SIZE; i++) {
+    for (i = G[k]; i < n; i++) {
-      triangle_t *tmp = A[i];
+      triangle_t tmp = t[i];
       j = i - G[k];
-      while (j >= 0 && cmp_triangle(tmp, A[j]) < 0) {
+      while (j >= 0 && cmp_triangle(tmp, t[j]) < 0) {
-        A[j + G[k]] = A[j];
+        t[j + G[k]] = t[j];
         j -= G[k];
       }
-      A[j + G[k]] = tmp;
+      t[j + G[k]] = tmp;
     }
@@ -392,11 +406,11 @@
 //クイックソートにおける分割処理
-int partition(pivot, left, right)
+int partition(triangle_t t[], int pivot, int left, int right)
-{
+{
-  A[right] = A[pivot];
+  t[right] = t[pivot];
   int l = left;
@@ -406,11 +420,11 @@
   while (1) {
-    while (A[l] < A[right]) l++;
+    while (cmp_triangle(t[l], t[right]) < 0) l++;
-    while (l <= r && A[r] >= A[right]) r--;
+    while (l <= r && cmp_triangle(t[r], t[right]) >= 0) r--;
-    if (l < r) swap(A[l], A[r]);
+    if (l < r) swap(&t[l], &t[r]);
     else break;
@@ -418,7 +432,7 @@
-  swap(A[l], A[right]);
+  swap(&t[l], &t[right]);
   return l;
@@ -428,13 +442,13 @@
 //左端, 中央, 右端のうち真ん中の値の要素のインデックスを出力する
-int middle_value()
+int middle_value(triangle_t t[], int n)
-{
+{
-  triangle_t *B[3] = {A[0], A[SIZE / 2], A[SIZE - 1]};
+  triangle_t B[3] = {t[0], t[n / 2], t[n - 1]};
-  triangle_t *max = B[0], *min = B[0], *mid;
+  triangle_t max = B[0], min = B[0], mid;
   int i;
@@ -464,11 +478,11 @@
-  if (cmp_triangle(mid, A[0]) == 0) return 0;
+  if (cmp_triangle(mid, t[0]) == 0) return 0;
-  else if (cmp_triangle(mid, A[SIZE / 2])) return SIZE / 2;
+  else if (cmp_triangle(mid, t[n / 2])) return n / 2;
-  else if (cmp_triangle(mid, A[SIZE - 1])) return SIZE - 1;
+  else if (cmp_triangle(mid, t[n - 1])) return n - 1;
   else return -1;
@@ -478,17 +492,17 @@
 //クイックソート
-void quick_sort(left, right)
+void quick_sort(triangle_t t[], int left, int right, int n)
 {
   if (left < right) {
-    int pivot = middle_value();
+    int pivot = middle_value(t, n);
-    int p = partition(pivot, left, right); //分割処理
+    int p = partition(t, pivot, left, right); //分割処理
       //A[pivot]未満のデータをA[left],...,A[p-1]に集める
@@ -498,9 +512,9 @@
-    quick_sort(left, p - 1);
+    quick_sort(t, left, p - 1, n);
-    quick_sort(p + 1, right);
+    quick_sort(t, p + 1, right, n);
   }
@@ -518,7 +532,9 @@
   //ソートテスト
-  triangle_t *T[TEST_NUM];
+  triangle_t T[TEST_NUM];
+  //init_triangle(T, TEST_NUM);
   srand((unsigned)time(NULL));
@@ -526,11 +542,11 @@
-  bubble_sort();
-  //shell_sort();
-  //quick_sort(0, SIZE - 1);
+  //bubble_sort(T, TEST_NUM);
+  shell_sort(T, TEST_NUM);
+  //quick_sort(T, 0, TEST_NUM - 1, TEST_NUM);
@@ -544,30 +560,6 @@
-  /*
-  triangle_t *tr1, *tr2;
-  int cmp;
-  tr1 = create_triangle();
-  tr2 = create_triangle();
-  print_cmp_triangle(tr1, tr2);
-  //for (i = 0; i < 3; i++) printf("%d %6d %6d %6d\n", i + 1, tr->p[i].x, tr->p[i].y, tr->p[i].z);
-  */
   return 0;
 }