常連

最近Swiftに触り始めたのですが、癖でコピペをしてしまい、コードが複雑になってしまいました。
コードを丸投げするのは良くないと思うのですが、ここからパースした情報をTableViewに追加しようとして複雑になったコードのせいで足止めをくらってしまい、申し訳ないのですが、悪い点直したほうがいい点を教えてくださると助かります。

このアプリでやりたいことはバーコードリーダーで書籍のISBNを読み取り、楽天書籍検索apiを使って、帰って来たデータや画像をTableViewに追加するというものです、
最終的にはそのデータをExcelやスプレットシートに書き出せたらと思っています
``` swift2
//barcode.swift
import UIKit
import AVFoundation

final class Barcode: UIViewController, UITableViewDelegate{
    
    
    @IBOutlet weak var tableView: UITableView!
    @IBOutlet weak var captureView: UIView?
    private lazy var captureSession: AVCaptureSession = AVCaptureSession()
    private lazy var captureDevice: AVCaptureDevice = AVCaptureDevice.defaultDeviceWithMediaType(AVMediaTypeVideo)
    private lazy var capturePreviewLayer: AVCaptureVideoPreviewLayer = {
        let layer = AVCaptureVideoPreviewLayer(session: self.captureSession)
        return layer
    }()
    
    private var captureInput: AVCaptureInput? = nil
    private lazy var captureOutput: AVCaptureMetadataOutput = {
        let output = AVCaptureMetadataOutput()
        output.setMetadataObjectsDelegate(self, queue: dispatch_get_main_queue())
        return output
    }()
    
    override func viewDidLoad() {
        super.viewDidLoad()
        
        // Do any additional setup after loading the view, typically from a nib.
        setupBarcodeCapture()
    }
    
    override func viewDidLayoutSubviews() {
        super.viewDidLayoutSubviews()
        capturePreviewLayer.frame = self.captureView?.bounds ?? CGRectZero
    }
    
    override func didReceiveMemoryWarning() {
        super.didReceiveMemoryWarning()
        // Dispose of any resources that can be recreated.
    }
    
    // MARK: - private
    private func setupBarcodeCapture() {
        do {
            captureInput = try AVCaptureDeviceInput(device: captureDevice)
            captureSession.addInput(captureInput)
            captureSession.addOutput(captureOutput)
            captureOutput.metadataObjectTypes = captureOutput.availableMetadataObjectTypes
            capturePreviewLayer.frame = self.captureView?.bounds ?? CGRectZero
            capturePreviewLayer.videoGravity = AVLayerVideoGravityResizeAspectFill
            captureView?.layer.addSublayer(capturePreviewLayer)
            captureSession.startRunning()
        } catch let error as NSError {
            print(error)
        }
    }
    
    private func convartISBN(value: String) -> String? {
        let v = NSString(string: value).longLongValue
        let prefix: Int64 = Int64(v / 10000000000)
        guard prefix == 978 || prefix == 979 else { return nil }
        let isbn9: Int64 = (v % 10000000000) / 10
        var sum: Int64 = 0
        var tmpISBN = isbn9
        /*
         for var i = 10; i > 0 && tmpISBN > 0; i -= 1 {
         let divisor: Int64 = Int64(pow(10, Double(i - 2)))
         sum += (tmpISBN / divisor) * Int64(i)
         tmpISBN %= divisor
         }
         */
        
        var i = 10
        while i > 0 && tmpISBN > 0 {
            let divisor: Int64 = Int64(pow(10, Double(i - 2)))
            sum += (tmpISBN / divisor) * Int64(i)
            tmpISBN %= divisor
            i -= 1
        }
        
        let checkdigit = 11 - (sum % 11)
        return String(format: "%lld%@", isbn9, (checkdigit == 10) ? "X" : String(format: "%lld", checkdigit % 11))
    }
        func imageview(img:String){
        guard let urlurl = NSURL(string:img)else {
            print("nill")
            return
        }
        let req = NSURLRequest(URL:urlurl)
        //非同期で変換
        NSURLConnection.sendAsynchronousRequest(req, queue:NSOperationQueue.mainQueue()){(res, data, err) in
            let image = UIImage(data:data!)
            
        }
    }
}


extension Barcode: AVCaptureMetadataOutputObjectsDelegate {
    
    func captureOutput(captureOutput: AVCaptureOutput!, didOutputMetadataObjects metadataObjects: [AnyObject]!, fromConnection connection: AVCaptureConnection!) {
        self.captureSession.stopRunning()
        guard let objects = metadataObjects as? [AVMetadataObject] else { return }
        var detectionString: String? = nil
        let barcodeTypes = [AVMetadataObjectTypeEAN8Code, AVMetadataObjectTypeEAN13Code]
        for metadataObject in objects {
            loop: for type in barcodeTypes {
                guard metadataObject.type == type else { continue }
                guard self.capturePreviewLayer.transformedMetadataObjectForMetadataObject(metadataObject) is AVMetadataMachineReadableCodeObject else { continue }
                if let object = metadataObject as? AVMetadataMachineReadableCodeObject {
                    detectionString = object.stringValue
                    break loop
                }
            }
            var text = ""
            guard let value = detectionString else { continue }
            text += "読み込んだ値:\t\(value)"
            text += "\n"
            guard let isbn = convartISBN(value) else { continue }
            text += "ISBN:\t\(isbn)"
            
            let urlString:String = "https://app.rakuten.co.jp/services/api/BooksBook/Search/20130522?format=json&booksGenreId=001&sort=sales&applicationId=(アプリケーションID)&isbn=\(isbn)"
            guard let url = NSURL(string: urlString)else {
                print("nil")
                continue
            }
            //アクセスするタスクを実行
            let task = NSURLSession.sharedSession().dataTaskWithURL(url){
                
                //渡ってくる変数群。重要なデータは文字通りdataの中に
                (data,response,error) in
                
                //中身が入っているかどうかをフィルタリング
                guard let data = data else{return}
                
                //dataを扱いやすいようにJSON化
                let json = JSON(data: data)
                
                let title = json["Items"][0]["Item"]["title"].stringValue
                let author = json["Items"][0]["Item"]["author"].stringValue
                let salesDate = json["Items"][0]["Item"]["salesDate"].stringValue
                let Image = json["Items"][0]["Item"]["mediumImageUrl"].stringValue
                let company = json["Items"][0]["Item"]["publisherName"].stringValue

                self.imageview(Image)
            }
            task.resume()
        }
        self.captureSession.startRunning()
    }
    
}
```
よろしくお願いいたします

SwftyJSON
XCODE7
Swift2

	@@ -1 +1 @@
1	- コー~~ドの整理と~~TableViewへの追加
1	+ JSONで返って来たデータをTableViewに追加したい、コードの複雑化

質問編集履歴