編集履歴

質問編集履歴

解決したコード及びER図を追加。

2020/12/18 09:02

投稿

punchan36

スコア105

test CHANGED Viewed

File without changes

test CHANGED Viewed

@@ -257,3 +257,103 @@
 RubyGems 3.0.3
 Rails 5.2.3
+### 【追記】ER図
+![イメージ説明](3eb28b15259792379cb3515f2c257132.jpeg)
+### 【追記】解決したコード
+### rooms_controller.rb
+```Ruby
+  def index
+    #以下、メッセージ機能に関する記述。変更なし。
+    @rooms = Room.page(params[:page]).per(3)
+    @user = @current_user
+    @currentEntries = @current_user.entries
+    myRoomIds = []
+    @currentEntries.each do | entry |
+      myRoomIds << entry.room_id
+    end
+    @anotherEntries = Entry.includes(:user, :room).where(room_id: myRoomIds).where('user_id != ?', @user.id).order(created_at: :desc)
+    # 既読機能についてはコントローラでは特に記述せず。ビューにて記述。
+  end
+   def show
+    #以下、メッセージ機能に関する記述。変更なし。
+    @rooms = Room.page(params[:page]).per(3)
+    @user = @current_user
+    @currentEntries = @current_user.entries
+    myRoomIds = []
+    @currentEntries.each do | entry |
+      myRoomIds << entry.room_id
+    end
+    @anotherEntries = Entry.includes(:user, :room).where(room_id: myRoomIds).where('user_id != ?', @user.id).order(created_at: :desc)
+    # ここから既読機能。ログイン中のユーザーが抱える「message」に関する「相手からの通知」のうち、該当のroom_idを取得し、showを開いた時点でreadをtrueにする。
+    @current_user.passive_notifications.where(action: 'message', read: false, room_id: params[:id]).each do |notification|
+      notification.update_attributes(read: true)
+    end
+   end
+```
+### rooms_index.html.erb と rooms_show.html.erb（既読機能に関する内容は同じ）
+```Rails
+   <!-- ログイン中のユーザーが保持している各Entryの中で、未読メッセージがある場合countを繰り返し表示。-->
+   <% message_count = Notification.where(action: "message", visited_id: @current_user.id, visitor_id: e.user.id, room_id: e.room.id, read: false).count %>
+   <% if message_count > 0 %>
+     <div class="message-count date-and-count"><%= message_count %></div>
+   <% end %>
+```

rooms_controller.rb内のindexに追記。

2020/12/18 09:01

投稿

punchan36

スコア105

test CHANGED Viewed

File without changes

test CHANGED Viewed

@@ -162,12 +162,20 @@
       @anotherEntries = Entry.includes(:user, :room).where(room_id: myRoomIds).where('user_id != ?', @user.id).order(created_at: :desc)
+      @notifications = @current_user.passive_notifications.where(action: 'message').includes([:visitor], [:visited]).order(created_at: :desc).page(params[:page]).per(7)
+      @notifications.where(checked: false).each do |notification|
+        notification.update_attributes(checked: true)
+      end
       @unread = @notifications.where(room_id: params[:id], read: false).count
    end
 ```

現状のコードに変更。エラー文は出なくなったので、エラー文は削除。

2020/12/15 12:30

投稿

punchan36

スコア105

test CHANGED Viewed

File without changes

test CHANGED Viewed

@@ -134,7 +134,7 @@
       # ログイン中のユーザーが抱える相手からの通知のうち、該当のroom_idを取得し、showを開いた時点でreadをtrueにする。
-      @current_user.passive_notifications.find_by(room_id: params[:id]).update(read: true)
+      @current_user.passive_notifications.find_by(params[:id]).update(read: true)
       # 該当のroom_id内にある未読メッセージの数を取得。
@@ -146,6 +146,22 @@
    def index
+      @rooms = Room.page(params[:page]).per(3)
+      @user = @current_user
+      @currentEntries = @current_user.entries
+      myRoomIds = []
+      @currentEntries.each do | entry |
+        myRoomIds << entry.room_id
+      end
+      @anotherEntries = Entry.includes(:user, :room).where(room_id: myRoomIds).where('user_id != ?', @user.id).order(created_at: :desc)
       @unread = @notifications.where(room_id: params[:id], read: false).count
    end
@@ -162,7 +178,63 @@
 ```Rails
+    <div class="message-items">
+      <% @anotherEntries.each do |e| %>
+        <div class="message-item">
+          <div class="message-left">
+            <%= link_to room_path(e.room.id) do %>
+              <img src="<%= "/user_images/#{e.user.image_name}" %>">
+            <% end %>
+          </div>
+          <div class="message-center">
+            <div class="message-center-username">
+              <%= link_to room_path(e.room.id) do %
+                <%= e.user.name %>
-     <%= @unread %>
+                <%= @unread %>
+              <% end %>
+            </div>
+            <div class="message-center-message">
+              <%= link_to room_path(e.room.id) do %>
+                <% dm = Message.find_by(id: e.room.message_ids.last).try(:content) %>
+                <%= truncate(dm, length: 9) %>
+              <% end %>
+            </div>
+          </div>
+          <div class="message-right">
+            <div class="message-date" style="color: #C0C0C0;"><%= e.updated_at.strftime("%Y/%m/%d") %></div>
+            <div class="message-time" style="color: #C0C0C0;"><%= e.updated_at.strftime("%H:%M") %></div>
+          </div>
+        </div>
+      <% end %>
+    </div>
 ```
@@ -177,171 +249,3 @@
 RubyGems 3.0.3
 Rails 5.2.3
-### 追記
-上記の記述ですと、`rooms_index.html.erb`は正常に表示されるものの`rooms_show.html.erb`を開くと以下のエラーが表示されます。
-```
-NoMethodError in RoomsController#show
-undefined method `update' for nil:NilClass
-Extracted source (around line #51):
-49      # 「message」に関する「相手からの通知」のうち、該当のroom_idを取得し、showを開いた時点でreadをtrueにする。
-50      # @notifications.find_by(room_id: params[:id]).update(read: true)
-51      @current_user.passive_notifications.find_by(room_id: params[:id]).update(read: true)
-52
-53      # 該当のroom_id内にある未読メッセージの数を取得。→rooms_show.html.erb
-54      # @unread = @notifications.find_by(room_id: params[:id]).where(read: false).count
-```
-またその際のログは以下の様になっています。
-```
-app/controllers/rooms_controller.rb:51:in `show'
-Started GET "/rooms/10" for ::1 at 2020-12-15 18:36:25 +0900
-Processing by RoomsController#show as HTML
-  Parameters: {"id"=>"10"}
-  User Load (0.3ms)  SELECT  "users".* FROM "users" WHERE "users"."id" = ? LIMIT ?  [["id", 20], ["LIMIT", 1]]
-  ↳ app/controllers/application_controller.rb:9
-  Entry Load (0.3ms)  SELECT "entries".* FROM "entries" WHERE "entries"."user_id" = ?  [["user_id", 20]]
-  ↳ app/controllers/rooms_controller.rb:24
-  Room Load (0.2ms)  SELECT  "rooms".* FROM "rooms" WHERE "rooms"."id" = ? LIMIT ?  [["id", 10], ["LIMIT", 1]]
-  ↳ app/controllers/rooms_controller.rb:31
-  Entry Load (0.5ms)  SELECT "entries".* FROM "entries" WHERE "entries"."user_id" = ? AND "entries"."room_id" = ?  [["user_id", 20], ["room_id", 10]]
-  ↳ app/controllers/rooms_controller.rb:32
-  Notification Load (0.6ms)  SELECT  "notifications".* FROM "notifications" WHERE "notifications"."visited_id" = ? AND "notifications"."room_id" = ? LIMIT ?  [["visited_id", 20], ["room_id", 10], ["LIMIT", 1]]
-  ↳ app/controllers/rooms_controller.rb:51
-Completed 500 Internal Server Error in 144ms (ActiveRecord: 8.7ms)
-NoMethodError (undefined method `update' for nil:NilClass):
-```
-また、`rooms_index.html.erb`を開いた際のログはこちらです。
-```
-app/controllers/rooms_controller.rb:51:in `show'
-Started GET "/rooms/index" for ::1 at 2020-12-15 18:41:37 +0900
-Processing by RoomsController#index as HTML
-  User Load (2.5ms)  SELECT  "users".* FROM "users" WHERE "users"."id" = ? LIMIT ?  [["id", 20], ["LIMIT", 1]]
-  ↳ app/controllers/application_controller.rb:9
-  Entry Load (0.4ms)  SELECT "entries".* FROM "entries" WHERE "entries"."user_id" = ?  [["user_id", 20]]
-  ↳ app/controllers/rooms_controller.rb:71
-  Notification Load (0.5ms)  SELECT  "notifications".* FROM "notifications" WHERE "notifications"."visited_id" = ? AND "notifications"."action" = ? AND "notifications"."checked" = ? ORDER BY "notifications"."created_at" DESC LIMIT ? OFFSET ?  [["visited_id", 20], ["action", "message"], ["checked", 0], ["LIMIT", 7], ["OFFSET", 0]]
-  ↳ app/controllers/rooms_controller.rb:86
-   (0.8ms)  SELECT COUNT(*) FROM (SELECT  1 AS one FROM "notifications" WHERE "notifications"."visited_id" = ? AND "notifications"."action" = ? AND "notifications"."room_id" IS NULL AND "notifications"."read" = ? ORDER BY "notifications"."created_at" DESC LIMIT ? OFFSET ?) subquery_for_count  [["visited_id", 20], ["action", "message"], ["read", 0], ["LIMIT", 7], ["OFFSET", 0]]
-  ↳ app/controllers/rooms_controller.rb:93
-  Rendering rooms/index.html.erb within layouts/application
-  Entry Load (1.6ms)  SELECT "entries".* FROM "entries" WHERE "entries"."room_id" IN (?, ?) AND (user_id != 20) ORDER BY "entries"."created_at" DESC  [["room_id", 10], ["room_id", 13]]
-  ↳ app/views/rooms/index.html.erb:11
-  User Load (0.5ms)  SELECT "users".* FROM "users" WHERE "users"."id" IN (?, ?)  [["id", 22], ["id", 13]]
-  ↳ app/views/rooms/index.html.erb:11
-  Room Load (0.7ms)  SELECT "rooms".* FROM "rooms" WHERE "rooms"."id" IN (?, ?)  [["id", 13], ["id", 10]]
-  ↳ app/views/rooms/index.html.erb:11
-   (0.4ms)  SELECT "messages"."id" FROM "messages" WHERE "messages"."room_id" = ?  [["room_id", 13]]
-  ↳ app/views/rooms/index.html.erb:30
-  Message Load (0.7ms)  SELECT  "messages".* FROM "messages" WHERE "messages"."id" = ? LIMIT ?  [["id", 55], ["LIMIT", 1]]
-  ↳ app/views/rooms/index.html.erb:30
-   (0.3ms)  SELECT "messages"."id" FROM "messages" WHERE "messages"."room_id" = ?  [["room_id", 10]]
-  ↳ app/views/rooms/index.html.erb:30
-  Message Load (0.3ms)  SELECT  "messages".* FROM "messages" WHERE "messages"."id" IS NULL LIMIT ?  [["LIMIT", 1]]
-  ↳ app/views/rooms/index.html.erb:30
-  Rendered rooms/index.html.erb within layouts/application (68.2ms)
-  CACHE User Load (0.0ms)  SELECT  "users".* FROM "users" WHERE "users"."id" = ? LIMIT ?  [["id", 20], ["LIMIT", 1]]
-  ↳ app/views/layouts/application.html.erb:39
-   (0.5ms)  SELECT COUNT(*) FROM "notifications" WHERE "notifications"."visited_id" = ? AND "notifications"."checked" = ? AND "notifications"."action" = ?  [["visited_id", 20], ["checked", 0], ["action", "message"]]
-  ↳ app/helpers/notifications_helper.rb:47
-   (1.0ms)  SELECT COUNT(*) FROM "notifications" WHERE "notifications"."visited_id" = ? AND "notifications"."action" != ? AND "notifications"."checked" = ?  [["visited_id", 20], ["action", "message"], ["checked", 0]]
-  ↳ app/helpers/notifications_helper.rb:41
-Completed 200 OK in 321ms (Views: 260.2ms | ActiveRecord: 10.3ms)
-Started GET "/rooms/js/tag.js" for ::1 at 2020-12-15 18:41:37 +0900
-ActionController::RoutingError (No route matches [GET] "/rooms/js/tag.js"):
-```

rooms_controller.rb内及びエラー文を最新のものに書き換え。

2020/12/15 10:59

投稿

punchan36

スコア105

test CHANGED Viewed

File without changes

test CHANGED Viewed

@@ -132,9 +132,9 @@
       @notifications = @current_user.passive_notifications.where(action: 'message').includes([:visitor], [:visited]).order(created_at: :desc).page(params[:page]).per(7)
-      # 「message」に関する相手からの通知のうち、該当のroom_idを取得し、showを開いた時点でreadをtrueにする。
+      # ログイン中のユーザーが抱える相手からの通知のうち、該当のroom_idを取得し、showを開いた時点でreadをtrueにする。
-      @notifications.find_by(room_id: params[:id]).update(read: true)
+      @current_user.passive_notifications.find_by(room_id: params[:id]).update(read: true)
       # 該当のroom_id内にある未読メッセージの数を取得。
@@ -194,113 +194,131 @@
 undefined method `update' for nil:NilClass
+Extracted source (around line #51):
+49      # 「message」に関する「相手からの通知」のうち、該当のroom_idを取得し、showを開いた時点でreadをtrueにする。
-      @notifications.find_by(room_id: params[:id]).update(read: true)
+50      # @notifications.find_by(room_id: params[:id]).update(read: true)
+51      @current_user.passive_notifications.find_by(room_id: params[:id]).update(read: true)
+52
+53      # 該当のroom_id内にある未読メッセージの数を取得。→rooms_show.html.erb
+54      # @unread = @notifications.find_by(room_id: params[:id]).where(read: false).count
-```
+```
-何かパラメータが上手く渡っていないのか…。その際のログは以下の様になっています。
+またその際のログは以下の様になっています。
-```
+```
+app/controllers/rooms_controller.rb:51:in `show'
-Started GET "/rooms/10" for ::1 at 2020-12-13 23:19:49 +0900
+Started GET "/rooms/10" for ::1 at 2020-12-15 18:36:25 +0900
 Processing by RoomsController#show as HTML
   Parameters: {"id"=>"10"}
-  User Load (0.7ms)  SELECT  "users".* FROM "users" WHERE "users"."id" = ? LIMIT ?  [["id", 20], ["LIMIT", 1]]
+  User Load (0.3ms)  SELECT  "users".* FROM "users" WHERE "users"."id" = ? LIMIT ?  [["id", 20], ["LIMIT", 1]]
   ↳ app/controllers/application_controller.rb:9
+  Entry Load (0.3ms)  SELECT "entries".* FROM "entries" WHERE "entries"."user_id" = ?  [["user_id", 20]]
+  ↳ app/controllers/rooms_controller.rb:24
+  Room Load (0.2ms)  SELECT  "rooms".* FROM "rooms" WHERE "rooms"."id" = ? LIMIT ?  [["id", 10], ["LIMIT", 1]]
+  ↳ app/controllers/rooms_controller.rb:31
+  Entry Load (0.5ms)  SELECT "entries".* FROM "entries" WHERE "entries"."user_id" = ? AND "entries"."room_id" = ?  [["user_id", 20], ["room_id", 10]]
+  ↳ app/controllers/rooms_controller.rb:32
+  Notification Load (0.6ms)  SELECT  "notifications".* FROM "notifications" WHERE "notifications"."visited_id" = ? AND "notifications"."room_id" = ? LIMIT ?  [["visited_id", 20], ["room_id", 10], ["LIMIT", 1]]
+  ↳ app/controllers/rooms_controller.rb:51
+Completed 500 Internal Server Error in 144ms (ActiveRecord: 8.7ms)
+NoMethodError (undefined method `update' for nil:NilClass):
+```
+また、`rooms_index.html.erb`を開いた際のログはこちらです。
+```
+app/controllers/rooms_controller.rb:51:in `show'
+Started GET "/rooms/index" for ::1 at 2020-12-15 18:41:37 +0900
+Processing by RoomsController#index as HTML
+  User Load (2.5ms)  SELECT  "users".* FROM "users" WHERE "users"."id" = ? LIMIT ?  [["id", 20], ["LIMIT", 1]]
+  ↳ app/controllers/application_controller.rb:9
   Entry Load (0.4ms)  SELECT "entries".* FROM "entries" WHERE "entries"."user_id" = ?  [["user_id", 20]]
-  ↳ app/controllers/rooms_controller.rb:24
-  Room Load (0.4ms)  SELECT  "rooms".* FROM "rooms" WHERE "rooms"."id" = ? LIMIT ?  [["id", 10], ["LIMIT", 1]]
-  ↳ app/controllers/rooms_controller.rb:31
-  Entry Load (0.7ms)  SELECT "entries".* FROM "entries" WHERE "entries"."user_id" = ? AND "entries"."room_id" = ?  [["user_id", 20], ["room_id", 10]]
-  ↳ app/controllers/rooms_controller.rb:32
-  Notification Load (0.7ms)  SELECT  "notifications".* FROM "notifications" WHERE "notifications"."visited_id" = ? AND "notifications"."action" = ? AND "notifications"."room_id" = ? ORDER BY "notifications"."created_at" DESC LIMIT ? OFFSET ?  [["visited_id", 20], ["action", "message"], ["room_id", 10], ["LIMIT", 1], ["OFFSET", 0]]
-  ↳ app/controllers/rooms_controller.rb:50
-Completed 500 Internal Server Error in 143ms (ActiveRecord: 10.4ms)
-NoMethodError (undefined method `update' for nil:NilClass):
-```
-また、`rooms_index.html.erb`を開いた際のログはこちらです。
-```
-Started GET "/rooms/index" for ::1 at 2020-12-13 23:23:45 +0900
-Processing by RoomsController#index as HTML
-  User Load (0.7ms)  SELECT  "users".* FROM "users" WHERE "users"."id" = ? LIMIT ?  [["id", 20], ["LIMIT", 1]]
-  ↳ app/controllers/application_controller.rb:9
-  Entry Load (0.2ms)  SELECT "entries".* FROM "entries" WHERE "entries"."user_id" = ?  [["user_id", 20]]
-  ↳ app/controllers/rooms_controller.rb:70
-  Notification Load (3.0ms)  SELECT  "notifications".* FROM "notifications" WHERE "notifications"."visited_id" = ? AND "notifications"."action" = ? AND "notifications"."checked" = ? ORDER BY "notifications"."created_at" DESC LIMIT ? OFFSET ?  [["visited_id", 20], ["action", "message"], ["checked", 0], ["LIMIT", 7], ["OFFSET", 0]]
-  ↳ app/controllers/rooms_controller.rb:85
-   (2.2ms)  SELECT COUNT(*) FROM (SELECT  1 AS one FROM "notifications" WHERE "notifications"."visited_id" = ? AND "notifications"."action" = ? AND "notifications"."room_id" IS NULL AND "notifications"."read" = ? ORDER BY "notifications"."created_at" DESC LIMIT ? OFFSET ?) subquery_for_count  [["visited_id", 20], ["action", "message"], ["read", 0], ["LIMIT", 7], ["OFFSET", 0]]
-  ↳ app/controllers/rooms_controller.rb:92
+  ↳ app/controllers/rooms_controller.rb:71
+  Notification Load (0.5ms)  SELECT  "notifications".* FROM "notifications" WHERE "notifications"."visited_id" = ? AND "notifications"."action" = ? AND "notifications"."checked" = ? ORDER BY "notifications"."created_at" DESC LIMIT ? OFFSET ?  [["visited_id", 20], ["action", "message"], ["checked", 0], ["LIMIT", 7], ["OFFSET", 0]]
+  ↳ app/controllers/rooms_controller.rb:86
+   (0.8ms)  SELECT COUNT(*) FROM (SELECT  1 AS one FROM "notifications" WHERE "notifications"."visited_id" = ? AND "notifications"."action" = ? AND "notifications"."room_id" IS NULL AND "notifications"."read" = ? ORDER BY "notifications"."created_at" DESC LIMIT ? OFFSET ?) subquery_for_count  [["visited_id", 20], ["action", "message"], ["read", 0], ["LIMIT", 7], ["OFFSET", 0]]
+  ↳ app/controllers/rooms_controller.rb:93
   Rendering rooms/index.html.erb within layouts/application
-  Entry Load (0.5ms)  SELECT "entries".* FROM "entries" WHERE "entries"."room_id" IN (?, ?) AND (user_id != 20) ORDER BY "entries"."created_at" DESC  [["room_id", 10], ["room_id", 13]]
+  Entry Load (1.6ms)  SELECT "entries".* FROM "entries" WHERE "entries"."room_id" IN (?, ?) AND (user_id != 20) ORDER BY "entries"."created_at" DESC  [["room_id", 10], ["room_id", 13]]
   ↳ app/views/rooms/index.html.erb:11
-  User Load (0.6ms)  SELECT "users".* FROM "users" WHERE "users"."id" IN (?, ?)  [["id", 22], ["id", 13]]
+  User Load (0.5ms)  SELECT "users".* FROM "users" WHERE "users"."id" IN (?, ?)  [["id", 22], ["id", 13]]
   ↳ app/views/rooms/index.html.erb:11
-  Room Load (3.4ms)  SELECT "rooms".* FROM "rooms" WHERE "rooms"."id" IN (?, ?)  [["id", 13], ["id", 10]]
+  Room Load (0.7ms)  SELECT "rooms".* FROM "rooms" WHERE "rooms"."id" IN (?, ?)  [["id", 13], ["id", 10]]
   ↳ app/views/rooms/index.html.erb:11
-   (0.3ms)  SELECT "messages"."id" FROM "messages" WHERE "messages"."room_id" = ?  [["room_id", 13]]
+   (0.4ms)  SELECT "messages"."id" FROM "messages" WHERE "messages"."room_id" = ?  [["room_id", 13]]
   ↳ app/views/rooms/index.html.erb:30
-  Message Load (0.4ms)  SELECT  "messages".* FROM "messages" WHERE "messages"."id" = ? LIMIT ?  [["id", 55], ["LIMIT", 1]]
+  Message Load (0.7ms)  SELECT  "messages".* FROM "messages" WHERE "messages"."id" = ? LIMIT ?  [["id", 55], ["LIMIT", 1]]
   ↳ app/views/rooms/index.html.erb:30
-   (0.4ms)  SELECT "messages"."id" FROM "messages" WHERE "messages"."room_id" = ?  [["room_id", 10]]
+   (0.3ms)  SELECT "messages"."id" FROM "messages" WHERE "messages"."room_id" = ?  [["room_id", 10]]
   ↳ app/views/rooms/index.html.erb:30
-  Message Load (0.2ms)  SELECT  "messages".* FROM "messages" WHERE "messages"."id" IS NULL LIMIT ?  [["LIMIT", 1]]
+  Message Load (0.3ms)  SELECT  "messages".* FROM "messages" WHERE "messages"."id" IS NULL LIMIT ?  [["LIMIT", 1]]
   ↳ app/views/rooms/index.html.erb:30
-  Rendered rooms/index.html.erb within layouts/application (42.9ms)
+  Rendered rooms/index.html.erb within layouts/application (68.2ms)
   CACHE User Load (0.0ms)  SELECT  "users".* FROM "users" WHERE "users"."id" = ? LIMIT ?  [["id", 20], ["LIMIT", 1]]
@@ -310,10 +328,20 @@
   ↳ app/helpers/notifications_helper.rb:47
-   (0.6ms)  SELECT COUNT(*) FROM "notifications" WHERE "notifications"."visited_id" = ? AND "notifications"."action" != ? AND "notifications"."checked" = ?  [["visited_id", 20], ["action", "message"], ["checked", 0]]
+   (1.0ms)  SELECT COUNT(*) FROM "notifications" WHERE "notifications"."visited_id" = ? AND "notifications"."action" != ? AND "notifications"."checked" = ?  [["visited_id", 20], ["action", "message"], ["checked", 0]]
   ↳ app/helpers/notifications_helper.rb:41
-Completed 200 OK in 371ms (Views: 325.4ms | ActiveRecord: 13.1ms)
+Completed 200 OK in 321ms (Views: 260.2ms | ActiveRecord: 10.3ms)
+Started GET "/rooms/js/tag.js" for ::1 at 2020-12-15 18:41:37 +0900
+ActionController::RoutingError (No route matches [GET] "/rooms/js/tag.js"):
-```
+```

「追記」を記入

2020/12/15 09:45

投稿

punchan36

スコア105

test CHANGED Viewed

File without changes

test CHANGED Viewed

@@ -134,14 +134,24 @@
       # 「message」に関する相手からの通知のうち、該当のroom_idを取得し、showを開いた時点でreadをtrueにする。
-      @notifications.find_by(room_id: params[:id]).update_attributes(read: true)
+      @notifications.find_by(room_id: params[:id]).update(read: true)
       # 該当のroom_id内にある未読メッセージの数を取得。
-      @unread = @notifications.find_by(room_id: params[:id]).where(read: false, action: 'message').count
+      @unread = @notifications.where(room_id: params[:id], read: false).count
    end
+   def index
+      @unread = @notifications.where(room_id: params[:id], read: false).count
+   end
 ```
@@ -167,3 +177,143 @@
 RubyGems 3.0.3
 Rails 5.2.3
+### 追記
+上記の記述ですと、`rooms_index.html.erb`は正常に表示されるものの`rooms_show.html.erb`を開くと以下のエラーが表示されます。
+```
+NoMethodError in RoomsController#show
+undefined method `update' for nil:NilClass
+      @notifications.find_by(room_id: params[:id]).update(read: true)
+```
+何かパラメータが上手く渡っていないのか…。その際のログは以下の様になっています。
+```
+Started GET "/rooms/10" for ::1 at 2020-12-13 23:19:49 +0900
+Processing by RoomsController#show as HTML
+  Parameters: {"id"=>"10"}
+  User Load (0.7ms)  SELECT  "users".* FROM "users" WHERE "users"."id" = ? LIMIT ?  [["id", 20], ["LIMIT", 1]]
+  ↳ app/controllers/application_controller.rb:9
+  Entry Load (0.4ms)  SELECT "entries".* FROM "entries" WHERE "entries"."user_id" = ?  [["user_id", 20]]
+  ↳ app/controllers/rooms_controller.rb:24
+  Room Load (0.4ms)  SELECT  "rooms".* FROM "rooms" WHERE "rooms"."id" = ? LIMIT ?  [["id", 10], ["LIMIT", 1]]
+  ↳ app/controllers/rooms_controller.rb:31
+  Entry Load (0.7ms)  SELECT "entries".* FROM "entries" WHERE "entries"."user_id" = ? AND "entries"."room_id" = ?  [["user_id", 20], ["room_id", 10]]
+  ↳ app/controllers/rooms_controller.rb:32
+  Notification Load (0.7ms)  SELECT  "notifications".* FROM "notifications" WHERE "notifications"."visited_id" = ? AND "notifications"."action" = ? AND "notifications"."room_id" = ? ORDER BY "notifications"."created_at" DESC LIMIT ? OFFSET ?  [["visited_id", 20], ["action", "message"], ["room_id", 10], ["LIMIT", 1], ["OFFSET", 0]]
+  ↳ app/controllers/rooms_controller.rb:50
+Completed 500 Internal Server Error in 143ms (ActiveRecord: 10.4ms)
+NoMethodError (undefined method `update' for nil:NilClass):
+```
+また、`rooms_index.html.erb`を開いた際のログはこちらです。
+```
+Started GET "/rooms/index" for ::1 at 2020-12-13 23:23:45 +0900
+Processing by RoomsController#index as HTML
+  User Load (0.7ms)  SELECT  "users".* FROM "users" WHERE "users"."id" = ? LIMIT ?  [["id", 20], ["LIMIT", 1]]
+  ↳ app/controllers/application_controller.rb:9
+  Entry Load (0.2ms)  SELECT "entries".* FROM "entries" WHERE "entries"."user_id" = ?  [["user_id", 20]]
+  ↳ app/controllers/rooms_controller.rb:70
+  Notification Load (3.0ms)  SELECT  "notifications".* FROM "notifications" WHERE "notifications"."visited_id" = ? AND "notifications"."action" = ? AND "notifications"."checked" = ? ORDER BY "notifications"."created_at" DESC LIMIT ? OFFSET ?  [["visited_id", 20], ["action", "message"], ["checked", 0], ["LIMIT", 7], ["OFFSET", 0]]
+  ↳ app/controllers/rooms_controller.rb:85
+   (2.2ms)  SELECT COUNT(*) FROM (SELECT  1 AS one FROM "notifications" WHERE "notifications"."visited_id" = ? AND "notifications"."action" = ? AND "notifications"."room_id" IS NULL AND "notifications"."read" = ? ORDER BY "notifications"."created_at" DESC LIMIT ? OFFSET ?) subquery_for_count  [["visited_id", 20], ["action", "message"], ["read", 0], ["LIMIT", 7], ["OFFSET", 0]]
+  ↳ app/controllers/rooms_controller.rb:92
+  Rendering rooms/index.html.erb within layouts/application
+  Entry Load (0.5ms)  SELECT "entries".* FROM "entries" WHERE "entries"."room_id" IN (?, ?) AND (user_id != 20) ORDER BY "entries"."created_at" DESC  [["room_id", 10], ["room_id", 13]]
+  ↳ app/views/rooms/index.html.erb:11
+  User Load (0.6ms)  SELECT "users".* FROM "users" WHERE "users"."id" IN (?, ?)  [["id", 22], ["id", 13]]
+  ↳ app/views/rooms/index.html.erb:11
+  Room Load (3.4ms)  SELECT "rooms".* FROM "rooms" WHERE "rooms"."id" IN (?, ?)  [["id", 13], ["id", 10]]
+  ↳ app/views/rooms/index.html.erb:11
+   (0.3ms)  SELECT "messages"."id" FROM "messages" WHERE "messages"."room_id" = ?  [["room_id", 13]]
+  ↳ app/views/rooms/index.html.erb:30
+  Message Load (0.4ms)  SELECT  "messages".* FROM "messages" WHERE "messages"."id" = ? LIMIT ?  [["id", 55], ["LIMIT", 1]]
+  ↳ app/views/rooms/index.html.erb:30
+   (0.4ms)  SELECT "messages"."id" FROM "messages" WHERE "messages"."room_id" = ?  [["room_id", 10]]
+  ↳ app/views/rooms/index.html.erb:30
+  Message Load (0.2ms)  SELECT  "messages".* FROM "messages" WHERE "messages"."id" IS NULL LIMIT ?  [["LIMIT", 1]]
+  ↳ app/views/rooms/index.html.erb:30
+  Rendered rooms/index.html.erb within layouts/application (42.9ms)
+  CACHE User Load (0.0ms)  SELECT  "users".* FROM "users" WHERE "users"."id" = ? LIMIT ?  [["id", 20], ["LIMIT", 1]]
+  ↳ app/views/layouts/application.html.erb:39
+   (0.5ms)  SELECT COUNT(*) FROM "notifications" WHERE "notifications"."visited_id" = ? AND "notifications"."checked" = ? AND "notifications"."action" = ?  [["visited_id", 20], ["checked", 0], ["action", "message"]]
+  ↳ app/helpers/notifications_helper.rb:47
+   (0.6ms)  SELECT COUNT(*) FROM "notifications" WHERE "notifications"."visited_id" = ? AND "notifications"."action" != ? AND "notifications"."checked" = ?  [["visited_id", 20], ["action", "message"], ["checked", 0]]
+  ↳ app/helpers/notifications_helper.rb:41
+Completed 200 OK in 371ms (Views: 325.4ms | ActiveRecord: 13.1ms)
+```

rooms_controller.rb及びrooms_index.html.erbを現在の状態に書き直し。

2020/12/13 14:42

投稿

punchan36

スコア105

test CHANGED Viewed

File without changes

test CHANGED Viewed

@@ -124,45 +124,23 @@
-この記述ですと、どの`room`を開いても全ての`message`レコードが`read: true`になってしまいます…。
 ```Ruby
   def show
-      # ログイン中のユーザーが抱える「message」に関する「相手からの通知」を取得。
+      # ログイン中のユーザーが抱える「message」に関する相手からの通知を取得。
       @notifications = @current_user.passive_notifications.where(action: 'message').includes([:visitor], [:visited]).order(created_at: :desc).page(params[:page]).per(7)
-      @notifications.where(read: false).each do |notification|
+      # 「message」に関する相手からの通知のうち、該当のroom_idを取得し、showを開いた時点でreadをtrueにする。
-        # rooms/:idを表示した時点で、それらのレコードを確認済み(checked: true)に変更。
+      @notifications.find_by(room_id: params[:id]).update_attributes(read: true)
-        notification.update_attributes(read: true)
+      # 該当のroom_id内にある未読メッセージの数を取得。
-      end
+      @unread = @notifications.find_by(room_id: params[:id]).where(read: false, action: 'message').count
    end
-```
-### notifications_helper.rb
-この記述ですと、未読メッセージが全部でいくつあるかが取得され、各room内における個別の件数が分かりません。
-```Ruby
-    #ログイン中のユーザーに、「message」に関する未読(=read: false)の通知が「いくつあるか」を判別。
-    def unread_message_notifications_count
-      @unread = @current_user.passive_notifications.where(read: false, action: 'message').count
-    end
 ```
@@ -174,7 +152,7 @@
 ```Rails
-     <%= unread_message_notifications_count %>
+     <%= @unread %>
 ```

helper.rb内、index.html.erb内の記述を編集。

2020/12/13 10:39

投稿

punchan36

スコア105

test CHANGED Viewed

File without changes

test CHANGED Viewed

@@ -156,13 +156,13 @@
 ```Ruby
-   #ログイン中のユーザーに、「message」に関する未読(=checked: false)の通知が「いくつあるか」を判別。
+    #ログイン中のユーザーに、「message」に関する未読(=read: false)の通知が「いくつあるか」を判別。
-   def unchecked_message_notifications_count
+    def unread_message_notifications_count
-     @m_notifications = @current_user.passive_notifications.where(checked: false, action: 'message').count
+      @unread = @current_user.passive_notifications.where(read: false, action: 'message').count
-   end
+    end
 ```
@@ -174,11 +174,7 @@
 ```Rails
-   <% if message_id.notification.read = 'false' %>
-     <%= unchecked_message_notifications_count %>
+     <%= unread_message_notifications_count %>
-   <% end %>
 ```