常連

```python
import numpy as np
import pygame
import os

BLACK = (0,0,0)
WHITE = (255,255,255)
GLAY = (100,100,100)
SKYBLUE = (100,200,300)
BROWN = (100,500,0)
GREEN = (0,255,0)
red = (255,0,0)
width = 1000
height = 1000

pygame.init()

screen = pygame.display.set_mode((width,height))
myclock = pygame.time.Clock()
myfont_small_small=pygame.font.Font(None,16)
myfont_small=pygame.font.Font(None,32)
myfont=pygame.font.Font(None,64)
myfont_big=pygame.font.Font(None,100)
myfont_big_big=pygame.font.Font(None,200)

scare = 1/20000
time_per_flame = 1

display_position_x = 0
display_position_y = 0


gravitational_constant = 6.667e-11

def absolute_path_maker(relative_path):
    """making absolute path　images\????.png"""
    return os.path.join(os.getcwd(), relative_path)

def to_vector(before):
    aspect = before[0]
    power = before[1]
    value = ((power**2)/(aspect[0]**2 + aspect[1]**2))**(1/2)
    return_val = np.array([aspect[0] * value,aspect[1] * value])
    del value
    del power
    del aspect
    return return_val

class heavenly_body:
    def __init__(self,position_x,position_y,mass,initial_acceleration):
        """the position unit must be "m".the mass unit must be "kg"."""
        self.position_x = position_x
        self.position_y = position_y
        self.speed = np.array([0,0])
        self.acceleration = np.array([0,0])
        self.acceleration_list = {(0,0):0}#the unit is "m/s"
        self.acceleration_list = {}
        self.power = {(0,0):0}#the unit is "N"
        self.power = {}
        self.mass = mass
        for direction,power in initial_acceleration.items():
            self.acceleration_list[direction] = power
    def update(self,group):
        global time_per_flame
        global gravitational_constant
        for ins in group:
            if ins.cla != self:
                distance_x = ins.cla.position_x - self.position_x
                distance_y = ins.cla.position_y - self.position_y
                self.distance = ((distance_x ** 2) + (distance_y ** 2)) ** (1/2)
                power = ((self.mass * ins.cla.mass)/(self.distance ** 2))*gravitational_constant
                ins.cla.power[(-distance_x,-distance_y)] = (time_per_flame**2) * power
        for directions,power in self.power.items():
            self.acceleration_list[directions] = power/self.mass
        self.power = {}
        self.acceleration = np.array([0,0])
        for aspect,power in self.acceleration_list.items():
            self.acceleration = self.acceleration + to_vector([aspect,power])
        self.speed = self.speed + time_per_flame * self.acceleration
        self.acceleration_list = {}
        self.position_x += time_per_flame * self.speed[0]
        self.position_y += time_per_flame * self.speed[1]

class heavenly_body_pygame(pygame.sprite.Sprite):
    def __init__(self,position_x,position_y,mass,initial_acceleration = {(1,1):0},planet_image_path = "images\main.png"):
        global scare
        pygame.sprite.Sprite.__init__(self)
        self.image = pygame.image.load(absolute_path_maker(planet_image_path))
        self.rect = self.image.get_rect()
        self.rect.centerx = int(position_x * scare)
        self.rect.centery = int(position_y * scare)
        global heavenly_body
        self.cla = heavenly_body(position_x,position_y,mass,initial_acceleration)
    def update(self,group):
        global scare
        global display_position_x
        global display_position_y
        self.cla.update(group.sprites())
        next_position_x = self.cla.position_x
        next_position_y = self.cla.position_y
        next_position_x = next_position_x * scare
        next_position_y = next_position_y * scare
        next_position_x += display_position_x
        next_position_y += display_position_y
        next_position_x = int(next_position_x)
        next_position_y = int(next_position_y)
        self.rect.centerx = next_position_x
        self.rect.centery = next_position_y

star = heavenly_body_pygame(10000000,10000000,5.972e+20,{(0,-1):0},"images\sun.png")
planet = heavenly_body_pygame(10000000,13758000,7.347e+18,{(-1,0):102},"images\e.png")
planet2 = heavenly_body_pygame(10000000,3000000,7.347e+18,{(-1,0):30},"images\c.png")
planet3 = heavenly_body_pygame(10000000, 9000000, 1e+18, {(1,0):130},"images\m.png")
planet4 = heavenly_body_pygame(10000000, 20000000, 1e+19, {(-1,0):50},"images\j.png")
planet5 = heavenly_body_pygame(10000000, 8000000, 1e+10, {(-1,0):150},"images\s.png")
planets = pygame.sprite.Group()
planets.add(planet)
planets.add(star)
planets.add(planet2)
planets.add(planet3)
planets.add(planet4)
planets.add(planet5)
state = "title"

key_pressing = []

while state == "title":
    for event in pygame.event.get():
        if event.type == pygame.QUIT:
            state = "end"
        if event.type == pygame.KEYUP:
            if event.key == pygame.K_SPACE:
                state = "normal"
while state != "end":
    screen.fill((0,0,0))
    for i in range(60):
        planets.update(planets)
    planets.draw(screen)
    pygame.display.flip()
    for event in pygame.event.get():
        if event.type == pygame.QUIT:
            state = "end"
        if event.type == pygame.KEYDOWN:
            if event.key == pygame.K_LEFT:
                key_pressing.append("left")
            if event.key == pygame.K_RIGHT:
                key_pressing.append("right")
            if event.key == pygame.K_UP:
                key_pressing.append("up")
            if event.key == pygame.K_DOWN:
                key_pressing.append("down")
            if event.key == pygame.K_LCTRL:
                key_pressing.append("lctrl")
            if event.key == pygame.K_RCTRL:
                key_pressing.append("rctrl")
        if event.type == pygame.KEYUP:
            if event.key == pygame.K_LEFT:
                key_pressing.remove("left")
            if event.key == pygame.K_RIGHT:
                key_pressing.remove("right")
            if event.key == pygame.K_UP:
                key_pressing.remove("up")
            if event.key == pygame.K_DOWN:
                key_pressing.remove("down")
            if event.key == pygame.K_LCTRL:
                key_pressing.remove("lctrl")
            if event.key == pygame.K_RCTRL:
                key_pressing.remove("rctrl")
            if event.key == pygame.K_SPACE:
                if ("lctrl" in key_pressing) or ("rctrl" in key_pressing):
                    scare = scare / 2
                    display_position_x = display_position_x / 2
                    display_position_y = display_position_y / 2
                    display_position_x = display_position_x + width / 4
                    display_position_y = display_position_y + height / 4
                else:
                    scare = scare * 2
                    display_position_x = display_position_x * 2 
                    display_position_y = display_position_y * 2
                    display_position_x = display_position_x - width / 2
                    display_position_y = display_position_y - height / 2
    for i in key_pressing:
        if i == "left":
            display_position_x += 10
        if i == "right":
            display_position_x -= 10
        if i == "up":
            display_position_y += 10
        if i == "down":
            display_position_y -= 10
    myclock.tick(60)
pygame.quit()

```
pythonで、天体について書いてみたのですが、
このコードは良いコードですか？
そもそも物理法則的に間違っていたらそれについても教えていただけないでしょうか？

```python
import numpy as np
import pygame
import os

BLACK = (0,0,0)
WHITE = (255,255,255)
GLAY = (100,100,100)
SKYBLUE = (100,200,300)
BROWN = (100,500,0)
GREEN = (0,255,0)
red = (255,0,0)
width = 1000
height = 1000

pygame.init()

screen = pygame.display.set_mode((width,height))
myclock = pygame.time.Clock()
myfont_small_small=pygame.font.Font(None,16)
myfont_small=pygame.font.Font(None,32)
myfont=pygame.font.Font(None,64)
myfont_big=pygame.font.Font(None,100)
myfont_big_big=pygame.font.Font(None,200)

scare = 1/20000
time_per_flame = 1

display_position_x = 0
display_position_y = 0


gravitational_constant = 6.667e-11

def absolute_path_maker(relative_path):
    """making absolute path　images\????.png"""
    return os.path.join(os.getcwd(), relative_path)

def to_vector(before):
    aspect = before[0]
    power = before[1]
    value = ((power**2)/(aspect[0]**2 + aspect[1]**2))**(1/2)
    return_val = np.array([aspect[0] * value,aspect[1] * value])
    del value
    del power
    del aspect
    return return_val

class heavenly_body:
    def __init__(self,position_x,position_y,mass,initial_acceleration):
        """the position unit must be "m".the mass unit must be "kg"."""
        self.position_x = position_x
        self.position_y = position_y
        self.speed = np.array([0,0])
        self.acceleration = np.array([0,0])
        self.acceleration_list = {(0,0):0}#the unit is "m/s"
        self.acceleration_list = {}
        self.power = {(0,0):0}#the unit is "N"
        self.power = {}
        self.mass = mass
        for direction,power in initial_acceleration.items():
            self.acceleration_list[direction] = power
    def update(self,group):
        global time_per_flame
        global gravitational_constant
        for ins in group:
            if ins.cla != self:
                distance_x = ins.cla.position_x - self.position_x
                distance_y = ins.cla.position_y - self.position_y
                self.distance = ((distance_x ** 2) + (distance_y ** 2)) ** (1/2)
                power = ((self.mass * ins.cla.mass)/(self.distance ** 2))*gravitational_constant
                ins.cla.power[(-distance_x,-distance_y)] = (time_per_flame**2) * power
        for directions,power in self.power.items():
            self.acceleration_list[directions] = power/self.mass
        self.power = {}
        self.acceleration = np.array([0,0])
        for aspect,power in self.acceleration_list.items():
            self.acceleration = self.acceleration + to_vector([aspect,power])
        self.speed = self.speed + time_per_flame * self.acceleration
        self.acceleration_list = {}
        self.position_x += time_per_flame * self.speed[0]
        self.position_y += time_per_flame * self.speed[1]

class heavenly_body_pygame(pygame.sprite.Sprite):
    def __init__(self,position_x,position_y,mass,initial_acceleration = {(1,1):0},planet_image_path = "images\main.png"):
        global scare
        pygame.sprite.Sprite.__init__(self)
        self.image = pygame.image.load(absolute_path_maker(planet_image_path))
        self.rect = self.image.get_rect()
        self.rect.centerx = int(position_x * scare)
        self.rect.centery = int(position_y * scare)
        global heavenly_body
        self.cla = heavenly_body(position_x,position_y,mass,initial_acceleration)
    def update(self,group):
        global scare
        global display_position_x
        global display_position_y
        self.cla.update(group.sprites())
        next_position_x = self.cla.position_x
        next_position_y = self.cla.position_y
        next_position_x = next_position_x * scare
        next_position_y = next_position_y * scare
        next_position_x += display_position_x
        next_position_y += display_position_y
        next_position_x = int(next_position_x)
        next_position_y = int(next_position_y)
        self.rect.centerx = next_position_x
        self.rect.centery = next_position_y

star = heavenly_body_pygame(10000000,10000000,5.972e+20,{(0,-1):0},"images\sun.png")
planet = heavenly_body_pygame(10000000,13758000,7.347e+18,{(-1,0):102},"images\e.png")
planet2 = heavenly_body_pygame(10000000,3000000,7.347e+18,{(-1,0):30},"images\c.png")
planet3 = heavenly_body_pygame(10000000, 9000000, 1e+18, {(1,0):130},"images\m.png")
planet4 = heavenly_body_pygame(10000000, 20000000, 1e+19, {(-1,0):50},"images\j.png")
planet5 = heavenly_body_pygame(10000000, 8000000, 1e+10, {(-1,0):150},"images\s.png")
planets = pygame.sprite.Group()
planets.add(planet)
planets.add(star)
planets.add(planet2)
planets.add(planet3)
planets.add(planet4)
planets.add(planet5)
state = "title"

key_pressing = []

while state == "title":
    for event in pygame.event.get():
        if event.type == pygame.QUIT:
            state = "end"
        if event.type == pygame.KEYUP:
            if event.key == pygame.K_SPACE:
                state = "normal"
while state != "end":
    screen.fill((0,0,0))
    for i in range(60):
        planets.update(planets)
    planets.draw(screen)
    pygame.display.flip()
    for event in pygame.event.get():
        if event.type == pygame.QUIT:
            state = "end"
        if event.type == pygame.KEYDOWN:
            if event.key == pygame.K_LEFT:
                key_pressing.append("left")
            if event.key == pygame.K_RIGHT:
                key_pressing.append("right")
            if event.key == pygame.K_UP:
                key_pressing.append("up")
            if event.key == pygame.K_DOWN:
                key_pressing.append("down")
            if event.key == pygame.K_LCTRL:
                key_pressing.append("lctrl")
            if event.key == pygame.K_RCTRL:
                key_pressing.append("rctrl")
        if event.type == pygame.KEYUP:
            if event.key == pygame.K_LEFT:
                key_pressing.remove("left")
            if event.key == pygame.K_RIGHT:
                key_pressing.remove("right")
            if event.key == pygame.K_UP:
                key_pressing.remove("up")
            if event.key == pygame.K_DOWN:
                key_pressing.remove("down")
            if event.key == pygame.K_LCTRL:
                key_pressing.remove("lctrl")
            if event.key == pygame.K_RCTRL:
                key_pressing.remove("rctrl")
            if event.key == pygame.K_SPACE:
                if ("lctrl" in key_pressing) or ("rctrl" in key_pressing):
                    scare = scare / 2
                    display_position_x = display_position_x / 2
                    display_position_y = display_position_y / 2
                    display_position_x = display_position_x + width / 4
                    display_position_y = display_position_y + height / 4
                else:
                    scare = scare * 2
                    display_position_x = display_position_x * 2 
                    display_position_y = display_position_y * 2
                    display_position_x = display_position_x - width / 2
                    display_position_y = display_position_y - height / 2
    for i in key_pressing:
        if i == "left":
            display_position_x += 10
        if i == "right":
            display_position_x -= 10
        if i == "up":
            display_position_y += 10
        if i == "down":
            display_position_y -= 10
    myclock.tick(60)
pygame.quit()

```
pythonで、天体について書いてみたのですが、
このコードは良いコードですか？
そもそも物理法則的に間違っていたらそれについたも教えていただけないでしょうか？

@@ -390,4 +390,4 @@
 このコードは良いコードですか？
-そもそも物理法則的に間違っていたらそれについたも教えていただけないでしょうか？
+そもそも物理法則的に間違っていたらそれについても教えていただけないでしょうか？

質問編集履歴