編集履歴

質問編集履歴

コード更新

2020/06/02 07:19

投稿

junnnnchan

スコア26

test CHANGED Viewed

File without changes

test CHANGED Viewed

@@ -156,7 +156,7 @@
 	Country[] countries = new Country[1000];
-	Country[] gold , silver , bronze;
+//	Country[] gold , silver , bronze;
@@ -168,15 +168,15 @@
 				//country = new String[NUM_OF_COUNTRIES];
-				gold = new Country[countries.length];
+//				gold = new Country[countries.length];
-				silver = new Country[countries.length];
+//				silver = new Country[countries.length];
-				bronze = new Country[countries.length];
+//				bronze = new Country[countries.length];
+//
-		next = 0;
+	//	next = 0;
 	}

エラー文の追加

2020/06/02 07:19

投稿

junnnnchan

スコア26

test CHANGED Viewed

File without changes

test CHANGED Viewed

@@ -380,6 +380,18 @@
 ```
+ーーーーーーーーーーーーーーーーーーーーーーーーーーーーーーーーーーーーーーーーー
+エラー文
+Exception in thread "main" java.lang.NullPointerException
+	at medals1.Ranking.addMedal(Ranking.java:57)
+	at medals1.Competition.main(Competition.java:15)
+----------------------------------------------------------------------------------
 Rankingクラスで国名やメダル情報を格納していたメンバ変数を廃止して、代わりにCountryクラスの配列変数countriesを宣言して、これを使用するように書き換えたいです。
 アバウトな説明ですが、アドバイスよろしくお願いします。

更新

2020/06/02 06:49

投稿

junnnnchan

スコア26

test CHANGED Viewed

File without changes

test CHANGED Viewed

@@ -146,16 +146,18 @@
 	// メンバ変数宣言部分
-//	final int NUM_OF_COUNTRIES = 1000;
+	//	final int NUM_OF_COUNTRIES = 1000;
-//	String[] country;
+	//	String[] country;
-//	int[] gold, silver, bronze;
+	//	int[] gold, silver, bronze;
 	int next;
 	Country[] countries = new Country[1000];
+	Country[] gold , silver , bronze;
@@ -164,15 +166,15 @@
 	public Ranking() {
-//		country = new String[NUM_OF_COUNTRIES];
+				//country = new String[NUM_OF_COUNTRIES];
-//		gold = new int[country.length];
+				gold = new Country[countries.length];
-//		silver = new int[country.length];
+				silver = new Country[countries.length];
-//		bronze = new int[country.length];
+				bronze = new Country[countries.length];
-		Country gold = gold;
 		next = 0;
@@ -196,109 +198,109 @@
 		for (int i = next - 1; i >= 0; i--) {
-			if (countries[i].equals(countryName)) {
+			if (countries[i].name.equals(countryName)) {
 				return i;
 			}
-				countries[i] = new Country(countryName);
+			countries[i] = new Country(countryName);
+		}
+		return -1;
+	}
+	/**
+	 * IOCコードで指定された国に指定された色のメダルを1つ追加
+	 * @param countryName 国(3文字のIOCコード)
+	 * @param color メダルの色
+	 */
+	public void addMedal(String countryName, Color color) {
+		// addMedal前半部分
+		int index = indexOfCountry(countryName);
+		if (index < 0) {
+			countries[next].name = countryName;
+			index = next;
+			next ++;
+		}
+		// addMedal後半部分
+		if (color == Color.Gold) {
+			countries[index].gold++;
+		} else if (color == Color.Silver) {
+			countries[index].silver++;
+		} else if (color == Color.Bronze) {
+			countries[index].bronze++;
+		}
+	}
+	// sortResultsメソッド部分
+	public void sortResults() {
+		for (int i = 1; i < countries.length && countries[i] != null; i++) {
+			int j = i - 1;
+			String c = countries[i].name;
+			int g = countries[i].gold;
+			int s = countries[i].silver;
+			int b = countries[i].bronze;
+			while (j >= 0 && c.compareTo(countries[j].name) < 0) {
+				countries[j+1].name = countries[j].name;
+				countries[j+1].gold = countries[j].gold;
+				countries[j+1].silver = countries[j].silver;
+				countries[j+1].bronze = countries[j].bronze;
+				j--;
 			}
-		return -1;
-	}
-	/**
-	 * IOCコードで指定された国に指定された色のメダルを1つ追加
-	 * @param countryName 国(3文字のIOCコード)
-	 * @param color メダルの色
-	 */
-	public void addMedal(String countryName, Color color) {
-		// addMedal前半部分
-		int index = indexOfCountry(countryName);
-		if (index < 0) {
-			countries[next] = countryName;
-			index = next;
-			next ++;
-		}
-		// addMedal後半部分
-		if (color == Color.Gold) {
-			gold[index]++;
-		} else if (color == Color.Silver) {
-			silver[index]++;
-		} else if (color == Color.Bronze) {
-			bronze[index]++;
-		}
-	}
-	// sortResultsメソッド部分
-	public void sortResults() {
-		for (int i = 1; i < country.length && country[i] != null; i++) {
-			int j = i - 1;
-			String c = countries[i];
-			int g = gold[i];
-			int s = silver[i];
-			int b = bronze[i];
-			while (j >= 0 && c.compareTo(countries[j]) < 0) {
-				countries[j+1] = countries[j];
-				gold[j+1] = gold[j];
-				silver[j+1] = silver[j];
-				bronze[j+1] = bronze[j];
-				j--;
-			}
 			j++;
-			countries[j] = c;
+			countries[j].name = c;
-			gold[j] = g;
-			silver[j] = s;
-			bronze[j] = b;
+			countries[j].gold = g;
+			countries[j].silver = s;
+			countries[j].bronze = b;
 		}
@@ -314,19 +316,19 @@
 		for (int i = 0; i < countries.length && countries[i] != null; i++) {
-			System.out.print(countries[i]);
+			System.out.print(countries[i].name);
-			int sum = gold[i];
+			int sum = countries[i].gold;
-			System.out.print("(" + gold[i]);
-			sum += silver[i];
-			System.out.print("," + silver[i]);
-			sum += bronze[i];
-			System.out.print("," + bronze[i]);
+			System.out.print("(" + countries[i].gold);
+			sum += countries[i].silver;
+			System.out.print("," + countries[i].silver);
+			sum += countries[i].bronze;
+			System.out.print("," + countries[i].bronze);
 			System.out.println(")[" + sum + "]");
@@ -342,6 +344,8 @@
 ```
 ```