編集履歴

質問編集履歴

誤字修正

2020/02/21 12:17

投稿

duck015

スコア29

test CHANGED Viewed

File without changes

test CHANGED Viewed

@@ -300,8 +300,6 @@
     var presenter: QuestionListViewPresenter!
-    var itemInfo: IndicatorInfo = "新着"
     override func viewDidLoad() {

文字修正

2020/02/21 12:17

投稿

duck015

スコア29

test CHANGED Viewed

File without changes

test CHANGED Viewed

@@ -268,268 +268,138 @@
 ```
-```QuestionListViewPresenter
-class QuestionListViewPresenter {
-    private weak var view: ListViewInterface!
-    var questionModel: QuestionModel!
-    var likeModel = LikeModel()
-    var numberOfQuestions: Int {
-        return questionModel?.questions.count ?? 10
-    }
-    init(view: ListViewInterface) {
-        self.view = view
-        self.questionModel = QuestionModel()
-        self.questionModel.addObserver(self, selector: #selector(self.updated))
-    }
+```NewArrivalQuestionListViewController
+protocol ListViewInterface: class {
+    func reloadData()
+    func navigateDetail(entity: QuestionEntity)
+}
+protocol LikeInterface: class {
+    var questionId: Int { get }
+}
+class NewArrivalQuestionListViewController: UIViewController, ListViewInterface {
+    @IBOutlet weak var newArrivalQuestionListTableView: UITableView!
+    var presenter: QuestionListViewPresenter!
+    var itemInfo: IndicatorInfo = "新着"
+    override func viewDidLoad() {
+        super.viewDidLoad()
+        initializePresenter()
+        initializeTableView()
+        newArrivalQuestionListTableView.refreshControl = UIRefreshControl()
+        newArrivalQuestionListTableView.refreshControl?.addTarget(self, action: #selector(self.updateQuestions), for: .valueChanged)
+        print("didload")
+    }
+    override func viewWillAppear(_ animated: Bool) {
+        super.viewWillAppear(true)
+        updateQuestions()
+        print("willappear")
+    }
+    func initializeTableView() {
+        newArrivalQuestionListTableView.delegate = self
+        newArrivalQuestionListTableView.dataSource = self
+        newArrivalQuestionListTableView.register(UINib(nibName: "QuestionListTableViewCell", bundle: nil), forCellReuseIdentifier: "QuestionListTableViewCell")
+    }
+    func initializePresenter() {
+        presenter = QuestionListViewPresenter(view: self)
+    }
+    func reloadData() {
+        newArrivalQuestionListTableView.refreshControl?.endRefreshing()
+        newArrivalQuestionListTableView.reloadData()
+        print("リロード")
+    }
+    func navigateDetail(entity: QuestionEntity) {
+        let questoinDetailViewController = QuestionDetailViewController(entity: entity)
+        self.navigationController?.pushViewController(questoinDetailViewController, animated: true)
+       }
     @objc func updateQuestions() {
-        questionModel.fetchNewArivalQuestions()
+        presenter.updateQuestions()
-        print("presenter")
+        newArrivalQuestionListTableView.refreshControl?.beginRefreshing()
-    }
+    }
-    func entity(at indexPath: IndexPath) -> QuestionEntity {
+    @objc func likeButtonTapped(_ sender: UIButton, forEvent event: UIEvent) {
+        let touch = event.allTouches?.first
-        return questionModel.questions[indexPath.row]
+        let point = touch!.location(in: self.newArrivalQuestionListTableView)
-    }
-    func didSelectRow(at indexPath: IndexPath) {
-        view?.navigateDetail(entity: questionModel.questions[indexPath.row])
+        let indexPath = newArrivalQuestionListTableView.indexPathForRow(at: point)!
-    }
-    @objc func updated() {
-        view?.reloadData()
-    }
-    func likeButtonTapped(at indexPath: IndexPath) {
+        presenter.likeButtonTapped(at: indexPath)
-        likeModel.updateLikesData(id: questionModel.questions[indexPath.row].id)
     }
 }
 ```
-```NewArrivalQuestionListViewController
-protocol ListViewInterface: class {
-    func reloadData()
-    func navigateDetail(entity: QuestionEntity)
-}
-protocol LikeInterface: class {
-    var questionId: Int { get }
-}
-class NewArrivalQuestionListViewController: UIViewController, ListViewInterface {
-    @IBOutlet weak var newArrivalQuestionListTableView: UITableView!
-    var presenter: QuestionListViewPresenter!
-    var itemInfo: IndicatorInfo = "新着"
-    override func viewDidLoad() {
-        super.viewDidLoad()
-        initializePresenter()
-        initializeTableView()
-        newArrivalQuestionListTableView.refreshControl = UIRefreshControl()
-        newArrivalQuestionListTableView.refreshControl?.addTarget(self, action: #selector(self.updateQuestions), for: .valueChanged)
-        print("didload")
-    }
-    override func viewWillAppear(_ animated: Bool) {
-        super.viewWillAppear(true)
-        updateQuestions()
-        print("willappear")
-    }
-    func initializeTableView() {
-        newArrivalQuestionListTableView.delegate = self
-        newArrivalQuestionListTableView.dataSource = self
-        newArrivalQuestionListTableView.register(UINib(nibName: "QuestionListTableViewCell", bundle: nil), forCellReuseIdentifier: "QuestionListTableViewCell")
-    }
-    func initializePresenter() {
-        presenter = QuestionListViewPresenter(view: self)
-    }
-    func reloadData() {
-        newArrivalQuestionListTableView.refreshControl?.endRefreshing()
-        newArrivalQuestionListTableView.reloadData()
-        print("リロード")
-    }
-    func navigateDetail(entity: QuestionEntity) {
-        let questoinDetailViewController = QuestionDetailViewController(entity: entity)
-        self.navigationController?.pushViewController(questoinDetailViewController, animated: true)
-       }
-    @objc func updateQuestions() {
-        presenter.updateQuestions()
-        newArrivalQuestionListTableView.refreshControl?.beginRefreshing()
-    }
-    @objc func likeButtonTapped(_ sender: UIButton, forEvent event: UIEvent) {
-        let touch = event.allTouches?.first
-        let point = touch!.location(in: self.newArrivalQuestionListTableView)
-        let indexPath = newArrivalQuestionListTableView.indexPathForRow(at: point)!
-        presenter.likeButtonTapped(at: indexPath)
-    }
-}
-extension NewArrivalQuestionListViewController: UITableViewDelegate, UITableViewDataSource {
-    func tableView(_ tableView: UITableView, numberOfRowsInSection section: Int) -> Int {
-        return presenter.numberOfQuestions
-    }
-    func tableView(_ tableView: UITableView, cellForRowAt indexPath: IndexPath) -> UITableViewCell {
-        let cell = newArrivalQuestionListTableView.dequeueReusableCell(withIdentifier: "QuestionListTableViewCell", for: indexPath) as! QuestionListTableViewCell
-        cell.setQuestion(entity: presenter.entity(at: indexPath))
-        cell.likeButton.addTarget(self, action: #selector(likeButtonTapped(_:forEvent:)), for: .touchUpInside)
-        return cell
-    }
-    func tableView(_ tableView: UITableView, didSelectRowAt indexPath: IndexPath) {
-        newArrivalQuestionListTableView.deselectRow(at: indexPath, animated: true)
-        presenter.didSelectRow(at: indexPath)
-    }
-}
-extension NewArrivalQuestionListViewController: IndicatorInfoProvider {
-    func indicatorInfo(for pagerTabStripController: PagerTabStripViewController) -> IndicatorInfo {
-            return itemInfo
-        }
-}
-```

誤字修正

2020/02/21 12:15

投稿

duck015

スコア29

test CHANGED Viewed

File without changes

test CHANGED Viewed

@@ -130,406 +130,406 @@
 ```
+```QuestionModel
+class QuestionModel {
+    var questions: [QuestionEntity] = []
+    var notificationName: Notification.Name {
+        return Notification.Name(rawValue: "questions")
+    }
+    func fetchNewArivalQuestions() {
+        print("fetch")
+        Alamofire.request("https://teratail.com/api/v1/questions").responseJSON { response in
+            self.questions = []
+            guard let object = response.result.value else { return }
+            let json = JSON(object)
+            json["questions"].forEach { (_, json) in
+                let id = json["id"].intValue
+                let title = json["title"].stringValue
+                let tags = json["tags"].arrayObject
+                let displayName = json["user"]["display_name"].stringValue
+                let photo = json["user"]["photo"].stringValue
+                let created = json["created"].stringValue
+                let isAccepted = json["is_accepted"].boolValue
+                self.questions.append(QuestionEntity(id: id, title: title, tags: tags as! [String], displayName: displayName, photo: photo, created: created, isAccepted: isAccepted))
+            }
+            self.notify()
+            print("通知")
+        }
+    }
+    func addObserver(_ observer: Any, selector: Selector) {
+        NotificationCenter.default.addObserver(observer, selector: selector, name: notificationName, object: nil)
+    }
+    func removeObserver(_ observer: Any) {
+        NotificationCenter.default.removeObserver(observer)
+    }
+    func notify() {
+        NotificationCenter.default.post(name: notificationName, object: nil)
+    }
+}
 ```
-class QuestionModel {
+```QuestionListTableViewCell
+class QuestionListTableViewCell: UITableViewCell {
+    @IBOutlet weak var photoImageView: UIImageView!
+    @IBOutlet weak var displayNameLabel: UILabel!
+    @IBOutlet weak var createdLabel: UILabel!
+    @IBOutlet weak var titleLabel: UILabel!
+    @IBOutlet weak var likeButton: UIButton!
+    @IBOutlet weak var tagsLabel: UILabel!
+    @IBOutlet weak var isAcceptedLabel: UILabel!
-    var questions: [QuestionEntity] = []
+    func setQuestion(entity: QuestionEntity) {
-    var notificationName: Notification.Name {
+        self.displayNameLabel.text = entity.displayName
+//        Likeボタンの表示
+        if entity.isLiked == true {
+            likeButton.setImage(UIImage(systemName: "star.fill"), for: .normal)
+            print("starfill")
+        } else {
-        return Notification.Name(rawValue: "questions")
+            likeButton.setImage(UIImage(systemName: "star"), for: .normal)
-    }
-    func fetchNewArivalQuestions() {
-        print("fetch")
+            print("star")
-        Alamofire.request("https://teratail.com/api/v1/questions").responseJSON { response in
-            self.questions = []
-            guard let object = response.result.value else { return }
-            let json = JSON(object)
-            json["questions"].forEach { (_, json) in
-                let id = json["id"].intValue
-                let title = json["title"].stringValue
-                let tags = json["tags"].arrayObject
-                let displayName = json["user"]["display_name"].stringValue
-                let photo = json["user"]["photo"].stringValue
-                let created = json["created"].stringValue
-                let isAccepted = json["is_accepted"].boolValue
-                self.questions.append(QuestionEntity(id: id, title: title, tags: tags as! [String], displayName: displayName, photo: photo, created: created, isAccepted: isAccepted))
-            }
-            self.notify()
-            print("通知")
         }
     }
-    func addObserver(_ observer: Any, selector: Selector) {
-        NotificationCenter.default.addObserver(observer, selector: selector, name: notificationName, object: nil)
-    }
-    func removeObserver(_ observer: Any) {
-        NotificationCenter.default.removeObserver(observer)
-    }
-    func notify() {
-        NotificationCenter.default.post(name: notificationName, object: nil)
-    }
 }
 ```
-```QuestionListTableViewCell
+```QuestionListViewPresenter
-class QuestionListTableViewCell: UITableViewCell {
+class QuestionListViewPresenter {
+    private weak var view: ListViewInterface!
+    var questionModel: QuestionModel!
+    var likeModel = LikeModel()
+    var numberOfQuestions: Int {
+        return questionModel?.questions.count ?? 10
+    }
+    init(view: ListViewInterface) {
+        self.view = view
+        self.questionModel = QuestionModel()
+        self.questionModel.addObserver(self, selector: #selector(self.updated))
+    }
+    @objc func updateQuestions() {
+        questionModel.fetchNewArivalQuestions()
+        print("presenter")
+    }
+    func entity(at indexPath: IndexPath) -> QuestionEntity {
+        return questionModel.questions[indexPath.row]
+    }
+    func didSelectRow(at indexPath: IndexPath) {
+        view?.navigateDetail(entity: questionModel.questions[indexPath.row])
+    }
+    @objc func updated() {
+        view?.reloadData()
+    }
+    func likeButtonTapped(at indexPath: IndexPath) {
+        likeModel.updateLikesData(id: questionModel.questions[indexPath.row].id)
+    }
+}
+```
+```NewArrivalQuestionListViewController
+protocol ListViewInterface: class {
+    func reloadData()
+    func navigateDetail(entity: QuestionEntity)
+}
+protocol LikeInterface: class {
+    var questionId: Int { get }
+}
+class NewArrivalQuestionListViewController: UIViewController, ListViewInterface {
+    @IBOutlet weak var newArrivalQuestionListTableView: UITableView!
+    var presenter: QuestionListViewPresenter!
+    var itemInfo: IndicatorInfo = "新着"
+    override func viewDidLoad() {
+        super.viewDidLoad()
+        initializePresenter()
+        initializeTableView()
+        newArrivalQuestionListTableView.refreshControl = UIRefreshControl()
+        newArrivalQuestionListTableView.refreshControl?.addTarget(self, action: #selector(self.updateQuestions), for: .valueChanged)
+        print("didload")
+    }
+    override func viewWillAppear(_ animated: Bool) {
+        super.viewWillAppear(true)
+        updateQuestions()
+        print("willappear")
-    @IBOutlet weak var photoImageView: UIImageView!
-    @IBOutlet weak var displayNameLabel: UILabel!
-    @IBOutlet weak var createdLabel: UILabel!
-    @IBOutlet weak var titleLabel: UILabel!
-    @IBOutlet weak var likeButton: UIButton!
-    @IBOutlet weak var tagsLabel: UILabel!
-    @IBOutlet weak var isAcceptedLabel: UILabel!
-    func setQuestion(entity: QuestionEntity) {
-        self.displayNameLabel.text = entity.displayName
-//        Likeボタンの表示
-        if entity.isLiked == true {
-            likeButton.setImage(UIImage(systemName: "star.fill"), for: .normal)
-            print("starfill")
-        } else {
-            likeButton.setImage(UIImage(systemName: "star"), for: .normal)
-            print("star")
+    }
+    func initializeTableView() {
+        newArrivalQuestionListTableView.delegate = self
+        newArrivalQuestionListTableView.dataSource = self
+        newArrivalQuestionListTableView.register(UINib(nibName: "QuestionListTableViewCell", bundle: nil), forCellReuseIdentifier: "QuestionListTableViewCell")
+    }
+    func initializePresenter() {
+        presenter = QuestionListViewPresenter(view: self)
+    }
+    func reloadData() {
+        newArrivalQuestionListTableView.refreshControl?.endRefreshing()
+        newArrivalQuestionListTableView.reloadData()
+        print("リロード")
+    }
+    func navigateDetail(entity: QuestionEntity) {
+        let questoinDetailViewController = QuestionDetailViewController(entity: entity)
+        self.navigationController?.pushViewController(questoinDetailViewController, animated: true)
+       }
+    @objc func updateQuestions() {
+        presenter.updateQuestions()
+        newArrivalQuestionListTableView.refreshControl?.beginRefreshing()
+    }
+    @objc func likeButtonTapped(_ sender: UIButton, forEvent event: UIEvent) {
+        let touch = event.allTouches?.first
+        let point = touch!.location(in: self.newArrivalQuestionListTableView)
+        let indexPath = newArrivalQuestionListTableView.indexPathForRow(at: point)!
+        presenter.likeButtonTapped(at: indexPath)
+    }
+}
+extension NewArrivalQuestionListViewController: UITableViewDelegate, UITableViewDataSource {
+    func tableView(_ tableView: UITableView, numberOfRowsInSection section: Int) -> Int {
+        return presenter.numberOfQuestions
+    }
+    func tableView(_ tableView: UITableView, cellForRowAt indexPath: IndexPath) -> UITableViewCell {
+        let cell = newArrivalQuestionListTableView.dequeueReusableCell(withIdentifier: "QuestionListTableViewCell", for: indexPath) as! QuestionListTableViewCell
+        cell.setQuestion(entity: presenter.entity(at: indexPath))
+        cell.likeButton.addTarget(self, action: #selector(likeButtonTapped(_:forEvent:)), for: .touchUpInside)
+        return cell
+    }
+    func tableView(_ tableView: UITableView, didSelectRowAt indexPath: IndexPath) {
+        newArrivalQuestionListTableView.deselectRow(at: indexPath, animated: true)
+        presenter.didSelectRow(at: indexPath)
+    }
+}
+extension NewArrivalQuestionListViewController: IndicatorInfoProvider {
+    func indicatorInfo(for pagerTabStripController: PagerTabStripViewController) -> IndicatorInfo {
+            return itemInfo
         }
-    }
 }
 ```
-```QuestionListViewPresenter
-class QuestionListViewPresenter {
-    private weak var view: ListViewInterface!
-    var questionModel: QuestionModel!
-    var likeModel = LikeModel()
-    var numberOfQuestions: Int {
-        return questionModel?.questions.count ?? 10
-    }
-    init(view: ListViewInterface) {
-        self.view = view
-        self.questionModel = QuestionModel()
-        self.questionModel.addObserver(self, selector: #selector(self.updated))
-    }
-    @objc func updateQuestions() {
-        questionModel.fetchNewArivalQuestions()
-        print("presenter")
-    }
-    func entity(at indexPath: IndexPath) -> QuestionEntity {
-        return questionModel.questions[indexPath.row]
-    }
-    func didSelectRow(at indexPath: IndexPath) {
-        view?.navigateDetail(entity: questionModel.questions[indexPath.row])
-    }
-    @objc func updated() {
-        view?.reloadData()
-    }
-    func likeButtonTapped(at indexPath: IndexPath) {
-        likeModel.updateLikesData(id: questionModel.questions[indexPath.row].id)
-    }
-}
-```
-```NewArrivalQuestionListViewController
-protocol ListViewInterface: class {
-    func reloadData()
-    func navigateDetail(entity: QuestionEntity)
-}
-protocol LikeInterface: class {
-    var questionId: Int { get }
-}
-class NewArrivalQuestionListViewController: UIViewController, ListViewInterface {
-    @IBOutlet weak var newArrivalQuestionListTableView: UITableView!
-    var presenter: QuestionListViewPresenter!
-    var itemInfo: IndicatorInfo = "新着"
-    override func viewDidLoad() {
-        super.viewDidLoad()
-        initializePresenter()
-        initializeTableView()
-        newArrivalQuestionListTableView.refreshControl = UIRefreshControl()
-        newArrivalQuestionListTableView.refreshControl?.addTarget(self, action: #selector(self.updateQuestions), for: .valueChanged)
-        print("didload")
-    }
-    override func viewWillAppear(_ animated: Bool) {
-        super.viewWillAppear(true)
-        updateQuestions()
-        print("willappear")
-    }
-    func initializeTableView() {
-        newArrivalQuestionListTableView.delegate = self
-        newArrivalQuestionListTableView.dataSource = self
-        newArrivalQuestionListTableView.register(UINib(nibName: "QuestionListTableViewCell", bundle: nil), forCellReuseIdentifier: "QuestionListTableViewCell")
-    }
-    func initializePresenter() {
-        presenter = QuestionListViewPresenter(view: self)
-    }
-    func reloadData() {
-        newArrivalQuestionListTableView.refreshControl?.endRefreshing()
-        newArrivalQuestionListTableView.reloadData()
-        print("リロード")
-    }
-    func navigateDetail(entity: QuestionEntity) {
-        let questoinDetailViewController = QuestionDetailViewController(entity: entity)
-        self.navigationController?.pushViewController(questoinDetailViewController, animated: true)
-       }
-    @objc func updateQuestions() {
-        presenter.updateQuestions()
-        newArrivalQuestionListTableView.refreshControl?.beginRefreshing()
-    }
-    @objc func likeButtonTapped(_ sender: UIButton, forEvent event: UIEvent) {
-        let touch = event.allTouches?.first
-        let point = touch!.location(in: self.newArrivalQuestionListTableView)
-        let indexPath = newArrivalQuestionListTableView.indexPathForRow(at: point)!
-        presenter.likeButtonTapped(at: indexPath)
-    }
-}
-extension NewArrivalQuestionListViewController: UITableViewDelegate, UITableViewDataSource {
-    func tableView(_ tableView: UITableView, numberOfRowsInSection section: Int) -> Int {
-        return presenter.numberOfQuestions
-    }
-    func tableView(_ tableView: UITableView, cellForRowAt indexPath: IndexPath) -> UITableViewCell {
-        let cell = newArrivalQuestionListTableView.dequeueReusableCell(withIdentifier: "QuestionListTableViewCell", for: indexPath) as! QuestionListTableViewCell
-        cell.setQuestion(entity: presenter.entity(at: indexPath))
-        cell.likeButton.addTarget(self, action: #selector(likeButtonTapped(_:forEvent:)), for: .touchUpInside)
-        return cell
-    }
-    func tableView(_ tableView: UITableView, didSelectRowAt indexPath: IndexPath) {
-        newArrivalQuestionListTableView.deselectRow(at: indexPath, animated: true)
-        presenter.didSelectRow(at: indexPath)
-    }
-}
-extension NewArrivalQuestionListViewController: IndicatorInfoProvider {
-    func indicatorInfo(for pagerTabStripController: PagerTabStripViewController) -> IndicatorInfo {
-            return itemInfo
-        }
-}
-```

誤字修正

2020/02/11 07:54

投稿

duck015

スコア29

test CHANGED Viewed

File without changes

test CHANGED Viewed

@@ -130,6 +130,92 @@
 ```
+```
+class QuestionModel {
+    var questions: [QuestionEntity] = []
+    var notificationName: Notification.Name {
+        return Notification.Name(rawValue: "questions")
+    }
+    func fetchNewArivalQuestions() {
+        print("fetch")
+        Alamofire.request("https://teratail.com/api/v1/questions").responseJSON { response in
+            self.questions = []
+            guard let object = response.result.value else { return }
+            let json = JSON(object)
+            json["questions"].forEach { (_, json) in
+                let id = json["id"].intValue
+                let title = json["title"].stringValue
+                let tags = json["tags"].arrayObject
+                let displayName = json["user"]["display_name"].stringValue
+                let photo = json["user"]["photo"].stringValue
+                let created = json["created"].stringValue
+                let isAccepted = json["is_accepted"].boolValue
+                self.questions.append(QuestionEntity(id: id, title: title, tags: tags as! [String], displayName: displayName, photo: photo, created: created, isAccepted: isAccepted))
+            }
+            self.notify()
+            print("通知")
+        }
+    }
+    func addObserver(_ observer: Any, selector: Selector) {
+        NotificationCenter.default.addObserver(observer, selector: selector, name: notificationName, object: nil)
+    }
+    func removeObserver(_ observer: Any) {
+        NotificationCenter.default.removeObserver(observer)
+    }
+    func notify() {
+        NotificationCenter.default.post(name: notificationName, object: nil)
+    }
+}
+```
 ```QuestionListTableViewCell

誤字修正

2020/02/11 07:52

投稿

duck015

スコア29

test CHANGED Viewed

File without changes

test CHANGED Viewed

@@ -18,7 +18,7 @@
-しかし、`viewDidLoad`、`viewWillAppear`、UIRefershControl実行時にはデフォルトの状態で表示されてしまいます。
+しかし、`viewDidLoad`、`viewWillAppear`、`UIRefershControl`実行時にはデフォルトの状態で表示されてしまいます。
 つまり、`func updateQuestions()`実行時に問題が発生します。