when の中身をまとめて少なくしたい

Kotlin
1    override fun onOptionsItemSelected(item: MenuItem): Boolean {
2        when (item.itemId) {
3            R.id.home -> {
4                val championsImage = findViewById<ImageView>(R.id.championsImage)
5                championsImage.setImageResource(R.drawable.icon)
6                val championsText = findViewById<TextView>(R.id.championsText)
7                championsText.text = ""
8                return true
9            }
10
11            R.id.Aatrox -> {
12                val championsImage = findViewById<ImageView>(R.id.championsImage)
13                championsImage.setImageResource(R.drawable.aatrox)
14                val championsText = findViewById<TextView>(R.id.championsText)
15                championsText.text = getString(R.string.Aatrox_text)
16                return true
17            }
18
19            R.id.Ahri -> {
20                val championsImage = findViewById<ImageView>(R.id.championsImage)
21                championsImage.setImageResource(R.drawable.ahri)
22                val championsText = findViewById<TextView>(R.id.championsText)
23                championsText.text = getString(R.string.Ahri_text)
24                return true
25            }
26
27            R.id.Akali -> {
28                val championsImage = findViewById<ImageView>(R.id.championsImage)
29                championsImage.setImageResource(R.drawable.akali)
30                val championsText = findViewById<TextView>(R.id.championsText)
31                championsText.text = getString(R.string.Akali_text)
32                return true
33            }
34
35            ...
36
37        }
38        return super.onOptionsItemSelected(item)
39    }

R.id.~というコードがまだまだ続く予定なのですが長くなりすぎて
汚く見えるので二つ目(Aatrox)以降を一つにまとめたいです。

手間はかかってもいいのでなるべくきれいにまとめられる方法を知りたいです。
よろしくお願いします。

行動規範の内容に同意します

回答1件

メソッドにする、itemId と各リソースIDとの関連をテーブル化する等、やり方は色々と思います。

kotlin
1class ChampionViews(val imageView: ImageView, val textView: TextView) {
2  private class Preset(val imageResId: Int, val stringResId: Int, val text: String?)
3  private val presetMap: MutableMap<Int, Preset> = HashMap()
4
5  fun putPreset(key: Int, imageResId: Int, strResId: Int): ChampionViews {
6    presetMap[key] = Preset(imageResId, strResId, null)
7    return this
8  }
9  fun putPreset(key: Int, imageResId: Int, str: String): ChampionViews {
10    presetMap[key] = Preset(imageResId, 0, str)
11    return this
12  }
13  fun selectPreset(key: Int): Boolean {
14    val preset = presetMap[key] ?: return false
15    imageView.setImageResource(preset.imageResId)
16    if(preset.stringResId == 0) {
17      textView.text = preset.text
18    } else {
19      textView.setText(preset.stringResId)
20    }
21    return true
22  }
23}
24
25class MainActivity : AppCompatActivity() {
26  lateinit var championViews: ChampionViews
27
28  override fun onCreate(savedInstanceState: Bundle?) {
29    super.onCreate(savedInstanceState)
30    setContentView(R.layout.activity_main)
31
32    championViews = ChampionViews(findViewById(R.id.championsImage), findViewById(R.id.championsText))
33        .putPreset(R.id.home, R.drawable.icon, "")
34        .putPreset(R.id.Aatrox, R.drawable.aatrox, R.string.Aatrox_text)
35        .putPreset(R.id.Ahri, R.drawable.ahri, R.string.Ahri_text)
36        .putPreset(R.id.Akali, R.drawable.akali, R.string.Akali_text)
37        //...
38  }
39
40  override fun onOptionsItemSelected(item: MenuItem): Boolean {
41    return if(championViews.selectPreset(item.itemId)) true
42           else super.onOptionsItemSelected(item)
43  }
44}