プロフィールの編集が反映されない

Question

質問内容・実現したいこと

・編集画面から写真を変更したい。

現状発生している問題・エラーメッセージ

・編集することができない。

どの処理までうまく動いているのか

・avater以外、送られていることが確認できました。

From: /Users/mark_naito/workspace/runteq/RUNTEQ_basic_level/948_mmmaaarrrkkk000_runteq_learning_basic/app/controllers/profiles_controller.rb @ line 9 :

     4:   def show; end
     5: 
     6:   def edit; end
     7: 
     8:   def update
 =>  9:     binding.irb
    10:     if @user.update(user_params)
    11:       redirect_to profile_path, success: t('.success')
    12:     else
    13:       flash.now[:danger] = t('fail')
    14:       render :edit

irb(#<ProfilesController:0x00007fda868aaf80>):001:0> @user
=> #<User id: 2, email: "[e-mail]", crypted_password: "$2a$10$xJt39WxBGYL/5Q.CbcjkQ.YMB09T.mk2Xv3O3JgqJDk...", salt: "4UeKEoKCCWknxJpLphD5", last_name: "1111", first_name: "1111", created_at: "2021-07-13 07:11:14", updated_at: "2021-07-13 07:11:14", avater: nil>
:002:0> user_params
=> <ActionController::Parameters {"email"=>"[e-mail]", "avater"=>#<ActionDispatch::Http::UploadedFile:0x00007fa6b1d568a8 @tempfile=#<Tempfile:/var/folders/8p/r7ndt03s6610f5cscd0hk6rw0000gn/T/RackMultipart20210715-94120-oac1ye.jpg>, @original_filename="DSCF9807.jpg", @content_type="image/jpeg", @headers="Content-Disposition: form-data; name=\"user[avater]\"; filename=\"DSCF9807.jpg\"\r\nContent-Type: image/jpeg\r\n">} permitted: true>

From: /Users/mark_naito/workspace/runteq/RUNTEQ_basic_level/948_mmmaaarrrkkk000_runteq_learning_basic/app/views/profiles/edit.html.erb @ line 7 :

     2: <div class='container'>
     3:   <div class='row'>
     4:     <div class='col-md-10 offset-md-1'>
     5:       <h1><%= t('.title') %></h1>
     6:       <%= form_with model: current_user, url: profile_path, method: :patch, local: true do |f| %>
 =>  7:         <% binding.irb %>
     8:         <%= render 'shared/errors_message', object: f.object %>
     9:         <div class='form-group'>
    10:           <%= f.label :email %>
    11:           <%= f.text_field :email, class: 'form-control' %>
    12:         </div>

irb(#<#<Class:0x00007fad3094ff18>:0x00007fad27c1aa08>):001:0> current_user
=> #<User id: 2, email: "[e-mail]", crypted_password: "$2a$10$xJt39WxBGYL/5Q.CbcjkQ.YMB09T.mk2Xv3O3JgqJDk...", salt: "4UeKEoKCCWknxJpLphD5", last_name: "1111", first_name: "1111", created_at: "2021-07-13 07:11:14", updated_at: "2021-07-13 07:11:14", avater: nil>

該当のソースコード

profile_control.rb

class ProfilesController < ApplicationController
  before_action :set_user, only: %i[edit show update]
  
  def show; end

  def edit; end

  def update
    if @user.update(user_params)
      redirect_to profile_path, success: t('.success')
    else
      flash.now[:danger] = t('fail')
      render :edit
    end
  end

  private

  def set_user
    @user = User.find(current_user.id)
  end

  def user_params
    params.require(:user).permit(:email, :last_name, :first_name, :avater)
  end
end

user.rb

mount_uploader :avater, ImageUploader

profile/edit.html.erb

<% content_for(:title, t('.title')) %>
<div class='container'>
  <div class='row'>
    <div class='col-md-10 offset-md-1'>
      <h1><%= t('.title') %></h1>
      <%= form_with model: current_user, url: profile_path, method: :patch, local: true do |f| %>
        <%= render 'shared/errors_message', object: f.object %>
        <div class='form-group'>
          <%= f.label :email %>
          <%= f.text_field :email, class: 'form-control' %>
        </div>
        <div class='form-group'>
          <%= f.label :last_name %>
          <%= f.text_field :email, class: 'form-control' %>
        </div>
        <div class='form-group'>
          <%= f.label :first_name %>
          <%= f.text_field :email, class: 'form-control' %>
        </div>
        <div class='form-group'>
          <%= f.label :avater %>
          <%= f.file_field :avater,
                           class: 'form-control mb-3',
                           accept: 'image/*',
                           onchange: 'previewFileWithId(preview)' %>
          <div class='mt-3 mb-3'>
            <%= image_tag current_user.avater.url, id: 'preview', class: 'rounded-circle', width: '100', height: '100'  %>
          </div>                   
        </div>
        <%= f.submit class: 'btn btn-primary' %>
      <% end %>
    </div>
  </div>
</div>

avater_upllader.rb

class AvaterUploader < CarrierWave::Uploader::Base
  # Include RMagick or MiniMagick support:
  # include CarrierWave::RMagick
  # include CarrierWave::MiniMagick

  # Choose what kind of storage to use for this uploader:
  storage :file
  # storage :fog

  # Override the directory where uploaded files will be stored.
  # This is a sensible default for uploaders that are meant to be mounted:
  def store_dir
    "uploads/#{model.class.to_s.underscore}/#{mounted_as}/#{model.id}"
  end

  # Provide a default URL as a default if there hasn't been a file uploaded:
   def default_url
    'sample.jpg'
   end

  # Process files as they are uploaded:
  # process scale: [200, 300]
  #
  # def scale(width, height)
  #   # do something
  # end

  # Create different versions of your uploaded files:
  # version :thumb do
  #   process resize_to_fit: [50, 50]
  # end

  # Add an allowlist of extensions which are allowed to be uploaded.
  # For images you might use something like this:
  def extension_allowlist
    %w(jpg jpeg gif png)
  end

  # Override the filename of the uploaded files:
  # Avoid using model.id or version_name here, see uploader/store.rb for details.
  # def filename
  #   "something.jpg" if original_filename
  # end
end

サーバーログ

Started PATCH "/profile" for ::1 at 2021-07-15 13:59:11 +0900
Processing by ProfilesController#update as HTML
  Parameters: {"utf8"=>"✓", "authenticity_token"=>"Iji82Az0iGs4fQOhfcF59IhP/Waw+fBAfwGyJ1VtmSS8kKiKeuzV5VKKbwB0rX/YAa0tTJANV7+AVJjgzp748w==", "user"=>{"email"=>"[e-mail]", "avater"=>#<ActionDispatch::Http::UploadedFile:0x00007fad30bb0c58 @tempfile=#<Tempfile:/var/folders/8p/r7ndt03s6610f5cscd0hk6rw0000gn/T/RackMultipart20210715-94262-rt7ou9.jpg>, @original_filename="DSCF9824.jpg", @content_type="image/jpeg", @headers="Content-Disposition: form-data; name=\"user[avater]\"; filename=\"DSCF9824.jpg\"\r\nContent-Type: image/jpeg\r\n">}, "commit"=>"更新する"}
  User Load (0.1ms)  SELECT  "users".* FROM "users" WHERE "users"."id" = ? LIMIT ?  [["id", 2], ["LIMIT", 1]]
  ↳ vendor/bundle/ruby/2.6.0/gems/activerecord-5.2.3/lib/active_record/log_subscriber.rb:98
  User Load (0.1ms)  SELECT  "users".* FROM "users" WHERE "users"."id" = ? LIMIT ?  [["id", 2], ["LIMIT", 1]]
  ↳ app/controllers/profiles_controller.rb:21
   (0.1ms)  begin transaction
  ↳ app/controllers/profiles_controller.rb:9
  User Exists (0.3ms)  SELECT  1 AS one FROM "users" WHERE "users"."email" = ? AND "users"."id" != ? LIMIT ?  [["email", "[e-mail]"], ["id", 2], ["LIMIT", 1]]
  ↳ app/controllers/profiles_controller.rb:9
   (0.1ms)  rollback transaction
  ↳ app/controllers/profiles_controller.rb:9
  Rendering profiles/edit.html.erb within layouts/application
  Rendered profiles/edit.html.erb within layouts/application (10.4ms)
  Rendered shared/_flash_message.html.erb (0.4ms)
  Rendered shared/_header.html.erb (3.4ms)
  Rendered shared/_footer.html.erb (0.5ms)
Completed 200 OK in 183ms (Views: 134.0ms | ActiveRecord: 0.6ms)

エラーから考えられる原因

・updateアクションで保存ができていないからでしょうか。 

サーバログで変更が取り消されている箇所を確認

rollback transaction
  ↳ app/controllers/profiles_controller.rb:9

updateに感嘆符をつけエラーの原因を特定する事ができました。

def update
    if @user.update!(user_params)
.
.

user.rb で定義したバリデーション引っかかってしまい更新できないということがわかりました。

=>#<ActionDispatch::Http::UploadedFile:0x00007feaab554a68 @tempfile=#<Tempfile:/var/folders/8p/r7ndt03s6610f5cscd0hk6rw0000gn/T/RackMultipart20210715-94737-1yepbxn.jpg>, @original_filename="DSCF9843.jpg", @content_type="image/jpeg", @headers="Content-Disposition: form-data; name=\"user[avater]\"; filename=\"DSCF9843.jpg\"\r\nContent-Type: image/jpeg\r\n">}, "commit"=>"更新する"}
  User Load (0.4ms)  SELECT  "users".* FROM "users" WHERE "users"."id" = ? LIMIT ?  [["id", 2], ["LIMIT", 1]]
  ↳ vendor/bundle/ruby/2.6.0/gems/activerecord-5.2.3/lib/active_record/log_subscriber.rb:98
   (0.1ms)  begin transaction
  ↳ app/controllers/profiles_controller.rb:9
  User Exists (0.2ms)  SELECT  1 AS one FROM "users" WHERE "users"."email" = ? AND "users"."id" != ? LIMIT ?  [["email", "[e-mail]"], ["id", 2], ["LIMIT", 1]]
  ↳ app/controllers/profiles_controller.rb:9
   (0.1ms)  rollback transaction
  ↳ app/controllers/profiles_controller.rb:9
Completed 422 Unprocessable Entity in 106ms (ActiveRecord: 0.8ms)


  
ActiveRecord::RecordInvalid (バリデーションに失敗しました: パスワードは3文字以上で入力してください, パスワード確認を入力してください):

この先どう手をつけたらいいか分からずにいます。。
ご教授いただきたいです。

よろしくお願いします。

Comments

[winterboum]

ここまで自力で進めてきたのは、力ありますね。
で
userのVALIDATIONに問題が、というところまでつめて居ながらそのcodeがないのはいただけない、、、

User管理をDevise使っているのか居ないのか、などでも変わりますので、model　Userのcodeを載せてください

[mmmaaarrrkkk000]

回答ありがとうございます！！
そう、言っていただき励みになります！

解決することができました！！

Answer 1

・エラー原因

user.rb

validates :password, confirmation: true, if: -> { new_record? || changes[:crypted_password] }
validates :password, length: { minimum: 3 }, if: -> { new_record? || changes[:crypted_password] }
validates :password_confirmation, presence: true, if: -> { new_record? || changes[:crypted_password] }

if: -> { new_record? || changes[:crypted_password] } 記述不足によりバリデーションエラー。

パスワード以外のプロフィール項目の更新を行いたい場合、パスワードを省略できる。