質問編集履歴

ソース、エラーの内容が変わりました。

2015/07/28 14:09

投稿

soccerkozo

スコア12

test CHANGED Viewed

	@@ -1 +1 @@
1	- androidアプリ録音したのもをwavファイルで保存する　~~nullpointerexceptionが起きる理由が分からないです。~~
1	+ androidアプリ録音したのもをwavファイルで保存する　ファイル間の受け渡し

test CHANGED Viewed

@@ -1,114 +1,104 @@
+- 0. ```> ここに言語を入力
+リスト
-録音したものをwavファイルで保存するandroidアプリを開発しています。
+```録音したものをwavファイルで保存するandroidアプリを開発しています。
-何度書き換えてもNullPrinterExceptionのエラーが発生します。
+ファイルは作られるのですが、中に何もデータが入っていません。
 理由の分かる方いらっしゃいましたらよろしくお願いします。
-端末はnexus7を使っています。
-以下ソースーーーーーーーーーーーーーーーーーー
+ーーーーーーーーーーーーーーーーーー
-import java.io.File;
-import java.io.FileInputStream;
-import java.io.FileNotFoundException;
-import java.io.FileOutputStream;
-import java.io.IOException;
-import java.io.OutputStream;
-import android.media.AudioFormat;
-import android.media.AudioRecord;
-import android.media.MediaRecorder;
-import android.os.Bundle;
-import android.os.Environment;
-import android.app.Activity;
-import android.view.Menu;
-import android.view.View;
-import android.view.View.OnClickListener;
-import android.widget.Button;
-public class MainActivity extends Activity implements OnClickListener {
+public class MainActivity extends Activity {
+	private static final int RECORDER_BPP = 16;
+	private static final String AUDIO_RECORDER_FILE_EXT_WAV = ".wav";
+	//private static final String AUDIO_RECORDER_FOLDER = "/DCIM/AudioRecorder";
+	private static final String AUDIO_RECORDER_TEMP_FILE = "record_temp.raw";
+	private static final int RECORDER_SAMPLERATE = 44100;
+	private static final int RECORDER_CHANNELS = AudioFormat.CHANNEL_IN_STEREO;
+	private static final int RECORDER_AUDIO_ENCODING = AudioFormat.ENCODING_PCM_16BIT;
-	private AudioRecord AR = null;
+	private AudioRecord recorder = null;
-	private byte data[];
-	private int bufsize;
+	private int bufferSize = 0;
-	private static final String ARFE = ".wav";
-	private static final String tmpfile = "record_temp.raw";
-	OutputStream ops = null;
-	String filename;
-	private boolean IR = false;
 	private Thread recordingThread = null;
+	private boolean isRecording = false;
-    @Override
+	@Override
-    protected void onCreate(Bundle savedInstanceState) {
+	public void onCreate(Bundle savedInstanceState) {
-        super.onCreate(savedInstanceState);
+		super.onCreate(savedInstanceState);
-        setContentView(R.layout.activity_main);
+		setContentView(R.layout.activity_main);
+		setButtonHandlers();
-        enableButtons(false);
+		enableButtons(false);
-        Button BSta = (Button)findViewById(R.id.button1);
+		bufferSize = AudioRecord.getMinBufferSize(8000,
-        Button BSto = (Button)findViewById(R.id.button2);
+				AudioFormat.CHANNEL_CONFIGURATION_MONO,
-        BSta.setOnClickListener(this);
-		BSto.setOnClickListener(this);
+				AudioFormat.ENCODING_PCM_16BIT);
-    }
+		}
+	private void setButtonHandlers() {
+		((Button)findViewById(R.id.btnStart)).setOnClickListener(btnClick);
+		((Button)findViewById(R.id.btnStop)).setOnClickListener(btnClick);
+		}
+	private void enableButton(int id,boolean isEnable){
+		((Button)findViewById(id)).setEnabled(isEnable);
+		}
+	private void enableButtons(boolean isRecording) {
+		enableButton(R.id.btnStart,!isRecording);
+		enableButton(R.id.btnStop,isRecording);
+		}
-    private String getFilename(){
+	private String getFilename(){
 		String filepath = Environment.getExternalStorageDirectory().getPath();
-		File file = new File(filepath,System.currentTimeMillis() + ARFE);
+		File file = new File(filepath,System.currentTimeMillis() + AUDIO_RECORDER_FILE_EXT_WAV/*AUDIO_RECORDER_FOLDER*/);
@@ -118,71 +108,123 @@
 			}
-		return(filepath+"/"+System.currentTimeMillis() + ARFE);
+		return (filepath + "/" + System.currentTimeMillis() + AUDIO_RECORDER_FILE_EXT_WAV);
-    }
+		}
-    private String getTempFilename(){
+	private String getTempFilename(){
 		String filepath = Environment.getExternalStorageDirectory().getPath();
+		File file = new File(filepath,System.currentTimeMillis() + AUDIO_RECORDER_FILE_EXT_WAV/*AUDIO_RECORDER_FOLDER*/);
+		if(!file.exists()){
+			file.mkdirs();
+			}
-		File tempFile = new File(filepath,tmpfile);
+		File tempFile = new File(filepath,AUDIO_RECORDER_TEMP_FILE);
-		if(tempFile.exists()){
+		if(tempFile.exists())
 			tempFile.delete();
-		}
-		return (filepath+"/"+tmpfile);
-    }
-    private void writeAudioDataToFile(){
-    	final int FREQUENCY = 8000;
-    	bufsize =android.media.AudioRecord.getMinBufferSize(FREQUENCY, AudioFormat.CHANNEL_CONFIGURATION_MONO, AudioFormat.ENCODING_PCM_16BIT);
-    	AR =new AudioRecord(MediaRecorder.AudioSource.MIC,FREQUENCY,AudioFormat.CHANNEL_CONFIGURATION_MONO,AudioFormat.ENCODING_PCM_16BIT,bufsize);
-    	try{
-    		ops = openFileOutput(filename,MODE_APPEND);
-    	}catch(FileNotFoundException e){
-    		e.printStackTrace();
-    	}
-    	int read = 0;
-    	data = new byte[bufsize];
-    	if(null != ops){
-			while(IR){
-				read = AR.read(data, 0, bufsize);
+		return (filepath + "/" + AUDIO_RECORDER_TEMP_FILE);
+		}
+	private void startRecording(){
+		recorder = new AudioRecord(MediaRecorder.AudioSource.MIC,
+				RECORDER_SAMPLERATE, RECORDER_CHANNELS,RECORDER_AUDIO_ENCODING, bufferSize);
+		int i = recorder.getState();
+		if(i==1)
+			recorder.startRecording();
+		isRecording = true;
+		recordingThread = new Thread(new Runnable() {
+			@Override
+			public void run() {
+				writeAudioDataToFile();
+				}
+			},"AudioRecorder Thread");
+		recordingThread.start();
+	}
+	private void writeAudioDataToFile(){
+		byte data[] = new byte[bufferSize];
+		String filename = getTempFilename();
+		FileOutputStream os = null;
+		try {
+			os = new FileOutputStream(filename);
+			} catch (FileNotFoundException e) {
+				// TODO Auto-generated catch block
+				e.printStackTrace();
+				}
+		int read = 0;
+		if(null != os){
+			while(isRecording){
+				read = recorder.read(data, 0, bufferSize);
@@ -190,7 +232,7 @@
 					try {
-						ops.write(data);
+						os.write(data);
 						} catch (IOException e) {
@@ -206,7 +248,7 @@
 			try {
-				ops.close();
+				os.close();
 				} catch (IOException e) {
@@ -216,13 +258,47 @@
 			}
-    }
+		}
+	private void stopRecording(){
+		if(null != recorder){
+			isRecording = false;
+			int i = recorder.getState();
+			if(i==1)
+				recorder.stop();
+			recorder.release();
+			recorder = null;
+			recordingThread = null;
+			}
+		copyWaveFile(getTempFilename(),getFilename());
+		deleteTempFile();
+		}
-    private void deleteTempFile() {
+	private void deleteTempFile() {
 		File file = new File(getTempFilename());
@@ -232,9 +308,9 @@
 		}
-    private void copyWaveFile(String inFilename,String outFilename){
+	private void copyWaveFile(String inFilename,String outFilename){
 		FileInputStream in = null;
@@ -244,15 +320,15 @@
 		long totalDataLen = totalAudioLen + 36;
-		long longSampleRate = 8000;
+		long longSampleRate = RECORDER_SAMPLERATE;
 		int channels = 2;
-		long byteRate = 16*8000*2/8;
+		long byteRate = RECORDER_BPP * RECORDER_SAMPLERATE * channels/8;
-		byte[] data = new byte[bufsize];
+		byte[] data = new byte[bufferSize];
@@ -268,7 +344,9 @@
-			WriteWaveFileHeader(out, totalAudioLen, totalDataLen,longSampleRate, channels, byteRate);
+			WriteWaveFileHeader(out, totalAudioLen, totalDataLen,
+					longSampleRate, channels, byteRate);
@@ -296,25 +374,15 @@
 		}
-    private void enableButton(int id,boolean isEnable){
-		((Button)findViewById(id)).setEnabled(isEnable);
-		}
-	private void enableButtons(boolean IR) {
+	private void WriteWaveFileHeader(
-		enableButton(R.id.button1,!IR);
+			FileOutputStream out, long totalAudioLen,
+			long totalDataLen, long longSampleRate, int channels,
-		enableButton(R.id.button2,IR);
+			long byteRate) throws IOException {
-		}
-    private void WriteWaveFileHeader(FileOutputStream out, long totalAudioLen,long totalDataLen, long longSampleRate, int channels,long byteRate) throws IOException {
@@ -390,7 +458,7 @@
 		header[33] = 0;
-		header[34] = 16;
+		header[34] = RECORDER_BPP; // bits per sample
 		header[35] = 0;
@@ -418,130 +486,86 @@
+	private View.OnClickListener btnClick = new View.OnClickListener() {
-    @Override
+		@Override
-    public boolean onCreateOptionsMenu(Menu menu) {
-        // Inflate the menu; this adds items to the action bar if it is present.
-        getMenuInflater().inflate(R.menu.main, menu);
-        return true;
-    }
-	@Override
-	public void onClick(View v) {
+		public void onClick(View v) {
-		// TODO 自動生成されたメソッド・スタブ
-		switch(v.getId()){
+			switch(v.getId()){
-		case R.id.button1:{
+			case R.id.btnStart:{
-			enableButtons(true);
+				enableButtons(true);
-			int i = AR.getState();
-			if(i==1){
-			AR.startRecording();
+				startRecording();
-			IR = true;
-			recordingThread = new Thread(new Runnable() {
-				@Override
-				public void run() {
-					writeAudioDataToFile();
-					}
-				},"AudioRecorder Thread");
-			recordingThread.start();
-			break;
+				break;
-			}
-		}
-		case R.id.button2:{
-			enableButtons(false);
-			if(AR != null){
-				IR = false;
-				int i = AR.getState();
-				if(i==1){
-					AR.stop();
-					AR.release();
-					AR = null;
-					recordingThread = null;
 				}
+			case R.id.btnStop:{
-				copyWaveFile(getTempFilename(),getFilename());
+				enableButtons(false);
-				deleteTempFile();
+				stopRecording();
+				break;
-			}
+				}
-			break;
-		}
-		}
-	}
-}
----------追加したpermission--------------
+---------エラー------------
+: E/AudioRecord-JNI(10620): Error creating AudioRecord instance: initialization check failed.
+: E/AudioRecord-Java(10620): [ android.media.AudioRecord ] Error code -20 when initializing native AudioRecord object.
+: W/System.err(10620): java.io.FileNotFoundException: /storage/sdcard0/record_temp.raw: open failed: ENOENT (No such file or directory)
+: W/System.err(10620): 	at libcore.io.IoBridge.open(IoBridge.java:416)
+: W/System.err(10620): 	at java.io.FileInputStream.<init>(FileInputStream.java:78)
+: W/System.err(10620): 	at java.io.FileInputStream.<init>(FileInputStream.java:105)
+: W/System.err(10620): 	at com.example.s3033051.jissen2samp1.MainActivity.copyWaveFile(MainActivity.java:178)
+: W/System.err(10620): 	at com.example.s3033051.jissen2samp1.MainActivity.stopRecording(MainActivity.java:156)
+: W/System.err(10620): 	at com.example.s3033051.jissen2samp1.MainActivity.access$2(MainActivity.java:142)
+: W/System.err(10620): 	at com.example.s3033051.jissen2samp1.MainActivity$1.onClick(MainActivity.java:269)
+: W/System.err(10620): 	at android.view.View.performClick(View.java:4204)
+: W/System.err(10620): 	at android.view.View$PerformClick.run(View.java:17355)
+: W/System.err(10620): 	at android.os.Handler.handleCallback(Handler.java:725)
+: W/System.err(10620): 	at android.os.Handler.dispatchMessage(Handler.java:92)
+: W/System.err(10620): 	at android.app.ActivityThread.main(ActivityThread.java:5292)
+: W/System.err(10620): 	at java.lang.reflect.Method.invoke(Method.java:511)
+: W/System.err(10620): 	at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:1031)
-<uses-permission android:name="android.permission.READ_EXTERNAL_STORAGE"/>
+: W/System.err(10620): 	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:798)
+: W/System.err(10620): 	at dalvik.system.NativeStart.main(Native Method)
-        <uses-permission android:name="android.permission.ACCESS_NETWORK_STATE"/>
+: W/System.err(10620): Caused by: libcore.io.ErrnoException: open failed: ENOENT (No such file or directory)
-        <uses-permission android:name="android.permission.RECORD_AUDIO"></uses-permission>
+: W/System.err(10620): 	at libcore.io.BlockGuardOs.open(BlockGuardOs.java:110)
-        <uses-permission android:name="permission.WRITE_EXTERNAL_STORAGE"></uses-permission>
+: W/System.err(10620): 	at libcore.io.IoBridge.open(IoBridge.java:400)

開発端末を書いておきます。

2015/07/28 14:09

投稿

soccerkozo

スコア12

test CHANGED Viewed

File without changes

test CHANGED Viewed

@@ -4,6 +4,8 @@
 理由の分かる方いらっしゃいましたらよろしくお願いします。
+端末はnexus7を使っています。
 以下ソースーーーーーーーーーーーーーーーーーー