undefined method `abs' for nil:NilClassというエラーを解決したいです。

Question

     if notes_all.where('profit_and_loss > 0').present? && notes_all.where('profit_and_loss < 0').present?
        @profit_factor=notes_all.where('profit_and_loss > 0').group("YEAR(exit_datetime)").group("MONTH(exit_datetime)").sum(:profit_and_loss).values.map.with_index{|money,index| [notes_all.where('profit_and_loss > 0').group("YEAR(exit_datetime)").group("MONTH(exit_datetime)").sum(:profit_and_loss).keys[index],money/notes_all.where('profit_and_loss < 0').group("YEAR(exit_datetime)").group("MONTH(exit_datetime)").sum(:profit_and_loss).values[index].abs]}

この部分のコードに対して、

undefined method `abs' for nil:NilClass

というエラーが出ます。

ifで条件分岐してnillclassになる場合は避けているはずなのですが、なぜエラーになるのでしょうか？

教えていただけると幸いです。

ご迷惑をおかけしますがよろしくお願い申し上げます。

以下に全体のコードを載せておきます。

def index
    @user=current_user
    @notes=@user.notes.all.order("id DESC").page(params[:page]).per(30)
    notes_all=@user.notes
    if notes_all.present?
      @profit_symbol=notes_all.group(:symbol).sum(:profit_and_loss)
      profit_month=notes_all.group("YEAR(exit_datetime)").group("MONTH(exit_datetime)")
      @profit_changes = profit_month.sum(:profit_and_loss).values.map.with_index{|money,index| [profit_month.sum(:profit_and_loss).keys[index],money/notes_all.sum(:profit_and_loss)*100]}
      @profit_times=notes_all.group("HOUR(CONVERT_TZ(exit_datetime, '+00:00', '+09:00'))").sum(:profit_and_loss).values.map.with_index{|money, index| [notes_all.group("HOUR(CONVERT_TZ(exit_datetime, '+00:00', '+09:00'))").sum(:profit_and_loss).keys[index],money/notes_all.sum(:profit_and_loss)*100]}
      @victry_times=notes_all.where('profit_and_loss > 0').group("HOUR(CONVERT_TZ(exit_datetime, '+00:00', '+09:00'))").count.values.map.with_index{|money,index| [notes_all.group("HOUR(CONVERT_TZ(exit_datetime, '+00:00', '+09:00'))").count.keys[index],money*100/notes_all.group("HOUR(CONVERT_TZ(exit_datetime, '+00:00', '+09:00'))").count.values[index]]}
      @victory_rates=notes_all.where('profit_and_loss > 0').group("YEAR(exit_datetime)").group("MONTH(exit_datetime)").count.values.map.with_index{|money,index| [notes_all.group("YEAR(exit_datetime)").group("MONTH(exit_datetime)").count.keys[index],money*100/notes_all.group("YEAR(exit_datetime)").group("MONTH(exit_datetime)").count.values[index]]}
      if notes_all.where(:buy_sell==1).present?
      @profit_short=notes_all.where(:buy_sell==1).group("YEAR(exit_datetime)").group("MONTH(exit_datetime)").sum(:profit_and_loss).values.map.with_index{|money,index| [notes_all.group("YEAR(exit_datetime)").group("MONTH(exit_datetime)").count.keys[index],money*100/notes_all.group("YEAR(exit_datetime)").group("MONTH(exit_datetime)").sum(:profit_and_loss).values[index]]}
      @victry_short=notes_all.where(:buy_sell==1).group("YEAR(exit_datetime)").group("MONTH(exit_datetime)").count.values.map.with_index{|money,index| [notes_all.group("YEAR(exit_datetime)").group("MONTH(exit_datetime)").count.keys[index],money*100/notes_all.group("YEAR(exit_datetime)").group("MONTH(exit_datetime)").count.values[index]]}
      end
      if notes_all.where(:buy_sell==0).present?
      @profit_long=notes_all.where(:buy_sell==0).group("YEAR(exit_datetime)").group("MONTH(exit_datetime)").sum(:profit_and_loss).values.map.with_index{|money,index| [notes_all.group("MONTH(exit_datetime)").count.keys[index],money*100/notes_all.group("YEAR(exit_datetime)").group("MONTH(exit_datetime)").sum(:profit_and_loss).values[index]]}
      @victry_long=notes_all.where(:buy_sell==0).group("YEAR(exit_datetime)").group("MONTH(exit_datetime)").count.values.map.with_index{|money,index| [notes_all.group("YEAR(exit_datetime)").group("MONTH(exit_datetime)").count.keys[index],money*100/notes_all.group("YEAR(exit_datetime)").group("MONTH(exit_datetime)").count.values[index]]}
      end
      this_month = Date.today.all_month
      before_month=Date.today.last_month
      profit_this_month = []
      profit_before_month = []
      notes_all.each do |note| 
        if this_month.include?(Date.parse(note[:created_at].to_s))
          profit_this_month << note.profit_and_loss
        elsif before_month.include?(Date.parse(note[:created_at].to_s))
          profit_before_month << note.profit_and_loss
        end
      end
      @profit_this_month= profit_this_month.sum
      @profit_this_month_average = @profit_this_month / profit_this_month.length
      @victory_rate_this_month = profit_this_month.select{|money| money > 0}.count/profit_this_month.count*100
      if profit_before_month.present?
      @profit_before_month= profit_before_month.sum
      @profit_before_month_average= @profit_before_month / profit_before_month.length
      @victory_rate_before_month=profit_before_month.select{|money| money > 0}.count/profit_before_month.count*100
      end
      if notes_all.where('profit_and_loss > 0').present? && notes_all.where('profit_and_loss < 0').present?
        @profit_factor=notes_all.where('profit_and_loss > 0').group("YEAR(exit_datetime)").group("MONTH(exit_datetime)").sum(:profit_and_loss).values.map.with_index{|money,index| [notes_all.where('profit_and_loss > 0').group("YEAR(exit_datetime)").group("MONTH(exit_datetime)").sum(:profit_and_loss).keys[index],money/notes_all.where('profit_and_loss < 0').group("YEAR(exit_datetime)").group("MONTH(exit_datetime)").sum(:profit_and_loss).values[index].abs]}
        @risk_reward_factor=notes_all.where('profit_and_loss > 0').group("YEAR(exit_datetime)").group("MONTH(exit_datetime)").average(:profit_and_loss).values.map.with_index{|money,index| [notes_all.where('profit_and_loss > 0').group("YEAR(exit_datetime)").group("MONTH(exit_datetime)").average(:profit_and_loss).keys[index],money/notes_all.where('profit_and_loss < 0').group("YEAR(exit_datetime)").group("MONTH(exit_datetime)").average(:profit_and_loss).values[index].abs]}
        @recovery_factor=profit_month.sum(:profit_and_loss).values.map.with_index{|money,index| [profit_month.sum(:profit_and_loss).keys[index],money/notes_all.where('profit_and_loss < 0').group("YEAR(exit_datetime)").group("MONTH(exit_datetime)").sum(:profit_and_loss).values[index].abs]}
      end
      respond_to do |format|
        format.html
        format.csv
        format.csv do |csv|
          send_notes_csv(notes_all)
        end
      end      
    end
  end

Answer 1

abs メソッドを呼び出している「親」は　～.values[index] ですから、これが nil なんでしょう。
index の値は if でチェックしていないから、そこでアウトなのでは？

Comments

[ganbarou_nippon]

解決しました。ありがとうございます！