rails チュートリアル１１章 メールでの有効化で、メールをクリックしてきたユーザーのアドレスがとれない。

Question

rails チュートリアル１１章のところを参考にメールでユーザーの有効化をする処理で、メールは送れるのですが、URLをクリックしてきたユーザーのアドレスが取れていないようで、有効化ができません。どなたかお知恵を貸してください。

def create
      @user = User.new(user_params)
      @user.imagename = "default_user.jpg"
      @user.point = 0
      @user.finishcount = 0
      password = params[:password]
      password_confirmation = params[:password_confirmation]
      @user.save
      if @user.save
          session[:user_id] = @user.id
          @user.send_activation_email     　　　　　　　　　　　　　　　 #メールを送る
          flash[:notice] = "メールを確認して登録を完了してください。"
          redirect_to("/")  
      else
         if User.find_by(email:params[:email])
           @error_message = "そのEmailアドレスは使われています"
         else
            if password.length < 6 
                @error_message = "パスワードは６字以上です"
            elsif password.length > 18
                @error_message = "パスワードは１８字以下です" 
            elsif password != password_confirmation
                @error_message = "パスワードと確認パスワードが一致しません"
            else
                @error_message = "入力されたEmailは正しくありません"
            end
         end
          render("/users/new")
      end
  end

class User < ApplicationRecord
  attr_accessor :remember_token , :activation_token          # 記憶トークンと有効化トークンを定義
  before_create :create_activation_digest                    # 作成前に適用


def self.search(search)
  if search
     User.where(['user_name LIKE?',"%#{search}%"])
  else
     User.all
  end
end

def send_activation_email
  UserMailer.account_activation(self).deliver_now
end

def activate
  update_attribute(:activated,        true)
  update_attribute(:activated_at,     Time.zone.now)
end

def remember
  self.remember_token = User.new_token
  update_attribute(:remember_digest, User.digest(remember_token))
end

# 渡された文字列のハッシュ値を返す
def User.digest(string)
cost = ActiveModel::SecurePassword.min_cost ? BCrypt::Engine::MIN_COST :
                                              BCrypt::Engine.cost
BCrypt::Password.create(string, cost: cost)
end

# ランダムなトークンを返す
def User.new_token
  SecureRandom.urlsafe_base64
end


# 渡されたトークンがダイジェストと一致したらtrueを返す
def authenticated?(attritubte, token)
  digest = send("#{attritubte}_digest")
  return false if digest.nil?
  BCrypt::Password.new(digest).is_password?(token)
end

# ユーザーのログイン情報を破棄する
def forget
  update_attribute(:remember_digest, nil)
end



# 有効化トークンとダイジェストを作成および代入する
def create_activation_digest
  self.activation_token   =   User.new_token                         # ハッシュ化した記憶トークンを有効化トークン属性に代入
  self.activation_digest  =   User.digest(activation_token)          # 有効化トークンをBcryptで暗号化し、有効化ダイジェスト属性に代入
end

end

class UserMailer < ApplicationMailer
    default from: '[e-mail]'


    def account_activation(user)
        @user = user
        mail to: user.email, subject: "Welcome"  #subjectは件名
    end
    
    def password_reset
      @greeting = "Hi"

      mail to: "[e-mail]"
    end

    
end

<p>hello. <%= @user.user_name %>,</p>

<p>
 Welcome NEET'S  RIDE &nbsp;Plese&nbsp;&nbsp;click:
</p>

<%= link_to "Activate", edit_account_activation_url(@user.activation_token,　email: @user.email ) %>

class AccountActivationsController < ApplicationController
    def edit
        user = User.find_by(email: params[:email])
        if user && !user.activated? && user.authenticated?(:activation, params[:id])
          user.update_attribute(:activated,     true)
          user.update_attribute(:activated_at,  Time.zone.now)
          log_in user
          flash[:notice] = "アカウントを有効にしました。ログインしてください。"
          redirect_to("/")
        else
          flash[:notice] = "アカウントを有効にできませんでした。"
          @user = user  #消す
          redirect_to("/")
        end
    end
end

URLをクリックすると、ここのコントローラにはくるのですが、userがnilになっているようです。処理はいつも、elseの方で処理されます。

actionpack (5.2.4.1) lib/action_dispatch/middleware/debug_exceptions.rb:65:in `call'
web-console (3.7.0) lib/web_console/middleware.rb:135:in `call_app'
web-console (3.7.0) lib/web_console/middleware.rb:30:in `block in call'
web-console (3.7.0) lib/web_console/middleware.rb:20:in `catch'
web-console (3.7.0) lib/web_console/middleware.rb:20:in `call'
actionpack (5.2.4.1) lib/action_dispatch/middleware/show_exceptions.rb:33:in `call'
railties (5.2.4.1) lib/rails/rack/logger.rb:38:in `call_app'
railties (5.2.4.1) lib/rails/rack/logger.rb:26:in `block in call'
activesupport (5.2.4.1) lib/active_support/tagged_logging.rb:71:in `block in tagged'
activesupport (5.2.4.1) lib/active_support/tagged_logging.rb:28:in `tagged'
activesupport (5.2.4.1) lib/active_support/tagged_logging.rb:71:in `tagged'
railties (5.2.4.1) lib/rails/rack/logger.rb:26:in `call'
sprockets-rails (3.2.1) lib/sprockets/rails/quiet_assets.rb:13:in `call'
actionpack (5.2.4.1) lib/action_dispatch/middleware/remote_ip.rb:81:in `call'
actionpack (5.2.4.1) lib/action_dispatch/middleware/request_id.rb:27:in `call'
rack (2.0.8) lib/rack/method_override.rb:22:in `call'
rack (2.0.8) lib/rack/runtime.rb:22:in `call'
activesupport (5.2.4.1) lib/active_support/cache/strategy/local_cache_middleware.rb:29:in `call'
actionpack (5.2.4.1) lib/action_dispatch/middleware/executor.rb:14:in `call'
actionpack (5.2.4.1) lib/action_dispatch/middleware/static.rb:127:in `call'
rack (2.0.8) lib/rack/sendfile.rb:111:in `call'
railties (5.2.4.1) lib/rails/engine.rb:524:in `call'
puma (3.12.2) lib/puma/configuration.rb:227:in `call'
puma (3.12.2) lib/puma/server.rb:674:in `handle_request'
puma (3.12.2) lib/puma/server.rb:476:in `process_client'
puma (3.12.2) lib/puma/server.rb:334:in `block in run'
puma (3.12.2) lib/puma/thread_pool.rb:135:in `block in spawn_thread'
Started POST "/users/create" for ::1 at 2020-01-18 12:37:36 +0900
Processing by UsersController#create as HTML
  Parameters: {"utf8"=>"✓", "authenticity_token"=>"o9yKp5OUFDMyB2eQpVSpChIF3TWUcnbqShRgukbzCfALnfqsipePghb1d2BOjPATPgW5pXJ6mvBptS/2CC77fA==", "user_name"=>"田中", "email"=>"[e-mail]", "password"=>"[FILTERED]", "password_confirmation"=>"[FILTERED]"}
Unpermitted parameters: :utf8, :authenticity_token
   (0.1ms)  begin transaction
  ↳ app/controllers/users_controller.rb:19
  User Exists (0.7ms)  SELECT  1 AS one FROM "users" WHERE "users"."email" = ? LIMIT ?  [["email", "[e-mail]"], ["LIMIT", 1]]
  ↳ app/controllers/users_controller.rb:19
  User Create (3.0ms)  INSERT INTO "users" ("user_name", "password_digest", "email", "imagename", "finishcount", "point", "created_at", "updated_at", "activation_digest") VALUES (?, ?, ?, ?, ?, ?, ?, ?, ?)  [["user_name", "田中"], ["password_digest", "$2a$12$Y1ht9BMlEn373nv.mFr7Tus0HRS05YpnPXXFV8ighpMvfvJenTNGm"], ["email", "[e-mail]"], ["imagename", "default_user.jpg"], ["finishcount", 0], ["point", 0.0], ["created_at", "2020-01-18 12:37:37.618435"], ["updated_at", "2020-01-18 12:37:37.618435"], ["activation_digest", "$2a$12$dB4cuZG6hYCCZPDHR7.8veJ92pE6KaGFtvqTgGe8g7POZ4.2K6VMC"]]
  ↳ app/controllers/users_controller.rb:19
   (145.2ms)  commit transaction
  ↳ app/controllers/users_controller.rb:19
   (0.1ms)  begin transaction
  ↳ app/controllers/users_controller.rb:20
  User Exists (0.5ms)  SELECT  1 AS one FROM "users" WHERE "users"."email" = ? AND "users"."id" != ? LIMIT ?  [["email", "[e-mail]"], ["id", 38], ["LIMIT", 1]]
  ↳ app/controllers/users_controller.rb:20
   (0.1ms)  commit transaction
  ↳ app/controllers/users_controller.rb:20
  Rendering user_mailer/account_activation.html.erb within layouts/mailer
  Rendered user_mailer/account_activation.html.erb within layouts/mailer (1.5ms)
  Rendering user_mailer/account_activation.text.erb within layouts/mailer
  Rendered user_mailer/account_activation.text.erb within layouts/mailer (1.2ms)
UserMailer#account_activation: processed outbound mail in 52.8ms
Sent mail to [e-mail] (138.9ms)
Date: Sat, 18 Jan 2020 12:37:38 +0900
From: [e-mail]
To: [e-mail]
Message-ID: <[e-mail]>
Subject: Welcome NEET'S RIDE
Mime-Version: 1.0
Content-Type: multipart/alternative;
 boundary="--==_mimepart_5e227d825e66a_7ac45b526c84326";
 charset=UTF-8
Content-Transfer-Encoding: 7bit


----==_mimepart_5e227d825e66a_7ac45b526c84326
Content-Type: text/plain;
 charset=UTF-8
Content-Transfer-Encoding: quoted-printable

 =E7=94=B0=E4=B8=AD,=0D
Welcome NEET'S  RIDE &nbsp;Plese&nbsp;&nbsp;click:=0D
http://localhost:3000/account_activations/0TUelYOMvg6C4resAWAzjg/edit?ema=
il=3Dsample%40co.jp=0D
=0D

----==_mimepart_5e227d825e66a_7ac45b526c84326
Content-Type: text/html;
 charset=UTF-8
Content-Transfer-Encoding: quoted-printable

<!DOCTYPE html>=0D
<html>=0D
  <head>=0D
    <meta http-equiv=3D"Content-Type" content=3D"text/html; charset=3Dutf=
-8" />=0D
    <style>=0D
      /* Email styles need to be inline */=0D
    </style>=0D
  </head>=0D
=0D
  <body>=0D
    <p>hello. =E7=94=B0=E4=B8=AD,</p>=0D
=0D
<p>=0D
 Welcome NEET'S  RIDE &nbsp;Plese&nbsp;&nbsp;click:=0D
</p>=0D
=0D
<a href=3D"http://localhost:3000/account_activations/0TUelYOMvg6C4resAWAz=
jg/edit?%E3%80%80email=3Dsample%40co.jp">Activate</a>=0D
  </body>=0D
</html>=0D

logでは、アドレスが送られているのようなのに、params[:email]で取れないのはなぜなのでしょうか。どうぞよろしくお願いします。

Comments

[winterboum]

logはメール送信までで、AccountActivationsController#editへのアクセス部分がないですが。

[tori315]

質問の方に追加すると、文字数制限で投稿できないので、こちらに書かせていただきます。
以下、返ってきたときのログです。質問のアドレスとは違いますが、これでいいでしょうか？

Started GET "/letter_opener/1579354887_2057996_ad689a3/rich" for ::1 at 2020-01-18 22:42:50 +0900
Processing by LetterOpenerWeb::LettersController#show as HTML
Parameters: {"id"=>"1579354887_2057996_ad689a3", "style"=>"rich"}
Rendering html template
Rendered html template (0.1ms)
Completed 200 OK in 1058ms (Views: 75.2ms | ActiveRecord: 0.0ms)

Started GET "/account_activations/CXb0oS2Zuhe-FNYT2Wf6GA/edit?%E3%80%80email=sample1%40co.jp" for ::1 at 2020-01-18 22:42:59 +0900
Processing by AccountActivationsController#edit as HTML
Parameters: {"　email"=>"[e-mail]", "id"=>"CXb0oS2Zuhe-FNYT2Wf6GA"}
User Load (20.4ms) SELECT "users".* FROM "users" WHERE "users"."id" = ? LIMIT ? [["id", 40], ["LIMIT", 1]]
↳ app/controllers/application_controller.rb:7
User Load (1.2ms) SELECT "users".* FROM "users" WHERE "users"."email" IS NULL LIMIT ? [["LIMIT", 1]]
↳ app/controllers/account_activations_controller.rb:3
Redirected to http://localhost:3000/
Completed 302 Found in 329ms (ActiveRecord: 21.6ms)

Started GET "/" for ::1 at 2020-01-18 22:43:05 +0900
Processing by HomeController#top as HTML
User Load (0.4ms) SELECT "users".* FROM "users" WHERE "users"."id" = ? LIMIT ? [["id", 40], ["LIMIT", 1]]
↳ app/controllers/application_controller.rb:7
Rendering home/top.html.erb within layouts/application
Rendered home/top.html.erb within layouts/application (1.2ms)
Completed 200 OK in 1767ms (Views: 1726.3ms | ActiveRecord: 0.4ms)

[tori315]

↳ app/controllers/application_controller.rb:7のところは、

class ApplicationController < ActionController::Base
include SessionsHelper
before_action :set_current_user

def set_current_user
if (user_id = session[:user_id])
@current_user ||= User.find_by(id: user_id)　　　＃ここが７行目です。
elsif (user_id = cookies.signed[:user_id])
user = User.find_by(id: user_id)
if user && user.authenticated?(:remember, cookies[:remember_token])
log_in @user
@current_user = user
end
end
end

ここが原因になるのでしょうか？

Answer 1

メールアドレスの前に全角空白が入っているのが原因ですね。
ざっと見た所なぜ入るか読み込めていません。
明日見なおしてみますが、その目（どこで空白がはいるんだ！）で見なおしてみてください

Comments

[tori315]

ありがとうございます。考えてみます。

[tori315]

<%= link_to "Activate", edit_account_activation_url(@user.activation_token,　email: @user.email ) %>

<%= link_to"Activate",edit_account_activation_url(@user.activation_token,email:@user.email) %>

詰めてみたら、いけました。ご指摘があったおかげです。ありがとうございました。